- 03 Jan, 2019 25 commits
-
-
Junliang Yan authored
Port fa3cbf60 Original Commit Message: This changes Torque's builtin pointers to use a Smi representation underneath instead of storing the Code target object. Callsites look up the target entry point through IsolateData::builtin_entry_table. The notable effect of this CL is that builtin pointer calls no longer call any on-heap Code. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I49bb08de916fd93e576936a56b0e1a0e21072289 Reviewed-on: https://chromium-review.googlesource.com/c/1394301Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#58530}
-
Ulan Degenbaev authored
Bug: v8:8616 Change-Id: I0998b437712037277b81eb5d04b734826aabcd46 Reviewed-on: https://chromium-review.googlesource.com/c/1391754 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58529}
-
Junliang Yan authored
R=jgruber@chromium.org, joransiu@ca.ibm.com Change-Id: If31804509eaca51c0606409873dc180df4fb49f3 Reviewed-on: https://chromium-review.googlesource.com/c/1393301Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#58528}
-
Clemens Hammacher authored
We currently trigger a GC when creating a module while the remaining uncommitted code space is below 32MB. For bigger modules, this is not enough. Instead, make this limit relative: Trigger GC if we fall below 50% of the available code space, and re-adjust this limit after each GC to avoid repeated GCs that do not free anything. R=ahaas@chromium.org Bug: v8:8624 Change-Id: I7abfad3b57663d528a26d29232ad6bc2dc63cef4 Reviewed-on: https://chromium-review.googlesource.com/c/1391753Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58527}
-
Georg Neis authored
This is a partial reland of d3d13e4b, which made an incorrect assumption about how the typer visits the graph. Bug: chromium:906567 Change-Id: I55b70fdf7e655973e6ae33b64e127252c745517f Reviewed-on: https://chromium-review.googlesource.com/c/1394549Reviewed-by:
-
Junliang Yan authored
Port f323a5f4 Original Commit Message: Currently, Torque's builtin pointers store a Code target underneath and callsites generate a kArchCallCodeObject opcode. When embedded builtins are enabled, the call thus first calls the on-heap trampoline, which finally jumps to the target off-heap builtin code. This will no longer be possible in jitless mode, since on-heap code must not be executable. As a step towards changing the way builtin pointers are called (function pointers will hold the builtin index as a Smi, and callsites look up the off-heap target address and jump there), this CL adds a dedicated opcode for builtin pointer calls to the compiler pipeline. The calling mechanism itself is unchanged, changes there will happen in a follow-up. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I2d2229227e1c62e7c2515d4f5cb3d4dae49b3dd4 Reviewed-on: https://chromium-review.googlesource.com/c/1393913Reviewed-by:
-
Clemens Hammacher authored
The number of registers is very small, so any integer type is big enough anyway. Just use the simplest one, which is int. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I9762a5c934848b810b7937ee603cd183f883d557 Reviewed-on: https://chromium-review.googlesource.com/c/1394548Reviewed-by:
-
Junliang Yan authored
R=joransiu@ca.ibm.com Change-Id: I0587b286f3132347172f353cbce405158ef1c403 Reviewed-on: https://chromium-review.googlesource.com/c/1393910Reviewed-by:
-
Clemens Hammacher authored
We currently de-duplicate used registers also in regions which do not need merging. In those regions though it can never happen that we need to pass different values from any merge input. Apart from introducing unnecessary register moves, this also causes a DCHECK to fail, because we might later want to merge back different registers into one. Assume this initial stack state (where each letter is a register): [A B B C] If in any child block the two Bs get de-duplicated so something like [A B D C] then we run into trouble when merging back this state into the parent state, because both B and D would need to be put into B. In this case we can statically infer that B and D must hold the same value anyway, but having this situation does not make much sense in the first place, so the DCHECK fires correctly. R=titzer@chromium.org Bug: v8:8423, chromium:917412 Change-Id: I24c36b062e04a134cf7051725afab98126753f31 Reviewed-on: https://chromium-review.googlesource.com/c/1392190 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
On x64 the {kScratchRegister} cannot be held in a {LiftoffRegister}, since it is not a valid cache register. Also, the code unnecessarily checked whether there is an unused cache register, but then didn't use it. Simplify the logic to always use the scratch register, just distinguish between 4-byte and 8-byte moves. On ia32 we did not move 64-bit values correctly if we didn't have unused registers and needed to move via the stack. R=titzer@chromium.org Bug: v8:6600, chromium:917588, chromium:917450 Change-Id: I0bbe946c6ac8fca62f85711ae47afdac9c02ae6b Reviewed-on: https://chromium-review.googlesource.com/c/1391755Reviewed-by: -
Clemens Hammacher authored
We don't have our macros available there, so we should not enforce V8_NOEXCEPT on types declared in include/v8.h or other files in include/. R=mlippautz@chromium.org Bug: v8:8616 No-Try: true Change-Id: I51550a072a7957921c6cbd7e0866093f0462ff4e Reviewed-on: https://chromium-review.googlesource.com/c/1394547Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58520}
-
Georg Neis authored
This reverts commit d3d13e4b. Reason for revert: Makes an incorrect assumption. Original change's description: > [turbofan] Improve UpdateType debug output. > > R=jarin@chromium.org > > Bug: chromium:906567 > Change-Id: Ic99c7a240ecb37c7b032b388f604d3f256d335b3 > Reviewed-on: https://chromium-review.googlesource.com/c/1392196 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58497} TBR=jarin@chromium.org,neis@chromium.org Change-Id: I1bfc6d38f1c6cb67ef403d8be84070aa2c0effb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:906567 Reviewed-on: https://chromium-review.googlesource.com/c/1394546Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58519}
-
Clemens Hammacher authored
Templates are nicer than macros, and in this case it's not more complex. R=tebbi@chromium.org Bug: v8:8562 Change-Id: I3aea7b4138f144166418c0827dd7c58ea459c670 Reviewed-on: https://chromium-review.googlesource.com/c/1392200Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58518}
-
Clemens Hammacher authored
This specifier is deprecated and will be removed in C++20. Replace it with V8_NOEXCEPT where is makes sense and remove it otherwise. Also remove redundant constructors. R=tebbi@chromium.org Bug: v8:8562 Change-Id: I1335dcac5cac14b62b655cfd507decd4de653043 Reviewed-on: https://chromium-review.googlesource.com/c/1392204Reviewed-by:
-
Clemens Hammacher authored
Instead, always pass an index and an enum pointing to either half. R=titzer@chromium.org Bug: v8:6600, v8:8562 Change-Id: I7e73bd97bfc7ebf644b242980aa0a73cd5f18949 Reviewed-on: https://chromium-review.googlesource.com/c/1392189 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Mythri authored
If the parameter list contains class declarations we should use the block scope corresponding to the class when rewriting the initializers. Bug: chromium:917988 Change-Id: I7fcd44a264b7c0113cbd821b759e0bee6c9345a0 Reviewed-on: https://chromium-review.googlesource.com/c/1392240Reviewed-by:
-
Clemens Hammacher authored
Bring mips in line with the ia32 and arm implementions. Instead of computing the "half index" manually, pass the index and an enum pointing to either half. R=titzer@chromium.org Bug: v8:6600 Change-Id: Id8812114df84fbddd4aa2570306526d291bface6 Reviewed-on: https://chromium-review.googlesource.com/c/1392188 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Since https://crrev.com/c/1335572, our sanitizers allow to set custom segfault handlers. Thus remove special code that was added to handle sanitizers that prevent installation of segfault handlers. Instead, CHECK that the signal handler was installed correctly. R=ahaas@chromium.org, mseaborn@chromium.org, mark@chromium.org Bug: chromium:830894 Change-Id: I3bd66e33efdceb3e8469f3f4a09fbde90cb3d7ec Reviewed-on: https://chromium-review.googlesource.com/c/1392199Reviewed-by:
-
Leszek Swirski authored
Instead of de-sugaring destructuring assignment in the parser (using the pattern rewriter), pass the Object/ArrayLiterals through to the bytecode generator, which can desugar them in-place. This allows us to decrease the amount of AST node creation, and improve the generated bytecode using domain-specific knowledge. As a side effect we partially fix an old execution ordering spec bug. Currently only implemented for assignments, not declarations, as the latter has some additional complexity. Bug: v8:4951 Change-Id: I3d69d232bea2968ef20df68a74014d9e05808cfe Reviewed-on: https://chromium-review.googlesource.com/c/1375660 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#58512}
-
Frank Tang authored
Bug: v8:7684 Change-Id: Ibe7db0ef1baacb33d07a45234e6bda4f69e95643 Reviewed-on: https://chromium-review.googlesource.com/c/1381732 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58511}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/67f9fae..2df3750 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/16717a6..24bb5c4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I19b8cb8c1d1e748ba91b2214570dda8b6e8e4300 Reviewed-on: https://chromium-review.googlesource.com/c/1394288Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#58510}
-
Junliang Yan authored
Port 640d3adf Original Commit Message: InternalPackedArray now only has one constructor variant that expects no arguments (Chrome's only usage of InternalPackedArray). As such, these TFC builtins are no longer used and were removed: - InternalArrayNoArgumentConstructor_Holey - InternalArraySingleArgumentConstructor_Packed - InternalArraySingleArgumentConstructor_Holey On x64.release, this reduces builtins size by ~1.2KB. R=peter.wm.wong@gmail.com, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I46d86178c33e47acf2fb75fd3de743686641caa1 Reviewed-on: https://chromium-review.googlesource.com/c/1393825Reviewed-by:
-
Junliang Yan authored
Port a55803a1 Original Commit Message: This change makes the SFI to bytecode link pseudo-weak. The marking visitors check whether the bytecode is old, and if so, don't mark it and instead push the SFI onto a bytecode_flushing_candidates worklist. Once marking is complete, this list is walked, and for any of the candidates who's bytecode has not been marked (i.e., is only referenced by the shared function info), the bytecode is flushed and the SFI has the function data replaced with an UncompiledData (which overwrites the flushed bytecode array). Since we don't track JSFunctions, these can still think the underlying function is compiled, and so calling them will invoke InterpreterEntryTrampoline. As such, logic is added to InterpreterEntryTrampoline to detect flushed functions, and enter CompileLazy instead. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:8395 LOG=N Change-Id: I4a913d318363a584d79aa6d7f4ee09f04a89bbbe Reviewed-on: https://chromium-review.googlesource.com/c/1393824Reviewed-by:
-
Fabrice de Gans-Riberi authored
This Mac/Fuchsia build was broken as the generated assembly file must follow Linux-style calling conventions. Change-Id: I05d946e77690e97f05d57a3d5ba04cd2e63fbb9d Reviewed-on: https://chromium-review.googlesource.com/c/1377230 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58507}
-
Frank Tang authored
This reverts commit 8d094249. Reason for revert: Cause Memory regression TBR=gsathya@chromium.org Original change's description: > [Intl] Validate u extension type > > Fix intl402/*/ignore-invalid-unicode-ext-values > Add tests for other valid/invalid -u- ext values. > > Bug: v8:7481 > Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 > Reviewed-on: https://chromium-review.googlesource.com/c/1351307 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58173} TBR=cira@chromium.org,jshin@chromium.org,gsathya@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7481 Change-Id: Idabf2183684f264271ebe2b8c0ca10ae8e30d811 Reviewed-on: https://chromium-review.googlesource.com/c/1393499Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 02 Jan, 2019 14 commits
-
-
Sathya Gunasekaran authored
These are FixedArrays, not ObjectHashTable Change-Id: I8f5a4d8c16bc0f566719815fbea6be51b6bd8ec5 Reviewed-on: https://chromium-review.googlesource.com/c/1387864 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Junliang Yan authored
Port 24e76616 Original Commit Message: This is a reland of f849396c Original change's description: > [nojit] Remove code stubs > > All stubs have been migrated to builtins. This CL removes most related > code. > > Bug: v8:7777, v8:5784 > Change-Id: I4470cfef34788e6c8e0fd5fd09e40e250d088dad > Reviewed-on: https://chromium-review.googlesource.com/c/1365284 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58093} R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ie05463245c24975804a8bb7ffdf902c70e042127 Reviewed-on: https://chromium-review.googlesource.com/c/1393302Reviewed-by:
-
Junliang Yan authored
Port b89d4249 Original Commit Message: This migrates the JSEntryStub to three dedicated builtins: JSEntry JSConstructEntry JSRunMicrotasksEntry correct macro assembler method to load and store external references through the kRootRegister). kRootRegister is initialized, so we first reserve the slot and later load its value. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ib84feca5e88d032307b5fab42377c56d074faf7f Reviewed-on: https://chromium-review.googlesource.com/c/1393296Reviewed-by:
-
Tobias Tebbi authored
This CL doesn't change anything, but builds the infrastructure to inline selected macros into the Torque IR. Bug: v8:7793 Change-Id: Icdaa014633edfb314f9263c1a8ad84de4a9e9f97 Reviewed-on: https://chromium-review.googlesource.com/c/1392202 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#58502}
-
Clemens Hammacher authored
Bring ia32 in line with the arm implemention. Instead of computing the "half index" manually, pass the index and an enum pointing to either half. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ia3799a42fe2b9890aa4076d2e09947380331348e Reviewed-on: https://chromium-review.googlesource.com/c/1391758 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Apart from being more in-line with the style guide, this allows to use DEFINE_LAZY_LEAKY_OBJECT_GETTER for defining {TypeCache::Get}. R=tebbi@chromium.org Bug: v8:8562 Change-Id: I016b28624950ce9404180fc1ca1a232551f75cd0 Reviewed-on: https://chromium-review.googlesource.com/c/1392201Reviewed-by: -
Junliang Yan authored
Port f7f18b0f Original Commit Message: In preparation for converting JSEntry into a builtin. The root register used to be initialized by an embedded external reference, which is not isolate-independent. Pass in its value explicitly instead. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I447c880c7f840a012e53870e28e2bd3bfa552040 Reviewed-on: https://chromium-review.googlesource.com/c/1393288 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Clemens Hammacher authored
The first leak only happens if the default platform does not provide a page allocator, which is never the case in d8. I am not sure why the second leak was not detected so far. Anyway, this CL removes it. R=tebbi@chromium.org Change-Id: I215435f28a498298034e1657e7d2ebb8db8450c4 Reviewed-on: https://chromium-review.googlesource.com/c/1392197Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Bug: chromium:906567 Change-Id: Ic99c7a240ecb37c7b032b388f604d3f256d335b3 Reviewed-on: https://chromium-review.googlesource.com/c/1392196Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58497}
-
Vasili Skurydzin authored
Related: c6b0e12e [nojit] Refactor CallApiCallback calling convention a31338aa PPC/s390: [nojit] Refactor CallApiCallback calling convention Change-Id: I8f96c7b9a32ba3dde9dbbabb115d79fa36a0db46 Reviewed-on: https://chromium-review.googlesource.com/c/1380991Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Clemens Hammacher authored
And use it in several places in wasm. R=tebbi@chromium.org Bug: v8:8562 Change-Id: I1e857baf33e99849eb32ac2c94e39d7f27b180c8 Reviewed-on: https://chromium-review.googlesource.com/c/1391757 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Introduce a LeakyObject template and use that to implement static lazily initialized objects that never get destructed. This was done in a hand-crafted and complex way before via LazyInstance and LazyStaticInstance. R=tebbi@chromium.org Bug: v8:8600, v8:8562 Change-Id: Id160996753b2cb1baf0f4b2cec9e1727f1d01512 Reviewed-on: https://chromium-review.googlesource.com/c/1388539 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
In the description of the `v8_use_snapshot` gn arg, we had a link to the old location of our blog. R=mathias@chromium.org No-Try: true Change-Id: Ib7d0ae21f3e109b4fae9ca51a1c69d07d42f9017 Reviewed-on: https://chromium-review.googlesource.com/c/1392191Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58493}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ff33f8c..67f9fae Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ecf56e8..16717a6 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ieadefe1fbbe9660eb3eb29e106cbcfee186b399d Reviewed-on: https://chromium-review.googlesource.com/c/1392246Reviewed-by:
-
- 01 Jan, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2d305f3..ff33f8c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I24f35fc87d77ab782fde87b73ef1f51fedb022d7 Reviewed-on: https://chromium-review.googlesource.com/c/1392242Reviewed-by:
-
