- 16 Apr, 2019 14 commits
-
-
Sergiy Belozorov authored
The test is currently passing at over 90% of its timeout both on desktop and Android devices and already occasionally failing due to timeouts on Android. R=jarin@chromium.org, mvstanton@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:841700 Change-Id: Id1ba078d6a730d304935407426bdbfd0588a138b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569429Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60868}
-
Simon Zünd authored
The Torque compiler makes heavy use of scoped globals (contextuals). This created a problem for the design of the compiler interface: - Either the compiler provides all the necessary scopes itself, disallowing callers any access to the contextuals, which might contain data the caller is interested in (such as the compilation result). - Or the caller provides all the necessary scopes. This design was fine when the compiler executable was the only user. With the recent addition of unit tests and the language server, this interface became brittle, as missing scopes are only detected at runtime. This CL refactors the compiler interface to not leak contextual scopes past the interface boundary. Content of contextuals is collected and returned, providing access for the caller and freedom to either use the data directly or move it into the callers own scopes. R=sigurds@chromium.org Bug: v8:7793 Change-Id: Ieb988522d08fc6026b3fb74d976008e566146770 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529000 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60867}
-
Andrew Comminos authored
Adds CpuProfiler::SetUsePreciseSampling, which provides a hint whether to sacrifice CPU cycles to reduce the level of sampling interval variance. On Windows, this controls whether or not busy waiting is performed for sample rates < 100ms. Defaults to enabled (old behaviour). Bug: v8:3967 Change-Id: Iee84c3ae8132541c78b1f78bf294ec7c718bb19b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510577 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60866}
-
Simon Zünd authored
When a stack trace is captured, it is stored in a private symbol on the respective Error object. The first access to "Error.stack" will then format the stack trace, with a possible call into user JS via the Error.prepareStackTrace callback. Until now, the accessor converted ".stack" to a normal data property containing the formatted stack trace. This causes a new Map with a new DescriptorArray to be created, which will not be shared with anything else (also not other error objects with formated stack traces). This CL changes the accessor to store the formatted stack trace in the same symbol (stack_trace_symbol) as the structured data. The result is that an error object will have the same Map before and after "Error.stack" is accessed. Bug: v8:9115 Change-Id: I7d6bf49be76d63b57fbbaf904cc6ed7dbdbfb96b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564061 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60865}
-
tzik authored
After this CL, MicrotasksScope allows null MicrotaskQueue parameter, so that the user can migrate one-by-one from the default microtask queue to the finer grained one. Change-Id: Id519920a9d57e80e279026ad05a14422fb72b050 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559678Reviewed-by:
-
Joyee Cheung authored
Previously when an unresolved private name is not found in the current scope but found in an outer class scope, we forget to push it to the outer class scope so the name would never get bound. This patch simplifies ClassScope::ResolvePrivateNamesPartially() and removes the search in outer class scopes since they are incomplete at this point. Instead just push any private name that can't be resolved in the current scope to the outer class scope so that it gets handled later when the outer class scope is complete. Bug: chromium:952722 Change-Id: Ia0dda74cac57a0a1e25a9a09575f55633c6093b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1567709Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#60863}
-
tzik authored
Blink used to use v8::MicrotasksScope::GetCurrentDepth() to get the number of nested MicrotasksScope for the default microtask queue. However, there was no corresponding one for non-default queues. Change-Id: I1c2472ba19b1a11cb968f02119d91d92867c6e02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1567705Reviewed-by:
-
peterwmwong authored
Bug: v8:8976 Change-Id: I2d5131c2a1d96e5d5e0114efac3b1b2c3497351d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566249Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#60861}
-
Simon Zünd authored
This is a reland of ffe6940f The UBSan issue is fixed with https://crrev.com/c/1566511 TBR=tebbi@chromium.org Original change's description: > Reland^2 "[torque] Throw exception instead of aborting if something goes wrong" > > This is a reland of 251d1623 > > The reland fixes ASAN component builds by adding RTTI build config to both > torque executables. Big thanks to sigurds for finding the fix. > > Original change's description: > > Reland "[torque] Throw exception instead of aborting if something goes wrong" > > > > This is a reland of 3bd49f9b > > > > The issue on the windows bot is apparently a compiler bug in MSVC related to > > move construction. The fix seems to be to change the order of the fields in > > "JsonParseResult" (go figure). > > > > Drive-by-change: Fix LS on windows by emitting correct line endings and > > enabling exceptions for the LS executable as well. > > > > Original change's description: > > > [torque] Throw exception instead of aborting if something goes wrong > > > > > > This CL enables exceptions for the Torque compiler and Torque language > > > server. Instead of aborting when something goes wrong during > > > compilation, a TorqueError is thrown, containing the error message > > > and a source position. The compiler executable still prints the error > > > and aborts, while the language server will pass this information > > > along to the client (not included in this CL). > > > > > > R=danno@chromium.org > > > > > > Bug: v8:8880 > > > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003 > > > Reviewed-by: Daniel Clifford <danno@chromium.org> > > > Commit-Queue: Simon Zünd <szuend@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#60512} > > > > Bug: v8:8880 > > Change-Id: I00e6591bbb4c516dd7540a7e27196853bc637f11 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545995 > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > > Commit-Queue: Simon Zünd <szuend@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#60736} > > Bug: v8:8880 > Change-Id: Iba198d771169283e83e74324f27aa9e90b8d8975 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1563770 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60804} Bug: v8:8880 Change-Id: I5b7e40ad27bff8f7bfa22240954c2cb75083ad82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564065Reviewed-by:
-
Michael Achenbach authored
Those tests were wrongly reenabled in: https://crrev.com/c/1565892 They don't fail assertOptimized, but other GC sensitive assertions. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:9127 Change-Id: Ic1f7838dca5c2e6917f245d84e6c1e0b9414396d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569426Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60859}
-
tzik authored
MicrotasksPolicy was a missing functionality of MicrotaskQueue that was available on the per-Isolate MicrotaskQueue. This expose that as a construction time option. Change-Id: I22bcc8082ca64552d107ee6db138011654047861 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559677Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a7f62a0..f202325 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/218cb3d..d5c58b8 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/fbddc46..9b96c3d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b614c56..2f423f7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/db58954..4b79c38 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5f253f8..edee5c0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic0f239e9a7438cec2012483f6043c3f64c99a801 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1568947Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60857}
-
Frank Tang authored
Use ICU64 new API formatStringsToValue Bug: v8:8836 Change-Id: I7399a301b2536f331b1df1e1845adf2e533bafb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1560659 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#60856}
-
Adam Klein authored
This is a reland of 656f57bd, which was reverted due to Blink test failures. Those failures have been temporarily suppressed. Original change's description: > [wasm] Add off-by-default runtime flag for growing shared memory > > Grow memory isn't ready to ship in M75. > > Bug: v8:8564, chromium:951795 > Change-Id: I75602bce833653b7943f5606236a97ca6dbad5c9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566239 > Reviewed-by: Ben Smith <binji@chromium.org> > Commit-Queue: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60836} Bug: v8:8564, chromium:951795 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Change-Id: If096f76b4d5d1f5cbcb98e9c11a525a540e21f14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1568125Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#60855}
-
- 15 Apr, 2019 16 commits
-
-
Sathya Gunasekaran authored
This reverts commit f4a747b7. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite%20-%20debug/3001 Original change's description: > [parser] Skip TDZ Checks in more cases of let and const > > The parser can now skip TDZ checks for cases when a reference is in, > or nested in, a scope that's both a sibling of the declaration and > created by a function expression. > > Bug: v8:7331 > Change-Id: Ia9748b5a8faa3037873efe5081837f5d0aa74115 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1542042 > Commit-Queue: Suraj Sharma <surshar@microsoft.com> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60853} TBR=adamk@chromium.org,verwaest@chromium.org,surshar@microsoft.com Change-Id: Iaa34b1f7cafcc0e77cd7cc20372885b1904bd827 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7331 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1568078Reviewed-by:
-
Suraj Sharma authored
The parser can now skip TDZ checks for cases when a reference is in, or nested in, a scope that's both a sibling of the declaration and created by a function expression. Bug: v8:7331 Change-Id: Ia9748b5a8faa3037873efe5081837f5d0aa74115 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1542042 Commit-Queue: Suraj Sharma <surshar@microsoft.com> Reviewed-by:
-
Bill Ticehurst authored
Check if storage for thread_local variables has been allocated before attempting to access such variables, as exceptions may be raised in the thread before this initializion is complete, causing an infinite loop. Bug: v8:8966 Change-Id: Ifc6223b74999a55bfd0ed2d6ebf054bbffd7e809 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507714 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60852}
-
Tom Anderson authored
libc++ will assert when indexing one element past the end of a vector, but V8 uses this as the end iterator for ScopedPtrList. Similarly, when there's no elements in the vector, v[0] will also assert, so ScopedPtrList::begin() needs to be updated too. This CL changes ScopedPtrList to use std::vector::data() to get the iterators. BUG=chromium:923166 TBR=machenbach Change-Id: Ic6a5176611d52ed592da743ecce44287c452b379 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565543 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#60851}
-
Clemens Hammacher authored
We are missing wasm code ref scopes, and fail layout tests: https://ci.chromium.org/p/chromium/builders/try/linux-rel/69013 This CL fixes this by managing ref counts explicitly in the LogCodesTask. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I86ee09da7b36abf184c5a64a5b0648a3e39c1bb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565902 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60850}
-
Michael Lippautz authored
Edge names are not always string constants and have to be deleted at some point. Copy them over to StringStorage to allow the embedder freeing up their copy. Bug: chromium:936797 Change-Id: I1c1a617c79c2016b3bd30c3460bb7a47edce1b95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565903 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Hablich authored
This reverts commit 656f57bd. Reason for revert: This blocks lkgr advancement/rolling, see https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/31263. Please fix upstream tests first. Original change's description: > [wasm] Add off-by-default runtime flag for growing shared memory > > Grow memory isn't ready to ship in M75. > > Bug: v8:8564, chromium:951795 > Change-Id: I75602bce833653b7943f5606236a97ca6dbad5c9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566239 > Reviewed-by: Ben Smith <binji@chromium.org> > Commit-Queue: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60836} TBR=binji@chromium.org,adamk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8564, chromium:951795 Change-Id: If212f1b21699394b66e9e306d12a3baf37ccf4b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565901Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#60848}
-
Dan Elphick authored
While crrev.com/c/1520721 tried to avoid collecting source positions when throw exceptions, it failed because they were still collected in Isolate::CaptureStackTrace. This removes that collection point and lets SetStackFrameCacheCommon bail out when trying to set the stack frame cache for a bytecode that doesn't have source positions. It also adds tests that ensure source positions are not collected when an exception is thrown (although one is disabled as it does not yet work). Bug: v8:8510 Change-Id: Id5caf579dda549d637fa9b3129c419d524be5ff2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565898 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#60847}
-
Frederik Gossen authored
Added test cases for entirely lazily compiled modules. They are treated just like empty modules are. Bug: v8:9003 Change-Id: Ic0fcae7de32e50a0aac271567c18159bf8154028 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1562130 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60846}
-
Clemens Hammacher authored
This CL introduces the first (and most important) place where we need to decrement the ref count of wasm code. When installing new code in the code table and jump table, the prior code becomes unreachable via new function calls. This change executes many code paths that were unreachable before, since the ref count was never decremented. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: Ibe33df562f240f7cd5996f6061809e93838be425 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566512Reviewed-by:
-
Michael Starzinger authored
This makes sure that all overrides of {StackFrame::unchecked_code} return a value, even if there is no {Code} object associated with the frame. This ensures debug functions like {StackTraceFailureMessage} continue working for all stack traces. R=neis@chromium.org BUG=chromium:952761 Change-Id: Ie42b301e4d43ebf67acc80e6c1b7bcb4cdc7c947 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566515Reviewed-by:Georg Neis <neis@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60844}
-
Clemens Hammacher authored
Since {NativeModule::GetCode} returns a raw pointer to {WasmCode}, it needs to increment the reference counter on that code object. {HasCode} on the other hand does not return a code pointer, so it's implemented separately now. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I812981aaf89281fb0296682114f248079e57a5e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566514Reviewed-by: -
Peter Marshall authored
- Remove AllocationSpaceName() which was in SHOUTY_CASE and did not actually handle CODE_LO_SPACE. - Make GetSpaceName() static because it is. - Change callers of old AllocationSpaceName() to use GetSpaceName(). - Change the input type to a AllocationSpace rather than int given the function crashes on invalid values. Space::name() now returns a lower case result but this is only used by functions guarded by gc_verbose or trace_fragmentation so I don't think this will break anything. Change-Id: Ice9a955365d4a22233af7ba39126ad8e5cff2aab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565474 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60842}
-
Sergiy Belozorov authored
Even though we override chromiums UBSan settings in our own BUILD.gn to include all sanitizers, vptr is still excluded. The reason is that the vptr sanitizer requires RTTI to be enabled. The "is_ubsan_vptr" flag will enable RTTI as well as some linker flags to export libc++abi symbols. Both are required by the vptr sanitizer. Change-Id: I803ed71781bb3edc824bbe5d1aaa830841b4b304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566511Reviewed-by:
-
Sergiy Belozorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bee1272..a7f62a0 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2309843..b614c56 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/4ae7482..35f7e13 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Bug: v8:9131 Change-Id: Ie342eb673ea4c987bc8f2010e37e15a6626ae9d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1567282 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Frederik Gossen authored
Tests streaming compilation with Wasm compilation hints enabled. In particular, validation errors in lazily compiled functions are covered. Bug: v8:9003 Change-Id: I81611988b8451ce2f6562962dbd50561f5086aef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561310 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by:
-
- 13 Apr, 2019 3 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f10a653..bee1272 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/095babf..2309843 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1de3cd4..db58954 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ice4dafc17dcddb8f9a6026ce4f4bca8f3ec1cd67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566248Reviewed-by:
-
Yu Yin authored
port https://crrev.com/c/1541476 Original Commit Message: This CL adds handling for cleaning up weakmap (EphemeronHashTable) keys during scavenge, even if the weakmap resides in oldspace. Change-Id: If0598a499641ba502b00857204e32ca63e0712c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564320Reviewed-by:
-
Adam Klein authored
Grow memory isn't ready to ship in M75. Bug: v8:8564, chromium:951795 Change-Id: I75602bce833653b7943f5606236a97ca6dbad5c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566239Reviewed-by:
-
- 12 Apr, 2019 7 commits
-
-
Sathya Gunasekaran authored
Bug: v8:9060 Change-Id: Ibea24457354a6b7d32449ae41c680ff37481341e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565541Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#60835}
-
Z Duong Nguyen-Huu authored
Basically, SetPropertyInternal is called without handling COW map. Improve test coverage as well. Bug: chromium:951438 Change-Id: Iea8c818ab6a8ddea204f86a9d676a1ea42fd07f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1562731 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Ross McIlroy authored
Should no longer be flaky since bug is fixed. BUG=v8:8964 TBR=machenbach@chromium.org Change-Id: I3fc124aca8bcfc16ddf7560d48d84dc01d4ce332 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564069Reviewed-by:
-
Sathya Gunasekaran authored
This reverts commit 68ba8574. Reason for revert: breaks windows builds https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20builder/27839 Original change's description: > Fix array.concat with double for sealed, frozen object > > Treat packed sealed, frozen element as packed element. > Also rename to IsPackedFrozenOrSealedElementsKind. > > Bug: chromium:951988 > Change-Id: Ia636f0a14a229e4c44772627728927db1b877f27 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565470 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#60831} TBR=jarin@chromium.org,ishell@chromium.org,verwaest@chromium.org,duongn@microsoft.com Change-Id: I84caf106dbdd2209aef0a994173e1c3982e9f7b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:951988 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565542Reviewed-by:
-
Z Duong Nguyen-Huu authored
Treat packed sealed, frozen element as packed element. Also rename to IsPackedFrozenOrSealedElementsKind. Bug: chromium:951988 Change-Id: Ia636f0a14a229e4c44772627728927db1b877f27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565470Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:9060 Change-Id: Ia58f7f9e19726f26dd09665d32efc1037f71e7e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1560409 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Z Duong Nguyen-Huu authored
For slow-path of array.includes, it should be able to handle if arguments is undefined for sealed/frozen object Bug: chromium:951780 Change-Id: I42dcf1e23ab07bfcd87e7a5d27b52e66b2d1d2ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565031Reviewed-by:
-
