- 05 Jan, 2018 21 commits
-
-
Eric Holk authored
This is a step towards falling back on bounds checks when there are too many guarded Wasm memories. Bug: v8:7143 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I01916cbdd5ddb08fe1d946ab83b801f37a8fe1c6 Reviewed-on: https://chromium-review.googlesource.com/832944 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#50390}
-
Yang Guo authored
Turns out gclient calls download_from_google_storage, which needs to be included in PATH. TBR=machenbach@chromium.org Bug: v8:6105 Change-Id: I15d44d67152f6fa0d20ae7bc7e44bc5e0393b519 Reviewed-on: https://chromium-review.googlesource.com/852616Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50389}
-
Karl Schimpf authored
Fixes nits found by @clemensh after CL https://chromium-review.googlesource.com/c/v8/v8/+/834670 was committed. That is, the code uses static asserts instead of assert. Bug: v8:7226 Change-Id: I5488ec4609d1bee3aafa61a3ff2505f71b06d80d Reviewed-on: https://chromium-review.googlesource.com/847687Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Cr-Commit-Position: refs/heads/master@{#50388}
-
Sathya Gunasekaran authored
Bug: v8:5367 Change-Id: Ieb7b04f47bbad575c22a3a16ec7bd7cb9e8ba0c9 Reviewed-on: https://chromium-review.googlesource.com/851425Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#50387}
-
Michael Achenbach authored
This reverts commit 86bc1517. Reason for revert: breaks gcc bot: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/17209 Original change's description: > [wasm] remove kExecuteSimdLowered mode from wasm cctest > > R=clemensh@chromium.org,titzer@chromium.org,bbudge@chromium.org,gdeepti@chromium.org > BUG=v8:7028 > > Change-Id: Ie0b984ebd18e267cdaf7aaff9f17fb4328d8e5fa > Reviewed-on: https://chromium-review.googlesource.com/849638 > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50385} TBR=bbudge@chromium.org,titzer@chromium.org,gdeepti@chromium.org,aseemgarg@chromium.org,ahaas@chromium.org,clemensh@chromium.org Change-Id: I890b8810ea802fe2b9273def07c9056d4b904a4e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7028 Reviewed-on: https://chromium-review.googlesource.com/852712Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50386}
-
Aseem Garg authored
R=clemensh@chromium.org,titzer@chromium.org,bbudge@chromium.org,gdeepti@chromium.org BUG=v8:7028 Change-Id: Ie0b984ebd18e267cdaf7aaff9f17fb4328d8e5fa Reviewed-on: https://chromium-review.googlesource.com/849638 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
-
Yang Guo authored
Otherwise dynamic linking with dlopen, as is the case with Node.js addons, would not work. R=fhinkel@chromium.org Bug: v8:6105 Change-Id: I5a884afc003fdfdb9de7e9b0c736f1894ba0019a Reviewed-on: https://chromium-review.googlesource.com/850112 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Karl Schimpf authored
This CL removes some magic numbers used to convert floating values into integer values, and the corresponding comments describing how they were computed. It replaces these tests with template function is_inbounds() that makes the compiler automatically generate the appropriate constants and tests. Note: This CL only changes the WASM interpreter to use is_inbounds(). Tests have not yet been updated to guarantee that this change did not break anything. Note: This change was initialed by a comment by @clemensh in CL https://chromium-review.googlesource.com/c/v8/v8/+/834670. Bug: v8:7226 Change-Id: I14c0962eb6ae20cf6647787c006924a208f7ce4a Reviewed-on: https://chromium-review.googlesource.com/846280 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by:
-
Michael Achenbach authored
TBR=jgruber@chromium.org NOTRY=true Bug: v8:7120 Change-Id: Ib8375e6ad811d9299c9a477ed39c6bc76c0c90dd Reviewed-on: https://chromium-review.googlesource.com/852232 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: chromium:798982 Change-Id: I0aa2bee5bf33884fa9bfc15da3053d817e1a1b49 Reviewed-on: https://chromium-review.googlesource.com/852212Reviewed-by:
-
Clemens Hammacher authored
This adds the gn flag 'v8_untrusted_code_mitigations', which defaults to true. If false, the DISABLE_UNTRUSTED_CODE_MITIGATIONS preprocessor macro will be defined, which sets the default for the --untrusted-code-mitigations runtime flag to false. R=machenbach@chromium.org, hablich@chromium.org CC=bmeurer@chromium.org Bug: chromium:798964 Change-Id: Ief037e194dc9eeb7fe224b5d414a4ea8e69beb20 Reviewed-on: https://chromium-review.googlesource.com/852074 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: chromium:799263 Change-Id: I656d6b621234f2f0a7f379866a114b8cb66eca25 Reviewed-on: https://chromium-review.googlesource.com/852072Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#50379}
-
Michael Achenbach authored
Bug: chromium:798982 Change-Id: I096e2df5a5f8d038c980bc9f575857256f0a01df Reviewed-on: https://chromium-review.googlesource.com/852073Reviewed-by:
-
Michael Achenbach authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9f00b2f..1a03e2d Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/a2e9bc7..7d781b3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/035dfdb..95f3b4d Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/07e0150..ac1e5f7 Rolling v8/tools/luci-go: https://chromium.googlesource.com/chromium/src/tools/luci-go/+log/564ab65..d882048 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib122ca284f689874dae7790a359cbe4052b37280 Bug: Reviewed-on: https://chromium-review.googlesource.com/851572 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#50377}
-
Clemens Hammacher authored
Flags can be passed as "--any_flag" or "--any-flag". It seems that people generally prefer the second form, but our help outputs the first one. Avoid confusion by outputting the second form. R=bmeurer@chromium.org Change-Id: I21e07a7d2484ae78ccd27736f8373d53eb312818 Reviewed-on: https://chromium-review.googlesource.com/850692Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50376}
-
Clemens Hammacher authored
Even though kSpecMaxWasmMemoryPages == WasmModule::kPageSize, the computation {wasm::kV8MaxWasmMemoryPages * wasm::kSpecMaxWasmMemoryPages} is semantically wrong. R=titzer@chromium.org Change-Id: If4a875c714f1ca3c1fc928ec79b8be8aab62e8d0 Reviewed-on: https://chromium-review.googlesource.com/850072Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50375}
-
Jaroslav Sevcik authored
This makes the bitcasts that change pointerness effectful so that they are not accidentally reordered with memory allocation. Change-Id: I70e820fc0de1adb2a81b52a43bce4d47f2c304b9 Reviewed-on: https://chromium-review.googlesource.com/852052Reviewed-by:
-
Clemens Hammacher authored
Remove the --extra-masking and --mask-array-index flags. Instead, use --untrusted-code-mitigations directly. This also changes the default for these flags: There were off by default so far, but --untrusted_code_mitigations is on by default. Store the value of the untrusted_code_mitigations flag in the CompilationInfo in order to ensure that it stays consistent during the compilation of one function. R=jarin@chromium.org, bmeurer@chromium.org, hablich@chromium.org CC=rmcilroy@chromium.org Bug: chromium:798964 Change-Id: I15a919e741f0628afa6a6ea1e8274ad0c4399929 Reviewed-on: https://chromium-review.googlesource.com/850412 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#50373}
-
Benedikt Meurer authored
Previously the Promise builtins would always use a runtime function to schedule a new microtask, which is unnecessarily expensive. Since the runtime function only adds the microtask to a FixedArray (potentially growing that array) and increments the number of pending microtasks, it is fairly straight-forward to do this in CSA land instead. This change improves the Bluebird benchmarks by 2-4% on average. Bug: v8:7253 Change-Id: I77e96b9e5afbb4bdbe129b6bb289d9905ed581bf Reviewed-on: https://chromium-review.googlesource.com/851972 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
WasmGraphBuilder contains fields which store state which is modified during graph construction, other fields store information which is never modified. Make the latter fields const. R=mtrofin@chromium.org Change-Id: I3ea57fbca6b24247989f5ae7260ffed2013ad82a Reviewed-on: https://chromium-review.googlesource.com/850396 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#50371}
-
Clemens Hammacher authored
Add a flag which controls our mitigations for executing untrusted code, in particular mitigations against speculative side channel attacks. The new flag (--untrusted-code-mitigations) is enabled by default, and currently only controls the mitigations we do in wasm. In the future, it should also replace the --extra-masking flag controlling our javascript mitigations. R=bradnelson@chromium.org, bmeurer@chromium.org CC=hablich@chromium.org Bug: chromium:798964 Change-Id: I94a008fdb95b6bce07d547a8b81ec9f23f392496 Reviewed-on: https://chromium-review.googlesource.com/850212Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50370}
-
- 04 Jan, 2018 19 commits
-
-
Sathya Gunasekaran authored
Create a new function kind for initializer functions and ban arguments if used in such a function. Bug: v8:5367, v8:7183 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id3089e587b3d6a25f27224045f250e032b831818 Reviewed-on: https://chromium-review.googlesource.com/850547 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Yang Guo authored
These APIs have been marked as deprecated for more than 6 months. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I4f05a8904c367f335be7e159709f564362c8bbd9 Reviewed-on: https://chromium-review.googlesource.com/848782Reviewed-by:
-
Benedikt Meurer authored
This changes the names of the builtins on the Promise.prototype to match the general naming convention and make it easier to tell what the builtin is about just by looking at its name. Bug: v8:7253 Change-Id: I906cc6fc14a6b9d8ffe9c0dcfd94b50439c4cfcf Reviewed-on: https://chromium-review.googlesource.com/850698Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50367}
-
Benedikt Meurer authored
This is a simple refactoring to make the code dealing with the marker symbols for the default resolve/reject handlers more readable. Bug: v8:7253 Change-Id: Ife279e77007d52ad11fed3726009d60d7c352c33 Reviewed-on: https://chromium-review.googlesource.com/850696Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I7bc5d09ff19a9cf7cb4bee68ca6cf34f5cfa8b19 Reviewed-on: https://chromium-review.googlesource.com/850874 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
This patch breaks out bailout reasons into two enum classes. This helps save 3 bits on the SharedFunctionInfo as we don't have to track the abort reasons. Change-Id: Ic2e7e7e32b0fa31491f1c6f0003a61390d68fd97 Reviewed-on: https://chromium-review.googlesource.com/848244Reviewed-by:
-
Mike Stanton authored
The initial fast array may change, invalidating assumptions. Bug: chromium:798026 Change-Id: Iddcc40867221a2a58aef33b64e7399e0f2784e89 Reviewed-on: https://chromium-review.googlesource.com/850356 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#50363}
-
Franziska Hinkelmann authored
This reverts commit d5fbf7c5. Reason for revert: Performance regression, see https://bugs.chromium.org/p/chromium/issues/detail?id=798279 Original change's description: > [api] Prefer Descriptor interceptor over Getter in GetPropertyAttributes > > Also fix GetPropertyDescriptorWithInterceptor so that it only calls the > interceptor once. > > R=ahaas@chromium.org, franzih@chromium.org > > Bug: node:17480, node:17481 > Change-Id: I2c3813f80df2962ec909bae7267884ce0b8ccbef > Reviewed-on: https://chromium-review.googlesource.com/816515 > Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> > Reviewed-by: Franziska Hinkelmann <franzih@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50260} TBR=timothygu99@gmail.com,ahaas@chromium.org,franzih@chromium.org,sergiyb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: node:17480, node:17481 Change-Id: I4997e0f3a330d719026e56dd83c1bb999b986bcf Reviewed-on: https://chromium-review.googlesource.com/850355Reviewed-by:
Franziska Hinkelmann <franzih@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#50362}
-
Michal Majewski authored
I added additional exception logging in the execution.py since errors in processing results were really difficult to debug. There is a problem on Windows with class serialization when it comes from dynamically loaded module. To fix it I moved all output processors to the tools/testrunner/outproc/ and import them in test/*/testcfg.py. Bug: v8:6917 Change-Id: Ida604641d659b006e91faf1d56a37769ec47f5f3 Reviewed-on: https://chromium-review.googlesource.com/842784 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Tobias Tebbi authored
DeadValue was a constant node of type None. This is unsound in the presence of re-scheduling. This CL adds a value input to DeadValue, which preserves the dependency on the original node of type None. This reland addresses the bug that the EffectControlLinearizer could destroy dependencies of DeadValue by attaching DeadValue nodes to the effect chain in the EffectControlLinearizer. Bug: chromium:796041 chromium:798938 Change-Id: If47b54a7986d257eb63b437f855769b503679ff5 Reviewed-on: https://chromium-review.googlesource.com/850392Reviewed-by:
-
Benedikt Meurer authored
The Promise builtins call out to arbitrary JavaScript a lot, but always use the generic Call builtin with the "any" mode, which means that the builtin has to dispatch based on the type of receiver. Yet these builtins always know for sure that the receiver is either undefined or definitely not null or undefined. So this changes the builtins to pass the correct ConvertReceiverMode and thus save a couple of checks. Bug: v8:7253 Change-Id: I4efbc1e379169cbeefc40e5455713cd7fbe947ed Reviewed-on: https://chromium-review.googlesource.com/850000 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Mike Stanton authored
Array.prototype.{forEach, filter, map, every} get this support with the help of a new opcode NumberIsFloat64Hole. Bug: v8:1956 Change-Id: Ic6a785590cec66bae4c1462c19d6843c0aa5473b Reviewed-on: https://chromium-review.googlesource.com/847435Reviewed-by:Daniel Clifford <danno@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#50358}
-
Mike Stanton authored
Bug: v8:1956 Change-Id: Ie941811110b3c106e252a2621544864673074da5 Reviewed-on: https://chromium-review.googlesource.com/846759Reviewed-by:
-
Tobias Tebbi authored
Revert "[turbofan] add value input to DeadValue" and "[turbofan] add regression test for chromium:796041" This reverts https://chromium-review.googlesource.com/c/v8/v8/+/848995 and https://chromium-review.googlesource.com/c/v8/v8/+/847011 Bug: chromium:798938 Change-Id: I4be8e5bca77037a278fd9882f0d76de1ae12c23f TBR: jarin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/849995Reviewed-by:
-
Clemens Hammacher authored
This adds support for get_local and set_local to the wasm compile fuzzer. Each function will have between 0 and 32 locals of random type. For set_local, we generate a value of the respective type and store it in the local. For get_local, we load any local and convert it to the wanted type. Note that with get_local, we now also check that parameters are passed correctly between functions. Drive-by: Fix parameters passed to the main function (was [1,2,3] for the interpreter, but [1,1,1] for compiled code). R=ahaas@chromium.org, eholk@chromium.org Change-Id: I38e85fe25b1fb4ac298fa81ec8e33711294e78bb Reviewed-on: https://chromium-review.googlesource.com/847535Reviewed-by:
Eric Holk <eholk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50355}
-
Sigurd Schneider authored
These checks seem to be redundant, since the relevant information of both Array.prototype and Object.prototype is already guarded by the NoElements protector, which guarantees no indexed data and accessor properties. Bug: v8:7127, v8:7205 Change-Id: I0785c31670c04a3db29eefdc2f75cc63971fed3b Reviewed-on: https://chromium-review.googlesource.com/848780 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This removes a stability check from CanInlineArrayResizeOperation. This is safe, since all prototype maps are either stable or in dictionary mode, where the latter is ruled out separately. Bug: v8:7127, v8:7205 Change-Id: I3a07805cb89f41adf031c6c2a6dd5b2defcb87a8 Reviewed-on: https://chromium-review.googlesource.com/848778 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7127, v8:7205 Change-Id: I9c4af8b604845861f4e29b872cc516fdeb89b519 Reviewed-on: https://chromium-review.googlesource.com/848999Reviewed-by:
-
Mostyn Bramley-Moore authored
Bug: v8:7127, v8:7204, v8:7205 Change-Id: Iedea388590991e4d0edcf59e02c767b6c04460e7 Reviewed-on: https://chromium-review.googlesource.com/849216Reviewed-by:
-
