- 17 Dec, 2019 3 commits
-
-
Maya Lekova authored
MapRef::GetStrongValue now returns an Optional to account for the case where we can't figure out the name of the bound function during serialization. We could reach out to the heap in the future in this case. Fixed: chromium:1034203 Change-Id: I9fa81921b5dbd8bc9f68aa3c10921bc01b695a6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967386Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#65470}
-
Peter Marshall authored
Add an API on Isolate that returns a sorted vector of code pages allocated within V8. The implementation is designed to be signal-safe, so that the user (the UMA sampling profiler) can access this information from a signal handler, where allocation and taking locks is prohibited. This CL adds the machinery for maintaining the list of allocated code pages. Further CLs will modify the Unwinder API itself to accept the code pages provided by this API. The unwinder API currently uses the reserved virtual-memory range called the CodeRange to identify where all V8 code objects live, but this doesn't exist on arm32 or any 32-bit platform, so this approach adds a way to expose the location of all valid V8 code objects in a signal-safe way for use by the UMA sampling profiler. On 64-bit, this API always gives the code_range and embedded_code_range, and does not maintain a vector of code pages. This is so that we have a unified API on 32 and 64-bit that can be used in exactly the same way by embedders. Design doc: https://docs.google.com/document/d/1VGwUult5AHLRk658VetwEHMOmDDxA2eDQs9lDFMZTE0 Bug: v8:8116 Change-Id: I732509a45121fc54853182481c24d1083275afce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564068 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65469}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/03d0c36..2da4a4a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/69337c3..b119e4e TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I6f83c95169248851b32bf2ec4f95144b8df295fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970152Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65468}
-
- 16 Dec, 2019 14 commits
-
-
Ng Zhi An authored
Liftoff supports unfixed stack slot sizes now, so we can have SlotSizeForType return different values based on the value type it is spilling. We make the change for architectures that support unaligned access, x64, ia32, arm64. Note for ppc/s390/mips/mips64 ports: SlotSizeForType remains as 8 byte (old behavior), but can be changed. This patch also makes adjustments to PatchPrepareStackFrame to align sp to appropriate values (pointer size). Bug: v8:9909 Change-Id: Iddd2dcd652b162a04a02ed704c5b06f6af8a186d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1956165 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65467}
-
Milad Farazmand authored
Port 0f8769df R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ica16f208f429d637faef14942d31ed66527b3dab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1969064Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65466}
-
Joshua Litt authored
Bug: v8:9838 Change-Id: I9cfa7af623af3b387962ea4fa90cfc599612f976 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958961Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65465}
-
Victor Gomes authored
Change-Id: I0657847fd58d9dc08e5bbdc37c6c0dcc9527e5eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967378 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65464}
-
Clemens Backes authored
The {cmp} instruction might add an entry to the constant pool at a time where we didn't expect any entries to be added. This can be fixed by moving the {CheckConstPool} call *after* the {cmp}. R=mslekova@chromium.org Bug: chromium:1034394 Change-Id: If075ad0b02e2973a734d70d9e58c205bd14e6a33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967380Reviewed-by: -
Shu-yu Guo authored
This is in preparation to hold on to unregister tokens weakly. The key map will be changed to be keyed off the tokens' identity hash instead of the token objects themselves. Once changed, a WeakCell's key (its token's hash) will be different from its unregister token. In particular, in case of collision, WeakCells with different unregister tokens may have the same key. Bug: v8:8179 Change-Id: Ifa18ace915265340db7f01431161a6e0425f2927 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1968958 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Joshua Litt authored
Bug: v8:9838 Change-Id: I4111e17515d5f2b440e30d08582174047be4b92b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1957761Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65461}
-
Michael Achenbach authored
Some test cases stress all global functions and hang when calling readline. No-Try: true Bug: chromium:1034285 Change-Id: I0eaf64437c0806cf3df0a5306aecea4367763cad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967381 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=ecmziegler@chromium.org Bug: v8:10063 Change-Id: I2c962e4c91578dd82ff40df1b2b69aeee7dbbf18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967379Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#65459}
-
Thibaud Michaud authored
Add a lock to prevent races between {WasmImportWrapperCache::Get} and the cache modification scope. R=clemensb@chromium.org Change-Id: Ife281c127c765d3ca57f58c975e15a76833983ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965588 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: -
Clemens Backes authored
If you are not using them too often, their relationship and meaning is not totally obvious. Especially that {kTaggedSigned} means "uncompressed Smi" cannot be inferred from the name. R=neis@chromium.org Bug: v8:10021 Change-Id: If684b87ba24da0bbce846d4e35a790c2ee96116b No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967374Reviewed-by: -
Dominik Inführ authored
PrototypeUsers::Add now iterates the WeakArrayList to find empty slots before growing the array. Not reusing empty slots caused a memory leak. It might also be desirable to shrink the WeakArrayList in the future. Right now it is only compacted when invoking CreateBlob. Also removed unused PrototypeUsers::IsEmptySlot declaration. Bug: v8:10031 Change-Id: I570ec78fca37e8f0c794f1f40846a4daab47c225 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967317Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#65456}
-
Tobias Tebbi authored
This makes it obvious that methods are actually macros. Also, in the future, we might allow methods that are actually builtins. Bug: v8:7793 Change-Id: Ib641c4b5a222b27c67aa0c31fd3611ed4a11842c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967330Reviewed-by:
-
Santiago Aboy Solanes authored
This is a reland of c924f54e Reason: Added back a bitcast that was supposed to be redundant (but it wasn't) Changes can be seen from patchets 1..3. Original change's description: > [turbofan][ptr-compr] Remove redundant ChangeTaggedToCompressed > > The final goal is to eliminate it altogether. This CL just > eliminate the redundant ones. > > Bug: v8:7703 > Change-Id: If6e718c373fca7c65ce46c347533ec4550fbc444 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950968 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65398} Bug: v8:7703 Change-Id: I099e67d0255d4ad5529a73b272df893069374136 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965582Reviewed-by:
-
- 15 Dec, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9caeb8b..03d0c36 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ifb2da55fd51334b96b5000bd956d0fd12f47d1a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965537Reviewed-by:
-
- 14 Dec, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1c5a738..9caeb8b Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/6b3e658..fa02977 Rolling v8/buildtools/linux64: git_revision:ad9e442d92dcd9ee73a557428cfc336b55cbd533..git_revision:6feb55993083dfd27b93da195c8a82a3a9529848 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b34e896..69337c3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f1ad6e4..ba4699f TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie45bced17927efd17403d65731a6c90cbeadb0e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1966143Reviewed-by:
-
- 13 Dec, 2019 15 commits
-
-
Tobias Tebbi authored
Drive-by cleanup: improve prining of lists Bug: v8:7793 Change-Id: I84d2d5c64ae3cb564acf53d93ea4f12a829b787d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967328Reviewed-by:
Joshua Litt <joshualitt@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65451}
-
Michael Achenbach authored
This reverts commit 83786cb4. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux%20Debug/2037 Original change's description: > Delay setting up deserialized JSArrayBuffer > > Setting up JSArrayBuffer may trigger GC. Delay this until we > are done with deserialization. > > R=ulan@chromium.org > > Bug: chromium:1033395 > Change-Id: I6c79bc47421bc2662dc1906534fc8e820c351ced > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965580 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65441} TBR=ulan@chromium.org,yangguo@chromium.org,petermarshall@chromium.org Change-Id: I77b8ae836e9003eaaccef440dfaf3ae840c112cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1033395 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967327Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65450}
-
Anna Henningsen authored
This improves documentation about some things that came up in conversation and things that I noticed while working on those other things. :) Change-Id: I4f47cec6594f7b331259bea8ed506f5de908d438 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954386 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Johannes Henkel authored
New revision: 726836d7317a4031f48af9960bab51d7a2ab2867 The gist is that serialization is direct from protocol objects to CBOR, no more detour via protocol::Value. Upstream PRs: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1956388 https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1966418 Also: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1941035 Change-Id: I89f742a4fd47b5eb8ebd98ce6e10ecba0501cf66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958956Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65448}
-
Jakob Kummerow authored
This reverts commit 5f8e95c1. Reason for revert: crbug.com/1033418. TypedArrays are not, by default, concat-spreadable; the existing code is inconsistent and this CL didn't update/fix enough of it. Original change's description: > Fix ArrayConcat length estimation for TypedArrays > > TypedArrays cannot be handled on the JSArray path. > This patch should provide a minor performance improvement while > being functionally non-observable. > > Change-Id: I05259517b9079aa715b3cf4be9b0cf6bb47236ac > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948712 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65419} TBR=jkummerow@chromium.org,ishell@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1033418 Change-Id: I345c8ebc38be6df42d5bdbecd0d06d19967ad6f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967324 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Joshua Litt authored
Bug: v8:9838 Change-Id: I770133cdf719efeee8de9415bda0586d0f5ac8d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954329Reviewed-by:
-
Dominik Inführ authored
Maximum semispace size was capped at kMaxSemiSpaceSize. Also allow non-power-of-2 sizes. Change-Id: I3385674a13455b47802a3f6e62ac5b9ed3987264 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962863Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
This new testing allocator for ArrayBuffers uses a small real allocation that is repeatedly mapped into the requested allocation size. Its purpose is to allow testing of huge TypedArrays without actually consuming a huge amount of memory, at the expense of correct behavior (elements will alias each other). It is only supported on Linux for now, and of course off by default. Bug: v8:4153 Change-Id: I4917a78b6190dc075dc4614ebe2696e63addc8c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962270 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=hpayer@chromium.org Change-Id: I2b9a77317cd4dcf8502c237b7f8f167b80859859 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962866Reviewed-by:
-
David Carlier authored
Not best to rely on /proc presence basically when the linux compatibily layer is enabled so going through more programmatically. Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664Reviewed-by:
-
Yang Guo authored
Setting up JSArrayBuffer may trigger GC. Delay this until we are done with deserialization. R=ulan@chromium.org Bug: chromium:1033395 Change-Id: I6c79bc47421bc2662dc1906534fc8e820c351ced Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965580Reviewed-by:
-
Dan Elphick authored
Moves the TailCall instruction codes to the start of the enum, and changes the test for IsTailCall from 4 equality tests to a single inequality. Bug: v8:10051 Change-Id: I679d6377161bd4f9a05f6202763d52c0a67b7900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1964075Reviewed-by:
-
Michael Starzinger authored
R=clemensb@chromium.org Change-Id: Ibd6790a222590fd4dce9f918219a19f01c2e1e0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960293Reviewed-by:
-
Zhao Jiazhong authored
The OutputRegister shouldn't be overwritten, because it may be the same register as InputRegister(1), which will be used later. And remove the useless if-else in And32, Or32, Xor32. Change-Id: I1f944b5b6acd5c183cef537524827b47a8cb0186 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967092 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#65438}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/dfe5662..1c5a738 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4082c91..b34e896 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8b34eb4..f1ad6e4 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f262c1b..d7f3ca9 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I8b0e66842ceb08f8c8158f832e375cc5da64b956 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1966133Reviewed-by:
-
- 12 Dec, 2019 6 commits
-
-
Johannes Henkel authored
Add Exported::AppendSerialized (consistency with Serialized interface). Deprecate Exported::writeBinary. Upstream PRs: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1958506 https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1941035 Change-Id: I50d6db05ea7c1336022b0b63e5ec2c69488ab525 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958575Reviewed-by:
-
Joshua Litt authored
Bug: v8:9838 Change-Id: Iae406457754c66c8e03843bdfc42b6defd76e3ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955756 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Bug: chromium:1029530 Change-Id: I12aa4c238387f6a47bf149fd1a136ea83c385f4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962278 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65434}
-
Tobias Tebbi authored
Bug: chromium:1021444, chromium:1033196 Change-Id: Ic0468bce60577ad238581f17c4510a23ab63882a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1964390 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Seth Brenith authored
Part of the GetObjectProperties test case is for verifying the human- readable brief object description string that GetObjectProperties returns. That string might look something like this: "xy" (0x28f038d5 <v8::internal::SeqOneByteString>) GetObjectProperties also tries to detect known immortal objects by recognizing their addresses, which is useful in crash dumps with limited memory. The recognized object name, if it exists, is prepended to the description string. In order to provide this data accurately (in builds without pointer compression), GetObjectProperties relies on the caller to provide the addresses of the first pages in read-only space, map space, and old space. If the caller doesn't provide those addresses, then GetObjectProperties does the best it can with limited information and reports possible matches based on an object's offset within the heap page that contains it. So the result string might look like this, if the object happened to get allocated at a lucky offset within its page: maybe LoadHandler3Map "xy" (0x28f038d5 <v8::internal::SeqOneByteString>) As a result, when testing these descriptions, we should generally check that they contain the interesting data rather than that they start with it, because some incorrect "maybe" match with a known object might be included at the beginning. Bug: v8:10034 Change-Id: I0cf5afd67793a239614aba3665ef57cd2d663a47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950233Reviewed-by:
-
Mythri A authored
With bytecode flushing and the current OSR triggering mechanism which stores OSR nesting level on bytecode array it is possible to trigger OSR on a closure that doesn't have feedback vector. Bug: chromium:1031479 Change-Id: I4c62486f6b0eb6d6f9c96f98c1c1b275f3e6d6d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962850 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#65431}
-
