- 18 Feb, 2016 16 commits
-
-
rmcilroy authored
Moves the accumulator value on-heap to be restored in the InterpreterNotifyDeopt handler rather than explicitly setting the accumulator register. This allows it to be materialized correctly if required. BUG=v8:4678 LOG=N Review URL: https://codereview.chromium.org/1707133003 Cr-Commit-Position: refs/heads/master@{#34113}
-
akos.palfi authored
Port 2166bd8c BUG= Review URL: https://codereview.chromium.org/1708853002 Cr-Commit-Position: refs/heads/master@{#34112}
-
rossberg authored
Implements iterator finalisation by desugaring for-of loops with an additional try-finally wrapper. See comment in parser.cc for details. Also improved some AST printing facilities while there. @Ross, I had to disable the bytecode generation test for for-of, because it got completely out of hand after this change (the new bytecode has 150+ lines). See the TODO that I assigned to you. Patch set 1 is WIP patch by Georg (http://crrev.com/1695583003), patch set 2 relative changes. @Georg, FYI, I changed the following: - Moved try-finally out of the loop body, for performance, and in order to be able to handle `continue` correctly. - Fixed scope management in ParseForStatement, which was the cause for the variable allocation failure. - Fixed pre-existing zone initialisation bug in rewriter, which caused the crashes. - Enabled all tests, adjusted a few others, added a couple more. BUG=v8:2214 LOG=Y Review URL: https://codereview.chromium.org/1695393003 Cr-Commit-Position: refs/heads/master@{#34111}
-
machenbach authored
This also ports a few changes from run-test.py to make sure cwd = v8 root directory. BUG=chromium:535160 LOG=n Review URL: https://codereview.chromium.org/1707963003 Cr-Commit-Position: refs/heads/master@{#34110}
-
zhengxing.li authored
Unstructured control flow caused by excpetion leads to a wrong x87 FPU stack state in TurboFan's exception handler. This patch is to reset the x87 FPU stack state when calling the TurboFan's exception handler from the CEntryStub. BUG= Review URL: https://codereview.chromium.org/1702383005 Cr-Commit-Position: refs/heads/master@{#34109}
-
ishell authored
In case when F inlined normal call to G which tail calls H we should not write translation for G for the tail call site. Otherwise we will see G in a stack trace inside H. This CL also adds a "megatest" which tests product of the following cases: 1) tail caller is inlined/not-inlined 2) tail callee is inlined/not-inlined 3) tail caller has an arguments adaptor frame above or not 4) tail callee has an arguments adaptor frame above or not 5) tail callee is a normal/bound/proxy function Note that tests for not yet supported cases are not run for now. BUG=v8:4698 LOG=N Review URL: https://codereview.chromium.org/1709583002 Cr-Commit-Position: refs/heads/master@{#34108}
-
ahaas authored
The BufferedRawMachineAssemblerTester caused problems for the Int64Lowering. Instead we construct a TF graph now which is compiled by Pipeline::GenerateCodeForTesting. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1702023002 Cr-Commit-Position: refs/heads/master@{#34107}
-
machenbach authored
This downloads a patched version of jsfunfuzz from google storage (google internal bucket) as a hook on demand. Similar to the gcmole approach from https://codereview.chromium.org/1703533002/ BUG=chromium:535160 LOG=n Review URL: https://codereview.chromium.org/1706963005 Cr-Commit-Position: refs/heads/master@{#34106}
-
verwaest authored
BUG=v8:4761 LOG=y Review URL: https://codereview.chromium.org/1706823003 Cr-Commit-Position: refs/heads/master@{#34105}
-
zhengxing.li authored
The reason: Similar to the CL 31552 (https://codereview.chromium.org/1419573007). The CL 33972 (https://codereview.chromium.org/1698783002) optimized some JS function in regress-crbug-242924 test case by TurboFan compiler. But it will hit the known issue that X87 will change a sNaN to qNaN by default. And then it will fail when comparing the source (sNaN) Hole NaN and the result (qNaN) which was expected to be a (sNaN) Hole NaN too. BUG= Review URL: https://codereview.chromium.org/1704313003 Cr-Commit-Position: refs/heads/master@{#34104}
-
jarin authored
Review URL: https://codereview.chromium.org/1711513003 Cr-Commit-Position: refs/heads/master@{#34103}
-
jochen authored
By short-cutting the DefineOwnProperty machinery similar to how ForceSet does it, we should get a few cycles out of this heavily used API. BUG=chromium:569668 R=verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1702353002 Cr-Commit-Position: refs/heads/master@{#34102}
-
jochen authored
R=adamk@chromium.org BUG= Review URL: https://codereview.chromium.org/1705013002 Cr-Commit-Position: refs/heads/master@{#34101}
-
zhengxing.li authored
port 32b4bc13 (r34083) original commit message: This CL introduces two new bytecodes TailCall and TailCallWide. BUG= Review URL: https://codereview.chromium.org/1703233003 Cr-Commit-Position: refs/heads/master@{#34100}
-
fmeawad authored
This CL adds a TRACE_EVENT where there is an isolated LOG, a HistogramTimer or a TimerEvent. Once we have a d8 tracing controller, all TimerEvents will be removed since they do not provide an added value over TRACE_EVENTs. HistogramTimers will remain, but their functionality will be limited to Histograms only. BUG=v8:4562 LOG=N Review URL: https://codereview.chromium.org/1707563002 Cr-Commit-Position: refs/heads/master@{#34099}
-
v8-autoroll authored
Rolling v8/tools/clang to 893d75d10357b96b4441ca9ffa363654bd2a07df TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1705413002 Cr-Commit-Position: refs/heads/master@{#34098}
-
- 17 Feb, 2016 24 commits
-
-
hablich authored
R=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1703103002 Cr-Commit-Position: refs/heads/master@{#34097}
-
mbrandy authored
Port 32b4bc13 Original commit message: This CL introduces two new bytecodes TailCall and TailCallWide. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4698,v8:4687 LOG=N Review URL: https://codereview.chromium.org/1705913002 Cr-Commit-Position: refs/heads/master@{#34096}
-
machenbach authored
Revert of Add Scoped Context Info (Isolate) to V8 Traces (patchset #5 id:80001 of https://codereview.chromium.org/1686233002/ ) Reason for revert: [Sheriff] Breaks arm cross-compile: https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/7825/ Original issue's description: > Add Scoped Context Info (Isolate) to V8 Traces > > This patch adds the newly added support for contexts in V8 Tracing, as well > as use it to mark all the entry points for a V8 Isolate. > > BUG=v8:4565 > LOG=N > > Committed: https://crrev.com/44823c3c6965966c63b7e2e2361d0f2a58d196ea > Cr-Commit-Position: refs/heads/master@{#34092} TBR=jochen@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4565 Review URL: https://codereview.chromium.org/1710573002 Cr-Commit-Position: refs/heads/master@{#34095}
-
bmeurer authored
We already have a proper abstraction for dealing with subclassable builtins, namely JSObject::New, so we should use that instead of inlining this rather complex code sequence multiple times. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1709563003 Cr-Commit-Position: refs/heads/master@{#34094}
-
binji authored
This is not currently implemented in the simulator, just the assembler and disassembler. BUG=v8:4614 LOG=y Review URL: https://codereview.chromium.org/1699173003 Cr-Commit-Position: refs/heads/master@{#34093}
-
fmeawad authored
This patch adds the newly added support for contexts in V8 Tracing, as well as use it to mark all the entry points for a V8 Isolate. BUG=v8:4565 LOG=N Review URL: https://codereview.chromium.org/1686233002 Cr-Commit-Position: refs/heads/master@{#34092}
-
machenbach authored
Revert of [fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic. (patchset #1 id:1 of https://codereview.chromium.org/1708523002/ ) Reason for revert: [Sheriff] Speculative revert for adding arm flakes: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim/builds/5756 https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20novfp3/builds/3375/ And some more... Original issue's description: > [fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic. > > This intrinsic was only supported in fullcodegen, and is actually no > longer relevant for SunSpider peak performance it seems, so let's get > rid of it and maybe just implement Array.prototype.join with a fast > path at some point instead. > > R=mstarzinger@chromium.org > > Committed: https://crrev.com/ccf12b4bede3f1ce3ce14fb33bcc4041525a40af > Cr-Commit-Position: refs/heads/master@{#34084} TBR=mstarzinger@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1709693002 Cr-Commit-Position: refs/heads/master@{#34091}
-
mbrandy authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1710453002 Cr-Commit-Position: refs/heads/master@{#34090}
-
bbudge authored
Adds kSimd128 to MachineRepresentation. Adds a Simd128Register concept that's platform independent. Adds UntaggedSimd128 to types.h. LOG=N BUG=v8:4124 Review URL: https://codereview.chromium.org/1693963004 Cr-Commit-Position: refs/heads/master@{#34089}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1703083002 Cr-Commit-Position: refs/heads/master@{#34088}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1706833002 Cr-Commit-Position: refs/heads/master@{#34087}
-
verwaest authored
I replaced the hidden string with hidden_properties_symbol, so we don't need the extra hash-check anymore. This is slightly faster anyway. BUG= Review URL: https://codereview.chromium.org/1707653003 Cr-Commit-Position: refs/heads/master@{#34086}
-
mbrandy authored
Port 0d595bb0 Original commit message: It's fine to only have the runtime call here, as it's only used in the debug mirror. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1707683002 Cr-Commit-Position: refs/heads/master@{#34085}
-
bmeurer authored
This intrinsic was only supported in fullcodegen, and is actually no longer relevant for SunSpider peak performance it seems, so let's get rid of it and maybe just implement Array.prototype.join with a fast path at some point instead. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1708523002 Cr-Commit-Position: refs/heads/master@{#34084}
-
ishell authored
This CL introduces two new bytecodes TailCall and TailCallWide. BUG=v8:4698,v8:4687 LOG=N Review URL: https://codereview.chromium.org/1698273003 Cr-Commit-Position: refs/heads/master@{#34083}
-
machenbach authored
Revert of More simplification and unification of frame handling (patchset #5 id:80001 of https://codereview.chromium.org/1702593002/ ) Reason for revert: [Sheriff] Breaks nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/5329 Original issue's description: > More simplification and unification of frame handling > > Frame slots indexes numbers are used more consistently for > computation in both TurboFan and Crankshaft. Specifically, > Crankshaft now uses frame slot indexes in LChunk, removing > the need for some special-case maths when building the > deoptimization translation table. > > LOG=N > R=mstarzinger@chromium.org > > Committed: https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755 > Cr-Commit-Position: refs/heads/master@{#34078} TBR=mstarzinger@chromium.org,jarin@chromium.org,danno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1708583002 Cr-Commit-Position: refs/heads/master@{#34082}
-
mstarzinger authored
This removes the CompilationInfo field from the BytecodeGraphBuilder class. The intention is to reduce the risk of using uninitialized or unavailable values from the CompilationInfo (e.g. values that are only available after parsing). R=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1704913002 Cr-Commit-Position: refs/heads/master@{#34081}
-
bmeurer authored
There's no need to have inline platform code for this intrinsic, which is only used when generating a descriptive string for an error, the runtime call is just fine here. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1706743002 Cr-Commit-Position: refs/heads/master@{#34080}
-
machenbach authored
BUG=chromium:535160 LOG=n TBR=tandrii@chromium.org, kjellander@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1706783002 Cr-Commit-Position: refs/heads/master@{#34079}
-
danno authored
Frame slots indexes numbers are used more consistently for computation in both TurboFan and Crankshaft. Specifically, Crankshaft now uses frame slot indexes in LChunk, removing the need for some special-case maths when building the deoptimization translation table. LOG=N R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1702593002 Cr-Commit-Position: refs/heads/master@{#34078}
-
bmeurer authored
It's dead^Wa runtime call Jim! R=jarin@chromium.org Review URL: https://codereview.chromium.org/1702313002 Cr-Commit-Position: refs/heads/master@{#34077}
-
hablich authored
R=machenbach@chromium.org TBR=danno@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1706753002 Cr-Commit-Position: refs/heads/master@{#34076}
-
machenbach authored
BUG=chromium:535160 LOG=n TBR=tandrii@chromium.org, kjellander@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1703853002 Cr-Commit-Position: refs/heads/master@{#34075}
-
nikolaos authored
R=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1704963002 Cr-Commit-Position: refs/heads/master@{#34074}
-