- 22 Nov, 2021 9 commits
-
-
Andreas Haas authored
With dynamic tiering, not all functions get compiled with TurboFan, and not all functions can therefore get cached. With this metric we want to keep track of the time needed to compile missing functions with Liftoff. R=jkummerow@chromium.org Bug: v8:12281 Change-Id: I1f2de3e1f6b004477985df5d2116f69371528c3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289178Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78020}
-
Nico Hartmann authored
This reverts commit d7c3f1cd. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Android%20Arm64%20-%20debug%20builder/22043/overview Original change's description: > Reland "[fastcall] Enable float support on arm64 simulator" > > This is a reland of b9ddcbc8 > > The original CL was reverted due to an MSAN issue, that is fixed by > moving the signature mapping onto the Isolate (instead of having > per-thread storage, which got invalid on multithreaded compilation). > > This CL also contains fixes for the Bazel config and for a data race > when obtaining the PerIsolateSimulatorData. > > Original change's description: > > [fastcall] Enable float support on arm64 simulator > > > > This CL adds support for handling calls to C functions with arbitrary > > signatures on the arm64 simulator. It adds infrastructure for > > encoding the signature data from CallDescriptor and FunctionInfo > > classes into a compact representation, stored in the simulator and > > called EncodedCSignature. > > > > Design doc: > > https://docs.google.com/document/d/1ZxOF3GSyNmtU0C0YJvrsydPJj35W_tTJZymeXwfDxoI/edit > > > > This CL is a follow up on the native support added in > > https://chromium-review.googlesource.com/c/v8/v8/+/3182232 > > and is partially based on the previous attempt: > > https://chromium-review.googlesource.com/c/v8/v8/+/2343072 > > > > Bug: chromium:1052746 > > Change-Id: I0991b47bd644b2fc2244c5eb923b085261f04765 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060486 > > Commit-Queue: Maya Lekova <mslekova@chromium.org> > > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#77744} > > Bug: chromium:1052746, chromium:1267854 > Change-Id: I89bbd01e33fb1080543d98bcfd4c2d17b5c76861 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3270541 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78018} Bug: chromium:1052746, chromium:1267854 Change-Id: Ia8f10d085d13990b331f306957f95ecf3e003cfd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295453 Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#78019}
-
Maya Lekova authored
This is a reland of b9ddcbc8 The original CL was reverted due to an MSAN issue, that is fixed by moving the signature mapping onto the Isolate (instead of having per-thread storage, which got invalid on multithreaded compilation). This CL also contains fixes for the Bazel config and for a data race when obtaining the PerIsolateSimulatorData. Original change's description: > [fastcall] Enable float support on arm64 simulator > > This CL adds support for handling calls to C functions with arbitrary > signatures on the arm64 simulator. It adds infrastructure for > encoding the signature data from CallDescriptor and FunctionInfo > classes into a compact representation, stored in the simulator and > called EncodedCSignature. > > Design doc: > https://docs.google.com/document/d/1ZxOF3GSyNmtU0C0YJvrsydPJj35W_tTJZymeXwfDxoI/edit > > This CL is a follow up on the native support added in > https://chromium-review.googlesource.com/c/v8/v8/+/3182232 > and is partially based on the previous attempt: > https://chromium-review.googlesource.com/c/v8/v8/+/2343072 > > Bug: chromium:1052746 > Change-Id: I0991b47bd644b2fc2244c5eb923b085261f04765 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060486 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77744} Bug: chromium:1052746, chromium:1267854 Change-Id: I89bbd01e33fb1080543d98bcfd4c2d17b5c76861 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3270541Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#78018}
-
Leszek Swirski authored
There are cases where DeclareEvalVar can fail to create a variable, in particular when the declaration scope is not extensible. Throw an error in such cases. Fixed: chromium:1145119 Change-Id: I6260f570570c4d7801231bdb5f6724f3734444fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295348 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78017}
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I4e4ba332611e3feedc70b32c39f4270cdb0e11cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295446Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#78016}
-
Omer Katz authored
Once CppHeap moves away from EmbedderHeapTracer, it can no longer be returned by Isolate::GetEmbedderHeapTracer. Blink currently uses GetEmbedderHeapTracer to trigger GCs. This CL introduces a variant of Isolate::RequestGarbageCollectionForTesting to replace that. Bug: v8:12407 Change-Id: I099989f55291a0daab7d2051072dedddef58dd40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293413 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78015}
-
Dominik Inführ authored
Instead of just DCHECKing that we are in a safepoint in Snapshot::Create, pass the GlobalSafepointScope as argument. Bug: v8:11708, v8:12377 Change-Id: Ia856c27b92223bf3a96fe6946b86e4625f3a1e0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295342Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78014}
-
Dominik Inführ authored
This is a reland of 90a9d6cb The original CL got reverted because of two different issues: * The DCHECK failure on AllowGarbageCollection::IsAllowed() got fixed in https://crrev.com/c/3289625. * The crash with the incremental marking job were because of a nested GC started from a SafepointScope. This CL adds IgnoreLocalGCRequests scopes to SafepointScopes in src/heap. In addition this CL prevents shared GCs during isolate deserialization by locking the clients_mutex_ until the isolate is fully deserialized. The original GC used a DisallowSafepoints scope to prevent shared GCs from interrupting isolate deserialization. Original change's description: > [heap] Support multiple clients in shared GC > > Add support for safepointing multiple isolates as described in the > design doc (link is below). A safepoint across multiple isolates is > considered a global safepoint to distinguish it from regular safepoints. > > The basic idea behind the implementation is that we reach a > safepoint for each client. What's new is that now also main threads > need to participate in the safepointing protocol and need to give up > control in time. The slow paths of Park(), Unpark() and Safepoint() on > the main thread need to be adjusted for this reason as well. > > This CL introduces GlobalSafepoint and GlobalSafepointScope to mirror > IsolateSafepoint and IsolateSafepointScope. > > This CL adds the type IgnoreLocalGCRequests, it is used to prevent > Park() and Unpark() from honoring the request from background threads > to perform a local GC. This is used heap-internally to not have GCs > (or even nested GCs) in certain locations. E.g. when initiating a > safepoint to perform a GC we don't want a "recursive" GC to occur. > > Design doc: https://docs.google.com/document/d/1y6C9zAACEr0sBYMIYk3YpXosnkF3Ak4CEuWJu1-3zXs/edit?usp=sharing > > Bug: v8:11708 > Change-Id: I5aca8f5f24873279271a53be3bb093fc92a1a1eb > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3009224 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77812} Bug: v8:11708, v8:12375, v8:12377 Change-Id: I9d1af6fbc06a3a8b6f216ec5e9027665ad071809 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3283067 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#78013}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/63b08e1..eabf027 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I5d37b3b024f5da8769268becc86166d74282c6ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3294405 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78012}
-
- 21 Nov, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3335020..63b08e1 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/a63bbc1..e504863 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8b575c9..8a112e2 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I457b5528fce8eafbb3fc99424656554a0442ae6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3294681 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78011}
-
- 20 Nov, 2021 7 commits
-
-
Omer Katz authored
Starting an incremental GC when it is not supported is not allowed but trying to finalize one when it might be unknown whether it's supported or not should be legal. In such cases, finalization would immediately bail out since there is no active gc. Bug: chromium:1272076 Change-Id: If5aaaa130dc55474d3fc3afcd7039880a2c11333 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293411 Auto-Submit: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78010}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/8401429..ce92bbf remove long-defunct cli parameter (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/ce92bbf lose some build warnings (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/88ea9d9 Disable clang-tidy (unused-using-decls) (#1287) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/91ed7ee disable lint check where we know it'd fail (#1286) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/8722d6f Add Setup/Teardown option on Benchmark. (#1269) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/b5bb9f0 Googletest renamed master to main today. (#1285) (Donald Aingworth) https://chromium.googlesource.com/external/github.com/google/benchmark/+/a07f6d1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I590fce794f7df0271ea97efce0ee04efd6d5d5a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3294010 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78009}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/d3ba6ae..bf66d37 Reduce size by using lao dictionary from ICU 69. (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/bf66d37 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,ftang@chromium.org Change-Id: Ibe8ce74e1cb9997f6da001e8dc445fe5656e1aca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3294011 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78008}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/26f1f4567e..d52b510a Bug: v8:7834 Change-Id: Ied739ce9ee8482cbd23ebb19b5e76c62387d8ef6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3292508Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78007}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/994f319..3335020 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/81212d2..a63bbc1 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/7f068e5..038090f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e6e1eb6..8b575c9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1c7dec3..b6c1ed4 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/1a3e2a2..3e0e32b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/8caa4c5..b0d8d05 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I693d6a3bdac5fc1265cfa24eca70dd13dac04fa6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3294008 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78006}
-
Frank Tang authored
Remove two flags for feature shipped in m95 --harmony_intl_displaynames_v2 --harmony_intl_more_timezone Bug: v8:11637, v8:11661 Change-Id: I9432865722664f64c64b5bf7fde5e05e6b324b20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3292518Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78005}
-
Ng Zhi An authored
Bug: v8:12284 Change-Id: Iaa2b98029b46e5d22fac19bf2db5abd56f82670b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3272641Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#78004}
-
- 19 Nov, 2021 14 commits
-
-
Ng Zhi An authored
This is a partial revert of https://crrev.com/c/2033171 to bring back WasmModuleObject::Compile, that compiles Wasm bytes into a Wasm module. Also adding a simple test to make sure the compile works. There are some users, e.g. Cloudflare, Halide, see bug for more details. Bug: v8:10461 Change-Id: I199abea108311025decad793d2232a08bba05d38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3292088 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78003}
-
Milad Fa authored
PPC and S390 implement vsel slightly differently which is also reflected on the simulator. Change-Id: Iec5e49bfae09d8bf15149e5ab149b82971271b24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293409Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#78002}
-
Junliang Yan authored
Change-Id: I318a97a67242527c3a0f7a1dcd74b5503e5dcc55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289836Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#78001}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: Ie2b1801d7535e142774a1d912b992a203b1b8ecc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3284005 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78000}
-
Igor Sheludko authored
... in order to ease issues debugging. Bug: chromium:1241665 Change-Id: I3b51d3eaaa9c03cfadbdadc4e91dee35617f4b33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293090 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77999}
-
Leszek Swirski authored
`foo ## __LINE__` just emits foo__LINE__ because of how preprocessor expansion works. The typical solution for this is to use a CONCAT macro, but we in fact already have a helper for what this is trying to solve, UNIQUE_IDENTIFIER, so just use that instead. Change-Id: Icea3f01db458c5d557e0affd3b004f4478c6c315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293084 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77998}
-
Samuel Groß authored
Previously, an allocation from a separate thread could grab the just-released region and make it accessible before the regions permissions are changed to kNoAccess at the end of ReleasePages. Bug: v8:12414 Change-Id: I98c8f8e3df76d4a44c357ddab107cfeff20049b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293083Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#77997}
-
Dominik Inführ authored
When starting incremental marking from an allocation observer, the DCHECK for AllowGarbageCollection::IsAllowed() fails. We need to explicitly allow this here in order to use SafepointScope. Bug: chromium:1271659, v8:11708, v8:12413 Change-Id: I8607a82faed50f8dfffce1e495fb5e715a47bc1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293086 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77996}
-
Ray Wang authored
Bug: v8:12389 Change-Id: I53c728ab0c8ba38c7dd96c7e1089f771ba44b9f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289227Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77995}
-
Victor Gomes authored
Bug: v8:12054 Change-Id: I756c0a0d05860e2de748842157f4fa54726e94da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289177 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77994}
-
Victor Gomes authored
Bug: v8:12054 Change-Id: Ic121ef55ae7f8578aca3fc8303976f98959d2c8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289175 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77993}
-
Patrick Thier authored
std: :iterator is deprecated C++17. Use base::iterator instead. Change-Id: I682dc3b1547120e067a64eea4f71ffe4ee55ad16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289168 Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Patrick Thier <pthier@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77992}
-
Ng Zhi An authored
This reverts commit 2f17c069. Reason for revert: related to --concurrent_sparkplug and not to this Original change's description: > Revert "heap: Fix compaction aborting all pages" > > This reverts commit 18236dcb. > > Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20no-concurrent-marking/6576/overview > > Original change's description: > > heap: Fix compaction aborting all pages > > > > In such a case, we must post-process all aborted pages. The early > > bailout assumed that not pages are aborted before trying compaction. > > > > Bug: chromium:1271229 > > Change-Id: I4c5998b9d1c7974f7d1d25a6729f42d5690a5759 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289171 > > Reviewed-by: Hannes Payer <hpayer@chromium.org> > > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#77987} > > Bug: chromium:1271229 > Change-Id: Ia4b8687a0f3742bf0c894989f68c249b6c87c446 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291900 > Auto-Submit: Zhi An Ng <zhin@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Owners-Override: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77988} Bug: chromium:1271229 Change-Id: Iba76a1ab11f1a52b845305f0aee4710af1406a91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3292087 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#77991}
-
Milad Fa authored
Change-Id: I2abc916894b84aad5794e4a69979ca8683644806 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289933 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77990}
-
- 18 Nov, 2021 9 commits
-
-
Deepti Gandluri authored
This reverts commit 19bbd0f7. Reason for revert: Fails on future bot - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20no-concurrent-marking/6576/overview Original change's description: > [baseline] Enable Concurrent Sparkplug on future > > Bug: v8:12054 > Change-Id: I7bbd22067a9e98038a08ce5cb4b0ef494aadd651 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289252 > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Milad Fa <mfarazma@redhat.com> > Auto-Submit: Victor Gomes <victorgomes@chromium.org> > Reviewed-by: Milad Fa <mfarazma@redhat.com> > Cr-Commit-Position: refs/heads/main@{#77986} Bug: v8:12054 Change-Id: I97a511b00a79a606ac9abb6d15b707c75706deee No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3292095 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#77989}
-
Zhi An Ng authored
This reverts commit 18236dcb. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20no-concurrent-marking/6576/overview Original change's description: > heap: Fix compaction aborting all pages > > In such a case, we must post-process all aborted pages. The early > bailout assumed that not pages are aborted before trying compaction. > > Bug: chromium:1271229 > Change-Id: I4c5998b9d1c7974f7d1d25a6729f42d5690a5759 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289171 > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77987} Bug: chromium:1271229 Change-Id: Ia4b8687a0f3742bf0c894989f68c249b6c87c446 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291900 Auto-Submit: Zhi An Ng <zhin@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Owners-Override: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#77988}
-
Michael Lippautz authored
In such a case, we must post-process all aborted pages. The early bailout assumed that not pages are aborted before trying compaction. Bug: chromium:1271229 Change-Id: I4c5998b9d1c7974f7d1d25a6729f42d5690a5759 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289171Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77987}
-
Victor Gomes authored
Bug: v8:12054 Change-Id: I7bbd22067a9e98038a08ce5cb4b0ef494aadd651 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289252 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77986}
-
Clemens Backes authored
The entries contain more than just deoptimization info. Thus rename them to "entries" and use "EntryBuilder" instead of "DeoptimizationInfo". Drive-by: Remove the redundant {emitted_} field, just check if {offset_} was initialized. R=jkummerow@chromium.org Bug: v8:12401 Change-Id: Ifedc265dc27dd6817b731d9e24a1d8654edc99de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291310 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77985}
-
Junliang Yan authored
Change-Id: Ibd3ba4cd1edc174fdfaa826b8a6f7731f4627365 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289932Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77984}
-
Clemens Backes authored
Verify certain properties when emitting safepoint tables: - entries are ordered by PC, - trampoline PCs are also in order, - all trampoline PCs come after all regular PCs, and - an entry with a deopt index also has a trampoline PC set. Drive-by: Slightly simplify logic in {UpdateDeoptimizationInfo}. Drive-by 2: Inline IsIdenticalExceptForPc into the only caller, and further simplify the logic there. R=jkummerow@chromium.org Bug: v8:12401 Change-Id: I8ea41b1628dceb914191f23165c8dccb79f9204c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289162 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77983}
-
Michael Lippautz authored
We should not assume that the embedder can run with concurrent marking even though we just finalize the GC at this point. Bug: chromium:1271371 Change-Id: I3d3a45e4283dcae9c6fdd1a467158254914868c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289169Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77982}
-
Michael Lippautz authored
Change-Id: I4886923bd3b2c29f5f317fbfab078af4d5dd8510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289156 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77981}
-