- 21 Dec, 2018 17 commits
-
-
Mike Stanton authored
It's nice to have a quick way to get stable results on the local machine for the classic d8 benchmarks. CSuite revitalizes an old tool called BSuite which offers multiple averaged runs, and a nice ascii display of results. Sample usage: ./csuite.py octane baseline ~/src/v8/out/d8 ./csuite.py octane compare ~/src/v8/out-mine/d8 benchmark: score | master | % | ===================================================+==========+========+ Richards: 26201.0 | 26568.0 | -1.4 | DeltaBlue: 55744.0 | 58309.0 | -4.4 | Crypto: 31831.0 | 31815.0 | | RayTrace: 73481.0 | 73185.0 | 0.4 | ............<snip>............................ Octane: 36388.0 | 35741.0 | 1.8 | ---------------------------------------------------+----------+--------+ See README.md for more documentation. Change-Id: I182490506ca07fab1240bd485bd1d7a8920db893 Reviewed-on: https://chromium-review.googlesource.com/c/1387487 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58434}
-
Jakob Gruber authored
This defines V8_JITLESS_MODE if the v8_enable_lite_mode build-time option is enabled. Jitless mode will thus be tested by existing lite bots. The build-time option for jitless mode will only be needed temporarily and is expected to be removed again in the near future. Bug: v8:7777 Change-Id: I556ba5069dbd0810a6d7376601d8f7d498fef8c9 Reviewed-on: https://chromium-review.googlesource.com/c/1387499Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58433}
-
Toon Verwaest authored
That way we can drop PatternRewriter::scope_ and just use parser_->scope() instead. Change-Id: I66137d3ff8e7b805afc7108fd2d55537f69f11e6 Reviewed-on: https://chromium-review.googlesource.com/c/1387500Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#58432}
-
Maya Lekova authored
This reverts commit b3c85c9e. Reason for revert: Causing Check failures on Android - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Android%20Arm64%20-%20N5X/2391 Original change's description: > [tools] Pass large_output to avoid re-running tests that generate lots of output > > R=machenbach@chromium.org > > Bug: chromium:893593 > Change-Id: Ic3a3612fc557b1f35b4632cfab553b4492ec6222 > Reviewed-on: https://chromium-review.googlesource.com/c/1382734 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58399} TBR=machenbach@chromium.org,sergiyb@chromium.org Change-Id: I8ac42d1b53ce5840e80071625466135999a3c42c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:893593 Reviewed-on: https://chromium-review.googlesource.com/c/1387502Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#58431}
-
Clemens Hammacher authored
This silences the new presubmit check for the whole src/wasm directory. This change uncovered that MSVC is a bit behind with noexcept annotations on standard containers. This makes all implicit constructors and assignment operators noexcept(false) if the class contains any standard container. Thus disable noexcept on MSVC for now. R=tebbi@chromium.org CC=marja@chromium.org Bug: v8:8616, v8:7999 Change-Id: Ica86ac84a5b8a835dcea9b783c7987d9b850241a Reviewed-on: https://chromium-review.googlesource.com/c/1386869 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58430}
-
Clemens Hammacher authored
This replaces another use of std::vector. Stack states (consisting of locals plus operand stack) are also typically small, thus optimize for those cases. Using StackVector as part of CacheState requires the definition of move constructors and copy constructors, plus a few other methods. R=tebbi@chromium.org Bug: v8:8423 Change-Id: I5d39c1ebc4d6d65e4849dd06c556114cd2cd36ff Reviewed-on: https://chromium-review.googlesource.com/c/1380053 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Camillo Bruni authored
- Mark Serialize method as non-virtual - Use simple scheme to mask out bytes when de-/serializing Uint32 - Improve ByteArray::ByteArrayPrint method Drive-by-fix: Change-Id: I9a6779587c0a031bcf23e4f431d17026b83a808d Reviewed-on: https://chromium-review.googlesource.com/c/1387493Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58428}
-
Toon Verwaest authored
Change-Id: I9446a73bb47b11e2d161a4678638b7618ce52b9a Reviewed-on: https://chromium-review.googlesource.com/c/1387490Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: I28a8244ef22035db85b520d86aa6d5578c7c7f5d Reviewed-on: https://chromium-review.googlesource.com/c/1384309 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58426}
-
Sigurd Schneider authored
This reverts commit f63a657e. Reason for revert: breaks compile on lite mode: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8926535782549686576/+/steps/build/0/steps/compile/0/stdout Original change's description: > [deoptimizer] Refactor GenerateDeoptimizationEntries > > This reduces preprocessor-expanded source size by 64,359 from > > gen ( 21 files): 71,570 to 1,613,100 ( 23x) > src ( 624 files): 367,830 to 52,964,659 ( 144x) > test ( 392 files): 490,924 to 37,360,916 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1521 files): 1,184,093 to 102,461,098 ( 87x) > > to > > gen ( 21 files): 71,570 to 1,613,100 ( 23x) > src ( 624 files): 367,837 to 52,919,005 ( 144x) > test ( 392 files): 490,924 to 37,342,211 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1521 files): 1,184,100 to 102,396,739 ( 86x) > > Bug: v8:8562 > Change-Id: Iee474e22ababa1e080b8d6359af4d0076903e59a > Reviewed-on: https://chromium-review.googlesource.com/c/1384091 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58424} TBR=ulan@chromium.org,jarin@chromium.org,sigurds@chromium.org Change-Id: I06e6f95255a3cea6a428713e9e841781425dffe8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8562 Reviewed-on: https://chromium-review.googlesource.com/c/1387494Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58425}
-
Sigurd Schneider authored
This reduces preprocessor-expanded source size by 64,359 from gen ( 21 files): 71,570 to 1,613,100 ( 23x) src ( 624 files): 367,830 to 52,964,659 ( 144x) test ( 392 files): 490,924 to 37,360,916 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1521 files): 1,184,093 to 102,461,098 ( 87x) to gen ( 21 files): 71,570 to 1,613,100 ( 23x) src ( 624 files): 367,837 to 52,919,005 ( 144x) test ( 392 files): 490,924 to 37,342,211 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1521 files): 1,184,100 to 102,396,739 ( 86x) Bug: v8:8562 Change-Id: Iee474e22ababa1e080b8d6359af4d0076903e59a Reviewed-on: https://chromium-review.googlesource.com/c/1384091Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58424}
-
Sigurd Schneider authored
Disassembly selections now work even if no origin node is associated with the disassembly code range that the user selects. TBR=neis@chromium.org Bug: v8:7327 Change-Id: Ib5bfcaded66deb65314fde7d3cb9ed2c3c4f6fe9 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/1387492Reviewed-by:
-
Maya Lekova authored
This reverts commit d045f666. Reason for revert: Probably causing a timeout on Android bots - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Android%20Arm64%20-%20N5X/2393 Original change's description: > [tools] Push files using high-level device.PushChangedFiles method > > R=machenbach@chromium.org > > No-Try: true > Bug: chromium:893593 > Change-Id: I11cce7694eb7755ccee42c9a342fc1aa22663d85 > Reviewed-on: https://chromium-review.googlesource.com/c/1382468 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58407} TBR=machenbach@chromium.org,sergiyb@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I23b0a5ef9fb6c1cca56e4b4bfe44fdfe4b80a390 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:893593 Reviewed-on: https://chromium-review.googlesource.com/c/1387489Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7327 Notry: true Change-Id: Ia1c2164269d3d656b951d46debe42a811a6d9c89 Reviewed-on: https://chromium-review.googlesource.com/c/1386494Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58421}
-
Clemens Hammacher authored
Since FallThruTo is often followed by PopControl, we can save a few cache state copy operations in Liftoff by merging the two. On epic workloads, this saves ~18% of Steal operations and ~22% of Split operations. R=herhut@chromium.org Bug: v8:8423 Change-Id: I99900eaa49ae14ead6a0c08b69da2175730e077e Reviewed-on: https://chromium-review.googlesource.com/c/1384093Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58420}
-
Jakob Gruber authored
This is a reland of 0e22ec73 Original change's description: > [regexp] Escape newlines when setting [[OriginalSource]] > > This escapes LineTerminator characters in a regexp pattern when > creating the string that will be stored in the [[OriginalSource]] slot. > > As an example, the source property for all following objects will equal > "\n" (a '\' character followed by 'n'): > > /\n/ > new RegExp("\n") > new RegExp("\\n") > > Bug: v8:1982, chromium:855009 > Change-Id: I3b539497a0697e3d51ec969cae49308b0b312a19 > Reviewed-on: https://chromium-review.googlesource.com/c/1384316 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58387} Bug: v8:1982, chromium:855009 Change-Id: I1ba22395477ec37e8e8c944000f9beade1e3250b Reviewed-on: https://chromium-review.googlesource.com/c/1386495Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4f828d0..b61a4fb Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7d95d86..2f6c18c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2cc6e25..58649e3 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c8e8d67..4685377 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib98360f93dd1f94beff56fca3f37e687c65748ca Reviewed-on: https://chromium-review.googlesource.com/c/1387998Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#58418}
-
- 20 Dec, 2018 23 commits
-
-
Ulan Degenbaev authored
This fixes a bug from 0400fc20, which assumed that we can set the markbits and the marked descriptors counter independently. This does not work because the Scavenger skips slots recording for non-black promoted objects. The fix is to mark the descriptor array black whenever we change the marked descriptors counter. Bug: v8:8617, v8:8618, v8:8486 Tbr: mlippautz@chromium.org Change-Id: I80f3488061fa648b6c81963ba802ef045d92bcc6 Reviewed-on: https://chromium-review.googlesource.com/c/1387486 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:5368 Change-Id: I0f6edc028baf009b81612ecc4be9a70c3621bc4e Reviewed-on: https://chromium-review.googlesource.com/c/1385528Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58416}
-
Adam Klein authored
Also remove ImportNow() and helper runtime functions and Context methods that are now unused. Bug: v8:7624 Change-Id: I109b112d2147240e72eb0ed6112a267057de59cb Reviewed-on: https://chromium-review.googlesource.com/c/1385224 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
-
Michael Lippautz authored
The DCHECK was overly restrictive when checking that a weak handle is not a finalizer when hitting it through a regular scavenge processing path. Only happened with finalizers to unmodified API wrappers or regular objects that were also marked as independent. Bug: v8:8586 Change-Id: I2c2a5b21f6e8a5ddc6671f762b508ba083c04335 Reviewed-on: https://chromium-review.googlesource.com/c/1387485Reviewed-by:
-
Adam Klein authored
This CL makes several changes to bootstrapper to reduce code verbosity: - Adds an InstallToStringTag helper and uses it everywhere (while removing now-redundant comments). - Reduces explicit calls to Factory::InternalizeUtf8String by adding some overloads of helpers and of JSObject::AddProperty. - Uses InstallConstant in all applicable cases. - Removes attributes arguments when all callers pass DONT_ENUM. Change-Id: Ifb5f5102f5fbf89d475045270eeda78a2ee99248 Reviewed-on: https://chromium-review.googlesource.com/c/1385526Reviewed-by: -
Alexei Filippov authored
It failed on the CHECK when receiver object was JSAsyncFunctionObject. BUG=chromium:901241 Change-Id: I7ce563758185908728135005cb5ba2878fdea446 Reviewed-on: https://chromium-review.googlesource.com/c/1382822Reviewed-by:
-
Clemens Hammacher authored
This silences the new presubmit check for the whole src/compiler directory. R=neis@chromium.org Bug: v8:8616 Change-Id: Ib76d669861f829b4f35f9e9921b72b073300da08 Reviewed-on: https://chromium-review.googlesource.com/c/1386871Reviewed-by:
-
Jakob Kummerow authored
Merging the temporary HeapObjectPtr back into HeapObject. Bug: v8:3770 Change-Id: I5bcd23ca2f5ba862cf5b52955dca143e531c637b Reviewed-on: https://chromium-review.googlesource.com/c/1386492 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
The simulated C++ signature for generated code entry points should rely on primitive values (as opposed to ObjectPtr). Bug: v8:3770 Change-Id: I6f6f4dc8a93c7ba46bfc7052dc4745b16e9fd62f Reviewed-on: https://chromium-review.googlesource.com/c/1386875Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58409}
-
Clemens Hammacher authored
Avoid named constructors for Value and Control and the hack to also have them on subclasses. Instead, add a new template type and a constructor to create the subtype from this template. Instead of the named constructors on the subtype, we now create a template and initialize the subtype from the template. R=herhut@chromium.org Bug: v8:8562 Change-Id: I374fc4104ab1ae5769c587bdf5a4ca7f9a0a10d7 Reviewed-on: https://chromium-review.googlesource.com/c/1382454Reviewed-by:
-
Sergiy Belozorov authored
R=machenbach@chromium.org No-Try: true Bug: chromium:893593 Change-Id: I11cce7694eb7755ccee42c9a342fc1aa22663d85 Reviewed-on: https://chromium-review.googlesource.com/c/1382468Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58407}
-
Clemens Hammacher authored
The V8_NOEXCEPT annotation is not needed for deleted class members. Also our DISALLOW_COPY_AND_ASSIGN macro does not add it there. Additionally, include the file name to find the reported location more easy. R=jkummerow@chromium.org Bug: v8:8616 No-Try: true Change-Id: I93162804493542fed2a5832649b80386e338bd47 Reviewed-on: https://chromium-review.googlesource.com/c/1386870 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This simplifies NextArrowFunctionInfo, allows us to Scope::Snapshot::Reparent directly rather than moving it, and allows us to skip reparenting in the simple parameter arrow function cases. This CL additionally fixes arrow function name inferring. Change-Id: Ie3e5ea778f3d7b84b2a10d4f4ff73931cfc9384a Reviewed-on: https://chromium-review.googlesource.com/c/1386147Reviewed-by:
-
Clemens Hammacher authored
Forgetting V8_NOEXCEPT annotations on copy constructors, move constructors, copy assignment operators or move assignment operators can cause subtle performance bugs or compilation failures, sometimes only on specific architectures or compilers. Thus check that all those special class members are marked V8_NOEXCEPT. This check is only executed on modified files for now, and can be bypassed. Please report any false positives on the associated bug. Bug: v8:8616 R=jgruber@chromium.org, machenbach@chromium.org Change-Id: Ieefd8e39fbb1b314dc8d72ee87f6138b784205af Reviewed-on: https://chromium-review.googlesource.com/c/1386496Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9945d79..4f828d0 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/5cce74c..0e1cbc4 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/203676d..7d95d86 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c6a8d11..2cc6e25 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/2823bdd..23de016 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1bc365f..c8e8d67 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I016fd6ce19da97aef7aa97362731f7a5e220bfd6 Reviewed-on: https://chromium-review.googlesource.com/c/1386724Reviewed-by:
-
Ross McIlroy authored
BUG=v8:8395 Change-Id: Ibf97962f1bdfa5c83cd228569c88abcf9d0a7c51 Reviewed-on: https://chromium-review.googlesource.com/c/1386487Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58402}
-
Jakob Kummerow authored
This does not include moving function definitions from objects-inl.h to heap-object-inl.h, because that would be messy for no immediate benefit. This is in preparation for merging HeapObjectPtr into HeapObject. Bug: v8:5402 Change-Id: Id170d9cac8ebabb2876b85bad29ce90fe02d842d Reviewed-on: https://chromium-review.googlesource.com/c/1386491Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58401}
-
Yang Guo authored
Change-Id: I8de0f11c0a7d21d980f5d8691a6e3888a386cbba Reviewed-on: https://chromium-review.googlesource.com/c/1386144Reviewed-by:
-
Sergiy Belozorov authored
R=machenbach@chromium.org Bug: chromium:893593 Change-Id: Ic3a3612fc557b1f35b4632cfab553b4492ec6222 Reviewed-on: https://chromium-review.googlesource.com/c/1382734Reviewed-by:
-
Camillo Bruni authored
- Reduce ExpressionResultScope size by reusing accessing the generator from its RegisterAllocationScope member - Mark the ExpressionResultScope destructor non-virtual since there are no destructors in subclasses Change-Id: I3abe1856c091100217c668cd6bd5e7fd96eb8397 Reviewed-on: https://chromium-review.googlesource.com/c/1386485Reviewed-by:
-
Sigurd Schneider authored
This is work towards making instructions in the sequence view selectable. For now, they are clickable and will select the corresponding instructions in the disassembly view. Bug: v8:7327 Notry: true Change-Id: I8850efeec7f94487bd80c11a7ad250a959062393 Reviewed-on: https://chromium-review.googlesource.com/c/1386112 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 0e22ec73. Reason for revert: Breaks layout tests: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/28814 Original change's description: > [regexp] Escape newlines when setting [[OriginalSource]] > > This escapes LineTerminator characters in a regexp pattern when > creating the string that will be stored in the [[OriginalSource]] slot. > > As an example, the source property for all following objects will equal > "\n" (a '\' character followed by 'n'): > > /\n/ > new RegExp("\n") > new RegExp("\\n") > > Bug: v8:1982, chromium:855009 > Change-Id: I3b539497a0697e3d51ec969cae49308b0b312a19 > Reviewed-on: https://chromium-review.googlesource.com/c/1384316 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58387} TBR=yangguo@chromium.org,jgruber@chromium.org,mathias@chromium.org Change-Id: I1db7e6a0c6cd1cd995fe9f499458108e88dc8cb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:1982, chromium:855009 Reviewed-on: https://chromium-review.googlesource.com/c/1386493Reviewed-by:
-
Georg Neis authored
The check was accidentally done only when a stress-flag was enabled. Moreover, the check is actually unnecessary because the code will deopt itself once it gets run. Also add a DCHECK that these invalidations can only happen due to pretenuring changes. Bug: v8:8520 Change-Id: Ibb008f93e9e417d2f88cd5fd8fd1380db88bbb85 Reviewed-on: https://chromium-review.googlesource.com/c/1384304Reviewed-by:
-
