1. 30 Nov, 2017 2 commits
    • Michael Achenbach's avatar
      Revert "[objects] No longer create short external strings." · fc50e2c4
      Michael Achenbach authored
      This reverts commit e42e7fc8.
      
      Reason for revert: Speculative revert for:
      https://crbug.com/v8/7149
      
      Original change's description:
      > [objects] No longer create short external strings.
      > 
      > This fixes String::MakeExternal() to bail out if the subject string
      > doesn't fit a regular ExternalString, instead of creating a short
      > external string. The observation here is that for short external strings
      > the overhead of having to have the StringResource plus going to the
      > runtime/C++ for each and every character access from JavaScript land
      > is probably bigger than the anticipated benefits.
      > 
      > If this turns out to be wrong and there's a real benefit, we should make
      > use of ThinStrings instead of having a separate way to represent
      > external strings.
      > 
      > Bug: v8:6621, v8:7109, v8:7145
      > Change-Id: I4b75da08b82a72027c782a69de9c8eaf3cca1d4d
      > Reviewed-on: https://chromium-review.googlesource.com/799750
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#49735}
      
      TBR=yangguo@chromium.org,bmeurer@chromium.org
      
      Change-Id: I3f5cfa9ab5c99ddce1d61ede9ed9515cb3936cdd
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6621, v8:7109, v8:7145, v8:7149
      Reviewed-on: https://chromium-review.googlesource.com/801675Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49770}
      fc50e2c4
    • Benedikt Meurer's avatar
      [objects] No longer create short external strings. · e42e7fc8
      Benedikt Meurer authored
      This fixes String::MakeExternal() to bail out if the subject string
      doesn't fit a regular ExternalString, instead of creating a short
      external string. The observation here is that for short external strings
      the overhead of having to have the StringResource plus going to the
      runtime/C++ for each and every character access from JavaScript land
      is probably bigger than the anticipated benefits.
      
      If this turns out to be wrong and there's a real benefit, we should make
      use of ThinStrings instead of having a separate way to represent
      external strings.
      
      Bug: v8:6621, v8:7109, v8:7145
      Change-Id: I4b75da08b82a72027c782a69de9c8eaf3cca1d4d
      Reviewed-on: https://chromium-review.googlesource.com/799750Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49735}
      e42e7fc8
  2. 06 Jul, 2017 1 commit