- 30 Nov, 2017 2 commits
-
-
Michael Achenbach authored
This reverts commit e42e7fc8. Reason for revert: Speculative revert for: https://crbug.com/v8/7149 Original change's description: > [objects] No longer create short external strings. > > This fixes String::MakeExternal() to bail out if the subject string > doesn't fit a regular ExternalString, instead of creating a short > external string. The observation here is that for short external strings > the overhead of having to have the StringResource plus going to the > runtime/C++ for each and every character access from JavaScript land > is probably bigger than the anticipated benefits. > > If this turns out to be wrong and there's a real benefit, we should make > use of ThinStrings instead of having a separate way to represent > external strings. > > Bug: v8:6621, v8:7109, v8:7145 > Change-Id: I4b75da08b82a72027c782a69de9c8eaf3cca1d4d > Reviewed-on: https://chromium-review.googlesource.com/799750 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49735} TBR=yangguo@chromium.org,bmeurer@chromium.org Change-Id: I3f5cfa9ab5c99ddce1d61ede9ed9515cb3936cdd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6621, v8:7109, v8:7145, v8:7149 Reviewed-on: https://chromium-review.googlesource.com/801675Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49770}
-
Benedikt Meurer authored
This fixes String::MakeExternal() to bail out if the subject string doesn't fit a regular ExternalString, instead of creating a short external string. The observation here is that for short external strings the overhead of having to have the StringResource plus going to the runtime/C++ for each and every character access from JavaScript land is probably bigger than the anticipated benefits. If this turns out to be wrong and there's a real benefit, we should make use of ThinStrings instead of having a separate way to represent external strings. Bug: v8:6621, v8:7109, v8:7145 Change-Id: I4b75da08b82a72027c782a69de9c8eaf3cca1d4d Reviewed-on: https://chromium-review.googlesource.com/799750Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49735}
-
- 06 Jul, 2017 1 commit
-
-
Ross McIlroy authored
If a thin string can be dereferenced for StringConcat we still need to check whether the dereferenced string is a sequential string itself (it could be an external string). BUG=v8:6243 Change-Id: I146541512525726f092580512c0b5f02d33685a7 Reviewed-on: https://chromium-review.googlesource.com/558994 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46459}
-