- 14 May, 2020 5 commits
-
-
cjihrig authored
This commit resolves compilation errors on SmartOS that were found while upgrading Node.js. See: https://github.com/nodejs/node/pull/32831 Change-Id: Ia2a2e028ba4f5bfd69c050cab4fb4e13af5eefd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191054Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67793}
-
Dan Elphick authored
Also adds missing header includes. Bug: v8:10473 Change-Id: Ib5bf599dae5bc954edcb6e6fcbd83004bd48c1eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2199347 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Bug: chromium:1082309, chromium:1082083 Change-Id: I616da287adce5db7952eadf11364a7593e405fdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2199346Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#67791}
-
Thibaud Michaud authored
R=ahaas@chromium.org Bug: v8:10408 Change-Id: Ic5cb2b915584c64656bfc5baf8c9524a7d5bf48c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196346Reviewed-by:
-
Varun Varada authored
There should be a space between the quantity and the unit symbol as per the SI, so this commit fixes this issue. Change-Id: I3356942391d96906f3e3840c7bb802e10f29eb4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190230 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#67789}
-
- 13 May, 2020 26 commits
-
-
Omer Katz authored
This is needed to trace objects found durinbg stack scanning. Bug: chromium:1056170 Change-Id: I1280d98f2fe69281c514b3a7d4a57f909a2eed96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190425 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10501 Change-Id: I6dad0f4da4d7c50d0793d39a5a119defb6b53844 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191392 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67787}
-
Ng Zhi An authored
The AVX implementation does not have dst == input(0), so the vminps call was wrong. The intention is to compare the 2 input operands. Bug: chromium:1081030 Change-Id: Id54074327a6aca4b75988fc9d85beccfeabfc791 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2194471Reviewed-by:
-
Bill Budge authored
- Rewrites the following builtins using Torque: WasmAtomicNotify WasmI32AtomicWait64 WasmI64AtomicWait64 WasmAllocateStruct - Adds some helper builtins to reduce the size of the Atomics builtins. These do multiple conversions and CSA inlines all of this code. As these are runtime calls, the call overhead should be negligible. WasmInt32ToNumber WasmUint32ToNumber Change-Id: Ie15e15a965dc383c54ae50164d83bce211178888 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2176895Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I1b6787ecea6ad58173a0bcc8e8d0862a5b19d299 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2199342 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67784}
-
Igor Sheludko authored
... when one of the receivers is a JSArray that may have a read-only length. Bug: chromium:1069530 Change-Id: Idbaf1a9030bb5a0f9c25e30925f18f603a99832f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196353Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#67783}
-
Zhao Jiazhong authored
Port 91cbf3e3 https://crrev.com/c/2171475 Change-Id: I09e24f7da0449fa891633794bc3a8ef639352eeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198862Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#67782}
-
Zhao Jiazhong authored
Port b931af5d https://crrev.com/c/2190423 Change-Id: I9d5eeae078604e1bd5241afea14f169f45711ce3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198056Reviewed-by:
-
Milad Farazmand authored
Port 91cbf3e3 R=zhiguo.zhou@intel.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ie69563747b10a2a783289d21b39ea3c48e99e2c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198361Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67780}
-
Andreas Haas authored
This CL fixes a bug in Liftoff where stack parameters for builtins were pushed in the reversed order. CC=bbudge@chromium.org R=clemensb@chromium.org Bug: v8:10281 Change-Id: I51ab4f19b0dc3835140ca3c05c98cc82dfe9cac4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196341Reviewed-by:
-
Marja Hölttä authored
We can't attach a meaningful stack trace to the AggregateError Promise.any rejects with, but we can augment the individual errors' stack traces with Promise.any and the index of the corresponding Promise in the input. Bug: v8:9808 Change-Id: I7ba754c9b043594decaac8b3a23be74f05c3dffd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198983 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#67778}
-
Clemens Backes authored
Frames that have not been compiled by Liftoff for debugging are uninspectable. Instead of reporting an empty local scope and stack scope in this case, just don't report these two scopes at all. This also fixes a case missed in https://crrev.com/c/2196349, where we would still try to generate the stack scope for non-debugging code. Drive-by: Use {WasmFrame} instead of {StandardFrame} in the {DebugWasmScopeIterator}, and use the {FrameInspectionScope} consistently. R=thibaudm@chromium.org, bmeurer@chromium.org CC=kimanh@chromium.org Bug: v8:10359, chromium:1071757, chromium:1079328, chromium:1072839 Change-Id: I3a3731a0bd9f582f94458500252922b4146e394f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198982Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Add const Page iterators to Spaces, and add whichever const methods are necessary for this to work. This and a couple more const methods allows us to make Heap::Contains const. Change-Id: I1b63a10575ccdb8a3979aef4fa63a97b288ff836 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198975 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Ensure that page header flags are properly initialized before concurrent markers can discover objects. Bug: v8:10315 Change-Id: Ib9ce813dfd3fda75e4ee209a846828366222b110 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198990Reviewed-by:
-
Dan Elphick authored
BasicMemoryChunk will become the base class for ReadOnlySpace pages which won't be MemoryChunks. Since ReadOnlySpace pages don't participate in GC they don't need slot_set_. Also some references to BasicMemoryChunk fields that were still prefixed with MemoryChunk:: Bug: v8:10454 Change-Id: If8ce40c7ee72d1617d2a1161ad9d4b7929f8a8e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198988 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Jakob Gruber authored
With the default arg, node->Print() complains about a missing parameter in gdb. This CL adds a wrapper method instead of the default arg. Change-Id: Idd6e5bb8e0022255449d5f54420d930b55ca1134 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198991Reviewed-by:
-
Michael Lippautz authored
This is a reland of 3df36990 Original change's description: > cppgc: Port ObjectStartBitmap > > This ports ObjectStartBitmap from Blink. > > Bug: chromium:1056170 > Change-Id: Ib959d9ac1c5e1e34ffa6418f77956e993c570ffc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181331 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67735} Bug: chromium:1056170 Change-Id: I6e2fd99e96bebe3060f4feb8503ab04c0d452d51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198986Reviewed-by:
-
Igor Sheludko authored
... for the cases when the Isolate is necessary only for external pointers decoding. This will avoid unnecessary calls to non-inlined IsolateFromNeverReadOnlySpaceObject(). Bug: v8:10391 Change-Id: I0a299c8a44d5845f26cf704ce53555bf07c93f8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198978Reviewed-by:
-
Ambroise Vincent authored
Fold distinct MUL and ADD (or SUB) instructions into a single MLA (or MLS) instruction, mirroring what is being done for general purpose registers. SIMD wasm only uses the vectorized ADD and MUL instructions on quad vectors (NEON Q), so only those cases are handled. SIMD wasm only uses MUL by vectors, not by elements so there is no need to check for an addition and shift reduction. Change-Id: If07191dde9fb1dc37a5de27187800c15cc4325ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184239Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#67770}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/f1b0a1e27..d2f7d428 Bug: v8:7834, v8:10510 Change-Id: Iad860f82cb1b30639d07b3541540f244ab8c61a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2197618Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67769}
-
Camillo Bruni authored
This CL locally improves Number.toString by 5% for the slow case where the number is not found in the cache. - Introduce NumberCacheMode to avoid needless querying of the cache - Allow for some more inlining Bug: v8:10477 Change-Id: I4163e85db587ab3a6e89c126f81f6095fdb02b2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172793Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#67768}
-
Jakob Gruber authored
The native context independent (NCI) code variant will be used to test various aspects as the NCI implementation progresses. Examples: - Test js-generic-lowering with feedback collection. - Test NCI codegen without caching or tier-up. - Test NCI codegen and tier-up without caching. - Test full NCI (codegen, caching, tier-up). At some point a build-time flag may be required, we'll see when we get there. This variant should be removed once work on NCI is complete. Bug: v8:8888 Change-Id: I8b12c9a5d69bf167e39e002af385f8f523585550 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198776 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Marja Hölttä authored
There's no need for them to be in NativeContext. This CL moves the only remaining Proxy-related SFI. Bug: v8:10482 Change-Id: I2f5e2d250c30f552787915d306c1be23b9d033bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196184Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Yolanda Chen authored
[regalloc] Do not spill uses that are constrained to move to register in backwards spilling heuristics For uses that are moved to registers, they are not beneficial for backwards spilling as it will introduce memory loads from stack to register. Bug: chromium:1066869, chromium:1063831 Change-Id: I562d22336b6607a8f7286fc65dbf5b95a941a130 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172052Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7793, v8:10475 Change-Id: I3c528d07e8d3192d7110ebc81e9e89f79a7c735d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196132Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67764}
-
Zhou, Zhiguo authored
Bug: v8:9909 Change-Id: I1bd17d6a1a6f32e9076d80c91be2743868ecad2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2171475Reviewed-by:
-
- 12 May, 2020 9 commits
-
-
Ng Zhi An authored
Bug: v8:10180 Change-Id: I4c1d18c71d1514a561c37fb9ae821617de949d87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2194175Reviewed-by:
-
Shu-yu Guo authored
This reverts commit c25352f3. Reason for revert: Causing raytrace timeouts on TSAN: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20concurrent%20marking/13089 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20concurrent%20marking/13090 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20concurrent%20marking/13091 Original change's description: > Reland "[heap] Remove sweeping state in incremental marking" > > This is a reland of 7f29c48e > > After fixing TSAN failures in https://crrev.com/c/2192661 and https://crrev.com/c/2193712, this CL and be relanded without changes. > > Original change's description: > > [heap] Remove sweeping state in incremental marking > > > > Remove the SWEEPING state from incremental marking. Sweeping is now > > always completed when starting incremental marking. Before this change > > there needed to be a safepoint each for starting marking and completing > > sweeping. Now both happens within a single safepoint. > > > > Bug: v8:10315 > > Change-Id: Iad2835554865f2de24376372affe9a98992d1fa0 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190419 > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#67678} > > Bug: v8:10315 > Change-Id: Ic949d125e72c4d17fd427d08d4b6f9056721eee9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196182 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67741} TBR=ulan@chromium.org,dinfuehr@chromium.org Change-Id: Ie529fd3bef13a28301f22876758d731e466d3939 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2197457Reviewed-by:
-
Frank Tang authored
Bug: v8:9934 Change-Id: I8e4c0bb647913b703c01fd0d11329fba254e5350 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2195491Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67760}
-
Thibaud Michaud authored
The recent changes to support multi-value calls should also apply to indirect calls, so this bailout can be removed. R=ahaas@chromium.org Bug: v8:10408 Change-Id: Ia1b2e49caa6f308a4d2f30712a132c7e072df9f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196350Reviewed-by:
-
Shu-yu Guo authored
This reverts commit e473d232. Reason for revert: Checking if build infra is fixed Original change's description: > Whitespace change to trigger bots > > Some bots turned red. Might be an infra failure. Let's see if this CL > makes it disappear. > > Tbr: machenbach@chromium.org > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I269257184cfca5423fb2c52ae8cfc1ad696002e9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196352 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67757} TBR=clemensb@chromium.org Change-Id: Ibe1d2725cc2bd621a3243b8930b43f8ec732420b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2197254Reviewed-by:
-
Clemens Backes authored
Some bots turned red. Might be an infra failure. Let's see if this CL makes it disappear. Tbr: machenbach@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I269257184cfca5423fb2c52ae8cfc1ad696002e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196352Reviewed-by:
-
Clemens Backes authored
Liftoff code generated for debugging has an extended function prologue which checks the "hook on function entry" flag on the isolate. Because of this, code positions between standard Liftoff code and Liftoff code for debugging do not match up. When (lazily) generating debug side tables, we always generate them for debugging-flavored Liftoff code. The issue that this CL fixes happened when we tried to inspect non-debug Liftoff code, and lazily generated the debug side table for that code. As noted above, source positions would not match up in that case, and we get DCHECK failures (or crashes in release builds) when inspecting the code. This issue was uncovered as part of the multi-threaded debugging effort, but because of the similarity in the stack trace, it might also fix the other issues linked below. We will get test coverage as soon as we add multi-threaded debugging tests (which are in development, but are still hitting other issues). R=thibaudm@chromium.org Bug: v8:10359, chromium:1071757, chromium:1079328, chromium:1072839 Change-Id: Ic0c14e635dc2a0b84ac86ceb6650288202dafedc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196349 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Changes: - Don't use UNIMPLEMENTED where it can be run. - Implement OpcodeLength for gc types. - Remove unreachable code. - Request the correct feature 'gc' for the respective opcodes and types. Bug: 1079337, 1079450, 1081529, 1081011, 1080444 Change-Id: Ib081139ca805c6f5471a372f862638a3606254b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196302 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a reland of 902f48bd, fixed to avoid lock inversion problems detected by TSan. Original change's description: > [wasm][debug] Fix tier down for multiple isolates > > If multiple isolates are using the same module, we need to keep it > tiered down as long as any isolate still has a debugger open. > Also, we cannot short-cut the {NativeModule::TierDown} method, since the > previously triggered tier down might not have finished yet. > For now, each isolate starts an independent tier down (i.e. a full > recompilation). We could optimize this later by skipping functions that > are already tiered down, or are already scheduled for tier down, but we > still need to wait for tier-down to finish on each isolate. > > R=thibaudm@chromium.org > > Bug: v8:10359 > Change-Id: I7ea6a6f5d3977e48718ac5bc94f9831541f6173f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190758 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67716} Bug: v8:10359 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Change-Id: Ie98cf073fc79e5c6991df6d4466de7b560274070 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2194451 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
