- 11 Sep, 2021 1 commit
-
-
Frank Tang authored
see https://github.com/tc39/test262/pull/3173 Bug: v8:12167 Change-Id: I49bed6bf361dbc216a5174be16d747fe2b104208 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152714Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#76778}
-
- 10 Sep, 2021 18 commits
-
-
Ng Zhi An authored
This is a follow-up on https://crrev.com/c/3131374 to support more instructions, float32 sqrt, cmp, round, float64 cmp. Rename the opcodes since they are no longer SSE specific. Bug: v8:12148 Change-Id: Ie5f74bc1b4510092cbfbcb7e420ef82cb1c39a14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3154983Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76777}
-
Junliang Yan authored
Change-Id: I1935a1ce50fcfb5f33511502367df624cc50a9df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3155382Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76776}
-
Ng Zhi An authored
In https://crrev.com/c/3131374 we switched some instructions to use macro-assembler functions which can handle AVX and SSE. However for Cvtsi2ss and Cvtsi2sd, the behavior subtly changed. The old behavior directly called cvtsi2ss/cvtsi2sd in the code-generator. The new behavior used the macro-assembler functions, which xor the dst operand. This led to more instructions and larger code size in some benchmarks. The xor is supposed to help reduce dependence chain length (see comments on Cvtsi2ss), but doesn't seem to have helped in this benchmark. So, partially revert the changes, and rename all affected IA32 opcodes back to SSE. Bug: chromium:1248509 Change-Id: Ie700e2980fe9ed083c1160bda3a28f64e1e43041 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3154349 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I05bcba3ad27b46b7c7888940895605ad463fc960 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3155302Reviewed-by:
-
Junliang Yan authored
Change-Id: Iea662aa79bf6d8fc7f8951482b6dfc0bcf30d081 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151964Reviewed-by:
-
Ng Zhi An authored
Move some AVX_OP into shared macro-assembler, for reuse by ia32 in future patches. Movlhps is also unused in x64, so remove it. Drive-by cleanup to use macro assembler helper Move to move 128-bit const into a XMMRegister. The change in liftoff-assembler-x64 is required because now the macro-assembler functions are defined in the base class, so even though we can use &TurboAssembler::Pcmpeqd to refer to that member function, it actually resolves to &SharedTurboAssembler::Pcmpeqd. Bug: v8:11589 Change-Id: Ie8f6a4dfd95b41192936f6e6be48c683042acec4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3150138Reviewed-by:
-
Clemens Backes authored
The {CountClearHalfWords} method is called whenever loading a constant into a register. It showed up with >0.5% in Liftoff compilation profiles. This CL refactors the method to return the number of *set* halfwords instead of *cleared* halfwords and avoids the loop in the implementation. This makes the method roughly twice as fast, and makes the code more readable. R=zhin@chromium.org Bug: v8:11879 Change-Id: I7da8160b3c045e5fc1e97fc0e575083b3920cb5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151962Reviewed-by:Zhi An Ng <zhin@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76771}
-
Clemens Backes authored
If background threads are tiering up, they could temporarily make code writable (if using the mprotect based approach). This would make our death tests fail (i.e. not crash). This CL fixes that by repeatedly writing in that case. Eventually, the code should be protected again, and then we would crash. Failure to crash would manifest as a timeout of the tests. R=jkummerow@chromium.org CC=mpdenton@chromium.org Bug: v8:11974 Change-Id: Ibe34af499da9b964ad260d58e9b4e390007898e9 Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151959 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76770}
-
Ng Zhi An authored
We already have some logic to try to get a reasonable name for the function when logging code. It looks up the name custom section, and falls back to the function index. Extract this into a helper, and call it when disassembly the code. Bug: v8:12098 Change-Id: Ieebe6594bc3184fa655f878faa0cb67c248d7f56 Fixed: v8:12098 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3125355Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76769}
-
Junliang Yan authored
Change-Id: I1efa3969ee07deca1dfa33f730f46a1067c12d73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152753Reviewed-by:
-
Junliang Yan authored
Change-Id: Ie9c8cf6475532df979c96df62254af32de6cf98f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152748Reviewed-by:
-
Milad Fa authored
StackCheck needs to be implemented on liftoff. Change-Id: I29624d65b82cbba3ef640ab7ea0cc78c2d5f2c4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152745Reviewed-by:
-
Clemens Backes authored
In the case that {dst}, {lhs} and {rhs} all point to the same register, we would emit wrong code (negating the register and adding it to itself). This CL fixes this by checking if {lhs == rhs}, and just clearing the {dst} register in that case. R=thibaudm@chromium.org Bug: chromium:1247659 Change-Id: I7913617850adb34a5ad812369f16a7422358454d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151955Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76765}
-
Marja Hölttä authored
Removing code left over by https://chromium-review.googlesource.com/c/v8/v8/+/3124806 . Bug: v8:7790 Change-Id: Id198df521ff58fe4f476f6f6a1fc624cb297be4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147591Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#76764}
-
Clemens Backes authored
With statically in-bounds memory accesses (implemented in https://crrev.com/c/2919827) we would only have an offset but no index register for {TraceMemoryOperation}. This CL fixes that situation. R=thibaudm@chromium.org Bug: chromium:1248024 Change-Id: I856b263a560cb71791c61e446e78dd99c9664190 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149464Reviewed-by:
-
Liu Yu authored
Change-Id: I1148508825b7bdff3dae0634aed5318a605ba4da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3153355Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#76762}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/17d097b..0c04087 Rolling v8/third_party/aemu-linux-x64: QewYN5289B8deg5Mn6clWEv58UqpocHGKeob2F0T87kC..vFeMtD7pamorE14xM1EkyVug7KRVEPRc7i89yT2sdaYC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2331f08..8141144 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7285666..e1482c5 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/ece15d0..3f44383 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/47226fa..20795c9 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I8f1144a9514c8e27c41701dee8380c6d9859db50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152860Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76761}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/50f3fca..66a3c3aa Bug: v8:7834, v8:12209 Change-Id: I74a5fd1b781c8280a68f47276e578e5c703876b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152710Reviewed-by:
-
- 09 Sep, 2021 21 commits
-
-
Ng Zhi An authored
We have a macro list defined, and already use it in other places, use it to disassemble the AVX instructions too. Bug: v8:11879 Change-Id: Id1a5bdc167d3f17d603aa2e43e1ac80ef4b1fdb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3150139Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76759}
-
Milad Fa authored
value must be written to memory in LE order on BE machines as they will be loaded in reverse when emitting S128Const. Change-Id: Ia1d6c784505abe499fb71a6d86daea2721615da4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151956Reviewed-by:
-
Ng Zhi An authored
With these accessors we can remove Assembler as a friend class. Drive-by cleanup to change DCHECK(!x || y) to DCHECK_IMPLIES(x, y). Change-Id: I74b7a23e85b50db93bbfe84fdfcc8563527f14d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144374Reviewed-by:
-
Ng Zhi An authored
This is similar to what is already done in x64, define a macro list for all the *sd instructions (prefix f2 0f), and use this macro list to define assembler functions and disassembly. Bug: v8:11879 Change-Id: Ia7fbd9fe7f07b72c04d82c81726b9673c40eb0de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3125774 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
By delegating to the macro-assembler, emit AVX instructions for some float opcodes (float sqrt, round, conversions to and from int, extract/insert/load word). Since they now support AVX, we rename the instruction ops to remove the SSE prefix, changing it to be IA32. Bug: v8:12148 Change-Id: Ib488f03928756e7d85ab78e6cb28eb869e0641f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3131374Reviewed-by:
-
Ng Zhi An authored
Change-Id: I51dee467f5b843e96ffccbe6e99ba203e8c3bf10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3111266Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76754}
-
Philip Pfaffe authored
Bug: chromium:1241860 Change-Id: Ieee7d5c67f1a42c0c9855148a7d497586d6c5555 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149456Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/main@{#76753}
-
Georg Neis authored
Bug: chromium:1247763 Change-Id: I6f09d5113ef7e4774032ea586d5a1ada98aa4b1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149462Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#76752}
-
Georg Neis authored
It could happen that the information about the feedback vector cached in a JSFunctionData disagreed with the current value of the function's feedback cell. The inlining code wasn't prepared for that and a CHECK could fail. The CL fixes this by removing the caching of has_feedback_vector and feedback_vector and by getting hold of the bytecode array before fetching the feedback vector in inlining. Bug: v8:12172, v8:7790 Change-Id: Ife3ab8872085d9496e6d1f34514114a086f653ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148010 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Liviu Rau authored
R=hablich@chromium.org, vahl@chromium.org Change-Id: Ibec33a0f0299cea3e215aebfcf0cc873356f795e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149461 Auto-Submit: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Lutz Vahl <vahl@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#76750}
-
Ilja Iskovs authored
Use an immediate zero operand for floating point comparison nodes when possible. This results in up to 20-25% runtime improvement in some microbenchmarks, as well as 1-1.5% runtime improvement in some real-use benchmarks on Cortex-A55 and Neoverse N1. Change-Id: I39d10871a08a037dbe8c0877d789d110476e1a58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3133143Reviewed-by:
-
Rakhim Khismet authored
We add call_ref and return_call_ref to the fuzzed module. We alter call function to generate call_ref in it. Bug: v8:11954 Change-Id: I972b8e053d7eab758ac343d48f0c4631ef24b22b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148011Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Clemens Backes authored
Test that also signal handlers cannot write to code, even if a {CodeSpaceWriteScope} is open when the signal is triggered. R=jkummerow@chromium.org CC=mpdenton@chromium.org Bug: v8:11974 Change-Id: I1e49e4b31ba196948f7f7adfdf88675816e0a58a Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3140607Reviewed-by: -
Jakob Gruber authored
The icu object cache consists of 5 keys at most -> change it from an unordered_set to a plain array. Possible return values of CompareStrings are {-1,0,1}. Return those directly instead of going through Factory::NewNumberFromInt. Bug: v8:12196 Change-Id: Ia42bb6b1a0ebdc99550f604aa79cb438b150ee88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149454 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#76746}
-
Marja Hölttä authored
They need to agree about when to delegate to CloneFastJSArray, since it produces arrays which are potentially COW. If they don't agree, TF generates code which produces a COW array and then expects it to be non-COW -> immediate deopt. This CL gets rid of the discrepancy in the case when there's exactly one argument and it's the number 0. Some corner cases remain, e.g., 1st argument not a number but ToInteger returns 0. These should be extremely rare in the real world. Bug: v8:12194 Change-Id: I10230245c97f8997da4d79702f29ebff11297229 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147910 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Patrick Thier authored
AbstractCode doesn't fully support Sparkplug code yet (SourcePosition and SourcePositionStatement are not supported). Fall back to using BytecodeArray as AbstractCode at call-sites where we use these functions. Bug: chromium:1246259 Change-Id: I839cbff65c96eaaa0057c1e5a8bdd12e2bd721ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147594Reviewed-by:
-
Michael Achenbach authored
Depends on https://crrev.com/c/3148012 to land first. No-Try: true Bug: chromium:1136844 Change-Id: I08b57e1d070a905dc7df71fce18891c9615a0153 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148013Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#76743}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/c23a001..1bd8098 Optimized docs installation (#1225) (Vitaly Zaitsev) https://chromium.googlesource.com/external/github.com/google/benchmark/+/1bd8098 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I2fa85b1c9ea2a3bc3422977560b8280f0723d649 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149526Reviewed-by:
-
Georg Neis authored
... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1e4482b..17d097b Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/fc37619..17de752 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/edf77b2..44ea7ab Rolling v8/third_party/aemu-linux-x64: ExffPYjGXL4Gz5i52elIFTU-ZZZ3Rgom_ZGpSi12LBoC..QewYN5289B8deg5Mn6clWEv58UqpocHGKeob2F0T87kC Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c678081..664e425 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: If5bde624ec64e78723a8e9d83a2cacb385fb1271 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149524Reviewed-by:
-
Zhao Jiazhong authored
The t6-t8 are scratch registers and should not be allocatable. Besides, add s0, s1, s2, s5 and s8 as allocatable registers. Change-Id: I0805cc5273d0e0ec5040a0376bcbfba276202077 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147315 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
