- 06 Oct, 2016 23 commits
-
-
mvstanton authored
With this CL, we devolve all Constants introduced as they are with an object handle into * Range - for integers * Nan * MinusZero * OtherNumberConstant - for doubles * HeapConstant We reduce the amount we have to inspect an object handle during optimization. Also, simplifications result. For example, you never have to check if a Range contains a HeapConstant. BUG= Review-Url: https://codereview.chromium.org/2381523002 Cr-Commit-Position: refs/heads/master@{#40041}
-
hpayer authored
This is an intermediate step for concurrent slot filtering. This CL already makes filtering concurrent, but does not integrate it in the actual sweeping. This will be done in two follow up CLs. One for the regular slot set and one for the typed slot set. BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2401563002 Cr-Commit-Position: refs/heads/master@{#40040}
-
Miran.Karic authored
Recent changes in Segment class caused many tests to fail on mips32 because of an unaligned read error. Setting the alignment to 8 for mips fixes the issue. Accessing doubles on mips32 must be eight bit aligned. BUG= Review-Url: https://codereview.chromium.org/2390303003 Cr-Commit-Position: refs/heads/master@{#40039}
-
hablich authored
Revert of [wasm] Refactor import handling for 0xC. (patchset #10 id:180001 of https://codereview.chromium.org/2390113003/ ) Reason for revert: Failes a few GC stress tests.https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/6253 Original issue's description: > [wasm] Refactor import handling for 0xC. > > Imports and exports in 0xC can be much more than functions, including > tables, memories, and globals. This CL refactors the underlying > organization of imports and exports to support these new import types. > > BUG= > > Committed: https://crrev.com/599f8a83420346d9cba5ff97bd2a7520468207b6 > Cr-Commit-Position: refs/heads/master@{#40033} TBR=mtrofin@chromium.org,ahaas@chromium.org,bradnelson@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2395133002 Cr-Commit-Position: refs/heads/master@{#40038}
-
hablich authored
TBR=machenbach@chromium.org NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2397153002 Cr-Commit-Position: refs/heads/master@{#40037}
-
jgruber authored
Flag getters are implemented as TurboFan stubs while the rest are written as C++. This distinction is somewhat arbitrary and more getters could be ported to TurboFan in the future. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2389233002 Cr-Commit-Position: refs/heads/master@{#40036}
-
epertoso authored
R=jarin@chromium.org BUG= Review-Url: https://codereview.chromium.org/2401553002 Cr-Commit-Position: refs/heads/master@{#40035}
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2397473004 Cr-Commit-Position: refs/heads/master@{#40034}
-
titzer authored
Imports and exports in 0xC can be much more than functions, including tables, memories, and globals. This CL refactors the underlying organization of imports and exports to support these new import types. BUG= Review-Url: https://codereview.chromium.org/2390113003 Cr-Commit-Position: refs/heads/master@{#40033}
-
heimbuef authored
In an anonymous namespace, all methods are already treated like being static, so no need for these keywords. Review-Url: https://codereview.chromium.org/2384403006 Cr-Commit-Position: refs/heads/master@{#40032}
-
mstarzinger authored
This switches the {ParseInfo} constructor to always determine the outer scope info from the shared function info instead of a concrete closure. It is a precursor to deprecate the constructor taking closures entirely and hence make the fact that we can parse without a closure explicit. R=jochen@chromium.org BUG=v8:2206 Review-Url: https://codereview.chromium.org/2397053003 Cr-Commit-Position: refs/heads/master@{#40031}
-
ahaas authored
BUG=chromium:653264 TEST=cctest/test-run-wasm-module/GrowMemoryZero R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2389263005 Cr-Commit-Position: refs/heads/master@{#40030}
-
mvstanton authored
BUG= R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2393923003 Cr-Commit-Position: refs/heads/master@{#40029}
-
mstarzinger authored
R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2388303008 Cr-Commit-Position: refs/heads/master@{#40028}
-
bmeurer authored
The generic implementations for typeof, strict equality and ToBoolean don't need a context, so we can just pass the NoContextConstant (which is Smi zero) instead, to reduce the live ranges for the context. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2400633002 Cr-Commit-Position: refs/heads/master@{#40027}
-
mlippautz authored
The scavenger should never consider mark bits for promotion/copy as this creates weird livetimes at the start of incremental marking. E.g. consider an object marked black by the marker at the start of incremental marking. A scavenge would promote it to the old generation although it could --and for short-living objects actually does-- become unreachable during marking Also, keeping this invariant significantly simplifies young generation mark compacting as we can compare against the scavenging decision without keeping different sets of markbits. BUG=chromium:651354 R=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2397713002 Cr-Commit-Position: refs/heads/master@{#40026}
-
ishell authored
... because the latter automatically respects the desired calling convention. BUG=v8:5408 Review-Url: https://codereview.chromium.org/2398683004 Cr-Commit-Position: refs/heads/master@{#40025}
-
heimbuef authored
because ownership over it is not obviously clear and leads to errors. Review-Url: https://codereview.chromium.org/2366283003 Cr-Commit-Position: refs/heads/master@{#40024}
-
ishell authored
... because the latter automatically respects the desired calling convention. BUG=v8:5408 Review-Url: https://codereview.chromium.org/2396023002 Cr-Commit-Position: refs/heads/master@{#40023}
-
bmeurer authored
Emit code like this cmpq reg, [kRootRegister + offset] when selecting instructions for comparisons with immortal, immovable roots. This reduces register pressure as we don't need to load those roots into registers first. R=jarin@chromium.org TBR=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2396923003 Cr-Commit-Position: refs/heads/master@{#40022}
-
jarin authored
Reland of "[turbofan] Osr value typing + dynamic type checks on entry. (patchset #5 id:80001 of https://codereview.chromium.org/2384113002/ )" Fixes: - Remove OsrGuards on frame specialization (for asm.js). - Handle the rename in the walk for native context. - Fix LoadContext effect wiring for Osr context chains. Review-Url: https://codereview.chromium.org/2388303006 Cr-Commit-Position: refs/heads/master@{#40021}
-
danno authored
Specifically an attempt to address a 3.5% regression on the total load time on cnn introduced by https://codereview.chromium.org/2113673002. Non-refactoring effect of this CL is to reduce the number of branches in CodeStubAssembler-generated loops iterating over FixedArrays from two to one. LOG=N BUG=v8:5423 Review-Url: https://codereview.chromium.org/2380953002 Cr-Commit-Position: refs/heads/master@{#40020}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/475d5b3..67604e1 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/5fd6695..39b1db2 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2397993002 Cr-Commit-Position: refs/heads/master@{#40019}
-
- 05 Oct, 2016 17 commits
-
-
gsathya authored
When we create native promises as part of PromiseThen, we don't have to create resolving closures. The closure will only ever be called once from PromiseHandle, therefore we don't need the alreadyResolved check. This results in a 21.76% improvement in the bluebird benchmark over 5 runs. BUG=v8:5046 Review-Url: https://codereview.chromium.org/2396763002 Cr-Commit-Position: refs/heads/master@{#40018}
-
ziyang authored
Port 7a82be3d Original commit message: The duplicated enum values are only used by the FastNewClosureStub, so inline them there, with the help of one new constant (kFunctionKindShift) in SharedFunctionInfo. R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Review-Url: https://codereview.chromium.org/2391343003 Cr-Commit-Position: refs/heads/master@{#40017}
-
kozyatinskiy authored
v8::Integer::Value() method returns int64 but all scriptIds are 32 bit based. We can safely cast int64 into int here to make compilers happy. R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2394973002 Cr-Commit-Position: refs/heads/master@{#40016}
-
leszeks authored
Adds string type feedback to Ignition's AddWithFeedback code stub, for now only adding a special case for when both lhs and rhs are strings. This improves octane's splay by >100%. BUG=v8:5400 Committed: https://crrev.com/fb4ae2239d37adaf0321165034050316914de708 Committed: https://crrev.com/bf1a94f1b269914856a8c8763fd282367f066c67 Review-Url: https://codereview.chromium.org/2392533002 Cr-Original-Original-Commit-Position: refs/heads/master@{#39987} Cr-Original-Commit-Position: refs/heads/master@{#39996} Cr-Commit-Position: refs/heads/master@{#40015}
-
bjaideep authored
On PPC64 linux the OS page size is 64KB, therefore when the snapshot is created the serialized heap already has LO_SPACE allocated(the allocation goes beyond the 1st page of CODE_SPACE and hence LO_SPACE is allocated). I've updated the testcase to check if the delta of the LO_SPACE is zero. R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org BUG= Review-Url: https://codereview.chromium.org/2394893002 Cr-Commit-Position: refs/heads/master@{#40014}
-
bradnelson authored
Allow fround to take values without dots for globals (the spec allows this subtly). Drop over-restrictive assert preventing floating point globals from working. BUG=v8:4203 R=jpp@chromium.org,aseemgarg@chromium.org Review-Url: https://codereview.chromium.org/2397823003 Cr-Commit-Position: refs/heads/master@{#40013}
-
ziyang authored
GCC on S390 31-bit treats size_t as 'long unsigned int', which is incompatible with %d format specifier that expects an 'int'. Using the appropriate macro (PRIuS) instead. R=mlippautz@chromium.org, hpayer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2398703002 Cr-Commit-Position: refs/heads/master@{#40012}
-
gsathya authored
Review-Url: https://codereview.chromium.org/2376613003 Cr-Commit-Position: refs/heads/master@{#40011}
-
machenbach authored
NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true TBR=hablich@chromium.org Review-Url: https://codereview.chromium.org/2392463007 Cr-Commit-Position: refs/heads/master@{#40010}
-
adamk authored
Revert of Reland "Turn libbase into a component" (patchset #1 id:1 of https://codereview.chromium.org/2395553002/ ) Reason for revert: Speculative revert due to very strange-looking win/dbg failures which reference SignedDivisionByConstant: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/12736 Original issue's description: > Reland "Turn libbase into a component" > > Original issue's description: > > Turn libbase into a component > > > > This is a precondition for turning libplatform into a component > > > > BUG=v8:5412 > > R=jgruber@chromium.org,machenbach@chromium.org > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_ > dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe > > > > Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104 > > Cr-Commit-Position: refs/heads/master@{#39950} > > BUG=v8:5412 > TBR=jgruber@chromium.org,machenbach@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng > > Committed: https://crrev.com/17cb51254cafa932025e9980b60f89f756d411cb > Cr-Commit-Position: refs/heads/master@{#39969} TBR=jgruber@chromium.org,machenbach@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5412 Review-Url: https://codereview.chromium.org/2396933002 Cr-Commit-Position: refs/heads/master@{#40009}
-
caitp authored
Reland https://codereview.chromium.org/2373983004/, reverted in 4e5a4d93. Reason: CL is not responsible for Win32 Debug failures (see https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/5031) ------------------------------------------------------------------------------ Implement the logic for StringIterator.prototype.next in the JSBuiltinReducer in order to allow inlining when the receiver is a JS_STRING_ITERATOR_TYPE map, built ontop of the SimplifiedOperators StringCharCodeAt and the newly added StringFromCodePoint. Also introduces a new StringFromCodePoint simplified op which may be useful for other String builtins, such as String.fromCodePoint() BUG=v8:5388 TBR=bmeurer@chromium.org, mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2394823003 Cr-Commit-Position: refs/heads/master@{#40008}
-
kozyatinskiy authored
BUG=chromium:496666 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2391323002 Cr-Commit-Position: refs/heads/master@{#40007}
-
ishell authored
An attempt to fix memory regression (r38047) caused another regression because custom capacity chosen for names dictionary implied reallocations during initialization in some cases. BUG=chromium:625894,chromium:632231 Review-Url: https://codereview.chromium.org/2394873002 Cr-Commit-Position: refs/heads/master@{#40006}
-
adamk authored
The duplicated enum values are only used by the FastNewClosureStub, so inline them there, with the help of one new constant (kFunctionKindShift) in SharedFunctionInfo. Review-Url: https://codereview.chromium.org/2390043003 Cr-Commit-Position: refs/heads/master@{#40005}
-
vogelheim authored
R=jochen@chromium.org BUG=chromium:651333, v8:4947 Review-Url: https://codereview.chromium.org/2391273002 Cr-Commit-Position: refs/heads/master@{#40004}
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2389133004 Cr-Commit-Position: refs/heads/master@{#40003}
-
rmcilroy authored
BUG=v8:4280 Review-Url: https://codereview.chromium.org/2384123002 Cr-Commit-Position: refs/heads/master@{#40002}
-