- 26 Nov, 2018 11 commits
-
-
Jakob Gruber authored
It's been failing for a while, and looks like we reach some arbitrary heap limit, triggering an early OOM before the debugger hook is set. Bug: v8:8494 Change-Id: I472dc8955ba2f0eb018ac6e7ca83e4beaaefc318 Reviewed-on: https://chromium-review.googlesource.com/c/1350830Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57820}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I325b10268a9ed9548fd28ecc3e5e2b0959afcdc4 Reviewed-on: https://chromium-review.googlesource.com/c/1350125Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57819}
-
Toon Verwaest authored
No-Tree-Checks: true No-Try: true Change-Id: I8b8651e499c2d862ae9f81a18af11d610214c0cd Reviewed-on: https://chromium-review.googlesource.com/c/1350118 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57818}
-
Toon Verwaest authored
No-Tree-Checks: true No-Try: true Change-Id: If9e39eb64db24e7d7dd2ae639d95f750aef04210 Reviewed-on: https://chromium-review.googlesource.com/c/1350119 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
No-Tree-Checks: true No-Try: true Change-Id: I88fb20bb78df733fb135d2103b38908926a9d512 Reviewed-on: https://chromium-review.googlesource.com/c/1350115 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
No-Tree-Checks: true No-Try: true Bug: chromium:908231 Change-Id: I1acf33400ad3546974a0ccb5955f8c6966b17dcf Reviewed-on: https://chromium-review.googlesource.com/c/1350116 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57815}
-
Marja Hölttä authored
- Remove heap-inl.h includes from places where it looked unnecessary. (This is a non-scientific approach, because it's probably pulled in indirectly anyway.) - Annotate places which include heap-inl.h because they need heap/ internals. - ACCESSORS legitimately needs heap-inl.h because of Heap::FromWritableHeapObject. - Add includes to heap/heap-write-barrier(-inl).h - A bunch of IWYU fixes discovered when working on this CL (includes which were missing because heap-inl.h pulls them in indirectly). BUG=v8:7490,v8:8238,v8:8499 Change-Id: I00f9a74d430f13d7c080dca77a92b03bcca7ef96 Reviewed-on: https://chromium-review.googlesource.com/c/1349241Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57814}
-
Toon Verwaest authored
Bug: chromium:908250 Change-Id: I414255f00bf7dcec0cf8b35e314a2b9b78a9116e Reviewed-on: https://chromium-review.googlesource.com/c/1350117 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I106b783899cef2f124450f8cc266b3b2ac09b4ae Reviewed-on: https://chromium-review.googlesource.com/c/1350114Reviewed-by:
-
Maya Lekova authored
This reverts commit ca086a49. Reason for revert: Seems to be the cause for https://bugs.chromium.org/p/chromium/issues/detail?id=908296 Original change's description: > [parser] Perfect hash for keywords > > Use gperf to generate a perfect hash table for keyword lookup. Adds a > python script which munges the output of gperf and adds additional > cleanup and optimisations. > > Change-Id: I3656a7287dbd0688917893de3a671faef9e4578a > Reviewed-on: https://chromium-review.googlesource.com/c/1349240 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57790} TBR=marja@chromium.org,leszeks@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia0cc283f21e9f6793522c46a1fd40ba2d88597fb Reviewed-on: https://chromium-review.googlesource.com/c/1350113Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#57811}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b471e77..2339062 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id6d0f397d17a6602222e109de565b41ff7451d0b Reviewed-on: https://chromium-review.googlesource.com/c/1350284 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57810}
-
- 25 Nov, 2018 3 commits
-
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: Id515906744a738d5d40dbb6dee15e243623f020c Reviewed-on: https://chromium-review.googlesource.com/c/1349111 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57809}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fa87ce6..b471e77 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie8d912df3b6c2cdb4688fca4070e58734ed412f1 Reviewed-on: https://chromium-review.googlesource.com/c/1350269Reviewed-by:
-
Jakob Kummerow authored
Removing the temporarily duplicated classes FixedArrayPtr and FixedArrayBasePtr. Bug: v8:3770 Change-Id: I056ad74ff69593e9f134ef5c976766812c4d9275 Reviewed-on: https://chromium-review.googlesource.com/c/1345913 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
- 24 Nov, 2018 8 commits
-
-
Sigurd Schneider authored
This reverts commit 81b5f713. Revert "[heap] Cleanup embedder tracing APIs" This reverts commit ce02d86b. Tbr: mlippautz@chromium.org Change-Id: I5900ac3c070c93b869c9173316a466d39287713a Reviewed-on: https://chromium-review.googlesource.com/c/1350111Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57806}
-
Clemens Hammacher authored
This is a reland of e8a22a70 Original change's description: > [iwyu] Add missing includes > > This fixes a presubmit error: > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Presubmit/454 > > It also adds another missing include. > > R=machenbach@chromium.org > CC=caitp@igalia.com > > Bug: v8:7490 > Change-Id: I915a5bf431073410a67ff08471fd5e6974e31aa1 > No-Try: true > No-Tree-Checks: true > Reviewed-on: https://chromium-review.googlesource.com/c/1346111 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57671} TBR=clemensh@chromium.org NOTRY=true NOTREECHECKS=true Bug: v8:7490 Change-Id: Id327a36cc5a727e734ea1bb6faf43e592ee2f21c Reviewed-on: https://chromium-review.googlesource.com/c/1350129Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57805}
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: If5328a4c63d8efe0ce7a0c5a744666c79c02e1ee Reviewed-on: https://chromium-review.googlesource.com/c/1345912 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: I49d4fdc1cac6c4bde81fbe0bf76341be12711109 Reviewed-on: https://chromium-review.googlesource.com/c/1345911 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cd7b727..fa87ce6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4ed4737..17079a5 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/25c4fce..6c18a1a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I2b67323a005e4dea8f3fe5bd36dd5b94c4d4f744 Reviewed-on: https://chromium-review.googlesource.com/c/1349732Reviewed-by:
-
Jakob Kummerow authored
to the new design. Bug: v8:3770 Change-Id: I3cd0a66eefefedc98a641494302fc79d897a153a Reviewed-on: https://chromium-review.googlesource.com/c/1345910 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: I06f7fb1b2915d1c87162cb464d0ed34d08516e24 Reviewed-on: https://chromium-review.googlesource.com/c/1345909 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: I0bac3cc2a0a2c7e6c1cf18e7db00bdffd2d9f7a1 Reviewed-on: https://chromium-review.googlesource.com/c/1345328 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
- 23 Nov, 2018 18 commits
-
-
Caitlin Potter authored
This is a reland of a5336471 Original change's description: > [builtins] Implement Object.fromEntries > > Adds the Object.fromEntries() method behind > --harmony-object-from-entries. > > > Includes an initial implementation of the new experimental builtin > Object.fromEntries implemented by Daniel Clifford, and > has been modified by Caitlin Potter to support a fast case to skip > the iterator protocol when it can be done unobservably in common cases. > > There are some incidental changes: A number of CSA macros have been > updated to use TNodes, and some Context arguments have been > re-arranged to be implicit in Torque. > > > There are also a number of mjsunit tests written mirroring and > expanding on the test262 tests. > > BUG=v8:8021 > > Change-Id: I1c12bee8a2f98c6297b77d5d723910a5e3b630cc > Co-authored-by: Daniel Clifford <danno@chromium.org> > Co-authored-by: Caitlin Potter <caitp@igalia.com> > Reviewed-on: https://chromium-review.googlesource.com/c/1337585 > Commit-Queue: Daniel Clifford <danno@chromium.org> > Reviewed-by: Daniel Clifford <danno@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57667} Bug: v8:8021 Change-Id: I706e2d87bfc2f688e833c1b7d40ca82f5d80f5a2 Reviewed-on: https://chromium-review.googlesource.com/c/1346630Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#57798}
-
Toon Verwaest authored
This reverts commit 8c359f64. Reason for revert: Tentative revert for ASAN breakage Original change's description: > [zone] Keep one page when we Zone::Reset for reuse > > Change-Id: I50c6124d3da5b35d4156c066f38d10d2dc966567 > Reviewed-on: https://chromium-review.googlesource.com/c/1349246 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57793} TBR=ishell@chromium.org,verwaest@chromium.org Change-Id: Iff319b5f0ad1a65b1171d219a02a4a75d33910bd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1349248Reviewed-by:
-
Toon Verwaest authored
Change-Id: I78dfc1ae0ec7bc47c14d2d525d2f20516e13effa Reviewed-on: https://chromium-review.googlesource.com/c/1349247Reviewed-by:
-
Michael Lippautz authored
Provide processing scope that makes it impossible to maintain locally cached wrappers that could get invalidated in Blink and yield in crashers. Bug: chromium:843903, v8:8238 Change-Id: I7ba1905f6c77a97bcc61ac42f921dcac4772471f Reviewed-on: https://chromium-review.googlesource.com/c/1349276 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: Icbda182a894ce6508efbfa3bdb17ba3adce360c7 Reviewed-on: https://chromium-review.googlesource.com/c/1349573Reviewed-by:
-
Toon Verwaest authored
Change-Id: I50c6124d3da5b35d4156c066f38d10d2dc966567 Reviewed-on: https://chromium-review.googlesource.com/c/1349246Reviewed-by:
-
Toon Verwaest authored
Rather check expressions used as patterns directly. Check parentheses by tagging parenthesized expressions as parenthesized. This allows us to drop UnexpectedPatternToken and makes it clear why a specific token is unexpected (because it's invalid in a binding pattern). This also more uniformly restores messages like "Invalid destructuring assignment target". Change-Id: Idd98e9116c85de4c2304cf1fef1baa097b67149d Reviewed-on: https://chromium-review.googlesource.com/c/1349572 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I348dbf52bc43078861e40e8377257c8f9a2bc920 Reviewed-on: https://chromium-review.googlesource.com/c/1349242Reviewed-by:
-
Leszek Swirski authored
Use gperf to generate a perfect hash table for keyword lookup. Adds a python script which munges the output of gperf and adds additional cleanup and optimisations. Change-Id: I3656a7287dbd0688917893de3a671faef9e4578a Reviewed-on: https://chromium-review.googlesource.com/c/1349240 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57790}
-
Peter Marshall authored
- Remove the InstallFunction variant which just passed its arguments straight to JSObject::AddProperty - Change InstallFunction to accept a String rather than a Symbol as all symbol installation goes through InstallFunctionAtSymbol now. This way we can avoid the call to Name::ToFunctionName as well - Add an explicit helper InstallFunctionWithBuiltinId for installing functions which have a builtin ID. These are always installed with DONT_ENUM PropertyAttributes so we can remove that parameter, too. - Remove PropertyAttributes from InstallFunction because it is always DONT_ENUM. Bug: v8:8238 Change-Id: I7af3d6d833d50065c20e198e21a72ef4a539c1ca Reviewed-on: https://chromium-review.googlesource.com/c/1349284Reviewed-by:
-
Andreas Haas authored
R=yangguo@chromium.org Bug: v8:8238 Change-Id: Ia59aefc54c2e9f4fa3348c42fb45e7fadab8ee76 Reviewed-on: https://chromium-review.googlesource.com/c/1349231Reviewed-by:
-
Andreas Haas authored
R=yangguo@chromium.org Bug: v8:8238 Change-Id: I657ec92031ffe8241eaac67ba207bddc989c73a7 Reviewed-on: https://chromium-review.googlesource.com/c/1349234Reviewed-by:
-
Marja Hölttä authored
This is a reland of 81756480 Original change's description: > [objects.h splitting] Move AsyncGeneratorRequest > > BUG=v8:5402,v8:8238 > > Change-Id: I988b1e0b7a958d06690820632bc533d9e5338535 > Reviewed-on: https://chromium-review.googlesource.com/c/1349190 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57776} TBR=clemensh@chromium.org,ulan@chromium.org Bug: v8:5402, v8:8238 Change-Id: I9f4b6b761313be586612df7e7753b97f99c4d1e9 Reviewed-on: https://chromium-review.googlesource.com/c/1349283 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Yang Guo authored
This reverts commit 38cd61d0. Reason for revert: Layout test http/tests/asmjs/asm-warnings.html fails due to missing context. See https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/238991 crash log for renderer (pid <unknown>): STDOUT: <empty> STDERR: [1:1:1123/024436.020348:FATAL:script_state.h(140)] Check failed: !context.IsEmpty(). STDERR: #0 0x5556817298df base::debug::StackTrace::StackTrace() STDERR: #1 0x55568167b5fb logging::LogMessage::~LogMessage() STDERR: #2 0x55568154ed45 blink::ScriptState::From() STDERR: #3 0x555683047aa9 blink::V8Initializer::MessageHandlerInMainThread() STDERR: #4 0x5556801793c8 v8::internal::MessageHandler::ReportMessageNoExceptions() STDERR: #5 0x555680178652 v8::internal::MessageHandler::ReportMessage() STDERR: #6 0x5556802c2563 v8::internal::PendingCompilationErrorHandler::ReportWarnings() STDERR: #7 0x55567fc8bcd3 v8::internal::(anonymous namespace)::FinalizeUnoptimizedCode() STDERR: #8 0x55567fc8b668 v8::internal::Compiler::Compile() STDERR: #9 0x55567fc8be6b v8::internal::Compiler::Compile() STDERR: #10 0x55568033a36f v8::internal::__RT_impl_Runtime_CompileLazy() STDERR: #11 0x5556808f2492 <unknown> STDERR: STDERR: [25209:25254:1123/024436.075700:WARNING:crash_handler_host_linux.cc(341)] Could not translate tid, attempt = 1 retry ... The issue seems to be that we do require the context for when we report a compile error when finalizing the compilation. Original change's description: > [Compiler] Ensure unoptimized code generation is context independent. > > Now that Asm.js code is also context independent, move code to ensure context independence > from BytecodeGenerator to FinalizeUnoptimizedCode. > > Change-Id: I7738eb3b347ea82764ecd3b5548dc82cb06d2f4e > Reviewed-on: https://chromium-review.googlesource.com/c/1347483 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57730} TBR=rmcilroy@chromium.org,mstarzinger@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Iaa15e608b35a3396ba51a03f996c6de1330f0016 Reviewed-on: https://chromium-review.googlesource.com/c/1349236 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=yangguo@chromium.org Bug: v8:8238 Change-Id: I37acbc2b7f14d16a57a27cc235769f8a7c18e3a1 Reviewed-on: https://chromium-review.googlesource.com/c/1349232Reviewed-by:
-
Andreas Haas authored
The callback set with this function is already not used anymore. R=yangguo@chromium.org Bug: chromium:860637, v8:8238 Change-Id: I26f4528720e936dcc9b7b244dff7db97a4b43273 Reviewed-on: https://chromium-review.googlesource.com/c/1345989Reviewed-by:
-
Toon Verwaest authored
- Reuse CheckDestructuringElement for object rest destructuring, - don't duplicate eval/arguments detection in object patterns, - don't unnecessarily locally validate expression when async(...) is a call, - don't classify pattern error for Property since it's only invalid as a binding pattern. Change-Id: I0eaf6abff39a563c2d6dc07dfbb17071c0f76caf Reviewed-on: https://chromium-review.googlesource.com/c/1349282Reviewed-by:
-
Clemens Hammacher authored
This method is only used in a slow dcheck, thus omit it completely otherwise. R=ahaas@chromium.org Bug: v8:8238 Change-Id: Ic23d0ff10a1dfe9f383237c99a365c2d3ee93e51 Reviewed-on: https://chromium-review.googlesource.com/c/1349233Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57781}
-
