Commits · 964ec21e5350f8ed9e2f69e1fb78a166f1ee2d6b · Linshizhi / V8

14 Aug, 2014 9 commits

bmeurer@chromium.org authored Aug 14, 2014

And while we are at it, use the stupid MSVC compiler intrinsics.

TEST=base-unittests/BitTest
TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/473773003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

964ec21e

Unify MachineType and RepType. · 9803a724

titzer@chromium.org authored Aug 14, 2014

MachineType now tracks both the representation and the value type of machine quantities and is used uniformly throughout TurboFan.

These types can now express uint8, int8, uint16, and int16, i.e. signed and unsigned smallish integers. Note that currently only uint8 and uint16 are implemented in the TF backends.

R=bmeurer@chromium.org, mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/470593002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9803a724

[turbofan] Introduce WordRor machine operator. · ae7d781d

bmeurer@chromium.org authored Aug 14, 2014

Move recognition of rotate-right operations to the
MachineOperatorReducer, so we don't need to repeat that in the
InstructionSelector for every backend.

TEST=base-unittests,compiler-unittests,cctests
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/469213002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23121 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ae7d781d

Fast-forward version number on bleeding_edge to 3.29.0 · d9e671b5

jochen@chromium.org authored Aug 14, 2014

BUG=none
LOG=n
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/470083002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23120 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d9e671b5

Revert 23058 - "Allow externalizing cons and sliced string." · 2de0692a

jochen@chromium.org authored Aug 14, 2014

Reason for revert: broke inspector

| Fulfill overdue TODO.
|
| R=mstarzinger@chromium.org
|
| Review URL: https://codereview.chromium.org/460643002

TBR=yangguo@chromium.org,mstarzinger@chromium.org
BUG=403521
LOG=n

Review URL: https://codereview.chromium.org/470913002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23115 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2de0692a

Fix pointer iteration for maps. · 18a10e34

jarin@chromium.org authored Aug 14, 2014

BUG=
R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/475463003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23114 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

18a10e34

Fix test expectations. · efde48fb

yangguo@chromium.org authored Aug 14, 2014

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/461233003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23113 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

efde48fb

Ignore default reject handler when looking for reject handlers. · 0ae0b81c

yangguo@chromium.org authored Aug 14, 2014

LOG=N
BUG=v8:3093
R=aandrey@chromium.org

Review URL: https://codereview.chromium.org/461023002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23112 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0ae0b81c

[turbofan] Refactor the InstructionSelector tests. · f4b5224a

bmeurer@chromium.org authored Aug 14, 2014

Also fix some issues and improve test coverage.

TEST=compiler-unittests
BUG=v8:3489
LOG=y
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/469743002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23111 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f4b5224a

13 Aug, 2014 15 commits

Fix non-TF target build after r23107. · 76a49573

mstarzinger@chromium.org authored Aug 13, 2014

TBR=jarin@chromium.org
TEST=cctest/test-run-deopt

Review URL: https://codereview.chromium.org/473453002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

76a49573

MIPS: Fix DCHECK failure in simulator for fp32 mode. · c9879cfb

dusan.milosavljevic@imgtec.com authored Aug 13, 2014

TEST=mjsunit tests in debug
BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/467203002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23109 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c9879cfb

ES6: Make Map/Set constructors support iterable values · fdd094ab

arv@chromium.org authored Aug 13, 2014

Same for WeakMap/WeakSet

https://bugs.ecmascript.org/show_bug.cgi?id=3111

The change from the reverted version is that LoadIC_Miss now uses Name
instead of String.

BUG=v8:3508
LOG=Y
R=adamk@chromium.org, dslomov@chromium.org

Review URL: https://codereview.chromium.org/464093002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23108 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fdd094ab

Move %IsOptimized runtime helper into test case. · 8b7dd630

mstarzinger@chromium.org authored Aug 13, 2014

R=jarin@chromium.org
TEST=cctest/test-run-deopt

Review URL: https://codereview.chromium.org/468153002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23107 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8b7dd630

Simplify public pipeline interface. · e3d028f5

mstarzinger@chromium.org authored Aug 13, 2014

R=sigurds@chromium.org

Review URL: https://codereview.chromium.org/471563002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23106 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e3d028f5

Expose Value::IsArgumentsObject in V8 API. · 3a3d6bd4

aandrey@chromium.org authored Aug 13, 2014

R=yangguo@chromium.org, svenpanne@chromium.org, yangguo

Review URL: https://codereview.chromium.org/460333002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23105 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3a3d6bd4

Temporary workaround for scheduler running OOM. · a240fd62

mstarzinger@chromium.org authored Aug 13, 2014

R=titzer@chromium.org
TEST=benchmarks/octane/zlib

Review URL: https://codereview.chromium.org/468863002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23104 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a240fd62

Allow use of phase-local zone in GenericGraphVisit. · 2dfa9f97

mstarzinger@chromium.org authored Aug 13, 2014

R=titzer@chromium.org, bmeurer@chromium.org

Review URL: https://codereview.chromium.org/467103003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23103 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2dfa9f97

Remove a brittle assertion from Turbofan lazy deoptimization handling. · b80e7684

jarin@chromium.org authored Aug 13, 2014

As discussed in person with Benedikt, it is better to remove the assertion because it is too brittle. The assertion says that the continuation block should immediately follow the call. However, there are exceptions - such as nop or constant pool in-between being fine - that make the assertion brittle.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/471523002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23102 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b80e7684

Move Promise tracking from debug to isolate. · 1b17f59b

yangguo@chromium.org authored Aug 13, 2014

This prepares for tracking promise rejections when debugger is off.

R=aandrey@chromium.org

Review URL: https://codereview.chromium.org/462413003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23101 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1b17f59b

Add FOR_INT32_SHIFTS to value-helper.h · 07ab6791

titzer@chromium.org authored Aug 13, 2014

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/470533002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23100 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

07ab6791

ARM64: unit tests for instruction selection. · b5b4e2c0

rodolph.perfetta@arm.com authored Aug 13, 2014

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/464773004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b5b4e2c0

Disable some deoptimization tests on ARM64 no-snap. · 7f628527

mstarzinger@chromium.org authored Aug 13, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/471483002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23098 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7f628527

Revert "Refactor building of lazy bailouts in AstGraphBuilder." · e0c1ee15

jarin@chromium.org authored Aug 13, 2014

This reverts commit r23096.

TBR=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/470573002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23097 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e0c1ee15

Refactor building of lazy bailouts in AstGraphBuilder. · 89984f72

jarin@chromium.org authored Aug 13, 2014

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/464033002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23096 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

89984f72

12 Aug, 2014 16 commits

Revert "ES6: Make Map/Set constructors support iterable values" · 0a35d53f

arv@chromium.org authored Aug 12, 2014

Reason for revert:
TestSetConstructorIterableValue(WeakSet) fails on x64.debug

TBR=adamk@chromium.org,dslomov@chromium.org
LOG=Y
BUG=

Review URL: https://codereview.chromium.org/461193002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23093 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0a35d53f

ES6: Make Map/Set constructors support iterable values · f95b81a6

arv@chromium.org authored Aug 12, 2014

Same for WeakMap/WeakSet

https://bugs.ecmascript.org/show_bug.cgi?id=3111

BUG=v8:3508
LOG=Y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/466003002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23091 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f95b81a6

WeakMap/WeakSet: Add test for non object keys · 6c209206

arv@chromium.org authored Aug 12, 2014

Add test for non object keys in the iterable passed to the constructor.

BUG=v8:3399
LOG=Y
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/451033003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23090 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6c209206

[Auto-roll] Bump up version to 3.28.72.0 · 5ae2276f

machenbach@chromium.org authored Aug 12, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/466863002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23089 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5ae2276f

Reland "MIPS: Add support for arch. revision 6 to mips32 port." · 8804736b

dusan.milosavljevic@imgtec.com authored Aug 12, 2014

Fixing gclient runhooks failure caused by reverted commit r23050.

TEST=
BUG=
R=jkummerow@chromium.org, paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/467583002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23088 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8804736b

Fix predictable mode to make time pass faster. · 1d2a0759

mstarzinger@chromium.org authored Aug 12, 2014

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/460413002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23087 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1d2a0759

Old space cannot be assumed to be iterable between GCs, even if swept precisely. · 2c6d5cfb

jkummerow@chromium.org authored Aug 12, 2014

This is because allocation folding can cause uninitialized and hence uniterable fragments. Trying to inspect them causes SizeFromMap() crashes.

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/467693002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23084 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2c6d5cfb

Add "own" symbols support. · d2fe3e68

dslomov@chromium.org authored Aug 12, 2014

"Own" symbols are symbols that can only denote own properties of
objects.

R=hpayer@chromium.org, verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23056

Review URL: https://codereview.chromium.org/464473002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23083 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d2fe3e68

Implement Math.log1p using port from fdlibm. · 0f81d769

yangguo@chromium.org authored Aug 12, 2014

Port contributed by Raymond Toy <rtoy@google.com>.

R=rtoy@chromium.org
LOG=N
BUG=v8:3481

Review URL: https://codereview.chromium.org/457643002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23082 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0f81d769

Fix newly discovered presubmit errors. · 44247036

mstarzinger@chromium.org authored Aug 12, 2014

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/462033002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23081 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

44247036

Add print-to-file for turbofan tracing. · 867c0d8e

sigurds@chromium.org authored Aug 12, 2014

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/460723002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23080 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

867c0d8e

Revert 23077 - "Use CommonNodeCache for heap constants in ChangeLowering." · 5f1f8978

jochen@chromium.org authored Aug 12, 2014

Breaks compilation on Mac64

| TEST=compiler-unittests
| R=jarin@chromium.org
|
| Committed: https://code.google.com/p/v8/source/detail?r=23077

TBR=bmeurer@chromium.org,jarin@chromium.org
LOG=n
BUG=none

Review URL: https://codereview.chromium.org/456843004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23079 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5f1f8978

Fix presubmit error with explicit constructor in test. · 0e77a31c

titzer@chromium.org authored Aug 12, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/462813003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23078 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0e77a31c

Use CommonNodeCache for heap constants in ChangeLowering. · dae1e1ea

bmeurer@chromium.org authored Aug 12, 2014

TEST=compiler-unittests
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/466673004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23077 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dae1e1ea

ARM64: Enable TF tests. · d5f0ecfb

rodolph.perfetta@arm.com authored Aug 12, 2014

Updated the test status file accordingly.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/459093002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23076 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d5f0ecfb

Reduce redundant phi nodes after graph building. · b84dc472

mstarzinger@chromium.org authored Aug 12, 2014

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/461003002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23075 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b84dc472