- 08 Oct, 2019 2 commits
-
-
Clemens Backes authored
This brings our constants back in line with the changed spec text. We already use kExprTableGet and kExprTableSet, but for locals and globals we still use the old wording. This renaming is mostly mechanical. PS1 was created using: ag -l 'kExpr(Get|Set)Global' src test | \ xargs -L1 sed -E 's/kExpr(Get|Set)Global\b/kExprGlobal\1/g' -i PS2 contains manual fixes. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I064a6448cd95bc24d31a5931b5b4ef2464ea88b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847355 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#64163}
-
Clemens Backes authored
This brings our constants back in line with the changed spec text. We already use kExprTableGet and kExprTableSet, but for locals and globals we still use the old wording. This renaming is mostly mechanical. PS1 was created using: ag -l 'kExpr(Get|Set|Tee)Local' src test | \ xargs -L1 sed -E 's/kExpr(Get|Set|Tee)Local\b/kExprLocal\1/g' -i PS2 contains manual fixes. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I1617f1b2a100685a3bf56218e76845a9481959c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847354Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64161}
-
- 30 Jan, 2019 1 commit
-
-
Sven Sauleau authored
We noticed that almost every call site were loading both files, the split isn't necessary anymore. In some message tests, removed the absolute line number to allow future changes. Bug: v8:8726 Change-Id: I8527f0a1ecfa685aa01a5e2f5f47ddf1cb13a545 Reviewed-on: https://chromium-review.googlesource.com/c/1446452 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#59220}
-
- 10 Jan, 2019 1 commit
-
-
Andreas Haas authored
The flag has been enabled by default since June 2018, see https://crrev.com/c/1095650. R=binji@chromium.org Bug: v8:7625 Change-Id: I7cb4874db7f632b593f912e084b9fb7b8d568afe Reviewed-on: https://chromium-review.googlesource.com/c/1402546Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#58689}
-
- 11 Sep, 2018 1 commit
-
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I9734259c9f41378ac216d5a222f0f7c71fcb5fa6 Reviewed-on: https://chromium-review.googlesource.com/1219023Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55781}
-
- 12 Jun, 2018 1 commit
-
-
Ben Smith authored
Mutable globals are stored in the instance differently, so they must be exported differently as well. Also fix a counting bug that occurred when a module contained a global and an imported mutable global (CalculateGlobalOffsets is called twice). Bug: v8:7625 Change-Id: I1cd7ef5d6ff7cb7e09239035f89d7b36d0436063 Reviewed-on: https://chromium-review.googlesource.com/1096673 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53681}
-
- 30 May, 2018 1 commit
-
-
Ben Smith authored
This was renamed recently in the spec. Change-Id: I825e47e8b4113ddb2c3356ee8e7663705ba65e1c Reviewed-on: https://chromium-review.googlesource.com/1079851Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#53448}
-
- 27 Apr, 2018 1 commit
-
-
Ben Smith authored
* If the mutability of the global object doesn't match the module, then it should throw a LinkError. * There was a missing `return` when importing a Number as a mutable global. * All globals were being exported as immutable. * Attempting to set the value of an immutable global should throw a TypeError. * The length of the setter function should be 1. Bug: v8:7625 Change-Id: I08d6a428506a18db15eecadf4cbcee89e0658924 Reviewed-on: https://chromium-review.googlesource.com/1031626Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#52865}
-
- 26 Apr, 2018 1 commit
-
-
Ben Smith authored
The new spec has two arguments, the first is the global descriptor, and the second is the initial value: new WebAssembly.Global({type: i32}, 42); If the initial value argument is omitted, the value is set to 0. Bug: v8:7625 Change-Id: I679d4b7c49c69ec7ffcdfeb8ae506fa7ab9bba95 Reviewed-on: https://chromium-review.googlesource.com/1028847Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#52822}
-
- 25 Apr, 2018 2 commits
-
-
Ben Smith authored
The WasmInstanceObject stores two new arrays: - imported_mutable_globals_buffers_: a FixedArray of all the imported globals' array buffers. - imported_mutable_globals: a calloc'd array of Addresses pointing to the mutable global in its array buffer. When accessing the global, the generated code looks up the address in imported_mutable_globals to find where to load/store. Bug: v8:7625 Change-Id: I60844c21a788fce28f346455f10f2283d1c152e9 Reviewed-on: https://chromium-review.googlesource.com/1020602 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52794}
-
Ben Smith authored
The mutable-globals proposal spec allows importing as Numbers or WebAssembly.Global values, but always exports as WebAssembly.Global. Since the value is always boxed, we can also import/export i64 values. This CL also includes support for export of mutable globals. Since the underlying ArrayBuffer that stores the global's value is shared between the module and the WebAssembly.Global object, all that needs to be done is remove the validation check. Bug: v8:7625 Change-Id: I24d763e3bc193d229a7cc33b2f2690a473c6f2bc Reviewed-on: https://chromium-review.googlesource.com/1018406 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52789}
-