1. 30 Jan, 2019 1 commit
  2. 11 Sep, 2018 1 commit
    • Andreas Haas's avatar
      [wasm] Return immediately if code generation is not allowed · cecd2ed5
      Andreas Haas authored
      There was a bug in WebAssembly.instantiate in the case where a CSP
      disallows WebAssembly compilation. In this case the promise returned by
      WebAssembly.instantiate was rejected immediately because of the CSP,
      but then compilation was started anyways, and the promise was resolved
      after compilation for a second time, which caused the crash. With this
      CL we do not start compilation if CSP disallows WebAssembly compilation.
      
      R=clemensh@chromium.org
      
      Bug: chromium:881978
      Change-Id: Iffdb3e02c3006eb7f86211ab197f81cf20438f0e
      Reviewed-on: https://chromium-review.googlesource.com/1219706
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55788}
      cecd2ed5
  3. 09 Nov, 2017 1 commit
    • Karl Schimpf's avatar
      Add capability to handle CSP 'wasm-eval' in V8 · 1719ecb9
      Karl Schimpf authored
      Like CSP flag 'unsafe-eval', which communicates if both JS source
      files and WASM binary files may be compiled, this CL adds a similar
      flag for the compilation of WASM binary files.
      
      That is, a WASM binary file will be compiled only if the new flag is
      defined, or the flag for 'unsafe-eval' allows it. These flags are
      implemented as callback functions on the isolate. The callbacks get a
      (CSP) context, and a string, and returns the corresponding value of
      the flag.
      
      Both callbacks are initialized with the nullptr, and is used to
      communicate that no CSP policy is defined. This allows this concept to
      work, independent of it running in Chrome.
      
      It also does a small clean up in api.cc to use macro CALLER_SETTERS,
      instead of explicit code when appropriate.
      
      Bug: v8:7041
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: Idb3356574ae2a298057e6b7bccbd3492831952ae
      Reviewed-on: https://chromium-review.googlesource.com/759162Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
      Reviewed-by: 's avatarEric Holk <eholk@chromium.org>
      Commit-Queue: Karl Schimpf <kschimpf@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49243}
      1719ecb9
  4. 25 Oct, 2017 1 commit
  5. 16 Oct, 2017 1 commit
  6. 06 Oct, 2017 1 commit