- 06 Mar, 2019 24 commits
-
-
Sergiy Belozorov authored
R=ulan@chromium.org Bug: chromium:936713 Change-Id: If3361023fa6fecfc070028ef505ca1ab1ec1d568 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505800Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60066}
-
Clemens Hammacher authored
Callbacks can be called and deleted from any thread, so they need to be protected by a mutex. The deleted comment in {NotifyOnEvent} is outdated. Use a separate mutex such that callbacks can call back into the NativeModule or CompilationState without deadlocking. R=ahaas@chromium.org Bug: v8:8904, v8:8689 Change-Id: If28a1f5682894518453b216c3ea152e5d6d8afdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505457Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60065}
-
Deepti Gandluri authored
- Introduce a GROW_SHARED_MEMORY interrupt, and handler - Memory objects for isolates are updated on a stack check, add tracking for isolates that hit the stack check - When enough memory is not reserved ahead of time, fail to grow - Add tracking for externalized buffers in the MemoryTracker so that the MemoryTracker will know when backing_stores can be freed. - For shared buffer, do not always allocate a new buffer when growing an externalized buffer Change-Id: I9cf1be19f2f165fa6ea4096869f7d6365304c8c4 Bug: v8:8564 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1472430 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
-
Georg Neis authored
Followup to https://chromium-review.googlesource.com/c/v8/v8/+/1487491. Change-Id: I44deb28ef5c8638236b04849921359cc7285c10f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505576Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60063}
-
Ross McIlroy authored
Causes flakyness in TSAN runs when flag is written by EnforceFlagImplications and read by ConcurrentMarking. BUG=v8:8924 Change-Id: I2b0bf0fbb678e03492d7ed13e48657de9316b700 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505796 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#60062}
-
Georg Neis authored
This CL builds on top of feedback preprocessing. It brokerizes all parts of element access reduction and disallows heap access there (except for debug tracing). To make this work without breaking tests (when concurrent inlining is enabled): - We don't inline functions that weren't serialized for compilation. - We don't optimize for constant typed-array receivers when the typed array wasn't serialized. This means that from now on --concurrent-inlining (and thus --future) may result in less optimization than the default configuration. Bug: v8:7790 Change-Id: I22685258b7d841fc9183bf99775d3f09cd272927 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495556 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
zhiguo authored
When VTune JIT support is enabled, the WasmEngine of an Isolate tries to enable code logging by EnableCodeLogging() method. This multithreaded method requires a Mutex for safety. However, as the WasmEngine is not created, the Mutex of it is not initialized. An attempt of acquiring this Mutex results in an error. The bug is fixed by creating WasmEngine before it enables code logging. Change-Id: I59e749190288ec412f6661233e8f62b0dff3cd7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1337376Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60060}
-
Igor Sheludko authored
... when the latter is not already available. Bug: v8:8834 Change-Id: Ib45b0e04c35a797e2d36a96b891ff1f82d4de02c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505574Reviewed-by:
-
andrew-cc-chen authored
Change-Id: I8e353e6ae46b16abfe2812af88b6718250854e29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503562Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60058}
-
Jakob Gruber authored
This piggy-backs off similar support for lite mode, which silently skips tests that require optimization in lite (and now jitless) modes. Bug: v8:7777,v8:8778, v8:8885 Change-Id: I666d92685ca71682224028743f02d0cce3723135 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503758 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#60057}
-
Igor Sheludko authored
... when pointer compression is enabled and some number of cleanups. Bug: v8:7703 Change-Id: If7344abf68a1c4d54e4a79d066dc185f25055d7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1477737 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#60056}
-
Yang Guo authored
R=ulan@chromium.org Change-Id: Ib2caeeeb9877f853848b4014a8088ee447d1705a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503765Reviewed-by:
-
Predrag Rudic authored
Yu Yin is working for company that is willing to maintain MIPS ports therefore I am transferring ownership to Yu Yin. No-Presubmit: true TBR=mstarzinger@chromium.org NOTRY=true Change-Id: Ibb534165a1a67ad65a58ea85f5885a70b59302be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505454Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Predrag Rudic <prudic@wavecomp.com> Commit-Queue: Predrag Rudic <prudic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#60054}
-
Maya Lekova authored
This reverts commit 43b92772. Reason for revert: Breaks Mac build, see https://ci.chromium.org/p/v8/builders/ci/V8%20Mac64%20ASAN/22200 Particular cause: https://chromium.googlesource.com/chromium/src/build/+/7b62c8979c4963f8f0fa8ec33391793bd9d73f28 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80892bf..983d3df > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf661ac..7e68767 > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > Change-Id: I6f335b8628338d94558309b5bc06725f9d20ea8b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1504781 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#60050} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I6ca9cf4d0f7051979f59c4a72f2a46ad67331b21 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505812Reviewed-by:
-
Mathias Bynens authored
Unicode v12 was released today: https://unicode.org/versions/Unicode12.0.0/ This patch updates the following sequence property escapes per Unicode 12: - Emoji_Flag_Sequence (no changes) - Emoji_Keycap_Sequence (no changes) - Emoji_Tag_Sequence (no changes) - Emoji_ZWJ_Sequence Note that Emoji_Modifier_Sequence is still using Unicode 11 data. This will be fixed automatically once a version of ICU with Unicode 12 support rolls into V8, at which point I'll update the relevant tests. Bug: v8:7467 Change-Id: Iba575a471382ba7b029da06c2868c368ff43c649 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503764Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#60052}
-
Simon Zünd authored
Bug: chromium:938251 Change-Id: I336765c894cc78ca822904a32356db43feadea07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505312Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80892bf..983d3df Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf661ac..7e68767 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I6f335b8628338d94558309b5bc06725f9d20ea8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1504781Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60050}
-
Yu Yin authored
Port https://crrev.com/c/1469821 Original Commit Message: Refactor the CallApiCallback builtin to - pass the context as with other stubs, and - pass holder and call data in registers. This avoids having to place holder and call data onto the stack, and thus makes it possible to easily call the CallApiCallback builtin from other builtins while just forwarding the (stack) arguments. The idea is to use this in the future to optimize the general case of calling into any API method via a FunctionTemplateInfo and doing appropriate security and/or interface checks upfront as necessary (eventually making the HandleApiCall C++ builtin obsolete at some point). Change-Id: Ice52b68678fbea69e765c22daa3134524860e5de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505234Reviewed-by:
-
Michael Lippautz authored
Blink CL: http://crrev.com/c/1504573 Bug: chromium:936797 Change-Id: I24092f53f40dbd663ffb58122ec0239b7c185904 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505372Reviewed-by:
-
Simon Zünd authored
This CL refactors the torque-compiler module slightly to allow compilation of string inputs in addition to file path inputs. The added functionality is then used to implement the first 'goto type defintion' unit test. R=tebbi@chromium.org Bug: v8:8880 Change-Id: I178a387abda6e319e66d41c50431cb139ac6e9f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503263 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#60047}
-
Yang Guo authored
This becomes necessary due to [1]. We cannot roll DEPS otherwise [2]. WebRTC is doing this too [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1500198 [2] https://chromium-review.googlesource.com/c/v8/v8/+/1505272 [3] https://webrtc-review.googlesource.com/c/src/+/125840 TBR=machenbach@chromium.org Change-Id: I07ecc878f6c64767be025c9999dbb49423031e90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505292Reviewed-by:
-
tzik authored
This adds overloads of v8::Isolate::{Add,Remove}MicrotaskCompletedCallback, that use MicrotasksCompletedCallbackWithData, and marks the original one as V8_DEPRECATE_SOON for transition. Bug: v8:8124 Change-Id: I124c3108545e1a2b29cd95620f36901431663c65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1493766Reviewed-by: -
Yang Guo authored
This reverts commit 83fa1717. Reason for revert: Mac ASan failure. This also happens for WebRTC and is due to this change: https://chromium-review.googlesource.com/c/chromium/src/+/1500198 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80892bf..0416321 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf661ac..7e68767 > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > Change-Id: I029046d9e7fbceaed48d94e9e20c2eba61b08cac > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1504778 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#60043} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: If8c60c8d83f70a0fc966d7bda00999bc5630431e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505272Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80892bf..0416321 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf661ac..7e68767 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I029046d9e7fbceaed48d94e9e20c2eba61b08cac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1504778Reviewed-by:
-
- 05 Mar, 2019 16 commits
-
-
Frank Tang authored
This is in preparation for the removal of Unibrow. Bug: v8:8362 Change-Id: Icb969457e71d64d765eaf0fd1d0b8b9c6b6eb388 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1490572 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#60042}
-
Z Duong Nguyen-Huu authored
JSDate, JSStringIterator, JSAsyncFromSyncIterator, JSDataPropertyDescriptor Change-Id: Ia2cfd8fa61672fb4d6ec5082bae07e7add97fe60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1500674Reviewed-by:
-
Ben Smith authored
The bulk memory operations should not bounds check ahead of time, but instead should write as many bytes as possible until the first out-of-bounds access. Bug: v8:8890 Change-Id: Ia8179fe268fc65816c34a8f3461ed0a0d35600aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497520 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
-
Vadim Gorbachev (bmsdave) authored
we can't use {**dict1, **dict2} in python2 code. see report https://travis-ci.com/bmsdave/v8/jobs/180113432 Bug: v8:935200 Change-Id: I2f2a1283583432d6d0167436dd7d4205455049cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1484303 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60039}
-
Tamer Tas authored
R=clemensh@chromium.org CC=machenbach@chromium.org,sergiyb@chromium.org Bug: v8:8728 Change-Id: I37d10867a805647c98660699233c5c2b23429eae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503377Reviewed-by:
-
Hannes Payer authored
Bug: v8:8945 Change-Id: Ib26d97bb6b5b1a6d523079bd3277ca28488eec9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503264 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Sven Sauleau authored
Align the Table implementation limits with the JavaScript Embedding limits defined in the specification (from MAX_UINT32 to 1e7). Introduce a new helper (max_table_init_entries) that returns the maximum number of Table entry at initialization. It takes into account the maximum Table size, which can be passed by a flag. Bug: v8:8633 Change-Id: Idfa19418e81f478f7886a30876e66c9b216e25ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1496971 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
-
peterwmwong authored
Also ports GrowableFixedArray to Torque. The CSA version is preserved for now, as the Torque structs are not consumable by CSA builtins yet (Struct methods are inlined). TypedArrayPrototypeFilter builtin size decreased by 24% (Mac x64.release): TFJ Builtin, TypedArrayPrototypeFilter, 5689 -> 4298 TypedArrays/Filter micro benchmarks have improved 10-15% (Mac x64.release): TypedArrays-Uint8Array(Score): 746 -> 857 TypedArrays-Uint16Array(Score): 758 -> 862 TypedArrays-Uint32Array(Score): 746 -> 855 TypedArrays-Float32Array(Score): 749 -> 817 TypedArrays-Float64Array(Score): 751 -> 839 TypedArrays-BigUint64Array(Score): 562 -> 625 Bug: v8:8906 Change-Id: I1172b7407de95b067448e680ec327e726e9194cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1501469 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60035}
-
Clemens Hammacher authored
This reduces the number of {BackgroundCompileScope}s per compilation unit from 2 to 1. This reduces the number of concurrent accesses to the {SharedMutex}. R=ahaas@chromium.org Bug: v8:8916 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Change-Id: I872683101dfc9361aa7054ea67f16e3f3f2b82b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495989 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Mike Stanton authored
In the recent port of reduce() and reduceRight(), a check for a length change during the loop (standard for iterating builtins) was omitted. We did get array bounds check protection, however it didn't expose the issue in our tests because the bounds check is against the backing store length, not against the length in the referring JSArray. Also added a test for reduceRight(). R=jgruber@chromium.org Bug: chromium:937676 Change-Id: I76e22e0d71965bff84a0822b1df5dc818a00b50e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503732Reviewed-by:
-
Junliang Yan authored
Port 9c7b6e1e Original Commit Message: This is the implementation of crrev.com/c/766371 for arm. Original description: Add the ability to return (multiple) return values on the stack: - Extend stack frames with a new buffer region for return slots. This region is located at the end of a caller's frame such that its slots can be indexed as caller frame slots in a callee (located beyond its parameters) and assigned return values. - Adjust stack frame constructon and deconstruction accordingly. - Extend linkage computation to support register plus stack returns. - Reserve return slots in caller frame when respective calls occur. - Introduce and generate architecture instructions ('peek') for reading back results from return slots in the caller. - Aggressive tests. - Some minor clean-up. R=ahaas@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, miladfar@ca.ibm.com BUG= LOG=N Change-Id: I83df1af8c49f6d6c5b529db599fce61a1da2490d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1496549Reviewed-by:
-
Ben L. Titzer authored
When a function is exported from a WebAssembly module, it is implicitly wrapped in a WasmExportedFunction. For functions that were imports into this module, the exported function appears like other Wasm function, e.g. can be used in tables. When that exported function was re-imported to another module, the logic to compute the import kind mistakenly assumed the exported function was indeed originally a Wasm function and tried to call it directly, instead of treating it like an imported JS function. R=ahaas@chromium.org BUG=v8:8947 Change-Id: Ib8fac81fbe0f49c50cfbfb2e69d9bb60aef91fcc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503632 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: v8:8945 Change-Id: I2ee060c03496bbcb388d82fd05ecc61658047f98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503633Reviewed-by:
-
Hannes Payer authored
Bug: v8:8945 Change-Id: I4e5f08a722e83fd8b4accb066eca50242a116a6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503452Reviewed-by:
-
Ulan Degenbaev authored
This allows us to change the page size without affecting Scavenger heuristics and performance. Bug: chromium:852420 Change-Id: Idcff4296e88e16f9af0ee6ecd00c63d789866fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499494 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60028}
-
Tobias Tebbi authored
Bug: chromium:937649 Change-Id: I13c64a7cab7a6f1668c546114610006d0d6b91ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1501052Reviewed-by:
-
