- 17 Sep, 2015 22 commits
-
-
jkummerow authored
Now run-tests.py understands "suite/foo/bar" with forward slashes for command-line test selection on all test suites on all platforms. Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; that behavior is sacrificed here in favor of unification. For the cctest suite, OTOH, it wasn't possible on Windows to select specific tests at all. Original review: https://codereview.chromium.org/1348653003/ This reverts commit 5f44a910. NOTRY=true Review URL: https://codereview.chromium.org/1356613002 Cr-Commit-Position: refs/heads/master@{#30798}
-
cbruni authored
The core bottleneck lies in N-square cost of array union. Depending on the size of the arrays involved it makes sense to rely on a hash-set/table for the lookup. LOG=N BUG=v8:2904 Review URL: https://codereview.chromium.org/1316213008 Cr-Commit-Position: refs/heads/master@{#30797}
-
mlippautz authored
This reverts commit 7a0a0b8b. - The number of parallel tasks is still 1, i.e., we only compact on the main thread. - Remove emergency memory (PagedSpace, and CodeRange) - Introduce partial compaction of pages. - Logic for multiple tasks is in place. BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1356533002 Cr-Commit-Position: refs/heads/master@{#30796}
-
jkummerow authored
Revert of [test] Fix cctest path separators on Windows (patchset #2 id:20001 of https://codereview.chromium.org/1348653003/ ) Reason for revert: mozilla tests are failing on Windows Original issue's description: > [test] Fix cctest path separators on Windows > > Now run-tests.py understands "suite/foo/bar" with forward slashes for > command-line test selection on all test suites on all platforms. > > Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; > that behavior is sacrificed here in favor of unification. For the cctest > suite, OTOH, it wasn't possible on Windows to select specific tests at all. > > Committed: https://crrev.com/b36cfdb39ae648b49a1396c4f669df9b1f57996c > Cr-Commit-Position: refs/heads/master@{#30794} TBR=machenbach@google.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1349163002 Cr-Commit-Position: refs/heads/master@{#30795}
-
jkummerow authored
Now run-tests.py understands "suite/foo/bar" with forward slashes for command-line test selection on all test suites on all platforms. Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; that behavior is sacrificed here in favor of unification. For the cctest suite, OTOH, it wasn't possible on Windows to select specific tests at all. Review URL: https://codereview.chromium.org/1348653003 Cr-Commit-Position: refs/heads/master@{#30794}
-
machenbach authored
Revert of [runtime] Initial step towards switching Execution::Call to callable. (patchset #1 id:1 of https://codereview.chromium.org/1353723002/ ) Reason for revert: [Sheriff] Causes a dcheck failure in layout tests (and some test changes in release): https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64__dbg_/1442/layout-test-results/virtual/android/fullscreen/api/element-request-fullscreen-top-stderr.txt from http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/1442 Original issue's description: > [runtime] Initial step towards switching Execution::Call to callable. > > Currently Execution::Call (and friends) still duplicate a lot of the > Call sequence logic that should be encapsulated in the Call and > CallFunction builtins. So the plan now is to switch Execution::Call > to accept any Callable and just pass that through to the Call builtin. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg > R=jarin@chromium.org > BUG=v8:4413 > LOG=n > > Committed: https://crrev.com/359645f48156e15f235e9a9ede7910e0bcd9ae45 > Cr-Commit-Position: refs/heads/master@{#30791} TBR=jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4413 Review URL: https://codereview.chromium.org/1346763005 Cr-Commit-Position: refs/heads/master@{#30793}
-
conradw authored
BUG=v8:4392 LOG=Y Review URL: https://codereview.chromium.org/1354523003 Cr-Commit-Position: refs/heads/master@{#30792}
-
bmeurer authored
Currently Execution::Call (and friends) still duplicate a lot of the Call sequence logic that should be encapsulated in the Call and CallFunction builtins. So the plan now is to switch Execution::Call to accept any Callable and just pass that through to the Call builtin. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg R=jarin@chromium.org BUG=v8:4413 LOG=n Review URL: https://codereview.chromium.org/1353723002 Cr-Commit-Position: refs/heads/master@{#30791}
-
neis authored
R=jarin BUG= Review URL: https://codereview.chromium.org/1343933002 Cr-Commit-Position: refs/heads/master@{#30790}
-
hpayer authored
BUG=chromium:532784 LOG=n Review URL: https://codereview.chromium.org/1347363002 Cr-Commit-Position: refs/heads/master@{#30789}
-
mlippautz authored
Revert of [heap] Introduce parallel compaction algorithm. (patchset #9 id:160001 of https://codereview.chromium.org/1343333002/ ) Reason for revert: Check failed: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Win64/builds/5535/steps/Check%20%28flakes%29/logs/IndependentWeakHandle Original issue's description: > [heap] Introduce parallel compaction algorithm. > > - The number of parallel tasks is still 1, i.e., we only compact on the main > thread. > - Remove emergency memory (PagedSpace, and CodeRange) > - Introduce partial compaction of pages. > - Logic for multiple tasks is in place. > > BUG=chromium:524425 > LOG=N > > Committed: https://crrev.com/61ea4f55616d3f7bc2ce049a678f16f7475e03e0 > Cr-Commit-Position: refs/heads/master@{#30787} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Review URL: https://codereview.chromium.org/1347873003 Cr-Commit-Position: refs/heads/master@{#30788}
-
mlippautz authored
- The number of parallel tasks is still 1, i.e., we only compact on the main thread. - Remove emergency memory (PagedSpace, and CodeRange) - Introduce partial compaction of pages. - Logic for multiple tasks is in place. BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1343333002 Cr-Commit-Position: refs/heads/master@{#30787}
-
bmeurer authored
Revert "[profiler] Make no frame region detection code more robust", "Fix ASAN after r30777" and "Fix MSAN warning after r30777 (try 2)" This reverts commits 12c7bc9a, cb0b3592, and a6e00c6a, because they introduced weird flaky crashes in random places now at least in the arm simulator, where it see that quite often now on different change sets, i.e. see http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/8138/steps/Check%20%28flakes%29/logs/LoadICFastApi_DirectC.. and https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20mipsel%20-%20sim/builds/2566/steps/Check%20%28flakes%29/logs/LoadICFastApi_DirectC.. for example. TBR=alph@chromium.org BUG=chromium:529931 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true LOG=N Review URL: https://codereview.chromium.org/1354573002 Cr-Commit-Position: refs/heads/master@{#30786}
-
alph authored
TBR=bmeurer,yurys NOTRY=true Review URL: https://codereview.chromium.org/1348493003 Cr-Commit-Position: refs/heads/master@{#30785}
-
mtrofin authored
Small spelling fix. Review URL: https://codereview.chromium.org/1352673002 Cr-Commit-Position: refs/heads/master@{#30784}
-
mtrofin authored
Avoiding unnecessarily traversing conflicts when doing weight comparisons. This reduced compile time regressions from a few multiples to under 10% - at least for zlib. Review URL: https://codereview.chromium.org/1346263004 Cr-Commit-Position: refs/heads/master@{#30783}
-
v8-autoroll authored
Rolling v8/tools/clang to eea56c7ed84778edadbcd43f06793b0311a56b28 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1350993003 Cr-Commit-Position: refs/heads/master@{#30782}
-
chunyang.dai authored
port 1e00bb57 (r30737). original commit message: (reason for revert/reland: patch incorrectly left --vector-stores flag on, helpfully revealing some gcstress issues to look at, but they don't need to block this CL). Some pretty hacky code was used to carry out the tail-call handler dispatch on ia32 vector stores due to a lack of free registers. It really tanks performance. A better approach is to use a virtual register on the isolate. BUG= Review URL: https://codereview.chromium.org/1344383002 Cr-Commit-Position: refs/heads/master@{#30781}
-
chunyang.dai authored
port 54bab695 (r30747). original commit message: Move the implementation of the Abstract Equality Comparison to the runtime and thereby remove the EQUALS dispatcher builtin. Also remove the various runtime entry points that were only used to support the EQUALS builtin. Now the Abstract Equality Comparison is also using the correct ToPrimitive implementation, which properly supports @@toPrimitive. BUG= Review URL: https://codereview.chromium.org/1349623002 Cr-Commit-Position: refs/heads/master@{#30780}
-
alph authored
TBR=bmeurer,yurys NOTRY=true Review URL: https://codereview.chromium.org/1349953002 Cr-Commit-Position: refs/heads/master@{#30779}
-
ofrobots authored
Add an assertion that allocated_bytes >= 0 in IncrementalMark::Step and then make it pass. We were not being diligent in maintaining top_on_previous_step_ and as a result inaccurate, and even negative values of allocated_bytes were being reported to Step. BUG= R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1274453002 Cr-Commit-Position: refs/heads/master@{#30778}
-
alph authored
Upon collection of the stack trace if the current PC falls into the frame building code, the top frame might be in a non-consistent state. That leads to some of the frames could be missing from the stack trace. The patch makes it check instructions under current PC and if they look like the frame setup/destroy code, it skips the entire sample. Support for x86/x64 BUG=chromium:529931 LOG=N Review URL: https://codereview.chromium.org/1341413002 Cr-Commit-Position: refs/heads/master@{#30777}
-
- 16 Sep, 2015 18 commits
-
-
mtrofin authored
This is a performance bug, not a functional bug: we were losing grouping opportunities. BUG= Review URL: https://codereview.chromium.org/1342243003 Cr-Commit-Position: refs/heads/master@{#30776}
-
caitpotter88 authored
Some cleanup of ParsePropertyDefinition --- Replaces certain hacks with more structured, clean code, and adds additional comments to aid in comprehension of this tricky area of the ambiguous recursive descent parser. BUG=v8:3583 LOG=N R=adamk, aperez, wingo, rossberg Review URL: https://codereview.chromium.org/1348773004 Cr-Commit-Position: refs/heads/master@{#30775}
-
adamk authored
We already disallowed observing the global proxy; now we also disallow any observation of access-checked objects (regardless of whether the access check would succeed or fail, since there's not a good way to tell the embedder what kind of access is being requested). Also disallow Object.getNotifier for the same reasons. BUG=chromium:531891 LOG=y Review URL: https://codereview.chromium.org/1346813002 Cr-Commit-Position: refs/heads/master@{#30774}
-
domenic authored
This adds a utils object meant specifically for V8 extras, presenting a limited API surface for doing things that would otherwise require %-functions. BUG=v8:4276 LOG=Y R=jochen@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1343113003 Cr-Commit-Position: refs/heads/master@{#30773}
-
aperez authored
Defines a new --harmony-tolength flag, and a ToLengthFlagged() runtime function, that is used where ES6 requires ToLength(), but a pre-ES6 conversion existed before. When the flag is disabled, the function uses TO_UINT32(), which is the pre-ES6 behaviour. When the flag enabled, the ES6-compliant ToLength() conversion is used. Based on a patch initially from Diego Pino <dpino@igalia.com> BUG=v8:3087 LOG=Y Review URL: https://codereview.chromium.org/1309243003 Cr-Commit-Position: refs/heads/master@{#30772}
-
fedor authored
ArrayBuffer's backing store is a pointer to external heap, and can't be treated as a heap object. Doing so will result in crashes, when the backing store is unaligned. See: https://github.com/nodejs/node/issues/2791 BUG=chromium:530531 R=mlippautz@chromium.org LOG=N Review URL: https://codereview.chromium.org/1327403002 Cr-Commit-Position: refs/heads/master@{#30771}
-
karl authored
```` var array = new Uint8Array(65000); var startDate = Date.now(); var counter = 0; while (counter++ < 50000000) { array.subarray(start, end); } var endDate = Date.now(); print(endDate - startDate); ```` 4200 ms -> 3500 ms (16.67%) BUG= Review URL: https://codereview.chromium.org/1331993004 Cr-Commit-Position: refs/heads/master@{#30770}
-
caitpotter88 authored
Add support for `get` and `set` as shorthand properties. Also supports them for CoverInitializedName in BindingPatterns and (once implemented) AssignmentPatterns. BUG=v8:4412, v8:3584 LOG=N R=adamk, aperez, wingo, rossberg Review URL: https://codereview.chromium.org/1328083002 Cr-Commit-Position: refs/heads/master@{#30769}
-
mvstanton authored
This will catch an invalid receiver before being passed to a load ic miss handler in the runtime. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1351493002 Cr-Commit-Position: refs/heads/master@{#30768}
-
mvstanton authored
There isn't a plan to turn it on soon, so we'll take it out in favor of cleaner code. BUG= Review URL: https://codereview.chromium.org/1202173002 Cr-Commit-Position: refs/heads/master@{#30767}
-
mstarzinger authored
This makes sure that the arguments object materialization in the method prologue is composable with respect to inlining. The generic runtime functions materializing those objects now respect the deoptimization information when reconstructing the original arguments. R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1340313003 Cr-Commit-Position: refs/heads/master@{#30766}
-
ivica.bogosavljevic authored
Fixing floating point register clobbering for MIPSr6 (32 and 64) due to using of f31 floating point register as double compare register, without saving the value of the register before using it. TEST=cctest/test-debug/* BUG= Review URL: https://codereview.chromium.org/1346623002 Cr-Commit-Position: refs/heads/master@{#30765}
-
jarin authored
Review URL: https://codereview.chromium.org/1348073002 Cr-Commit-Position: refs/heads/master@{#30764}
-
vogelheim authored
BUG=v8:4422 R=jochen@chromium.org LOG=Y Review URL: https://codereview.chromium.org/1346613002 Cr-Commit-Position: refs/heads/master@{#30763}
-
bmeurer authored
No need to rely on the %_IsConstructCall magic here, we can just implement the Symbol constructor in C++ altogether (it was just a stupid wrapper around %CreateSymbol anyway). R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1349643002 Cr-Commit-Position: refs/heads/master@{#30762}
-
mstarzinger authored
This adds debug code that makes sure that the runtime functions that materialize arguments objects, {Runtime_New[Sloppy|Strict]Arguments}, are not being called from within an inlined scope. They would produce wrong results and we should avoid producing code that does this. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1343763002 Cr-Commit-Position: refs/heads/master@{#30761}
-
mlippautz authored
Adds concurrency support for: - MemoryChunk: Fragmentation counters - MemoryChunk: High-water mark - MemoryAllocator: Lowest and highest ever allocated addresses, size, and capacity R=hpayer@chromium.org BUG=chromium:524425 LOG=N This reverts commit 0db34dbe. BUG= Review URL: https://codereview.chromium.org/1346973002 Cr-Commit-Position: refs/heads/master@{#30760}
-
bmeurer authored
Implement the String constructor completely as native builtin, avoiding the need to do gymnastics in JavaScript builtin to properly detect the no argument case (which is different from the undefined argument case) and also allowing to just tailcall through to ToString or SymbolDescriptiveString for the common case. Also the JavaScript builtin was misleading since the case for construct call was unused, but could be triggered in a wrong way once we support tail calls from constructor functions. This refactoring allows us to properly implement subclassing for String builtins, once we have the correct initial_map on derived classes (it's merely a matter of using NewTarget instead of the target register now). This introduces a new %SymbolDescriptiveString runtime entry, which is also used by Symbol.toString() now. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1344893002 Cr-Commit-Position: refs/heads/master@{#30759}
-