Commits · 94b4240f5cd1d2f0e78818d7f47b2f6aa3f0f198 · Linshizhi / V8

24 May, 2013 10 commits

Introduce ObjectAccess, which is used by LoadNamedField and StoreNamedField to... · 94b4240f

titzer@chromium.org authored May 24, 2013

Introduce ObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts of an object are referred to by a given load or store. Refactor HGraphBuilder to use ObjectAccess, which removes the need to manually set GVN flags and simplifies the code as well.

Review URL: https://codereview.chromium.org/14284010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14791 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

94b4240f

Add belated test for the SeqStringSetChar bug. · 1d393554

yangguo@chromium.org authored May 24, 2013

R=titzer@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/15849003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14790 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1d393554

callback handler map not correctly populated by direct use of SetCallHandler · 91efd1e7

dcarney@chromium.org authored May 24, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/15814005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

91efd1e7

MIPS: Fix assert on ARM · 22a336c1

palfia@homejinni.com authored May 24, 2013

Port r14781 (a3491cb7)

BUG=

Review URL: https://codereview.chromium.org/15952002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14788 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

22a336c1

MIPS: Require smi for keyed store to smi. · 8b8232e2

palfia@homejinni.com authored May 24, 2013

Port r14779 (33d24080)

BUG=

Review URL: https://codereview.chromium.org/15889007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14787 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8b8232e2

MIPS: Tag length of FixedArrayBase and smi-array[x] as smi representation · 4b0f9cd4

palfia@homejinni.com authored May 24, 2013

Port r14778 (c7fdf61b)

BUG=

Review URL: https://codereview.chromium.org/15927005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14786 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4b0f9cd4

MIPS: Improve SeqStringSetChar implementation. · 31080249

palfia@homejinni.com authored May 24, 2013

Port r14769 (f0000b20)

BUG=

Review URL: https://codereview.chromium.org/15949002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14785 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

31080249

MIPS: Always require exact maps. · 6aef61b5

palfia@homejinni.com authored May 24, 2013

Port r14768 (5dec309f)

BUG=

Review URL: https://codereview.chromium.org/15948003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14784 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6aef61b5

MIPS: Omit smi-check for write-barrier unless tagged. · 344d9057

palfia@homejinni.com authored May 24, 2013

Port r14767 (40dd85ec)

BUG=

Review URL: https://codereview.chromium.org/15745021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14783 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

344d9057

MIPS: Implement HChange support for Smis and use it in Load/StoreNameField · ae74636c

palfia@homejinni.com authored May 24, 2013

Port r14765 (22625125)

BUG=

Review URL: https://codereview.chromium.org/15781006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14782 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ae74636c

23 May, 2013 18 commits

Fix assert on ARM · b2e8d4c5

verwaest@chromium.org authored May 23, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15886004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14781 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b2e8d4c5

Simplifying GC heuristics, deleted old generation allocation limit. · 0d5dd777

hpayer@chromium.org authored May 23, 2013

BUG=

Review URL: https://codereview.chromium.org/14700006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14780 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0d5dd777

Require smi for keyed store to smi. · d057410e

verwaest@chromium.org authored May 23, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15884002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14779 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d057410e

Tag length of FixedArrayBase and smi-array[x] as smi representation · 632f5918

verwaest@chromium.org authored May 23, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15858006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14778 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

632f5918

Fix embedded new-space pointer in LCmpObjectEqAndBranch. · 8fb20868

mstarzinger@chromium.org authored May 23, 2013

R=mvstanton@chromium.org
BUG=chromium:240032
TEST=mjsunit/regress/regress-crbug-240032

Review URL: https://codereview.chromium.org/15779004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14777 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8fb20868

Add asserts to String::GetFlatContent. · 6a806b99

yangguo@chromium.org authored May 23, 2013

R=verwaest@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/13841012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14776 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6a806b99

Missing type cell on ia32 from bindings. · 1a4482ab

mvstanton@chromium.org authored May 23, 2013

Javascript constructors called from C++ code didn't have a type cell
properly filled in on ia32. This showed up as a bug in webkit bindings.
Re-enabled flag optimize-constructed-arrays.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/15870002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14775 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1a4482ab

Don't use fast literal if the boilerplate map is still deprecated. · af451684

verwaest@chromium.org authored May 23, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15660005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14774 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af451684

Fix Windows build after r14770 · 28729d24

dslomov@chromium.org authored May 23, 2013

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/15848003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14771 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28729d24

Externalization API for ArrayBuffer · fc73052d

dslomov@chromium.org authored May 23, 2013

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/15001041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14770 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fc73052d

Improve SeqStringSetChar implementation. · a1e18bdf

yangguo@chromium.org authored May 23, 2013

R=jkummerow@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/15743006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14769 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a1e18bdf

Always require exact maps. · 06b7bf60

verwaest@chromium.org authored May 23, 2013

R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13923003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14768 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

06b7bf60

Omit smi-check for write-barrier unless tagged. · d41f9290

verwaest@chromium.org authored May 23, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15848002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14767 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d41f9290

Avoid creating duplicate entries for a value when merging HSimulates · f691f48c

jkummerow@chromium.org authored May 23, 2013

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/15660003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14766 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f691f48c

Implement HChange support for Smis and use it in Load/StoreNameField · 308e6975

verwaest@chromium.org authored May 23, 2013

BUG=
R=verwaest@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15303004

Patch from Daniel Clifford <danno@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14765 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

308e6975

de-isolate Persistent::Dispose · 36694884

dcarney@chromium.org authored May 23, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/15648008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14764 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

36694884

Move global pretenuring flag check to ShouldGloballyPretenure(). · 2cbc81a5

hpayer@chromium.org authored May 23, 2013

BUG=

Review URL: https://codereview.chromium.org/15734007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14763 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2cbc81a5

Make Object.freeze fast · 36e91242

verwaest@chromium.org authored May 23, 2013

This patch both speeds up the freeze operation itself, but also
allows properties to remain in fast mode. Objects with non-empty
elements backing stores still end up with slow elements.

Relanding r14758 and r14759 with fix for Test262: only mark properties
and elements READ_ONLY if they are not JS setter/getters. Tightened up
tests to assert frozen-ness, and added targeted tests for the new code
(covering accessors).

BUG=v8:1858, 115960
R=verwaest@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15691007

Patch from Adam Klein <adamk@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14762 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

36e91242

22 May, 2013 12 commits

MIPS: Handle holes in smi-untag from LoadKeyed requiring hole handling. · 71ab26d2

palfia@homejinni.com authored May 22, 2013

Port r14756 (fda1989f)

BUG=

Review URL: https://codereview.chromium.org/15690003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14761 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

71ab26d2

Revert "Make Object.freeze fast" · 4d48bb83

adamk@chromium.org authored May 22, 2013

and "Fix Object.freeze on dictionary-backed arrays to properly freeze elements"

This reverts r14758 and r14759 due to introducing failures in Test262

TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/15681004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4d48bb83

Fix Object.freeze on dictionary-backed arrays to properly freeze elements · 3ebccb7a

adamk@chromium.org authored May 22, 2013

Follow-up to r14758: slightly rearranges JSObject::Freeze() to avoid duplicating
code while still retaining proper dictionary elements storage behavior.

Also fix a lint error.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/15737018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14759 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3ebccb7a

Make Object.freeze fast · 648e99e3

adamk@chromium.org authored May 22, 2013

This patch both speeds up the freeze operation itself, but also
allows properties to remain in fast mode. Objects with non-empty
elements backing stores still end up with slow elements.

BUG=v8:1858, 115960
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/14888005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14758 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

648e99e3

Fix bogus deopt in BuildEmitDeepCopy for holey arrays. · b704cb91

mstarzinger@chromium.org authored May 22, 2013

R=verwaest@chromium.org
BUG=chromium:242924
TEST=mjsunit/regress/regress-crbug-242924

Review URL: https://codereview.chromium.org/15735012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14757 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b704cb91

Handle holes in smi-untag from LoadKeyed requiring hole handling. · d1b5a251

verwaest@chromium.org authored May 22, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15737003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14756 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d1b5a251

Don't allow copying holes to fields. · b353b1d1

verwaest@chromium.org authored May 22, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15745006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14753 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b353b1d1

Fix corner case in optimized code map zapping. · d259e1ce

mstarzinger@chromium.org authored May 22, 2013

R=jkummerow@chromium.org
TEST=mjsunit/math-floor-part2

Review URL: https://codereview.chromium.org/15743005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14752 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d259e1ce

Fix Windows shared library build. · aadfc39a

ulan@chromium.org authored May 22, 2013

We cannot dll-export templates.

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15697006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14751 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

aadfc39a

Prepare push to trunk. Now working on version 3.19.4. · 3512dd3b

ulan@chromium.org authored May 22, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15746005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14748 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3512dd3b

Fix VisitLogicalExpression for empty blocks on RHS. · bf413b51

mstarzinger@chromium.org authored May 22, 2013

R=jkummerow@chromium.org
BUG=chromium:242870
TEST=mjsunit/regress/regress-crbug-242870

Review URL: https://codereview.chromium.org/15744002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14747 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bf413b51

Fix unexpected elements transition in JSON.parse · 9960b246

yangguo@chromium.org authored May 22, 2013

R=verwaest@chromium.org
BUG=241344

Review URL: https://chromiumcodereview.appspot.com/15739003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14746 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9960b246