- 25 Feb, 2014 6 commits
-
-
marja@chromium.org authored
The original code, added by https://codereview.chromium.org/3384003/diff/7001/src/parser.cc 3.5 years ago, failed to write numbers which contain a chunk of 7 zeroes in the middle. The smallest such number is 2^14, so this is a problem if the source file to preparse contains 16384 or more symbols (which happens in the wild). This bug went unnoticed because the symbol data was not used by Parser (see https://codereview.chromium.org/172753002/ for starting to use it again) and there were no tests. R=ulan@chromium.org BUG=346221 LOG=y Review URL: https://codereview.chromium.org/179433004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19538 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ulan@chromium.org authored
It caused performance regression in dromaeo/jslib. BUG=346149 LOG=Y R=verwaest@chromium.org Review URL: https://codereview.chromium.org/179613002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19537 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
BUG=346343 LOG=y R=verwaest@chromium.org Review URL: https://codereview.chromium.org/179553002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19536 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ishell@chromium.org authored
BUG=345715 LOG=N R=verwaest@chromium.org Review URL: https://codereview.chromium.org/178833002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19535 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
BUG=346061 R=dcarney@chromium.org LOG=y Review URL: https://codereview.chromium.org/177943002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=rossberg@chromium.org LOG=N BUG=344285 Review URL: https://codereview.chromium.org/169393002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19533 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Feb, 2014 2 commits
-
-
marja@chromium.org authored
Preparsing is always maximally lazy (every function that can be lazy is preparsed lazily), but Parser has more complicated laziness logic. If we're going to parse eagerly, and we have preparse data from lazy preparsing, we're gonna have a bad time. The symbol stream won't contain symbols inside lazy functions, and when the Parser parses them eagerly, it will consume symbols from the symbol stream, and everything will go wrong. This bug was hidden because the symbol cache was not used for real (see https://codereview.chromium.org/172753002/ ). R=ulan@chromium.org BUG=346207 LOG=Y Review URL: https://codereview.chromium.org/177973002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19532 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
BUG=v8:3176 LOG=n R=danno@chromium.org Review URL: https://codereview.chromium.org/177523002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Feb, 2014 6 commits
-
-
baptiste.afsa@arm.com authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/170553002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19529 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
baptiste.afsa@arm.com authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/173773002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19528 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
m.m.capewell@googlemail.com authored
Fix bug where input register was potentially corrupted, tidy up register use in TruncateDoubleToI and rename TryInlineTruncateDoubleToI. BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/173663002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19527 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/170303003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19526 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
alexandre.rames@arm.com authored
BUG=v8:3168 LOG=N R=ulan@chromium.org Review URL: https://codereview.chromium.org/171603008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19525 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
R=yangguo@chromium.org TBR=yangguo@chromium.org Review URL: https://codereview.chromium.org/174873002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19522 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Feb, 2014 16 commits
-
-
danno@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/171533017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19521 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
plind44@gmail.com authored
TEST= BUG= R=jkummerow@chromium.org, plind44@gmail.com Review URL: https://codereview.chromium.org/173773003 Patch from Dusan Milosavljevic <Dusan.Milosavljevic@rt-rk.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19520 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
BUG=none R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/170483002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19519 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/165993004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19518 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
plind44@gmail.com authored
BUG= R=plind44@gmail.com Review URL: https://codereview.chromium.org/166273020 Patch from Balazs Kilvady <kilvadyb@homejinni.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19517 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
alexandre.rames@arm.com authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/166343004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19516 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
- This adds a python layer on top of the low-level git calls to control parameter passing and return values. - This also fixes a bug in FindLastTrunkPush that only shows up in manual mode when the last push versions are iterated. - The order of some parameters changed in some git calls in the tests to be uniform. BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/171423013 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19515 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jacob.bramley@arm.com authored
The cross_build_gcc.sh script didn't set LINK, so cross builds would fail at the last step. BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/170843011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19514 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jacob.bramley@arm.com authored
BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/173883003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19513 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/166323015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19512 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/165743003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19511 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/170203003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19510 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
The Parser never used the symbol stream produced by the PreParser for anything useful, due to a bug introduced 3.5 years ago by https://codereview.chromium.org/3356010/diff/7001/src/parser.cc. The bug is that calling Initialize on symbol_cache_ doesn't change its length. So the length remains 0, and the "if" in Parser::LookupSymbol is always true, and Parser::LookupCachedSymbol is never called and symbol_cache_ never filled. This bug also masked a bug that the symbol stream produced by PreParser doesn't match what Parser wants to consume. The repro case is the following: var myo = {if: 4}; print(myo.if); PreParser doesn't log a symbol for the first "if", but in the corresponding place, Parser consumes one symbol from the symbol stream. Since the consumed symbols were never really used, this mismatch went unnoticed. This CL also fixes that bug. BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/172753002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19505 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
baptiste.afsa@arm.com authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/172333004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19504 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
m.m.capewell@googlemail.com authored
Assert register sizes in StringCharLoadGenerator, and fix char_code comparison in DoStringCharFromCode. BUG= R=jochen@chromium.org Review URL: https://codereview.chromium.org/172483002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19503 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
BUG= TBR=ulan@chromium.org Review URL: https://codereview.chromium.org/173533002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19501 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Feb, 2014 10 commits
-
-
plind44@gmail.com authored
Regression surfaced with r19009, but latent error was present since r17767. BUG= R=dusan.milosavljevic@rt-rk.com Review URL: https://codereview.chromium.org/171793005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19500 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
plind44@gmail.com authored
Port r19487 (bd8c70f) BUG=v8:2938 LOG=N R=plind44@gmail.com Review URL: https://codereview.chromium.org/172533002 Patch from Balazs Kilvady <kilvadyb@homejinni.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19499 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
danno@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/165943005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19498 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
alexandre.rames@arm.com authored
The branch types include 'always' and 'never', and types like reg_zero (CBZ) and reg_bit_clear (TBZ). This will be used by incoming improvements to the code generated for deoptimization exit points. R=ulan@chromium.org Review URL: https://codereview.chromium.org/170783002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19497 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
The size_ member is only used in debug mode, so we should only define it in debug mode. BUG=none R=rodolph.perfetta@arm.com, ulan@chromium.org LOG=n Review URL: https://codereview.chromium.org/171583004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19495 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
This extracts the pattern "if call git fails: raise exception", which is spread all over the place. Now all calls to git are required to return gracefully and give a uniform exception message if they don't. BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/166903012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19494 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
Error message migration is done and Blink has updated the expected result. R=yangguo@chromium.org, ulan@chromium.org BUG=v8:3126 LOG=N Review URL: https://codereview.chromium.org/169353004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19493 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
Also rename is_lazily_compiled in (Pre)Parser; it really means "is lazily parsed" and doesn't correspond to the lazy compilation decision. R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/169223009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19492 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jacob.bramley@arm.com authored
This fixes some snapshot=off, debug-mode regressions. - Call CheckConstPool when entering InsturctionAccurateScopes. This fixes a problem in PushMultipleTimes where 'count' is very high. Each call to PushHelper starts an InstructionAccurateScope immediately after the last one finishes, with no opportunity for the constant pool to be generated. - Temporarily disable AssertStackConsistency in PrepareForPush. This assertion seems to push the code size too far, and several cctests (intermittently) fail due to buffer size limitations. I would like to renable this assertion later. BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/172453002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19491 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
Refresh the implementation of Symbols to catch up with what the specification now mandates: * The global Symbol() function manufactures new Symbol values, optionally with a string description attached. * Invoking Symbol() as a constructor will now throw. * ToString() over Symbol values still throws, and Object.prototype.toString() stringifies like before. * A Symbol value is wrapped in a Symbol object either implicitly if it is the receiver, or explicitly done via Object(symbolValue) or (new Object(symbolValue).) * The Symbol.prototype.toString() method no longer throws on Symbol wrapper objects (nor Symbol values.) Ditto for Symbol.prototype.valueOf(). * Symbol.prototype.toString() stringifies as "Symbol("<description>"), valueOf() returns the wrapper's Symbol value. * ToPrimitive() over Symbol wrapper objects now throws. Overall, this provides a stricter separation between Symbol values and wrapper objects than before, and the explicit fetching out of the description (nee name) via the "name" property is no longer supported (by the spec nor the implementation.) Adjusted existing Symbol test files to fit current, adding some extra tests for new/changed behavior. LOG=N R=arv@chromium.org, rossberg@chromium.org, arv, rossberg BUG=v8:3053 Review URL: https://codereview.chromium.org/118553003 Patch from Sigbjorn Finne <sigbjornf@opera.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19490 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-