- 12 Jan, 2022 10 commits
-
-
Dominik Inführ authored
This is a reland of 86038ecf Compared to the previous CL this one is adding a TSAN suppression for GlobalSafepoint::EnterSafepointScope. local_heaps_mutex_ of client isolates may be locked in any order. This would be detected by TSAN as a potential race. Add some additional DCHECKs to compensate for that missing test coverage. As a cleanup this CL also removes the unused methods ContainsLocalHeap() and ContainsAnyLocalHeap() from LocalHeap. Original change's description: > [heap] Optimize time to reach global safepoint > > Initial support for global safepoints kept it simple by entering a > safepoint for each of them one after another. This means > time-to-global-safepoint is the sum of all time-to-safepoint operations. > We can improve this slightly by splitting up the safepoint iteration > into two operations: > > 1) Initiate safepoint lock (locks local_heaps_mutex_, arms the barrier > and sets SafepointRequested flag for all client threads) > 2) Block until all runnning client threads reach a safepoint > > We now perform operation 1) for all clients first and only then start > with operation 2). > > Bug: v8:11708 > Change-Id: Iaafd3c6d70bcf7026f722633e9250b04148b3da6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310910 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78308} Bug: v8:11708, v8:12492 Change-Id: I7087ba23c08f2d4edb9b632eef3c218fc76342e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3328786Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78583}
-
Thibaud Michaud authored
- Add an ActiveSuspender root, similar to the ActiveContinuation root. - Add the missing "parent" field to the Suspender, which points to the outer Suspender when they are nested, and update that field when entering a new Suspender. - Add the missing "state" field and update it when the state of the Suspender changes. R=ahaas@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: I7a95f44f81390a347c6ef252ec6184fb4f0b0455 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3345003Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#78582}
-
Nikolaos Papaspyrou authored
This CL contains minor refactorings to some parts of the garbage collector: - Space iterators. - Removes a redundant call to Heap::CreateFillerObjectAt. - Heap::CompleteSweepingFull now ensures that sweeping in the C++ managed heap is also completed. - Checks, comments and code cleanup. Change-Id: I14a7fe45c270c463c94c86f45b0e65757249d548 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3377125Reviewed-by:
-
Dominik Inführ authored
This CL doesn't change behavior, only refactors MemoryAllocator: * De-templatify class, MemoryAllocator is used on slow path and doesn't really need templates for performance. * Rename FreeMode names * Move methods into private section of class Change-Id: I7894fba956dcd7aa78ad0284d0924662fef4acae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3379812Reviewed-by:
-
Igor Sheludko authored
The Isolate might not be aware that remapped builtins are used (see Code::OffHeapInstructionStart()), so always try to lookup PC in the remapped builtins if they are available. Bug: chromium:1241665, v8:11460 Change-Id: Iefc373cf0ea0110c8c002b7677e6a1fd8fd45319 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3379817Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78579}
-
Nikolaos Papaspyrou authored
Change-Id: I8e2b0756ac2cbbb3275a9560cfab749a9009033b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3365265Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#78578}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Ieedb5bb0d6555cdf6c628f6700f7116ca142a2d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3376963Reviewed-by:
-
Manos Koukoutos authored
We introduce {ConstantExpression}, which represents the most frequent constant expression types directly, and falls back to a {WireBytesRef} for the rest. During module decoding, we decode the most common expressions separately and store them as {ConstantExpression}, so we do not have to decode them again during module instantiation. Bug: chromium:1284557 Change-Id: Ie411bbe9811d0d9f6e750ba202bb0ccff801dfee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3378347Reviewed-by:Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78576}
-
JianxiaoLuIntel authored
To make sure print the correct gc_count in heap layout tracer. Change-Id: I790d9359acab188bbfd1f59b731531c58713d8f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3361842 Auto-Submit: Jianxiao Lu <jianxiao.lu@intel.com> Reviewed-by:
-
Frank Tang authored
get Temporal.*.prototype.(calendar|timeZone|epochNanoseconds) Bug: v8:11544 Change-Id: Iede568431847f1413e018ab0766cd74f3eeafc66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3374072Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78574}
-
- 11 Jan, 2022 21 commits
-
-
Joyee Cheung authored
It is possible for KeyedDefineOwnICKind to go into ElementsTransitionAndStoreIC_Miss when a computed field key is a valid index and the lazy feedback allocation is disabled. Bug: chromium:1277863 Change-Id: If8a81384257647426607495b6e3d8f235913e8f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3322634Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#78573}
-
Milad Fa authored
Vector load/store lane, splat, extend as well as load 32/64 zero have been rewritten to make use of new z15 instructions (or use older instructions if not available) in such Cls: https://crrev.com/c/3138212 https://crrev.com/c/3144373 Same has been done for PPC BE (AIX). As a result the workarounds in wasm-compiler are no longer needed. Change-Id: I1de7066fa20f6e4d9d68c1a6db77a164dc8ae2f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3379820Reviewed-by:
-
Hannes Payer authored
Change-Id: I9a8a667733247152f8760385391e7b3379731f02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380982Reviewed-by:
-
Shu-yu Guo authored
This is a temporary solution so prototyping of shared structs and shared strings can be worked on in parallel. Bug: v8:12007 Change-Id: Ic849ec66da1d3824d50d695f16e4b77380afa015 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3379222Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#78570}
-
Andreas Haas authored
V8 crashed with a FATAL when memory allocation during instantiation failed. With this CL, a RangeError is thrown instead. This is not the only possible OOM that can happen during the startup of a WebAssembly app, but since the allocation of WebAssembly memory is among the biggest allocations, this change may already prevent several crashes. R=clemensb@chromium.org Bug: chromium:1268898 Change-Id: I9376830ba2fe9df62b5595b6b19c92e35a75dfda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380586Reviewed-by:
-
Igor Sheludko authored
Windows requires additional writable page to be allocated in front of the code range, but at the same time the code range must not cross 4 GB boundary in order to make Code pointer compression work for Code pointers. All these constraints make the logic of hint calculation too dependent on what VirtualMemoryCage::InitReservation() would do with the provided hint. This CL simplifies the hint calculation and fully relies on VirtualMemoryCage::InitReservation() to do the right thing. On Linux the implementation of OS::GetFreeMemoryRangesWithin() doesn't work when Chromium sandbox is enabled, so we use the beginning of the preferred short builtin calls region as a hint. It should be at least as good as the fallback hint but with higher chances to point to free address space location. Bug: v8:11880 Change-Id: I0b6ebec98dd0cf483f67e6ba8a919deb9ce7cc25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380585Reviewed-by:
-
Piotr Sikora authored
Signed-off-by:
Piotr Sikora <piotrsikora@google.com> Change-Id: Ib4dc67fcb58d7d8f7e48752c579468229c23de52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3375469Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#78567}
-
Milad Fa authored
This CL takes advantage of the P9 `vector byte-reverse` instructions to add to support to BE platforms. Change-Id: Ia022e056ca61373b7f8f7754ec76e94774b80af3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3378922Reviewed-by:
-
Manos Koukoutos authored
We introduce a type arrayref, which is a supertype of all array types and a subtype of dataref. We change array.len to accept values of type (ref null array). Drive-by: Fix kEq/kData case in TypecheckJSObject. Bug: v8:7748 Change-Id: I47c6a4487ddf5e7280c1427f43abe87a97c896bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3368105Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Andreas Haas authored
The original CL introduced a test that does not work when it is executed concurrently on multiple isolates. This CL skips this test configuration. Original change's description: > [wasm] Lazy compilation after deserialization > > The serialization format contains one boolean flag per function which > specifies whether the function code exists in the serialized module or > not. With this CL, this boolean flag is extended to a three-value flag > which indicates whether the function exists, and if not, whether the > function was executed before serialization. This information can then be > used upon deserialization to compile only those functions that were > executed before serialization. > > Design doc: https://docs.google.com/document/d/1U3uqq4njqLqFhr1G2sU_bmpQxY-3bvfG55udSb-DvA4/edit?usp=sharing > > Bug: v8:12281 Change-Id: I36ce90b37736172aa01c47ab04e154ec8ea2d8aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380590Reviewed-by:
-
JianxiaoLuIntel authored
Change-Id: I443d6e84fb3ca9d27456300b777105319ec0fe25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3352457Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78563}
-
Victor Gomes authored
No-Try: true Change-Id: If4d72836d40ee994ea5b7f7f1f2a98092d7b4079 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380599 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Piotr Sikora authored
This leads to a noticable performance improvements, and this flag is flipped to "is_debug" by the V8 Autoroller in release branches for the GN builds, so this change matches that behavior. Signed-off-by:
-
Thibaud Michaud authored
- Add Suspender.suspendOnReturnedPromise method - Extend the WasmApiFunctionRef data with the suspender - Detect wrapped WasmJSFunctions when we resolve the import For now the generated wrapper is still a regular wasm-to-js wrapper, but this sets the ground for generating specific wrappers for functions wrapped by suspendOnReturnedPromise, and to access the suspender from the wrapper code. R=ahaas@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: I81cbec6b023507e47e6e1463b5f9b912f807da6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3345000Reviewed-by:
-
Piotr Sikora authored
Signed-off-by:
-
Aleksei Koziatinskii authored
BaseSpace classes. So BaseSpace should have a virtual destructor for memory to be freed properly. cppgc: :internal::RawHeap maintains a std::vector of std: :unique_ptr<BaseSpace> and stores there different derived from Change-Id: Id9f59817799303bf62aafb66b3a29770bbd2af1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3379228Reviewed-by:
-
Benedikt Meurer authored
The methods in the v8::internal::Factory deal with creating the objects described in src/objects, so there's no point in having different sets of owners for them. Bug: none Change-Id: I05b48535bd81d37796e3f741156a059be8554759 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359634Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/3b3de69..0d98dba Creating release commit for v1.6.1 (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/0d98dba Destructor not returning is expected in some cases (#1316) (staffantj) https://chromium.googlesource.com/external/github.com/google/benchmark/+/0e78738 Address c4267 warning on MSVC (#1315) (staffantj) https://chromium.googlesource.com/external/github.com/google/benchmark/+/6dfe7af R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I484073c46b839f7ba8d8c8abac6e6c28da79b1ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3379826 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78556}
-
Frank Tang authored
Bug: v8:11544 Change-Id: If0a6eeb6591538a969efaac9d148d019300b4113 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3374067Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/12badc1..3803b80 Rolling v8/buildtools/linux64: git_revision:f1b1412521b41e47118b29863224171e434a27a2..git_revision:80a40b07305373617eba2d5878d353532af77da3 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/58d1647..14da6e7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/aa0e8d0..dc12138 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d3cc7ad..0f5a4de Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6e330f7..f5a2da5 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ie20d091b4fd5b69d68a9b6f0e69ea3403abbce0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3379824 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78554}
-
Lu Yahan authored
enable simd on riscv64 Change-Id: I446d6b14e4f89164b49a66367340d904ba104911 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347493Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
-
- 10 Jan, 2022 9 commits
-
-
Piotr Sikora authored
This simplifies integration with Bazel workspaces that already have those libraries imported under different repository names. Signed-off-by:
-
Piotr Sikora authored
This allows other Bazel projects to use their existing zlib import, and only pull compression utils from Chromium's zlib. Signed-off-by:
-
Piotr Sikora authored
This allows other Bazel projects to fetch those dependencies without relying on a full "gclient" checkout. Added "com_googlesource_chromium" prefix to repository names to indicate that those are Chromium forks and not official releases. Signed-off-by:
-
Corentin Pescheloche authored
For consistency with the other enums values, avoid gaps between EmbedderState values. Bug: chromium:1263871 Change-Id: I22c58700f292b007ced7c12db219f578f82d77d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3370081 Auto-Submit: Corentin Pescheloche <cpescheloche@fb.com> Reviewed-by:
-
Adenilson Cavalcanti authored
The enablement of PAC in Chromium will have two phases where support will first be enabled on C++ code (e.g. Blink/Chrome/etc) and its dependencies, followed next by support for dynamic code generated by V8. This change will allow enable PAC support for C++ code when V8 is built with Chromium. Bug: chromium:919548 Change-Id: I8ebcbcfe3c2a3a38807b814f936272ac09625795 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372162Reviewed-by:
-
Alexander Timin authored
Add the new disabled-by-default-v8.inspector category (added by [1]) to the category list to ensure that v8 can be built with perfetto client library (example failure [2]). [1] https://chromium-review.googlesource.com/c/v8/v8/+/3364085 [2] https://ci.chromium.org/ui/p/chromium/builders/try/linux-perfetto-rel/5926/overview Change-Id: I7b187a18d2f996148fbfd42f9039f9a2012537bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3370121 Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Clemens Backes authored
This reverts commit fbcdb281. Reason for revert: New test fails for multiple (concurrent) isolates: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux/45152/overview Original change's description: > [wasm] Lazy compilation after deserialization > > The serialization format contains one boolean flag per function which > specifies whether the function code exists in the serialized module or > not. With this CL, this boolean flag is extended to a three-value flag > which indicates whether the function exists, and if not, whether the > function was executed before serialization. This information can then be > used upon deserialization to compile only those functions that were > executed before serialization. > > Design doc: https://docs.google.com/document/d/1U3uqq4njqLqFhr1G2sU_bmpQxY-3bvfG55udSb-DvA4/edit?usp=sharing > > Bug: v8:12281 > Change-Id: I465e31e5422fa45163256be0e6594045865f0174 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3364089 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78545} Bug: v8:12281 Change-Id: If0e327d02e8257a4d1cfcf8b82381af11f28e91c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3377126 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78546}
-
Andreas Haas authored
The serialization format contains one boolean flag per function which specifies whether the function code exists in the serialized module or not. With this CL, this boolean flag is extended to a three-value flag which indicates whether the function exists, and if not, whether the function was executed before serialization. This information can then be used upon deserialization to compile only those functions that were executed before serialization. Design doc: https://docs.google.com/document/d/1U3uqq4njqLqFhr1G2sU_bmpQxY-3bvfG55udSb-DvA4/edit?usp=sharing Bug: v8:12281 Change-Id: I465e31e5422fa45163256be0e6594045865f0174 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3364089Reviewed-by:
-
Milad Fa authored
This CL takes advantage of the P9 `vector byte-reverse` instruction to implement Simd LoadSplat opcodes. We will need to implement the rest of the `load transform` ops before enabling this from wasm-compiler on BE machines. Change-Id: I094e37d3b15e0dc04484eb2a701cb479f18e2f9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3371790Reviewed-by:
-
