- 23 Apr, 2019 17 commits
-
-
Shiyu Zhang authored
Change-Id: I9480650b23da4f5aa38a0634c1a7662bf88189d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1551407Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Cr-Commit-Position: refs/heads/master@{#60952}
-
Takuto Ikuta authored
As a preparation of trusty -> xenial migration, let me specify os dimension explicitly here. I added os dimension for the linux builders having tests property. I will change this dimension gradually with gradual swarming test bots trusty -> xenial migration. Currently this should not change ubuntu's version of bots running tests because v8 recipe module has default Ubuntu-14.04 dimension for linux. https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/v8/api.py?l=428&rcl=927948978a7a101fca66f07a784aeb3ddb6650c9 Bug: chromium:954890 Change-Id: Ib2404c5aaa54d6e8e47341394d6a757a9d99874a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578659 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60951}
-
Clemens Hammacher authored
The {Vector} class stores the size in a {size_t} since a while, but many accessors and constructors still accept an {int}. This CL removes all {int} uses except for the explicit {length()} accessor. It also adds a comment to avoid this accessor if possible. The {StrLength} function still has several users outside of vector.h, which I plan to remove in a follow-up CL. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: I33c5b0e8b8b2cb3531716c1d99e4516a13d6ba1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578480Reviewed-by: -
Clemens Hammacher authored
This CL fixes some issues with GC. 1) It removes dead code from the set of potentially dead code to avoid considering the same code for GC again and again. 2) It resets the {new_potentially_dead_code_size_} counter to avoid triggering too many GCs. 3) When code becomes dead after GC, do not unconditionally free it; just decrement its ref count (there might still be {WasmCodeRefScope}s holding the code alive). 4) Update the comment of the ref count to be more accurate. R=titzer@chromium.org Bug: v8:8217 Change-Id: I28e5a1fed74411b8473bb66ddbad3ffe7643f266 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574518 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60949}
-
Clemens Hammacher authored
This adds two counters for collecting the absolute size of freed code, and the percent of total generated code per module. R=titzer@chromium.org Bug: v8:8217 Change-Id: Ia065081104fbff6459791c919e0b18677ba45cc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1573698 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Sergiy Belozorov authored
This is dead code as no benchmarks seem to be using it and removing this additional logic will reduce maintenance cost for the perf infrastructure. R=machenbach@chromium.org, tmrts@chromium.org No-Try: true No-Tree-Checks: true Change-Id: I952af069d4d18d63624510b4c461fa1891703db9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570008 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60947}
-
Sergiy Belozorov authored
This is part of the refactoring to allow exporting more information about test execution to the recipes and upload this information to ChromePerf. This fixes running secondary even after primary run fails, which will allow us to differentiate between test and infra failures as latter ones will also affect refbuilds and re-runs without patch. R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:841700 Change-Id: I29ce49d2f8c5e73158f1d41a73c51f2b35929f36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570006 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This is the next step to test the GC better: We zap the code region of {WasmCode} objects which are detected to be unused. This is tested in the future variant, so ClusterFuzz has a chance to catch missing references. R=titzer@chromium.org Bug: v8:8217 Change-Id: I75a63384a2a8e2ed68b9447e6ee4faa24037da93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571622Reviewed-by: -
Sergiy Belozorov authored
This is part of the refactoring to allow exporting more information about test execution to the recipes and upload this information to ChromePerf. R=machenbach@chromium.org,tmrts@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:841700 Change-Id: Iab400e8922231d8eac91a6fa22ce8f45053f7ac6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569442Reviewed-by:
-
Michael Starzinger authored
The WebAssembly JavaScript Interface specifies[1] that exported functions are not constructors, hence do not have the "prototype" property. This is not true for asm.js exported functions which are expected to look like normal functions (or constructors). [1] https://webassembly.github.io/spec/js-api/index.html#exported-function-exotic-objects R=clemensh@chromium.org TEST=mjsunit/regress/regress-crbug-935800 BUG=chromium:935800 Change-Id: Idecacfb7f5d4668540589af95fd59872334c21a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578499 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60943}
-
Simon Zünd authored
This CL implements the first set of diagnostic notifications. When Torque compilation fails, the language server translates the Torque error into a diagnostics notification and pushes it to the client. Note that per specification, the server is responsible to manage the state of all published diagnostics. This means that the server is also responsible for clearing out previous notifications if they become stale. Bug: v8:8880 Change-Id: Ief46dc1d94d1e5b7fa3e0048df494bfc05974031 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569434Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60942}
-
Michael Achenbach authored
This prints the current v8-specific processes on linux whenever the test driver emits a heart beat (i.e. no output for 30 seconds). This is to investigate the cause of currently hanging tests on linux. Bug: v8:9145 Change-Id: I857bb6d1c5f0b0917c64cdc0aa6076c6633f9dd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578438 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
EmbeddedVector lives on the stack only, and should not be implicitly copied or assigned. This also removes remaining uses of the removed Vector::set_start method. R=sigurds@chromium.org Bug: v8:9142 Change-Id: I829e6ffad6b1a30baa6c874265e92d615dd0c981 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578458Reviewed-by:
-
Georg Neis authored
Before: 0x352ac49c2eb4 f4 4d898df0f10600 REX.W movq [r13+0x6f1f0] (WAAT??? What are we accessing here???),r9 After: 0x352ac49c2eb4 f4 4d898df0f10600 REX.W movq [r13+0x6f1f0],r9 Change-Id: I5f9af797de3c84117fd123204d9094251d18d07b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571618Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60939}
-
Michael Achenbach authored
NOTRY=true TBR=sigurds@chromium.org Bug: v8:8963 Change-Id: Idf19be92f7f039a14838c87695666d5f6963e6a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575585Reviewed-by:
-
Matheus Marchini authored
R=bmeurer@chromium.org, jgruber@chromium.org, yangguo@chromium.org Bug: v8:9122 Change-Id: I6336d2fc0249269a749d99dcae7c172b2ccaac75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570582Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b5c9a27..7dae72d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d8ce959..fb33e51 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8dfc0bc..6d9913a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I94dc1ff83c0c6bbbe46ee83065895810b19f6dc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578278Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60936}
-
- 21 Apr, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/f20b8e9..c46d4fa [spec] Work around Sphinx/Latex issue (#1004) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/c46d4fa TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Id928f05d1ccec2f24d8bbe6eaca6bc646c58f6fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1576818Reviewed-by:
-
- 20 Apr, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c0da152..b5c9a27 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9f474a8..d8ce959 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ifaea2c06ec5dd338d0ab6d9775a6cce30647d40d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575828Reviewed-by:
-
- 19 Apr, 2019 5 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/d14d538..f20b8e9 [spec] Pre/post-conditions and some renamings in embedding interface (#1003) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/f20b8e9 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I08aa77e87d5c66b6cfde86d439c2dad4bf9b5aba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574374Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cc63a88..c0da152 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4e967e7..9f474a8 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1e2cb15..8dfc0bc TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5e5ee21a818c6496cd8a3220ffa52d84b1e6c9f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574710Reviewed-by:
-
tzik authored
MicrotaskQueue associated to Context may be null after DetachGlobal, and triggering FinalizationGroup clean up on the detached context causes a crash. This CL fixes the crash by cancelling the clean up on such a context. Bug: chromium:937784 Change-Id: I57883ae0caf6c6bb35e482e441b6e09e921d9def Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552500Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#60931}
-
Frank Tang authored
Design Doc: https://goo.gl/PGUQ1d Use template to share code between formatRange and formatRangeToParts Lazy crate DateIntervalFormat inside formatRange/formatRangeToParts to reduce performance impact. Bug: v8:7729 Change-Id: I130748a5ff7ca11235e6608195d365e58d440580 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1556573 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:8699 Change-Id: I4e1f82132c3e48c21295ea7b0f3bcd24d5bd3c54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575019Reviewed-by:
-
- 18 Apr, 2019 16 commits
-
-
Frank Tang authored
Bug: v8:8604 Change-Id: Ieab15e55ed392019cc94de80d8e9c1a33f4d599a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1573038Reviewed-by:
-
Z Duong Nguyen-Huu authored
Per suggestion, we put this behind runtime flag in the mean time. Refactor some codes. Bug: v8:6831 Change-Id: Ibeb2a62b2a132971f8bc51c045bf0d2594eec198 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566238 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60927}
-
Frank Tang authored
Bug: v8:8702 Change-Id: I0d483be11fbb19b6555900f3f953eae531d3e8cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574618Reviewed-by:
-
George Burgess IV authored
We had one use of OS_CHROMEOS in mksnapshot. OS_CHROMEOS is defined if gn's `is_chromeos` is true, which checks `current_os`. `current_os != target_os` can happen if we're building with a non-default toolchain, which happens often on CrOS, since `mksnapshot` is a host binary. Tested by manually verifying that .text.hot.embedded now shows up on arm32/aarch64 builds of embedded.S. Bug: v8:9103 Change-Id: I038b56f4c18c7dd9a651ce676a977697dad14ae6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1573041 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This CL adds the representation changes from/to CompressedPointer to the other data types (excluding Tagged, which was done in a previous CL). Also adding missing write barriers for compressed values (WriteBarrierKindFor). Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: Ieb4e6dd72371e858ba1da551f765e42581a51f90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571616Reviewed-by:
-
Maya Lekova authored
Bug: chromium:951400 Change-Id: Ib5454541e7c661649ccdb9771298ff90b3e9db5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571614 Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
There seems to be an issue where LTO inlines the icache flushing method but removes the save and restore of the r7 register which is clobbered for the icache flush syscall. This CL tries to avoid the bug. It's purely speculative, as we cannot reproduce the exact bug locally. R=jkummerow@chromium.org Bug: chromium:952759 Change-Id: I634fc4de3e8c4d1cb649384542c381d925b07a42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571619Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60922}
-
Frederik Gossen authored
Add lazy validation for lazily compiled functions. The code is validated only on first use. This applies to functions that are lazily compiled by compilation hint as well as to entirely lazy modules. Bug: v8:9003 Change-Id: If6a640db4bf4b846ac5e3805c138b8ac0a493cf9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569427 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by:
-
Jakob Gruber authored
Block binary coverage currently also relies on invocation counts on the feedback vector, which are not maintained in optimized code. This fixes the SFI::IsInlineable predicate to also prevent inlining functions when 1. binary coverage is enabled and 2. the function has no reported binary coverage. Drive-by: Add new predicates for binary/count modes. Bug: v8:6000 Change-Id: I0039e43ebae880e3552e8349d20a144fe941ef3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571615 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60920}
-
Georg Neis authored
We see crashes in the wild that we suspect are caused by these changes. This is a manual revert because of conflicts. Revert "[turbofan] Fix incorrect CheckNonEmptyString lowering." This reverts commit b3b70118. Revert "[turbofan] Fix incorrect lowering of CheckNonEmptyString." This reverts commit 57582090. Revert "[turbofan] Significantly improve ConsString creation performance." This reverts commit d6a60a0e. Bug: v8:9147 Change-Id: I262c21e5406a9c4c8ad0e0f995582c5802f0fa1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571613Reviewed-by:
-
Michael Starzinger authored
R=jgruber@chromium.org BUG=v8:8758 Change-Id: Iba62ca0f9010cd68b47966ad8d04c1a4149efe70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571415Reviewed-by:
-
Jaroslav Sevcik authored
This uses the same comparison as the ICs to make sure that ICs learn after deoptimization (see https://chromium-review.googlesource.com/c/v8/v8/+/1561319 for the IC fix). Bug: v8:9139 Change-Id: I67a361d85ee0c8a4ad4a6abc2d33ac4ca5fa22bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569438 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Frederik Gossen authored
Add tests for tiering and lazy compilation with compilation hints. The tests build modules and verify the {WasmCode}'s tier internally. The module builder now supports compilation hints in CCTests. Bug: v8:9003 Change-Id: I18d926c3b1ef3508835a51a9d1d86bfadcb5216e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566522Reviewed-by: -
Santiago Aboy Solanes authored
We translate stores with TaggedXXX (XXX in {"", "Signed", "Pointer"}) representation in CSA into stores of CompressedXXX with a ChangeTaggedXXXToCompressedXXX in the raw-machine-assembler. This way, CSA doesn't need to know about Compressed values since we are introducing an explicit "compress" node. Also, on ARM64, removed CheckPageFlagSet and CheckPageFlagClear since CheckPageFlag can be used for both cases. Moved CheckPageFlag to the TurboAssembler (from MacroAssembler) since it was needed on code-generator-arm64.cc. Bug: v8:8977, v8:7703 Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Change-Id: Ia3a41b09a4d715588a36461620be0432ed064d13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566517Reviewed-by:Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Michael Hablich authored
TBR=machenbach@chromium.org NOTRY=true Change-Id: Iecc4c113a175a6acacc8d90b30c341762f9c7cb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571612Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#60914}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a0b2e3b..cc63a88 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/acbf095..4e967e7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7e7523b..1e2cb15 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/a42c2f6..ae68779 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/b617b27..9f893b9 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/edee5c0..396602c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I2964b7bb215b5981338eef6f46076e05d79a86e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1572680Reviewed-by:
-
