- 28 Mar, 2019 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/d51ec1b..4406612 [test] Check for "unreachable" consistently (#992) (Ben Smith) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/4406612 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Ib25b56bc297e47a8a35ba868707d9c689f71d79c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541451Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60498}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5256fba..adf96bc Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/d09c967..466efc7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2b058ca..6d6a48a Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c74cce1..51c0f38 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e0abf7a..39afd62 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I1b59b6b9931362db3ab9600dbd9b795f2363cacc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541450Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60497}
-
- 27 Mar, 2019 18 commits
-
-
Z Duong Nguyen-Huu authored
Bug: v8:8952 Change-Id: I74eaa1148116dfc8d6720e8be4f59ce90c8df164 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524664Reviewed-by: Daniel Clifford <danno@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#60496}
-
Pierre Langlois authored
Counters in generated code, as enabled with --native-code-counters, do not work in the snapshot. This adds a `v8_enable_snapshot_code_counters` build option enabled by defaut in debug mode that allows code from the snapshot to increment the current isolate's set of counters. For this to work, we need to add native code counters in the external reference table. To keep the no snapshot configuration similar, we've also enabled the --native-code-counters flag by default for debug builds. Change-Id: I4478b79858c9b04f57e06e7ec67449e9e3a76f53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528998 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60495}
-
Ben L. Titzer authored
R=mstarzinger@chromium.org BUG=chromium:944945 Change-Id: I9cd83118fd27556197bfd5c4597b4678fc97ee32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541479Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60494}
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: I2fe68c54e59fd452ee724ce7fbd80eca6ab5e096 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541106 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60493}
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: I3a939d65ec8468f034d4670d9b14a911e5ef5a61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541044Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60492}
-
Clemens Hammacher authored
{WasmInstanceObject} is a {JSObject}, so it can have user-defined properties and elements. DebugPrint should include them. R=titzer@chromium.org Change-Id: Id787fc2d40c256a0287aea69353066c6fd920a56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541236Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60491}
-
Igor Sheludko authored
Tbr: jgruber@chromium.org Bug: chromium:944971 Change-Id: I2dcbfae638848c11eac4e262c3d636f33c3f24a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541477 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#60490}
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: Ib775ce8ab450ad42a342a40c660230c091e4f41d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541053 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60489}
-
Clemens Hammacher authored
The elements of a {WasmInstanceObject} were not visited during GC, leading to crashes when using them later. This CL fixes this by visiting the whole {JSObject} header, consisting of properties and elements. R=titzer@chromium.org Bug: chromium:839919, chromium:946350 Change-Id: I070fb3e6a7fd87a7288fc68b284100a2f9c72e9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541237 Auto-Submit: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#60488}
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: I851e9a18eab0812e009d323cd98814bebc83f003 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541047 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60487}
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: Ia789e21ac9324fca77f559a88180fadd97491a91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541050 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60486}
-
Junliang Yan authored
regress-crbug-178790 test can cause overflow on debug mode Drive-by: clean up simulator skiped tests Change-Id: Iec6151518fe1814e8eefcaaf09439782a2d29426 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539791 Auto-Submit: Junliang Yan <jyan@ca.ibm.com> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60485}
-
Z Duong Nguyen-Huu authored
This cover all test files under mjsunit/compiler/array-* Bug: v8:6831 Change-Id: I7a5632ccb3895a6e23ebfb92598dd1939de133b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1531030 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60484}
-
Tomasz Moniuszko authored
Windows.h defines GetMessage macro which clashes with MessageHandler::GetMessage. The problem arises when icu_util.cc is included before messages.cc in the same jumbo file. win32-headers.h defines NOUSER before including windows.h. This prevents GetMessage from being defined. Bug: v8:9042 Change-Id: I174eae5036ed2134b210d628fd2a97718db816d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539838Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#60483}
-
Michael Achenbach authored
NOTRY=true Change-Id: I40ef00c7c2886f356de9f0caa667f453b63b7637 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539837Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60482}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/aee5bb4..5256fba Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/31e0bb5..d09c967 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/4daecde..955113d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/85ead57..2b058ca Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e17d1ed..c74cce1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/23688af..e0abf7a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5a9ea4b5f86dddf8cbee9cdc9dd6460409065f33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1540381Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60481}
-
Bill Budge authored
- Fixes a bug where signaling NaNs are converted to Infinities rather than quiet NaNs. Bug: v8:6020,v8:8639 Change-Id: I2601378f06f1987983f2b93e8970f401333073be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536911 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60480}
-
Milad Farazmand authored
Port: 7629afdb Original Commit Message: Allocate feedback vectors lazily when the function's interrupt budget has reached a specified threshold. This cl introduces a new field in the ClosureFeedbackCellArray to track the interrupt budget for allocating feedback vectors. Using the interrupt budget on the bytecode array could cause problems when there are closures across native contexts and we may delay allocating feedback vectors in one of them causing unexpected performance cliffs. In the long term we may want to remove interrupt budget from bytecode array and use context specific budget for tiering up decisions as well. Change-Id: I261a7f7cedbdaa3be2d0cf22bfa701598f749fd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539794Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60479}
-
- 26 Mar, 2019 20 commits
-
-
Deepti Gandluri authored
Change-Id: Ibe60c5025a25b353e6661576872a8fda1aeef5de Bug: v8:9014 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536986Reviewed-by: Aseem Garg <aseemgarg@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60478}
-
Frank Tang authored
Bug: v8:7834 Change-Id: I513f13033dd9aab72a78feb45ec5181183f9cc51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538833Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60477}
-
Georg Neis authored
If the LHS has a proxy in its prototype chain (or is itself one), then the LHS's [prototype_or_initial_map] being the hole does not necessarily imply that the result is false. This CL also adds support for --force-slow-path, which would have been useful in finding this bug earlier. Bug: v8:9036 Change-Id: I6f5134d6ce18f9f14549ced3d33527f54ce9bcb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539497 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60476}
-
Michael Achenbach authored
Change-Id: I6169e925f9f77e3a6b8f90c0df5ecedcb4164c2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539499Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60475}
-
Michael Achenbach authored
This reverts commit 63608968. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/19535 Original change's description: > [wasm] Implement table.init for interpreter > > This also fixes CheckCallViaJS when a trap occurs. In that case, the > trap callback is called instead of an exception being thrown, so if it > isn't handled, a bogus result will be returned instead. > > Bug: v8:8965 > Change-Id: I560e89f353756df23c062fb8c9484d9971c19253 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539078 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Ben Smith <binji@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60473} TBR=binji@chromium.org,mstarzinger@chromium.org Change-Id: Iee528ac2f16988b25579af3555e6f17974cb0b05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8965 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539498Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60474}
-
Ben Smith authored
This also fixes CheckCallViaJS when a trap occurs. In that case, the trap callback is called instead of an exception being thrown, so if it isn't handled, a bogus result will be returned instead. Bug: v8:8965 Change-Id: I560e89f353756df23c062fb8c9484d9971c19253 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539078Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#60473}
-
Deepti Gandluri authored
- Swap BitSelect operand order - Simplify, fix bugs for reductions Bug: v8:8636, v8:8665 Change-Id: I9f43ac8007f9ecb317b1ffa4f99e9c249c58a2dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1534972 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60472}
-
Clemens Hammacher authored
Reorder fields such that often-accessed fields are first. This minimized generated code size on x86 and x64. R=titzer@chromium.org Bug: chromium:839919 Change-Id: Ia2ef9bd2f9a1aa735ed9b1de93cb78aa5d77467b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538120 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60471}
-
Sigurd Schneider authored
Together with the previous CL, this is a 10x improvement. Bug: v8:8834 Change-Id: I89b86ee88c82479997c08b725571369b1bf9d190 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539592 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#60470}
-
Simon Zünd authored
R=sigurds@chromium.org Bug: v8:8952 Change-Id: I93a9a136e83510a92cd38b2bb16d0965be95110a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538483 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60469}
-
Clemens Hammacher authored
In WasmInstanceObject we want to reorder the fields such that fields that are often accessed from generated code have a small offset (<128 bytes). This requires mixing tagged and untagged fields. This CL prepares the existing GC support for WasmInstanceObject to only visit the listed tagged fields. R=titzer@chromium.org Bug: chromium:839919 Change-Id: Ia85d7bcfff54af35785b6d573e7e682a26c39ae6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538119Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60468}
-
Nico Weber authored
The snapshot requires building host code in target bitness, and chromium's base doesn't build in 32-bit on mac hosts due to some 64-bit-only assembly code. Bug: chromium:794838 Change-Id: I89887fe63c88c435bc4743c3d99f22ffe79a5bd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1534635 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60467}
-
Leszek Swirski authored
Moves the string instance type tag definitions around to be in order, makes their definitions slightly clearer (in terms of shifted 1 rather than hex values), and unifies/fixes the descriptions of the bits in the comments. Bug: v8:8834 Change-Id: I632b93053734445264f6c607c541e4171aae8038 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539583Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#60466}
-
Jaroslav Sevcik authored
Run memory optimizer after all the other graph phases. This is a step towards enabling allocation folding for arrays with >16 elements because constant additions will be properly constant-folded. Bug: v8:8984 Change-Id: Ia3c78a3bd32264f4f83d3e20bd78abf240d9292b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539496Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60465}
-
Jaroslav Sevcik authored
Bug: chromium:945187 Change-Id: If6f36a4767ffda5f23873c79775116514dd0a2b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539582 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60464}
-
Milad Farazmand authored
This reverts commit dd07cbcf. Change-Id: I3397af6d5c5cf2349b35c940eb46f4f9d2440a50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538904 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60463}
-
Georg Neis authored
TBR=jarin@chromium.org Bug: v8:7790 Change-Id: I8aeced2c149ef1a97d6e9df4f21afcf6a4145be0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539636Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60462}
-
Sigurd Schneider authored
..ordered-hash-table.h. Bug: v8:8834 Change-Id: Ibb79006beb020d06bc516d9a2dac81015a403728 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538518Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60461}
-
Georg Neis authored
Drive-by: also add support for trivial bytecodes such as LdaFalse. Bug: v8:7790 Change-Id: I72626500096310899d37d57e3d0dd3bd54fddff4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532066 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60460}
-
Mike Stanton authored
The bottlenecks to prevent storing signalling NaNs in backing stores were not perfect. This change makes it harder by ensuring that all the Torque-side "[]=" operator overloads for FixedDoubleArray stores have signalling NaNs silenced. Bug: chromium:944435 Change-Id: I295d9b34f4c896db30989bb9db1a2b452daa03ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538517Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#60459}
-