- 25 Apr, 2022 18 commits
-
-
Jakob Gruber authored
This CL switches over our OSR system to be based on the feedback vector osr caches. - OSRing to Sparkplug is fully separated from OSR urgency. If SP code exists, we simply jump to it, no need to maintain an installation request. - Each JumpLoop checks its dedicated FeedbackVector cache slot. If a valid target code object exists, we enter it *without* calling into runtime to fetch the code object. - Finally, OSR urgency still remains as the heuristic for requesting Turbofan OSR compile jobs. Note it no longer has a double purpose of being a generic untargeted installation request. With the new system in place, we can remove now-unnecessary hacks: - Early OSR tierup is replaced by the standard OSR system. Any present OSR code is automatically entered. - The synchronous OSR compilation fallback is removed. With precise installation (= per-JumpLoop-bytecode) we no longer have the problem of 'getting unlucky' with JumpLoop/cache entry mismatches. Execution has moved on while compiling? Simply spawn a new concurrent compile job. - Remove the synchronous (non-OSR) Turbofan compile request now that we always enter available OSR code as early as possible. - Tiering into Sparkplug no longer messes with OSR state. Bug: v8:12161 Change-Id: I0a85e53d363504b7dac174dbaf69c03c35e66700 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596167 Commit-Queue: Jakob Linke <jgruber@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80147}
-
jameslahm authored
... /codegen/code-layout-unittest. Bug: v8:12781 Change-Id: I39d2af33f38dc2f06668b6b390b15e607e2dbb73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599403Reviewed-by:
-
Clemens Backes authored
This introduces an AssemblerBufferCache class which will (later) cache the backing store of AssemblerBuffers. This is needed for PKU-protected assembler buffers, which are expensive to allocate and deallocate. For now, the AssemblerBufferCache does not do any caching, this will be added in a follow-up CL. R=thibaudm@chromium.org Bug: v8:12809 Change-Id: I4a7ccff49c9930584a9fcda8899cfe38cfc61419 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593136Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80145}
-
Victor Gomes authored
This assumes that Phi nodes never point to untagged values and TemporaryRegisters are always general registers. Bug: v8:7700 Change-Id: I74a6c43ff9f1ba87dd258e90a193f683d666b8ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3598883Reviewed-by:
-
Pierre Langlois authored
The `set disable-randomization off` command may fail on some platforms, such as the `rr` debugger. We can just ignore the error and carry on. Change-Id: I9b8dae183a9852178a3d3411172bf3aef173c995 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602519 Auto-Submit: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80143}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: Ifb3776bce308d869064120d5e28a2ea7df943757 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578652Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80142}
-
jameslahm authored
This is a reland of commit 62632c08. Reason for previous revert: Performance regressions crbug.com/1315724. The reland only optimizes strict equal boolean literal like "a===true" or "a===false", and we generate TestReferenceEqual rather than TestStrictEqual for the comparasion. And also add typed optimization for ReferenceEqual when all inputs are boolean with boolean constant. Original change's description: > [interpreter] Optimize strict equal boolean > > For strict equal boolean literal like "a===true" > or "a===false", we could generate TestReferenceEqual > rather than TestStrictEqual. And in `execution_result()->IsTest()` > case, we could directly emit JumpIfTrue/JumpIfFalse. > > E.g. > ``` > a === true > ``` > Generated Bytecode From: > ``` > LdaGlobal > Star1 > LdaTrue > TestEqualStrict > ``` > To: > ``` > LdaGlobal > Star1 > LdaTrue > TestReferenceEqual > ``` > > E.g. > ``` > if (a === true) > ``` > Generated Bytecode From: > ``` > LdaGlobal > Star1 > LdaTrue > TestEqualStrict > JumpIfFalse > ``` > To > ``` > LdaGlobal > JumpIfTrue > Jump > ``` > > > Bug: v8:6403 > Change-Id: Ieaca147acd2d523ac0d2466e7861afb2d29a1310 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568923 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: 王澳 <wangao.james@bytedance.com> > Cr-Commit-Position: refs/heads/main@{#79935} Bug: v8:6403 Change-Id: I2ae3ab57dce85313af200fa522e3632af5c3a554 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3592039Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Victor Gomes authored
We need to use MachineRepresentation to properly distinguish the types in compiler::UnallocatedOperand. Bug: v8:7700 Change-Id: I4273512a00290bb85b09aeb3788643e346be03f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602515Reviewed-by:
-
Jakob Kummerow authored
For call_direct, feedback (for the first level of inlining) only records call counts, not the statically-known target. So to be able to make feedback for potential additional inlining levels available, the feedback processor must look to the wire bytes to extract the call targets. Without feedback and hence unknown call counts, such multi-level inlining would not happen. Bug: v8:12166 Change-Id: I84ca58019e927a8bf9dad4e4aceddd341f945c04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3579105Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80139}
-
jameslahm authored
... /base/bignum-unittest. Bug: v8:12781 Change-Id: I217dd7c4ef59cf1fdbe83a268d0288c38f0e9d4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599401Reviewed-by:
-
Nico Hartmann authored
Bug: v8:12824 Change-Id: I96adf6c5d930b1476f7f1063ede4fc2344fb5885 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3605242Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#80137}
-
Tobias Tebbi authored
TurboShaft is a new, CFG-based IR for TurboFan. This CL adds the basic IR and bidirectional translation from/to TurboFan's sea-of-nodes-based IR for some common operators (still incomplete even for JS). Bug: v8:12783 Change-Id: I162fdf10d583a9275a9f655f5b44b888faf813f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3563562Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80136}
-
Anton Bikineev authored
In Oilpan minor GCs we don't trace the V8 subgraph. The commit 2da23bd5 broke it for the concurrent marker case. This CL bails out from visiting TracedReferences in the concurrent marker visitor, same as what we do for the mutator marking visitor. Bug: chromium:1029379 Change-Id: Iabeba11fd3d030e9dc5961a364481a0a7d8b8245 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602520Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#80135}
-
jameslahm authored
... /codegen/code-pages-unittest. Bug: v8:12781 Change-Id: Ied73476c801257fc9497b5101ea49a98b657f8ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599404Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/e5b846b..5fb93cb Fix thin_archive for icu (Manoj Gupta) https://chromium.googlesource.com/chromium/deps/icu/+/5fb93cb R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,ftang@chromium.org Change-Id: I8e827a95bc301dafb33d2953d99b9d8b424ea31a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3604594 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80133}
-
Lu Yahan authored
And port commit 5ee6b7a7 Change-Id: Ia43d1d888154ebffcd56d436e6dfa8970eae6583 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600174Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80132}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c68def5..e10cf1a Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/e025ba5..518fd76 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/1acfbbb..705543f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/cd131c2..3c4a622 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I9cb2342b815cb0868c85bdf367d049b5709dc559 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3604593 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80131}
-
jameslahm authored
- In DeserializeContext, scope info local values snapshot is in order of `name,value,name,value`, and we should ReadValue after ReadString. - Support non-inlined ScopeInfo locals, use NameToIndexHashTable to serialize and deserialize scope info local values when its local count is more than kScopeInfoMaxInlinedLocalNamesSize. Bug: v8:11525, v8:12820 Change-Id: I6ea2c498b594bed7ba8ca5be6af2ab9f0d39aa2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600531Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80130}
-
- 23 Apr, 2022 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/28bea73..c68def5 Rolling v8/buildtools/linux64: git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce..git_revision:7c8e511229f0fc06f6250367d51156bb6f578258 Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/2760db4..36c1580 Rolling v8/third_party/android_sdk/public: ppQ4TnqDvBHQ3lXx5KPq97egzF5X2FFyOrVHkGmiTMQC..bY55nDqO6FAm6FkGIj09sh2KW9oqAkCGKjYok5nUvBMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/960c656..88422dc Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/89ccf4a..dc8ca44 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/a0906c7..32e65ef Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4dd2e32..cd131c2 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I41663d5f20246e9b86ef73f0e264b67b390a4a83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599730 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80129}
-
jameslahm authored
... /objects/concurrent-script-context-table-unittest. Bug: v8:12781 Change-Id: I6576d5d4cf9c07c189cef9e70e8a6e6f377eb41a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600551Reviewed-by:
-
- 22 Apr, 2022 20 commits
-
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.fields Bug: v8:11544 Change-Id: I8df987ddbbf08372da637d7c4620c428fce97cae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3534619Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#80127}
-
Frank Tang authored
Use the new ICU 71-1 API Precision::incrementExact https://unicode-org.github.io/icu-docs/apidoc/dev/icu4c/classicu_1_1number_1_1Precision.html#aedfb413e5a37c69868594c870a87134b Change-Id: I6d8841e5a07972d1be36026ce150eb83dbf300e7 Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3430378Reviewed-by:
-
Deepti Gandluri authored
These were originally proposed as a part of the fixed-width SIMD proposal, and were then migrated to the relaxed-simd proposal which also deems these operations out of scope. Github issue: https://github.com/WebAssembly/relaxed-simd/issues/4 Bug: v8:12284 Change-Id: I65ceb6dfd25c43cf49bd7ec5b5ecd6b32cc3516a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3595970Reviewed-by:
-
Shu-yu Guo authored
This reverts commit 370cae1d. Reason for revert: Breaking gcc and bazel builds: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20gcc%20-%20builder/1646/overview https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20bazel%20-%20builder/1714/overview Original change's description: > heap: Inline GCTracer::Scope::Name > > This is a follow-up to https://crrev.com/c/3581774. > It inlines method GCTracer::Scope::Name so that the calculation of the > name of the trace event can be performed at compile time and optimized > away, at most call sites. > > Bug: chromium:1318062 > Change-Id: I483d8fdfcc2c82c2a88d245326f27e7e787979aa > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602511 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80122} Bug: chromium:1318062 Change-Id: Ib33472a3a51fa3922a0af4d1c7dbac4b30b0098b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600682 Auto-Submit: Shu-yu Guo <syg@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shu-yu Guo <syg@chromium.org> Owners-Override: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80124}
-
Seth Brenith authored
One of the biggest categories in heap snapshots is named “(system)”, which gives developers no indication of why all that memory is used or what they might do to reduce it. In this change, I propose that we create a new category for Maps, DescriptorArrays, and related objects, and call this new category “(object shape)” in the devtools. I think that this category name would be more meaningful, while still grouping those objects together so that they mostly stay out of the way. Bug: v8:12769 Doc: https://docs.google.com/document/d/1a-6V_2LIJuRcsppwh6E18g8OSnC9j6gN4ao2gq--BiU Change-Id: I282a7b87c34ca6ed371ff32f3c7332d794ae42ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3587974Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#80123}
-
Nikolaos Papaspyrou authored
This is a follow-up to https://crrev.com/c/3581774. It inlines method GCTracer::Scope::Name so that the calculation of the name of the trace event can be performed at compile time and optimized away, at most call sites. Bug: chromium:1318062 Change-Id: I483d8fdfcc2c82c2a88d245326f27e7e787979aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602511Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#80122}
-
Victor Gomes authored
RegisterFrameState is a container for free registers and values. It abstracts operations for GeneralRegisters and DoubleRegisters. It will be used later to call generic functions from the allocator, depending on the register type needed. See PrintLiveRegs as an example of function reuse. Bug: v8:7700 Change-Id: If8e6cdb048c1782ca097d9bc2d810c66f680601a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596127Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#80121}
-
Leszek Swirski authored
Removes the full Smi handler from LoadField, leaving just the offset. All other handler-based decisions (inline vs out-of-line, tagged vs. double) should be done at graph building time and as separate IR nodes. Bug: v8:7700 Change-Id: I55ba49edba5ef5628d5f30fc6ba60c8774e2ef9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602510Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80120}
-
Michael Lippautz authored
Remove PENDING state as handles were always immediately transitioned into FREE or NEAR_DEATH state. Bug: v8:12672 Change-Id: I9a9d40b573e862282d41d7a4a3f9c8c8ed21b9e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599473Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80119}
-
legendecas authored
As per https://tc39.es/ecma262/#sec-hostimportmoduledynamically defined, referencingScriptOrModule in HostImportModuleDynamically can be a Script Record, a Module Record, or null. So to https://tc39.es/proposal-shadowrealm/#sec-shadowrealmimportvalue, the HostImportModuleDynamicallyCallback is been invoked with a `null` resource_name. This may not be considered a breaking change as the parameter resource_name is defined as Local<Value>. Updates d8's DoHostImportModuleDynamically to handle null resource_name, and resolve the dynamically imported specifier relative to the executing script's origin. In this way, we have to set ModuleEmbedderData.origin even if the JavaScript source to be evaluated is Script. Also, a ModuleEmbedderData is created for each ShadowRealm to separate their module maps from the initiator context's. Bug: v8:11989 Change-Id: If70fb140657da4f2dd92eedfcc4515211602aa46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3522883Reviewed-by:
-
Leszek Swirski authored
It should delegate to VisitLdaContextSlot. Bug: v8:7700 Change-Id: I1591594648cfb038abccabb46a20c1b0c23b07a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602512 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Victor Gomes authored
- Introduces an array of RegisterStates for double registers - Adds two functions to iterate over the arrays We will be able to call the ForEach functions using a templated lambda for RegisterBase<T>. Bug: v8:7700 Change-Id: I7ef86917d9377933a4bc3456e30de3e4ec547f65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596122Reviewed-by:
-
jameslahm authored
... /objects/concurrent-js-array-unittest. Bug: v8:12781 Change-Id: Ie23432df7ffa785f96684060f5f2df3716713fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600549Reviewed-by:
-
Michael Achenbach authored
Using this flag has led to several duplicate issues. We need to stop using the flag for a while until the issues are investigated. Potentially these are all false positives. No-Try: true Bug: chromium:1317880 Change-Id: I09f4e1c642befc3a8f5b88c2eb003931dc112826 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602508 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Milad Fa authored
Result of `and` is stored in cr0. Change-Id: I113ff7ceb9412d2f1f8ffdd58397123603b5818a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600550Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80113}
-
jameslahm authored
This CL extends GetIterator to check whether the result of calling @@iterator is JSReceiver and throw SymbolIteratorInvalid if it's not JSReceiver. GetIterator bytecode involves 3 steps now: - method = GetMethod(obj, @@iterator) - iterator = Call(method, obj) - if(!IsJSReceiver(iterator)) throw SymbolIteratorInvalid [Added] New Builtin: CallIteratorWithFeedbackLazyDeoptContinuation, which is used when lazy deopt is triggered by call @@iterator. Related spec: https://tc39.es/ecma262/#sec-getiterator. Related doc: https://docs.google.com/document/d/1s67HC2f-4zxA_s1Bmm7dfwMFv_KDUfMiWIKkNSeQNKw/edit#heading=h.kdzv8mq4g4ks. Bug: v8:9489 Change-Id: I17952c0f3e24e1e600ee1348809fb188c2c70f8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3563447Reviewed-by:
-
Milad Fa authored
There is currently a bug in docker where fstat may not return the correct device id and as a result a check under `OS::RemapPages, stat_buf.st_dev != enclosing_region.dev` fails, details on the bug: https://github.com/moby/moby/issues/43512 Platform specific page sizes are also defined for kMaxPageSize to fix compilation errors. Change-Id: I026609329aa6432eda4f1880a0f586c0c2162461 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3601211Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This reverts commit 267b962d. Reason for revert: Flake turned out to not be reproducible: https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8816185753319345009/overview Original change's description: > Revert "[base/platform] Simplify fast TLS on macOS" > > This reverts commit 9cdee4f4. > > Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20-%20debug/38658/overview > > Original change's description: > > [base/platform] Simplify fast TLS on macOS > > > > Since the TLS offset is constant across all supported OS releases, we > > no longer need to adjust it, nor to read it at runtime. This also aligns > > the code in V8 with what is done in Chromium. > > > > Change-Id: I0f3c54da39a776406083c897de888f06c61852b8 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599481 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Commit-Queue: Benoit Lize <lizeb@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#80106} > > Change-Id: Ie6371c2ad12ed6f63be51b819083a7c0c4e22751 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602502 > Auto-Submit: Tobias Tebbi <tebbi@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Owners-Override: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80108} Change-Id: I6c50a568751a3892b82fe2dce6fe940fce293b3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602503 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Owners-Override: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80110}
-
Victor Gomes authored
Fixes https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20gcov%20coverage/29098/overview and https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20gcc%20-%20debug%20builder/1389/overview Bug: v8:7700 Change-Id: I90717b9644b75cef28656893d37aa57e5f03e2fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599478 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This reverts commit 9cdee4f4. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20-%20debug/38658/overview Original change's description: > [base/platform] Simplify fast TLS on macOS > > Since the TLS offset is constant across all supported OS releases, we > no longer need to adjust it, nor to read it at runtime. This also aligns > the code in V8 with what is done in Chromium. > > Change-Id: I0f3c54da39a776406083c897de888f06c61852b8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599481 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Benoit Lize <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80106} Change-Id: Ie6371c2ad12ed6f63be51b819083a7c0c4e22751 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602502 Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Owners-Override: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80108}
-
