- 09 Jul, 2015 6 commits
-
-
rmcilroy authored
Review URL: https://codereview.chromium.org/1225683010 Cr-Commit-Position: refs/heads/master@{#29551}
-
bmeurer authored
The b, bl and blx methods that take labels basically ignore the constant pool check and just block the constant pool for the next instruction. This way a long enough sequence of those instructions will block can potentially block the constant pool emission for too long. BUG=v8:4292 LOG=y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1223093004 Cr-Commit-Position: refs/heads/master@{#29550}
-
yangguo authored
R=mstarzinger@chromium.org BUG=chromium:507977 LOG=N Review URL: https://codereview.chromium.org/1230653004 Cr-Commit-Position: refs/heads/master@{#29549}
-
rmcilroy authored
Use NumAllocatableRegisters() instead of kMaxNumAllocatableRegisters in ArchDefaultRegisterConfiguration::ArchDefaultRegisterConfiguration() otherwise the compiler DCHECKS if triggered during snapshot builds on Arm where only 16 DoubleRegisters are avaiable instead of 32. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1230473006 Cr-Commit-Position: refs/heads/master@{#29548}
-
bmeurer authored
That parameter is just confusing and completely unused. Review URL: https://codereview.chromium.org/1228763003 Cr-Commit-Position: refs/heads/master@{#29547}
-
yangguo authored
The invariant is that as long as there is a debug info on the shared function info, no accessor IC is compiled for its code. That way we can guarantee that stepping into accessors, which requires a debug info, works for accessors. Review URL: https://codereview.chromium.org/1220283009 Cr-Commit-Position: refs/heads/master@{#29546}
-
- 08 Jul, 2015 19 commits
-
-
littledan authored
The breakage to Chrome seems to be based on @@isConcatSpreadable and turning that part off with this patch fixes the Maps Tips & Tricks test case. BUG=chromium:507553 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1226063002 Cr-Commit-Position: refs/heads/master@{#29545}
-
adamk authored
Revert of [turbofan] Optimize string "length" property access based on types. (patchset #2 id:20001 of https://codereview.chromium.org/1216593003/) Reason for revert: Causes crash when running benchmarks/octane/regexp.js on ARM: http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2492/steps/Benchmarks/logs/regexp Original issue's description: > [turbofan] Optimize string "length" property access based on types. > > Optimize string "length" property access based on static type > information if possible, but also optimistically optimize the access > based on type feedback from the LoadIC. > > R=jarin@chromium.org > > Committed: https://crrev.com/17add22ff4b9c5ca638502e7708f0d9d99baca40 > Cr-Commit-Position: refs/heads/master@{#29543} TBR=mstarzinger@chromium.org,jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1224083002 Cr-Commit-Position: refs/heads/master@{#29544}
-
bmeurer authored
Optimize string "length" property access based on static type information if possible, but also optimistically optimize the access based on type feedback from the LoadIC. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1216593003 Cr-Commit-Position: refs/heads/master@{#29543}
-
mbrandy authored
Port 8f13b655 Original commit message: - Add a TurboFanIC class, derived from TurboFanCodeStub, that automatically distinguishes between versions of the IC called from optimized and unoptimized code. - Add appropriate InterfaceDescriptors for both the versions of the stub called from unoptimized and optimized code - Change the MathFloor TF stub generator to output either the for-optimized or for-unoptimized version based on the minor_key parameter. R=danno@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1207253003 Cr-Commit-Position: refs/heads/master@{#29542}
-
binji authored
This one occurred when serializing an object. When the property getter threw an exception, that value was skipped, but the property count wasn't updated. The deserializer then tried to deserialize the wrong value. BUG=chromium:506549 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1220193004 Cr-Commit-Position: refs/heads/master@{#29541}
-
caitpotter88 authored
BUG=508074 LOG=N R=arv@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1222713013 Cr-Commit-Position: refs/heads/master@{#29540}
-
danno authored
- Add a TurboFanIC class, derived from TurboFanCodeStub, that automatically distinguishes between versions of the IC called from optimized and unoptimized code. - Add appropriate InterfaceDescriptors for both the versions of the stub called from unoptimized and optimized code - Change the MathFloor TF stub generator to output either the for-optimized or for-unoptimized version based on the minor_key parameter. Committed: https://crrev.com/8f13b655b8a10dae2116dd18b32f09337bb2d410 Cr-Commit-Position: refs/heads/master@{#29534} Review URL: https://codereview.chromium.org/1225943002 Cr-Commit-Position: refs/heads/master@{#29539}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1214673007 Cr-Commit-Position: refs/heads/master@{#29538}
-
machenbach authored
BUG=chromium:508074 LOG=n NOTREECHECKS=true NOTRY=true TBR=ishell@chromium.org Review URL: https://codereview.chromium.org/1215023016 Cr-Commit-Position: refs/heads/master@{#29537}
-
arv authored
Allow let in sloppy mode with --harmony-sloppy Allow ES'15 const in sloppy mode with --harmony-sloppy --no-legacy-const Functions in block are not done yet. They are only let bound in the block at this point. BUG=v8:3305, v8:2198 LOG=N R=littledan@chromium.org, rossberg@chromium.org, adamk@chromium.org Review URL: https://codereview.chromium.org/1219853004 Cr-Commit-Position: refs/heads/master@{#29536}
-
danno authored
Revert of Add unoptimized/optimized variants of MathFloor TF code stub (patchset #4 id:60001 of https://codereview.chromium.org/1225943002/) Reason for revert: Failure on compiling runtime.js on windows Original issue's description: > Add unoptimized/optimized variants of MathFloor TF code stub > > - Add a TurboFanIC class, derived from TurboFanCodeStub, that > automatically distinguishes between versions of the IC called from > optimized and unoptimized code. > - Add appropriate InterfaceDescriptors for both the versions of the > stub called from unoptimized and optimized code > - Change the MathFloor TF stub generator to output either the > for-optimized or for-unoptimized version based on the minor_key > parameter. > > Committed: https://crrev.com/8f13b655b8a10dae2116dd18b32f09337bb2d410 > Cr-Commit-Position: refs/heads/master@{#29534} TBR=mvstanton@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1220783006 Cr-Commit-Position: refs/heads/master@{#29535}
-
danno authored
- Add a TurboFanIC class, derived from TurboFanCodeStub, that automatically distinguishes between versions of the IC called from optimized and unoptimized code. - Add appropriate InterfaceDescriptors for both the versions of the stub called from unoptimized and optimized code - Change the MathFloor TF stub generator to output either the for-optimized or for-unoptimized version based on the minor_key parameter. Review URL: https://codereview.chromium.org/1225943002 Cr-Commit-Position: refs/heads/master@{#29534}
-
mbrandy authored
Port 4b38c158 Original commit message: We actually need round to zero truncation to implement the counterpart of LDoubleToI in TurboFan, which tries to convert a double to an integer as required for keyed load/store optimizations. Drive-by-cleanup: Reduce some code duplication in the InstructionSelector implementations. R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1220373003 Cr-Commit-Position: refs/heads/master@{#29533}
-
ishell authored
BUG=chromium:508074 LOG=N Review URL: https://codereview.chromium.org/1217493005 Cr-Commit-Position: refs/heads/master@{#29532}
-
machenbach authored
This prepares for making multiple measurements of one trace. For this, the suite/trace configurations need to be independent of the measurement instances. BUG=chromium:507213 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1227033002 Cr-Commit-Position: refs/heads/master@{#29531}
-
ishell authored
BUG=chromium:506956, chromium:505907 LOG=N Review URL: https://codereview.chromium.org/1215463012 Cr-Commit-Position: refs/heads/master@{#29530}
-
jkummerow authored
Smi immediates are not supported, so instructions with Smi representations need their constants in a register. LAddI has already been doing this. The manifestation of the bug was that an operation would compute 0 instead of the correct result. BUG=chromium:478612 LOG=y R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1224623017 Cr-Commit-Position: refs/heads/master@{#29529}
-
verwaest authored
BUG=chromium:507767 LOG=n Review URL: https://codereview.chromium.org/1224853003 Cr-Commit-Position: refs/heads/master@{#29528}
-
bmeurer authored
We actually need round to zero truncation to implement the counterpart of LDoubleToI in TurboFan, which tries to convert a double to an integer as required for keyed load/store optimizations. Drive-by-cleanup: Reduce some code duplication in the InstructionSelector implementations. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1225993002 Cr-Commit-Position: refs/heads/master@{#29527}
-
- 07 Jul, 2015 15 commits
-
-
arv authored
This flag is on by default but it will allow us to turn that off in favor of harmony-sloppy in the future. BUG=v8:3305, v8:2198 LOG=N R=littledan@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1218803006 Cr-Commit-Position: refs/heads/master@{#29526}
-
machenbach authored
Revert of [d8] bounds-check before getting Shell::Worker internal field (patchset #4 id:80001 of https://codereview.chromium.org/1214053004/) Reason for revert: [Sheriff] Fails here: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/4737 Original issue's description: > [d8] bounds-check before getting Shell::Worker internal field > > Prevents fatal error in debug builds > > BUG=v8:4271 > R=binji@chromium.org > LOG=N > > Committed: https://crrev.com/43ce9c6f101c4224addd9a54e0c39963188dc7fa > Cr-Commit-Position: refs/heads/master@{#29524} TBR=binji@chromium.org,jochen@chromium.org,adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4271 Review URL: https://codereview.chromium.org/1215333012 Cr-Commit-Position: refs/heads/master@{#29525}
-
caitpotter88 authored
Prevents fatal error in debug builds BUG=v8:4271 R=binji@chromium.org LOG=N Review URL: https://codereview.chromium.org/1214053004 Cr-Commit-Position: refs/heads/master@{#29524}
-
adamk authored
Review URL: https://codereview.chromium.org/1215383002 Cr-Commit-Position: refs/heads/master@{#29523}
-
arv authored
BUG=N LOG=N R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1226443004 Cr-Commit-Position: refs/heads/master@{#29522}
-
verwaest authored
Review URL: https://codereview.chromium.org/1218663009 Cr-Commit-Position: refs/heads/master@{#29521}
-
ishell authored
Review URL: https://codereview.chromium.org/1222203007 Cr-Commit-Position: refs/heads/master@{#29520}
-
rmcilroy authored
The RawMachineAssembler will be used to build the interpreter, so it needs to move back to src/compiler. This reverts commit b5b00cc0. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1221303014 Cr-Commit-Position: refs/heads/master@{#29519}
-
yangguo authored
If we compile handlers to call accessors, Debug::HandleStepIn won't get called. Therefore we need to clear ICs each time. This has not been necessary before because we used to patch ICs for breaking, and restored them with cleared ICs. This is no longer the case. We do not use ICs for breaking anymore, so they are not implicitly cleared any longer. R=mvstanton@chromium.org BUG=v8:4269 LOG=N Review URL: https://codereview.chromium.org/1212253009 Cr-Commit-Position: refs/heads/master@{#29518}
-
arv authored
Revert "Revert of [test262-es6] Update to 2011-06-29 (patchset #1 id:1 of https://codereview.chromium.org/1220793005/)" This reverts commit f50fff57. BUG=N LOG=N R=littledan@chromium.org, machenbach@chromium.org Review URL: https://codereview.chromium.org/1212723004 Cr-Commit-Position: refs/heads/master@{#29517}
-
mstarzinger authored
This removes various boilouts for super constructor calls from the TurboFan pipeline and unifies them. It also disables and optimization which breaks references to uninitialized const this variables. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1222843004 Cr-Commit-Position: refs/heads/master@{#29516}
-
ulan authored
disregarding the allocation throughput. BUG=chromium:506132 LOG=NO Review URL: https://codereview.chromium.org/1213313004 Cr-Commit-Position: refs/heads/master@{#29515}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1224643004 Cr-Commit-Position: refs/heads/master@{#29514}
-
machenbach authored
BUG=v8:4254 LOG=n NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1220333004 Cr-Commit-Position: refs/heads/master@{#29513}
-
ulan authored
This reverts commit 26991892. This reverts commit 435b3c87. The failing test is fixing in chromium. BUG=chromium:490559 LOG=NO TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/1208993009 Cr-Commit-Position: refs/heads/master@{#29512}
-