- 23 May, 2017 1 commit
-
-
bmeurer authored
Previously the inlining of accessors into try-blocks (i.e. try/catch, try/finally, for-of, etc.) was disabled in JSNativeContextSpecialization, which prevented a couple of interesting optimizations, i.e. we end up with a LOAD_IC in optimized code for this simple example: class A { get x() { return 1; } } function foo(a) { try { return a.x; } catch (e) { return 0; } } foo(new A) This is now fixed and the accessors are properly rewired into the handler chain. BUG=v8:6278,v8:6344,v8:6424 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2902533003 Cr-Commit-Position: refs/heads/master@{#45485}
-
- 02 May, 2017 1 commit
-
-
Wiktor Garbacz authored
BUG=v8:6325 Change-Id: I5a638c47b33d6e75d31f020c499ffd084348fea4 Reviewed-on: https://chromium-review.googlesource.com/489505 Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#45010}
-
- 15 Feb, 2017 1 commit
-
-
ishell@chromium.org authored
BUG= Change-Id: I859fef6b18e51cca80343a89e2b6f38eee95d408 Reviewed-on: https://chromium-review.googlesource.com/442428 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#43206}
-
- 17 Aug, 2012 1 commit
-
-
svenpanne@chromium.org authored
Highlights of this CL: * Introduced a new opcode in the deoptimizer for a setter stub frame. * Added a global setter stub for returning after deoptimizing a setter. * We do not need special deopt support for getters, although the getter stub creates an internal frame. The normal machinery works just right for this case, although we generate a stack that can never occur during normal fullcode execution. If this hurts us one day, we can parameterize and reuse the setter deopt machinery. Review URL: https://chromiumcodereview.appspot.com/10855098 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12328 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Aug, 2012 1 commit
-
-
svenpanne@chromium.org authored
Currently only simple setter calls are handled (i.e. no calls in count operations or compound assignments), and deoptimization in the setter is not handled at all. Because of the latter, we temporarily hide this feature behind the --inline-accessors flag, just like inlining getters. We now use an enum everywhere we depend on the handling of a return value, passing around several boolean would be more confusing. Made VisitReturnStatement and the final parts of TryInline more similar, so matching them visually is a bit easier now. Simplified the signature of AddLeaveInlined, the target of the HGoto can simply be retrieved from the function state. Review URL: https://chromiumcodereview.appspot.com/10836133 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12286 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-