Commits · 9070615980bb3ba027a7e8fd5665027e97e59a88 · Linshizhi / V8

28 Jan, 2014 11 commits

Fix for potential issue related to replacing CheckMaps with values. · 90706159

ishell@chromium.org authored Jan 28, 2014

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/134733007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18887 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

90706159

Flow engine fixes: unreachable block processing, state merging. · 5dafb426

ishell@chromium.org authored Jan 28, 2014

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/144013003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18885 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5dafb426

Load elimination fix with a test case. · d330d480

ishell@chromium.org authored Jan 28, 2014

R=titzer@chromium.org, verwaest@chromium.org

Review URL: https://codereview.chromium.org/143413019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18884 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d330d480

Allocation site pretenuring for StringAdd on all platforms. · a09a5a86

hpayer@chromium.org authored Jan 28, 2014

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/147763005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18882 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a09a5a86

Drop the native FastNewBlockContextStub. · a2d1f8b8

bmeurer@chromium.org authored Jan 28, 2014

This code is almost never executed in real world and benchmarks,
and there's obviously absolutely no need to have this native code
hanging around for no benefit.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/148873002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18880 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a2d1f8b8

We shouldn't throw under FLAG_debug_code, rather abort. · 371d6f6a

mvstanton@chromium.org authored Jan 28, 2014

Throwing under FLAG_debug_code confuses the rest of our infrastructure
which expects a safe point at the site of call into the runtime
for throw. We were doing that to make a clusterfuzz test happy, but
the better solution is to assert/abort under debug_code, and prevent
clusterfuzz from fuzzing on internal APIs that crash on incorrect
values.

We'll need to alter the fuzzer to turn off fuzzing for:

string-natives.js
lithium/SeqStringSetChar.js
regress/regress-seqstrsetchar-ex3.js
regress/regress-seqstrsetchar-ex1.js
regress/regress-crbug-320922.js

So as to prevent the fuzzer from running
%_OneByteSeqStringSetChar() and
%_TwoByteSeqStringSetChar().

BUG=
R=hpayer@chromium.org, machenbach@chromium.org

Review URL: https://codereview.chromium.org/139903005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18878 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

371d6f6a

Make `String.prototype.{starts,ends}With` throw when passing a regular expression · 1776dffa

ishell@chromium.org authored Jan 28, 2014

Contributed by Mathias Bynens <mathiasb@opera.com>.

TEST=mjsunit/harmony
BUG=v8:3070
LOG=Y
R=arv@chromium.org, ishell@chromium.org

Review URL: https://codereview.chromium.org/120683002

Patch from Mathias Bynens <mathiasb@opera.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18870 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1776dffa

Turn off global pretenuring when allocation site pretenuring is in use. · 9e462504

hpayer@chromium.org authored Jan 28, 2014

BUG=
R=mstarzinger@chromium.org, mvstanton@chromium.org

Review URL: https://codereview.chromium.org/133803002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9e462504

Remove obsolete instruction HOuterContext. · f9575fb8

bmeurer@chromium.org authored Jan 28, 2014

HOuterContext can be expressed in terms of HLoadNamedField.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/131513015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18867 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f9575fb8

Prepare push to trunk. Now working on version 3.24.26. · 577b2de2

machenbach@chromium.org authored Jan 28, 2014

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/148173008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18864 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

577b2de2

MIPS: stub fast api calls · e5a534f3

palfia@homejinni.com authored Jan 28, 2014

Port r18847 (c920fc50)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/145583012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18863 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e5a534f3

27 Jan, 2014 12 commits

[Sheriff] Fix status file entry. · fd4a006e

machenbach@chromium.org authored Jan 27, 2014

BUG=
TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/148183007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18861 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fd4a006e

Skip regression test 320948 temporarily. · e624346e

hpayer@chromium.org authored Jan 27, 2014

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/131503008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18859 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e624346e

Enable concurrent sweeping. · 86cf9ca6

hpayer@chromium.org authored Jan 27, 2014

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/146833012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18855 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

86cf9ca6

Hydrogen filter now supports trailing wildcard in negative filter. · 7c459465

ishell@chromium.org authored Jan 27, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/145663008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18851 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7c459465

fix windows after r18847 · 2c5c0817

dcarney@chromium.org authored Jan 27, 2014

TBR=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/145353005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18850 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2c5c0817

don't anger clang · d2a4bd32

dcarney@chromium.org authored Jan 27, 2014

R=svenpanne@chromium.org

BUG=

Review URL: https://codereview.chromium.org/141433016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18848 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d2a4bd32

stub fast api calls · d1a10c6e

dcarney@chromium.org authored Jan 27, 2014

R=verwaest@chromium.org, vervaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/140613004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18847 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d1a10c6e

Allow arbitrary names for weak references in heap snapshots. · 89ffd305

alph@chromium.org authored Jan 27, 2014

LOG=N
BUG=
R=ulan@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/146843003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18846 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

89ffd305

Fix issue with context not being saved on x64 introduced in 144543004 · 1b30de8b

dcarney@chromium.org authored Jan 27, 2014

TBR=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/143333003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18845 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1b30de8b

Revert "Allow arbitrary names for weak references in heap snapshots." · 361095d3

bmeurer@chromium.org authored Jan 27, 2014

This reverts commit r18838 for breaking build with clang. Errors are:

../../src/heap-snapshot-generator.cc:1217:53: error: empty macro arguments were standardized in C99 [-Werror,-pedantic]
    EXTRACT_CONTEXT_FIELD(OPTIMIZED_FUNCTIONS_LIST, , optimized_functions_list);
../../src/heap-snapshot-generator.cc:1218:48: error: empty macro arguments were standardized in C99 [-Werror,-pedantic]
    EXTRACT_CONTEXT_FIELD(OPTIMIZED_CODE_LIST, , optimized_code_list);
../../src/heap-snapshot-generator.cc:1219:50: error: empty macro arguments were standardized in C99 [-Werror,-pedantic]
    EXTRACT_CONTEXT_FIELD(DEOPTIMIZED_CODE_LIST, , deoptimized_code_list);
../../src/heap-snapshot-generator.cc:1220:46: error: empty macro arguments were standardized in C99 [-Werror,-pedantic]
    EXTRACT_CONTEXT_FIELD(NEXT_CONTEXT_LINK, , next_context_link);

TBR=alph@chromium.org

Review URL: https://codereview.chromium.org/145583003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18844 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

361095d3

Fix minor typos in platform-*.cc · fd8b3802

bmeurer@chromium.org authored Jan 27, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/146793002

Patch from Cosmin Truta <ctruta@blackberry.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18843 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fd8b3802

Prepare push to trunk. Now working on version 3.24.25. · 5740ebda

machenbach@chromium.org authored Jan 27, 2014

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/135533005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18840 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5740ebda

24 Jan, 2014 16 commits

MIPS: Reduce the stack requirements of GetNoCodeAgeSequence. · 387e6cc3

plind44@gmail.com authored Jan 24, 2014

Port r18815 (f93582a)

Original commit message:
Allocate the patcher object on the heap, to avoid occasional stack
overflows on QNX/ARM when entering GetNoCodeAgeSequence.

BUG=v8:3111
LOG=y
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/146993002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18839 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

387e6cc3

Allow arbitrary names for weak references in heap snapshots. · f4a470d5

alph@chromium.org authored Jan 24, 2014

LOG=N
R=ulan@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/145353003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18838 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f4a470d5

External Array renaming and boilerplate scrapping · 1a67b7f8

dslomov@chromium.org authored Jan 24, 2014

Replaced symbolic names with correct JS name (byte -> int8, unsigned int -> uint32 etc).
Using macros to scrap the boilerplate
BUG=
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/145133013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18835 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1a67b7f8

Mark weak fields of JSArrayBuffer and JSArrayBufferView as weak in heap snapshot. · 01a6c8ae

alph@chromium.org authored Jan 24, 2014

BUG=337144
LOG=N
R=ulan@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/138443009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18830 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

01a6c8ae

Delete v8_shell target now that chrome uses d8 · a3d03111

jochen@chromium.org authored Jan 24, 2014

BUG=331585
LOG=y
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/146763002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18829 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a3d03111

Simplify HUnaryMathOperation::Canonicalize. · 13395a83

svenpanne@chromium.org authored Jan 24, 2014

Made the logic architecture-independent, although we should really have some kind of instruction selection instead of trying to handle some weird cases at the hydrogen level.

Some tiny related cleanups on the way.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/141653015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18824 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13395a83

Fix HGraphBuilder::AddSimulate to pass removable down correctly · c86da7e5

vegorov@chromium.org authored Jan 24, 2014

It was passed as a position argument previously making all simulates added with it conservatively FIXED_SIMULATE.

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/146013002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18822 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c86da7e5

Use rand not random · fa0f929f

rossberg@chromium.org authored Jan 24, 2014

Should make VS happier.

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/145173012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18817 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fa0f929f

ARM: Reduce the stack requirements of GetNoCodeAgeSequence. · c19d55f8

svenpanne@chromium.org authored Jan 24, 2014

Allocate the patcher object on the heap, to avoid occasional stack
overflows on QNX/ARM when entering GetNoCodeAgeSequence.

BUG=v8:3111
LOG=y

Patch from Cosmin Truta <ctruta@blackberry.com>.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/144933002

Patch from Cosmin Truta <ctruta@blackberry.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18815 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c19d55f8

Reland ArrayPop / ArrayPush. · 21532ddf

verwaest@chromium.org authored Jan 24, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/138443012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18814 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

21532ddf

Type representation converter · 2311b678

rossberg@chromium.org authored Jan 24, 2014

R=danno@chromium.org
BUG=

Review URL: https://codereview.chromium.org/145083007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18813 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2311b678

Speed up some mjsunit test cases and clean up test expectations for arm and mips. · cde3ed1f

machenbach@chromium.org authored Jan 24, 2014

Many skipped test cases already run very fast. Removing the corresponding expectations.

BUG=
R=jkummerow@chromium.org, mvstanton@chromium.org

Review URL: https://codereview.chromium.org/138503008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cde3ed1f

Revert broken ArrayPop changes · ee4e034d

jkummerow@chromium.org authored Jan 24, 2014

This reverts:
r18749 "Reland (and fix) "Add hydrogen support for ArrayPop, and remove the handwritten call stubs."",
r18790 "Remove ArrayPush from the custom call generators, and instead call directly to the handler in crankshaft.", and
r18798 "MIPS: Remove ArrayPush from the custom call generators, and instead call directly to the handler in crankshaft."

For causing crashes on Canary.

BUG=chromium:337686
LOG=N
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/146003006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18805 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ee4e034d

Revert some movq->movp changes under the _WIN64 macro for X64 · 1a122359

haitao.feng@intel.com authored Jan 24, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/132233027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18803 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1a122359

Introduce Assembler::RelocInfoNone function for X64 · 10e04142

haitao.feng@intel.com authored Jan 24, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/140553004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

10e04142

Prepare push to trunk. Now working on version 3.24.24. · ae98a70b

machenbach@chromium.org authored Jan 24, 2014

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/146013006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18799 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ae98a70b

23 Jan, 2014 1 commit

MIPS: Remove ArrayPush from the custom call generators, and instead call... · b570073d

palfia@homejinni.com authored Jan 23, 2014

MIPS: Remove ArrayPush from the custom call generators, and instead call directly to the handler in crankshaft.

Port r18790 (0d675eeb)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/132773005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b570073d