1. 06 Dec, 2016 29 commits
  2. 05 Dec, 2016 11 commits
    • ynovikov's avatar
      Reland of [typedarrays] remove invalid optimization in NAMEConstructor()... · f5cb17a8
      ynovikov authored
      Reland of [typedarrays] remove invalid optimization in NAMEConstructor() (patchset #1 id:1 of https://codereview.chromium.org/2548583003/ )
      
      Reason for revert:
      The bot was not affected by the revert. Speculation was wrong.
      
      Original issue's description:
      > Revert of [typedarrays] remove invalid optimization in NAMEConstructor() (patchset #1 id:1 of https://codereview.chromium.org/2544503002/ )
      >
      > Reason for revert:
      > Speculative revert for causing timeouts on Win Debug gpu fyi bot
      >
      > Nothing else looks even remotely relevant in the list of changes.
      > Will reland if this doesn't fix the issues.
      >
      > BUG=670396
      >
      > Original issue's description:
      > > [typedarrays] remove invalid optimization in NAMEConstructor()
      > >
      > > Before, we were treating objects with the builtin ArrayValues iterator
      > > method as array-like, where the iterator would iterate through to the
      > > full length of the object.
      > >
      > > This optimization was not sound, because it does not ensure that the
      > > next method hasn't been modified. Even if it hasn't been modified,
      > > it's entirely possible to be modified during iteration. Thus, this
      > > optimization has been removed due to its observability.
      > >
      > > BUG=v8:5699
      > > R=littledan@chromium.org, cbruni@chromium.org
      > >
      > > Committed: https://crrev.com/77df8c67d9609ada3b7d79e8e6d33f198bbad5a1
      > > Cr-Commit-Position: refs/heads/master@{#41394}
      >
      > TBR=cbruni@chromium.org,littledan@chromium.org,caitp@igalia.com
      > # Not skipping CQ checks because original CL landed more than 1 days ago.
      > BUG=v8:5699
      >
      > Committed: https://crrev.com/0ea4a542202d501c4e550474e89512532571f3a0
      > Cr-Commit-Position: refs/heads/master@{#41461}
      
      TBR=cbruni@chromium.org,littledan@chromium.org,caitp@igalia.com,enne@chromium.org
      # Not skipping CQ checks because original CL landed more than 1 days ago.
      BUG=670396
      
      Review-Url: https://codereview.chromium.org/2553873002
      Cr-Commit-Position: refs/heads/master@{#41504}
      f5cb17a8
    • gsathya's avatar
      Object · 30b564c7
      gsathya authored
      -- New JSObject for promises: JSPromise
      
      Builtins
      -- PromiseThen TFJ
      -- PromiseCreateAndSet TFJ for internal use
      -- PerformPromiseThen TFJ for internal use
      -- PromiseInit for initial promise setup
      -- SpeciesConstructor for use in PromiseThen
      -- ThrowIfNotJSReceiver for use in SpeciesConstructor
      -- AppendPromiseCallback to update FixedArray with new callback
      -- InternalPerformPromiseThen
      
      Promises.js
      -- Cleanup unused symbols
      -- Remove PerformPromiseThen
      -- Remove PromiseThen
      -- Remove PromiseSet
      -- Remove PromiseAttachCallbacks
      
      Runtime
      -- PromiseSet to set promise inobject values
      -- Refactor functions to use FixedArrays for callbacks instead of
         JSArray
      -- Runtime_PromiseStatus to return promise status
      -- Runtime_PromiseResult to return promise result
      -- Runtime_PromiseDeferred to return deferred attached to promise
      -- Runtime_PromiseRejectReactions to return reject reactions attached
         to promise
      
      This CL results in a 13.07% improvement in the promises benchmark
      (over 5 runs).
      
      BUG=v8:5343
      
      Review-Url: https://codereview.chromium.org/2536463002
      Cr-Commit-Position: refs/heads/master@{#41503}
      30b564c7
    • cbruni's avatar
      Copy dictionary keys and values in enumeration in TransferNamedProperties · 7036eec6
      cbruni authored
      During bootstrapping when installing the global object we copy over the
      properties from the snapshotted global object to the one created from a
      provided template. Originally Genesis::TransferNamedProperties just iterated
      over the entries, making the final order hash and thus platform dependent.
      This CL fixes this by sorting the keys by enumeration index before copying them
      to the destination object and thus making the key enumaration on the global
      object platform independent.
      
      Drive-by-fix: avoid crash when printing the global object during bootstrapping.
      
      BUG=chromium:669029
      
      Review-Url: https://codereview.chromium.org/2533223002
      Cr-Commit-Position: refs/heads/master@{#41502}
      7036eec6
    • clemensh's avatar
      [debug] Remove DebugInterface class · e6bd3063
      clemensh authored
      It only contained type definitions and static functions, so we
      can also just make it a namespace.
      
      R=kozyatinskiy@chromium.org, yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2549133002
      Cr-Commit-Position: refs/heads/master@{#41501}
      e6bd3063
    • clemensh's avatar
      [wasm] Implement location from stack trace for asm.js frames · 6a8dccb1
      clemensh authored
      This avoids the crash which ClusterFuzz found, but still does not
      report the same position as without validate.asm.
      For calls like "foo()|0", we report the position of the call instead of
      the position of the "|" if ToNumber throws an error.
      
      After this CL, the correctness-fuzzer for validate-asm will probably
      find mismatches there.
      
      R=titzer@chromium.org
      BUG=chromium:670808
      
      Review-Url: https://codereview.chromium.org/2548323002
      Cr-Commit-Position: refs/heads/master@{#41500}
      6a8dccb1
    • mvstanton's avatar
      Remove FLAG_flush_optimized_code_cache · 3e46a3b7
      mvstanton authored
      It's no longer necessary, and has been off for a year.
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2553643002
      Cr-Commit-Position: refs/heads/master@{#41499}
      3e46a3b7
    • leszeks's avatar
      [ignition] Optimize jump checks to range checks · a32a67c7
      leszeks authored
      Reorders the jump bytecodes so that the majority of jump checks can be
      implemented as range checks (rather than a list of comparisons that get
      compiled to a bunch of jumps).
      
      Review-Url: https://codereview.chromium.org/2537123002
      Cr-Commit-Position: refs/heads/master@{#41498}
      a32a67c7
    • vogelheim's avatar
      Remove unused code, AstValueFactory::ConcatStrings. · 0315bfff
      vogelheim authored
      BUG=
      
      Review-Url: https://codereview.chromium.org/2545773003
      Cr-Commit-Position: refs/heads/master@{#41497}
      0315bfff
    • yangguo's avatar
      Sort native context fields alphanumerically. · cb37af88
      yangguo authored
      R=franzih@chromium.org
      
      Review-Url: https://codereview.chromium.org/2551883002
      Cr-Commit-Position: refs/heads/master@{#41496}
      cb37af88
    • neis's avatar
      [parsing] Fix bug in completion value of try-finally. · 67f1969a
      neis authored
      R=adamk@chromium.org, verwaest@chromium.org
      BUG=v8:5698
      
      Review-Url: https://codereview.chromium.org/2537413003
      Cr-Commit-Position: refs/heads/master@{#41495}
      67f1969a
    • dgozman's avatar
      [inspector] Roll inspector_protocol to c65b17da8a32bc6ab25b4ebbef1008f23c69e7d1. · 0e43c392
      dgozman authored
      Roll includes:
      - [inspector_protocol] Move imported/exported information to config options.
      - [inspector_protocol] Restructure generator code.
      
      BUG=chromium:664683
      
      Review-Url: https://codereview.chromium.org/2553513002
      Cr-Commit-Position: refs/heads/master@{#41494}
      0e43c392