- 05 Nov, 2015 31 commits
-
-
yangguo authored
R=bmeurer@chromium.org Committed: https://crrev.com/5a1e42c039ac3379ebe1e7e34fb8163e1ec1493e Cr-Commit-Position: refs/heads/master@{#31791} Committed: https://crrev.com/bf5c9af92ac0a5b7f020ac968d3d42ed06aa6144 Cr-Commit-Position: refs/heads/master@{#31805} Review URL: https://codereview.chromium.org/1428203003 Cr-Commit-Position: refs/heads/master@{#31838}
-
mstarzinger authored
Revert of [heap] Separate out optimized code map processing. (patchset #2 id:20001 of https://codereview.chromium.org/1421903012/ ) Reason for revert: Causes GC-Stress failures. Original issue's description: > [heap] Separate out optimized code map processing. > > This separates the post-processing step for optimized code maps out of > the CodeFlusher. It uses the complete SharedFunctionInfo::Iterator to > visit all candidates instead of gathering candidates during marking. > > Gathering candidates during marking no longer makes sense, now that the > majority of SharedFunctionInfo objects will hold such an optimized code > map. Also it reduces complexity of the implementation. Also conflating > this mechanism with "code flushing" was confusing. > > This reverts commit b6644e84. > > R=ulan@chromium.org > > Committed: https://crrev.com/bb7a5eb2d89bae25f2b5ecb9515669f0ac73c111 > Cr-Commit-Position: refs/heads/master@{#31836} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1412063012 Cr-Commit-Position: refs/heads/master@{#31837}
-
mstarzinger authored
This separates the post-processing step for optimized code maps out of the CodeFlusher. It uses the complete SharedFunctionInfo::Iterator to visit all candidates instead of gathering candidates during marking. Gathering candidates during marking no longer makes sense, now that the majority of SharedFunctionInfo objects will hold such an optimized code map. Also it reduces complexity of the implementation. Also conflating this mechanism with "code flushing" was confusing. This reverts commit b6644e84. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1421903012 Cr-Commit-Position: refs/heads/master@{#31836}
-
pkotwicz authored
The new GN rule will enable removal of code which copies natives_blob.bin and snapshot_blob.bin in Android GN code (for instance "copy_content_shell_assets"). BUG=547162 LOG=Y Review URL: https://codereview.chromium.org/1412333005 Cr-Commit-Position: refs/heads/master@{#31835}
-
adamk authored
Reland try/catch destructuring with a fix for the MemorySanitizer failure: initialization_pos needs to be initialized in the DeclarationDescriptor. This is a one line fix to http://crrev.com/a316db995e6e4253664920652ed4e5a38b2caeba BUG=v8:811 LOG=y Review URL: https://codereview.chromium.org/1411323008 Cr-Commit-Position: refs/heads/master@{#31834}
-
hablich authored
We are creating a lot of tags. The result is that git 'packs' some of them. Our parsers in the release script cannot handle this. R=machenbach@chromium.org LONG=N NOTRY=true Review URL: https://codereview.chromium.org/1403293009 Cr-Commit-Position: refs/heads/master@{#31833}
-
hablich authored
Revert of [heap] Separate out optimized code map processing. (patchset #3 id:40001 of https://codereview.chromium.org/1426953006/ ) Reason for revert: Breaks build: https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3565 Original issue's description: > [heap] Separate out optimized code map processing. > > This separates the post-processing step for optimized code maps out of > the CodeFlusher. It uses the complete SharedFunctionInfo::Iterator to > visit all candidates instead of gathering candidates during marking. > > Gathering candidates during marking no longer makes sense, now that the > majority of SharedFunctionInfo objects will hold such an optimized code > map. Also it reduces complexity of the implementation. Also conflating > this mechanism with "code flushing" was confusing. > > R=ulan@chromium.org > > Committed: https://crrev.com/8ad6168d197dd167235c9d342ec7ce37b0daa88b > Cr-Commit-Position: refs/heads/master@{#31830} TBR=ulan@chromium.org,yangguo@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1434503003 Cr-Commit-Position: refs/heads/master@{#31832}
-
mbrandy authored
Port ab840259 Also: - Fix big-endian compiler hints BYTE_OFFSET macro. - Clean up PPC code access to compiler hints -- which required some new SharedFunctionInfo fields to encapsulate kCompilerHintsSmiTagSize. Original commit message: The current implementation of classes throws the TypeError at the wrong point, after activating a new context when directly calling a class constructor. According to the spec, the TypeError has to be thrown in the caller context. R=bmeurer@chromium.org, cbruni@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com LOG=N BUG=v8:4428 Review URL: https://codereview.chromium.org/1423713014 Cr-Commit-Position: refs/heads/master@{#31831}
-
mstarzinger authored
This separates the post-processing step for optimized code maps out of the CodeFlusher. It uses the complete SharedFunctionInfo::Iterator to visit all candidates instead of gathering candidates during marking. Gathering candidates during marking no longer makes sense, now that the majority of SharedFunctionInfo objects will hold such an optimized code map. Also it reduces complexity of the implementation. Also conflating this mechanism with "code flushing" was confusing. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1426953006 Cr-Commit-Position: refs/heads/master@{#31830}
-
ishell authored
Review URL: https://codereview.chromium.org/1416243009 Cr-Commit-Position: refs/heads/master@{#31829}
-
bmeurer authored
These intrinsics are completely unused and there doesn't seem to an actual use case for it in the future. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1418663011 Cr-Commit-Position: refs/heads/master@{#31828}
-
bmeurer authored
This inserts a new bit set type Function, which is used to represent JSFunctions, and uses that type in typed lowering to optimize calls to use the CallFunction builtin directly. Also allows for better typing of the typeof operator, which can infern "function" for JSFunctions properly. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1410343016 Cr-Commit-Position: refs/heads/master@{#31827}
-
verwaest authored
Depends on https://codereview.chromium.org/1407373007/ After that CL, all receiver conversion is handled by the call builtin. BUG= Review URL: https://codereview.chromium.org/1414883011 Cr-Commit-Position: refs/heads/master@{#31826}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1412243017 Cr-Commit-Position: refs/heads/master@{#31825}
-
yangguo authored
R=littledan@chromium.org BUG=v8:3715, v8:4528 LOG=Y Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 Cr-Commit-Position: refs/heads/master@{#31753} Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 Cr-Commit-Position: refs/heads/master@{#31773} Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9 Cr-Commit-Position: refs/heads/master@{#31782} Committed: https://crrev.com/152163c1646b45f5fc5d31a4ec2eb55d7f4a2ffc Cr-Commit-Position: refs/heads/master@{#31804} Review URL: https://codereview.chromium.org/1419823010 Cr-Commit-Position: refs/heads/master@{#31824}
-
verwaest authored
This fixes receiver conversion since the Call builtin does it correctly. BUG=v8:4526 LOG=n Review URL: https://codereview.chromium.org/1407373007 Cr-Commit-Position: refs/heads/master@{#31823}
-
bmeurer authored
The %_StringAdd intrinsic is not used anymore, so no need to keep the code around. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1420283019 Cr-Commit-Position: refs/heads/master@{#31822}
-
bmeurer authored
The %_CallFunction doesn't implement the call sequence properly, it doesn't do the receiver wrapping, nor does it check for classConstructor. Also the eager deoptimization for %_CallFunction was seriously b0rked (we must have been lucky with TurboFan so far). R=yangguo@chromium.org BUG=v8:4413 LOG=n Review URL: https://codereview.chromium.org/1419813010 Cr-Commit-Position: refs/heads/master@{#31821}
-
bmeurer authored
TurboFan didn't fully support the relevant ES6 type conversion intrinsics like %_ToNumber, %_ToLength, %_ToName, %_ToString and %_ToInteger until now, we always went to the runtime instead. These intrinsics are now well supported in TurboFan, and we are even able to generate quite decent code in some cases. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1428243003 Cr-Commit-Position: refs/heads/master@{#31820}
-
ishell authored
Review URL: https://codereview.chromium.org/1425013006 Cr-Commit-Position: refs/heads/master@{#31819}
-
yangguo authored
Revert of Implement flag and source getters on RegExp.prototype. (patchset #6 id:110001 of https://codereview.chromium.org/1419823010/ ) Reason for revert: browser_tests failure with --gtest_filter=ExternallyConnectableMessagingTest.EnablingAndDisabling Original issue's description: > Implement flag and source getters on RegExp.prototype. > > R=littledan@chromium.org > BUG=v8:3715, v8:4528 > LOG=Y > > Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 > Cr-Commit-Position: refs/heads/master@{#31753} > > Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 > Cr-Commit-Position: refs/heads/master@{#31773} > > Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9 > Cr-Commit-Position: refs/heads/master@{#31782} > > Committed: https://crrev.com/152163c1646b45f5fc5d31a4ec2eb55d7f4a2ffc > Cr-Commit-Position: refs/heads/master@{#31804} TBR=littledan@chromium.org,jochen@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3715, v8:4528 Review URL: https://codereview.chromium.org/1426413002 Cr-Commit-Position: refs/heads/master@{#31818}
-
yangguo authored
Revert of Use in-object fields instead of private symbols for regexp slots. (patchset #4 id:60001 of https://codereview.chromium.org/1428203003/ ) Reason for revert: browser_tests failure with --gtest_filter=ExternallyConnectableMessagingTest.EnablingAndDisabling Original issue's description: > Use in-object fields instead of private symbols for regexp slots. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/5a1e42c039ac3379ebe1e7e34fb8163e1ec1493e > Cr-Commit-Position: refs/heads/master@{#31791} > > Committed: https://crrev.com/bf5c9af92ac0a5b7f020ac968d3d42ed06aa6144 > Cr-Commit-Position: refs/heads/master@{#31805} TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1432453005 Cr-Commit-Position: refs/heads/master@{#31817}
-
caitpotter88 authored
Fix an earlier regression which forbid non-VariableProxy LHS from being used in for-of loops. Like for-in loops, the spec allows any LHS to be used, with the sole exception that ObjectLiterals and ArrayLiterals must be valid AssignmentPatterns. Also fixes a bug in TurboFan which resulted in incorrectly replacing a variable load with a constant value in some instances, due to the AstLoopAssignmentAnalyzer failing to record the assignment to ForOfStatement's value. BUG=v8:4418, v8:2720 LOG=N R=wingo@igalia.com, littledan@chromium.org, adamk@chromium.org, bmeurer@chromium.org Review URL: https://codereview.chromium.org/1411873004 Cr-Commit-Position: refs/heads/master@{#31816}
-
zhengxing.li authored
port ab840259 (r31790). original commit message: The current implementation of classes throws the TypeError at the wrong point, after activating a new context when directly calling a class constructor. According to the spec, the TypeError has to be thrown in the caller context. BUG= Review URL: https://codereview.chromium.org/1419793007 Cr-Commit-Position: refs/heads/master@{#31815}
-
ofrobots authored
Expose the steps for incremental marking and idle scavenge more directly in NewSpace. Adjust the NewSpace and Heap interfaces to allow callers to be more clear about how they are interacting with inline allocation steps. This refactor prepares the ground for more consumers of inline allocation steps (e.g. sampling heap profiler.) R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/1404523002 Cr-Commit-Position: refs/heads/master@{#31814}
-
v8-autoroll authored
Rolling v8/third_party/icu to 42c58d4e49f2250039f0e98d43e0b76e8f5ca024 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1420993008 Cr-Commit-Position: refs/heads/master@{#31813}
-
chunyang.dai authored
This CL is a fix for https://codereview.chromium.org/1411223010. (X87: fix the deoptimization issue.). ArchDeoptimize instruction may contains duplicated x87 double register as input parameters. So the scope check is not correct. BUG= Review URL: https://codereview.chromium.org/1415023007 Cr-Commit-Position: refs/heads/master@{#31812}
-
paul.lind authored
Fix typos in big-endian BYTE_OFFSET macro. BUG= Review URL: https://codereview.chromium.org/1433543002 Cr-Commit-Position: refs/heads/master@{#31811}
-
littledan authored
This patch moves ES2015 ToLength semantics on array operations, etc to from staging to shipping. R=adamk BUG=v8:3087 LOG=Y Review URL: https://codereview.chromium.org/1433473003 Cr-Commit-Position: refs/heads/master@{#31810}
-
littledan authored
The maximum indexed element size is maxUint32-1, not maxUint32, because the maximum length of elements is maxUint32. This patch tweaks the limit to switch to named properties as appropriate. BUG=v8:4516 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1431503002 Cr-Commit-Position: refs/heads/master@{#31809}
-
chunyang.dai authored
The CL https://codereview.chromium.org/1409013004 added / changed some test cases. Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type case to keep the same precision. float expect = *i * *j; // *i + *j, etc. For test case "RunFloat64MulAndFloat64Add1 / RunFloat64MulAndFloat64Add2 / RunFloat64MulAndFloat64Sub1 / RunFloat64MulAndFloat64Sub2", the expected result calcaulated by GCC has difference precsion when comparing with V8 turbofan result for X87 platform. (Turbofan X87 result is the same as IA32 GCC and IA32 Turbofan). So we have to disable those four cases for X87 port. BUG= Review URL: https://codereview.chromium.org/1430943002 Cr-Commit-Position: refs/heads/master@{#31808}
-
- 04 Nov, 2015 9 commits
-
-
paul.lind authored
From 41f3e782. BUG= Review URL: https://codereview.chromium.org/1431843002 Cr-Commit-Position: refs/heads/master@{#31807}
-
dusan.m.milosavljevic authored
TEST=cctest/test-run-machops/Float(64|32)MaxP, Float(64|32)MinP, unittests/InstructionSelectorTest.Float64Min|Max BUG=v8:4206 LOG=N Review URL: https://codereview.chromium.org/1419753008 Cr-Commit-Position: refs/heads/master@{#31806}
-
yangguo authored
R=bmeurer@chromium.org Committed: https://crrev.com/5a1e42c039ac3379ebe1e7e34fb8163e1ec1493e Cr-Commit-Position: refs/heads/master@{#31791} Review URL: https://codereview.chromium.org/1428203003 Cr-Commit-Position: refs/heads/master@{#31805}
-
yangguo authored
R=littledan@chromium.org BUG=v8:3715, v8:4528 LOG=Y Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 Cr-Commit-Position: refs/heads/master@{#31753} Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 Cr-Commit-Position: refs/heads/master@{#31773} Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9 Cr-Commit-Position: refs/heads/master@{#31782} Review URL: https://codereview.chromium.org/1419823010 Cr-Commit-Position: refs/heads/master@{#31804}
-
rmcilroy authored
Avoid double incrementing the variable in the U16() macro. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1431803004 Cr-Commit-Position: refs/heads/master@{#31803}
-
caitpotter88 authored
Emit an early error when BindingPatterns are used in a VariableDeclaration or LexicalBinding without an Initializer. BUG=v8:4532 LOG=N R=adamk@chromium.org, rossberg@chromium.org, wingo@igalia.com Review URL: https://codereview.chromium.org/1416753009 Cr-Commit-Position: refs/heads/master@{#31802}
-
hablich authored
Revert of Implement flag and source getters on RegExp.prototype. (patchset #6 id:110001 of https://codereview.chromium.org/1419823010/ ) Reason for revert: Breaks Chromium tests and blocks the roll: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/124490 Original issue's description: > Implement flag and source getters on RegExp.prototype. > > R=littledan@chromium.org > BUG=v8:3715, v8:4528 > LOG=Y > > Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 > Cr-Commit-Position: refs/heads/master@{#31753} > > Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 > Cr-Commit-Position: refs/heads/master@{#31773} > > Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9 > Cr-Commit-Position: refs/heads/master@{#31782} TBR=littledan@chromium.org,jochen@chromium.org,ulan@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3715, v8:4528 Review URL: https://codereview.chromium.org/1432683002 Cr-Commit-Position: refs/heads/master@{#31801}
-
hablich authored
Revert of Use in-object fields instead of private symbols for regexp slots. (patchset #4 id:60001 of https://codereview.chromium.org/1428203003/ ) Reason for revert: A clean revert of https://codereview.chromium.org/1419823010/ was not possible because of this CL. Thus, I am also reverting this CL. Original issue's description: > Use in-object fields instead of private symbols for regexp slots. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/5a1e42c039ac3379ebe1e7e34fb8163e1ec1493e > Cr-Commit-Position: refs/heads/master@{#31791} TBR=bmeurer@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1421593009 Cr-Commit-Position: refs/heads/master@{#31800}
-
mstarzinger authored
This deprecates the ability of the raw machine assembler to utilize the CallFunctionStub in preparation of the stub itself being deprecated. We only used this to test instruction selection of calls to stubs that can deoptimize, the test has been adapted. R=verwaest@chromium.org TEST=unittests/InstructionSelectorTest Review URL: https://codereview.chromium.org/1408193006 Cr-Commit-Position: refs/heads/master@{#31799}
-