- 14 Apr, 2016 19 commits
-
-
zhengxing.li authored
port f954934d (r35140) original commit message: BUG= Review URL: https://codereview.chromium.org/1886243002 Cr-Commit-Position: refs/heads/master@{#35476}
-
mythria authored
Removes skips for two tests that no longer fail on windows system. Updates description of another failing test with more details. BUG=v8:4280,v8:4680 LOG=N Review URL: https://codereview.chromium.org/1878893004 Cr-Commit-Position: refs/heads/master@{#35475}
-
mlippautz authored
To keep track of memory characteristics of a JS program use GetHeapSpaceStatistics from a combination of - a GC epilogue callback registered using AddGCEpilogueCallback - an interrupt registered using RequestInterrupt Rationale: The feature is currently broken as those callbacks are (also) executed from background threads, breaking our implicit contract for only performing callbacks on the foreground thread. Furhtermore, it's not clear for the embedder whether these allocations originate in JS, or are required for a GC. Note: - The already deprecated non-isolate versions are removed with this CL. R=jochen@chromium.org BUG=v8:4813 LOG=Y Review URL: https://codereview.chromium.org/1886573006 Cr-Commit-Position: refs/heads/master@{#35474}
-
zhengxing.li authored
port 53d51c52 (r35139) original commit message: Removed Frame::needs_frame and the function-wide logic using it in favor of FrameAccessState::has_frame, which can be set on a more granular level, and driving it block by block. BUG= Review URL: https://codereview.chromium.org/1886963002 Cr-Commit-Position: refs/heads/master@{#35473}
-
mstarzinger authored
This removes one of the duplicated pipeline implementation from the compiler. By now we can reuse the existing CompileForDebugging for all compilations being kicked off for debugging. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1885063002 Cr-Commit-Position: refs/heads/master@{#35472}
-
mstarzinger authored
The compiler hints in question are already correctly initialized by the NewSharedFunctionInfoForLiteral function. Reinitializing them again here is no longer needed by now. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1887673002 Cr-Commit-Position: refs/heads/master@{#35471}
-
machenbach authored
Port https://codereview.chromium.org/1886493002 BUG=chromium:603011, chromium:603131 LOG=n TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/1880423003 Cr-Commit-Position: refs/heads/master@{#35470}
-
bmeurer authored
At some point we thought about using this instead of JSToNumber, but now there doesn't seem to be any reason for this anymore. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1890763002 Cr-Commit-Position: refs/heads/master@{#35469}
-
verwaest authored
This should bring back the performance of speedometer-backbone at least very close to the performance before @@species. BUG=chromium:596825 LOG=n Review URL: https://codereview.chromium.org/1879053003 Cr-Commit-Position: refs/heads/master@{#35468}
-
bradnelson authored
Collecting: Time histograms for: instantiate, decode module, decode function, compile, compile function. Memory histograms for: decode peak, instantiate peak, compile function peak, min mem pages, max mem pages, function bytes, module bytes. Range histograms of: functions per module. BUG= https://code.google.com/p/v8/issues/detail?id=4203 BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=575167 TEST=None R=ahaas@chromium.org,bmeurer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1866873002 Cr-Commit-Position: refs/heads/master@{#35467}
-
ahaas authored
We use the cvttsd2si (float64-to-int32) instruction to avoid that negative numbers get sign extended in the destination register. @rodolph: Is sign extension also a thing on arm64? I noticed that also on arm64 a float64-to-int64 instruction is used. Review URL: https://codereview.chromium.org/1877133004 Cr-Commit-Position: refs/heads/master@{#35466}
-
machenbach authored
BUG=v8:4751 LOG=n NOTRY=true TBR=adamk@chromium.org, rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1891693002 Cr-Commit-Position: refs/heads/master@{#35465}
-
zhengxing.li authored
The CL #35139 (https://codereview.chromium.org/1775323002) added V8_TARGET_ARCH_IA32 macro in src/globals.h. X87 is almost same as IA32, So It needs the V8_TARGET_ARCH_X87 macro in src/globals.h too. BUG= Review URL: https://codereview.chromium.org/1886233002 Cr-Commit-Position: refs/heads/master@{#35464}
-
v8-autoroll authored
Rolling v8/build/gyp to 6ea68631cdabab9b7c5257657567a785a261692e TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1886223002 Cr-Commit-Position: refs/heads/master@{#35463}
-
mbrandy authored
Port 5e9ddf6c Original commit message: * New atomic code stubs for x64, ia32, arm, arm64 * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue to macro-assembler-ia32 (API based on x64 macro assembler) * Remove runtime implementation of Atomics.load, the code stub should always be called instead * Add new test to mjsunit atomics test; check that Smi values of different sizes are supported when possible, else fall back to HeapNumbers These changes were needed to add another codestub: * Bump kStubMajorKeyBits from 7 to 8 * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 R=binji@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG=v8:4614 LOG=N Review URL: https://codereview.chromium.org/1887823002 Cr-Commit-Position: refs/heads/master@{#35462}
-
mbrandy authored
Port 9336f4cc Original commit message: This is useful for escape analysis, and helps upcoming changes to type feedback gathering. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1883743004 Cr-Commit-Position: refs/heads/master@{#35461}
-
joransiu authored
* Use proper int64_t printf format qualifier to fix 64-bit sim compile on Mac. * Minor cleanup to ExecuteInstruction() to remove an unncessary 'processed' variable. R=jyan@ca.ibm.com,mbrandy@us.ibm.com,michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1889643002 Cr-Commit-Position: refs/heads/master@{#35460}
-
adamk authored
R=littledan@chromium.org Review URL: https://codereview.chromium.org/1836183002 Cr-Commit-Position: refs/heads/master@{#35459}
-
aseemgarg authored
BUG=v8:4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,bradnelson@chromium.org,ahaas@chromium.org LOG=N Review URL: https://codereview.chromium.org/1887833002 Cr-Commit-Position: refs/heads/master@{#35458}
-
- 13 Apr, 2016 21 commits
-
-
jyan authored
size_t defined as unsigned long on 31-bit s390. R=jochen@chromium.org, jfb@chromium.org TBR=ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/1889623002 Cr-Commit-Position: refs/heads/master@{#35457}
-
robtsuk authored
Fixes for misnamed toolchain from https://github.com/appcelerator/v8_titanium. Added a way to specify the NDK path since the Mac versions of the NDK aren't checked into the tools repo. Disabled a few dependencies which do not build on the Mac but which aren't needed for building usable V8 static libraries. Made the including of libdl and librt omitted for Mac hosted builds. BUG= Review URL: https://codereview.chromium.org/1879793002 Cr-Commit-Position: refs/heads/master@{#35456}
-
aseemgarg authored
This change implements switch as a balanced if/else tree or break table or hybrid. A lot of asm.js modules are expected to extensively use switch alongside function tables that can benefit from a better implementation. BUG=v8:4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,bradnelson@chromium.org,ahaas@chromium.org LOG=N Review URL: https://codereview.chromium.org/1838973002 Cr-Commit-Position: refs/heads/master@{#35455}
-
mlippautz authored
Revert of [heap] Better integrate handling of aborted compaction pages (patchset #7 id:130001 of https://codereview.chromium.org/1881423003/ ) Reason for revert: Breaks: https://uberchromegw.corp.google.com/i/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/20 RecordMigratedSlotVisitor is not safe to use on code pages. Original issue's description: > [heap] Better integrate handling of aborted compaction pages > > - Get rid of fixing up pointers on the main thread > - Get rid of sweeping on the main thread > > Instead: > - Record (and process afterwards) slots in parallel > - Add the pages to the concurrent sweeper as pointers have already been fixed > > BUG=chromium:581412 > LOG=N > TEST=cctest/test-compaction/* > > Committed: https://crrev.com/2e4f57774d4993f9f98332d3b2469280ee10beca > Cr-Commit-Position: refs/heads/master@{#35451} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581412 Review URL: https://codereview.chromium.org/1890553002 Cr-Commit-Position: refs/heads/master@{#35454}
-
binji authored
Reland of (https://codereview.chromium.org/1617503003) * New atomic code stubs for x64, ia32, arm, arm64 * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue to macro-assembler-ia32 (API based on x64 macro assembler) * Remove runtime implementation of Atomics.load, the code stub should always be called instead * Add new test to mjsunit atomics test; check that Smi values of different sizes are supported when possible, else fall back to HeapNumbers These changes were needed to add another codestub: * Bump kStubMajorKeyBits from 7 to 8 * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 BUG=v8:4614 LOG=y TBR=jarin@chromium.org,bmeurer@chromium.org,rodolph.perfetta@gmail.com,machenbach@chromium.org Review URL: https://codereview.chromium.org/1617503003 Cr-Commit-Position: refs/heads/master@{#35427} Review URL: https://codereview.chromium.org/1881383003 Cr-Commit-Position: refs/heads/master@{#35453}
-
machenbach authored
BUG=chromium:603011,chromium:603131 LOG=n Review URL: https://codereview.chromium.org/1880383003 Cr-Commit-Position: refs/heads/master@{#35452}
-
mlippautz authored
- Get rid of fixing up pointers on the main thread - Get rid of sweeping on the main thread Instead: - Record (and process afterwards) slots in parallel - Add the pages to the concurrent sweeper as pointers have already been fixed BUG=chromium:581412 LOG=N TEST=cctest/test-compaction/* Review URL: https://codereview.chromium.org/1881423003 Cr-Commit-Position: refs/heads/master@{#35451}
-
Ilija.Pavlovic authored
Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. Port 52148c41 TEST= BUG= Review URL: https://codereview.chromium.org/1886723003 Cr-Commit-Position: refs/heads/master@{#35450}
-
ofrobots authored
Left trimming assumes that nobody other than the JSArray has a reference to the backing store. Sampling heap profiler may profile the backing store and keep a reference too it. This reference was never updated on a left-trim, causing a crash. R=alph@chromium.org, hpayer@chromium.org, mattloring@google.com BUG= Review URL: https://codereview.chromium.org/1885723002 Cr-Commit-Position: refs/heads/master@{#35449}
-
mlippautz authored
- Get rid of temp lists and use a lock-protected deque instead BUG= Review URL: https://codereview.chromium.org/1886723002 Cr-Commit-Position: refs/heads/master@{#35448}
-
Miran.Karic authored
Operand values in Bytecodes.DecodeBytecodeAndOperands test are encoded in little endian format. The test calls Bytecodes::Decode function which reads the operands but the values are byte swapped on big endian machines. Added big endian encoded data which decodes correctly on BE machines. BUG= Review URL: https://codereview.chromium.org/1881423002 Cr-Commit-Position: refs/heads/master@{#35447}
-
epertoso authored
Add the stubs for JavaScript's '<<', '>>' and '>>>' operators and lets Ignition make use of them in the respective bytecode handlers. Committed: https://crrev.com/599369d6b8e1a5ccdca857def06eebcbacf47dd4 Cr-Commit-Position: refs/heads/master@{#35433} Review URL: https://codereview.chromium.org/1881003002 Cr-Commit-Position: refs/heads/master@{#35446}
-
fedor authored
Despite man page documentation: -f Display the symbol table of a dynamic library flat (as one file not separate modules). `nm` on mac treats `-f` as a shorthand for `-format`. The `-f` argument does not seem to be required, so just remove it completely. (For `-format` documentation - see `nm --help` on mac). BUG= Review URL: https://codereview.chromium.org/1840633002 Cr-Commit-Position: refs/heads/master@{#35445}
-
machenbach authored
Revert of [stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs. (patchset #3 id:40001 of https://codereview.chromium.org/1881003002/ ) Reason for revert: Needed to revert https://codereview.chromium.org/1617503003 Original issue's description: > [stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs. > > Add the stubs for JavaScript's '<<', '>>' and '>>>' operators and lets Ignition make use of them in the respective bytecode handlers. > > Committed: https://crrev.com/599369d6b8e1a5ccdca857def06eebcbacf47dd4 > Cr-Commit-Position: refs/heads/master@{#35433} TBR=bmeurer@chromium.org,epertoso@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1880413002 Cr-Commit-Position: refs/heads/master@{#35444}
-
machenbach authored
Revert of [Atomics] code stubs for atomic operations (patchset #28 id:530001 of https://codereview.chromium.org/1617503003/ ) Reason for revert: [Sheriff] Roll was reverted. Please fix unused methods, see: https://codereview.chromium.org/1884913002/ https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/5585/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > [Atomics] code stubs for atomic operations > > * New atomic code stubs for x64, ia32, arm, arm64 > * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue > to macro-assembler-ia32 (API based on x64 macro assembler) > * Remove runtime implementation of Atomics.load, the code stub should always be > called instead > * Add new test to mjsunit atomics test; check that Smi values of different > sizes are supported when possible, else fall back to HeapNumbers > > These changes were needed to add another codestub: > * Bump kStubMajorKeyBits from 7 to 8 > * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 > > BUG=v8:4614 > LOG=y > > Committed: https://crrev.com/10b5febe11b318cfef130abae343183ac862e60d > Cr-Commit-Position: refs/heads/master@{#35427} TBR=jarin@chromium.org,bmeurer@chromium.org,rodolph.perfetta@gmail.com,binji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4614 Review URL: https://codereview.chromium.org/1884883003 Cr-Commit-Position: refs/heads/master@{#35443}
-
machenbach authored
TBR=hablich@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1885863003 Cr-Commit-Position: refs/heads/master@{#35442}
-
machenbach authored
Fix after https://codereview.chromium.org/1887583002/ TBR=hablich@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1881163003 Cr-Commit-Position: refs/heads/master@{#35441}
-
mvstanton authored
Visit the Optimized Code Map on first call rather than closure creation. This is useful for escape analysis, and helps upcoming changes to type feedback gathering. Adding notry due to crashed builders: NOTRY=true BUG= Committed: https://crrev.com/9336f4cc6d25d39a128176679a70dbd13a6d946e Cr-Commit-Position: refs/heads/master@{#35395} Review URL: https://codereview.chromium.org/1670143002 Cr-Commit-Position: refs/heads/master@{#35440}
-
neis authored
Annotate generator functions and loops therein with the number of contained yields. This information will eventually be used by the bytecode generator. R=bmeurer@chromium.org BUG=v8:4907 LOG=n Review URL: https://codereview.chromium.org/1877403003 Cr-Commit-Position: refs/heads/master@{#35439}
-
ssanfilippo authored
A new script, bytecode_dispatches_report.py reads the table produced when FLAG_trace_ignition_dispatches is enabled and produces either a report of top source-destination pairs, or a heatmap that can be viewed interactively and saved to file. BUG=v8:4899 LOG=N Review URL: https://codereview.chromium.org/1869423002 Cr-Commit-Position: refs/heads/master@{#35438}
-
machenbach authored
Check if a previous run left an inconsistent state behind. The check is right before trying to push a new state as then all information is available, like commit message and tag name. This is still only a band-aid. If gnumbd is down for a longer period, an unprocessed commit won't be found, but the push attempt will still fail. Review URL: https://codereview.chromium.org/1887583002 Cr-Commit-Position: refs/heads/master@{#35437}
-