- 15 Jun, 2021 25 commits
-
-
Andrew Comminos authored
To enable deallocation of CodeEntry objects after they're no longer being referenced by an active profile or alive on the heap, replace the |used| bit with a proper reference count maintained by a CodeMap. Bug: v8:11054 Change-Id: Id3d5941e509504415692f833e406ecdd2553d426 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2945541Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#75164}
-
Ross McIlroy authored
Moves TurboProp to optimize around the time of TurboFan right now, and removes some of the special-case logic we had to avoid aggressive early optimization of TurboProp. BUG=v8:9684 Change-Id: I0299408891ff6fd57e6523ff309b5f16624466a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964814 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#75163}
-
Frank Tang authored
1. Add test to ensure none of the array contains undefined 2. Calculate the fixed array size by considering the code may filter out some itmes returned by ICU. 3. Add test to check there are no undefined. 4. Add test to check the locale.timeZones return sorted array. 5. Also refactor the JSArray generation code. Bug: v8:11871 Change-Id: I8ad4a779d137d9b7e2deead7a1aa38e599e1af2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953517 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75162}
-
Camillo Bruni authored
The shorter xorl + movb instructions cause regressions. Bug: chromium:1220093 Change-Id: Ib7da0ea16669fa490b78a8095f6f3b35e972e1cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964396Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75161}
-
Michael Lippautz authored
StateBase requires a virtual destructor as it is destroyed through the base class. Failing to provide a virtual dtor leaks internal state in State (and possible in future RootState). Bug: chromium:1056170 Change-Id: I4408a57dc05fdeb81408f571dd6eb87312ba7c9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964815Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#75160}
-
Camillo Bruni authored
Long live --log-ic! Change-Id: I4d8cefd64cdbf693a868019deb2a864d43cbd2ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964393 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75159}
-
Jakob Kummerow authored
No changes to the algorithm; minor speedup due to the move from Handle<BigInt> to Digits. Bug: v8:11515 Change-Id: Id85fe4f0c276d3ad826fee79205719092d0e0715 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947412 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#75158}
-
Milad Fa authored
The boolean value is expected to be present during code generation. Change-Id: I3f9bd8f3977badd7fc7c0a716858d0d46032ae95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2963834Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75157}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Ifdc661d3f4f95d8bd0dbacdface6aed15b9f1942 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960210 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Victor Gomes authored
Command to build: `bazel build :d8` Caveats: - Needs clang - Only supports x64 on Linux - Bare V8: no Wasm and no ICU - Still needs GN to generate inspector files Bug: v8:11234 Change-Id: I6d01fecff5fba5c3582995d071692e5c6c6c6310 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960949 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75155}
-
Liu Yu authored
This CL fixes tests failure caused by register allocation conflicts. Change-Id: Ie5ba445d2e36047abf95644b613f49d3ed47315f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2963492Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#75154}
-
Leszek Swirski authored
Inline scripts share the same URL, so lookup of script by URL on them can give the wrong result. Also, their source positions are relative to the start of the HTML file, so we need to infer the starting line from the Script's compilation event. As a drive-by, fix the tooltip to lock in-place on click. Change-Id: I5db6d35b0fbd2521531e48c34dea44b43b65ca4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2963592 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Camillo Bruni authored
CodeComment nicely indents nested comments for better readable disassembled code. In addition, there are two helper macros: - ASM_CODE_COMMENT adds the current function name as comment - ASM_CODE_COMMENT_STRING macro can be used with custom strings Bug: v8:11879 Change-Id: If5ff7e315f5acebe613f24b20d34694155f928d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960888 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#75152}
-
Georg Neis authored
I don't see any reason why we need to convert the 'uninitialized' Oddball into a Smi 0 in the Smi case, nor why we need to convert the hole-NaN HeapNumber into the Oddball in the Tagged case. These are temporary anyways. Change-Id: Ifdcd67528c7b19c36a1bde11291d78c3f211897f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953291Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75151}
-
Camillo Bruni authored
- Open and focus separate views for each log entry - Map.prototype.parent is now a getter - Fix SharedLibLogEntry tooltips - Store codeEntry in IcLogEntry for linking back to code objects - New property-link-table which is used in tooltip and code-panel - Ignore right-click events in the timeline-tracks Bug: v8:10644, v8:11835 Change-Id: Id2fe5002b776adf362b1580b96082c84790a6ef0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960804Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75150}
-
Thibaud Michaud authored
Inactive live ranges are ordered by their next start, so in UpdateDeferredFixedRanges, we can stop the search for conflicts as soon as the next start is after the end of the current extent of deferred code. Bug: v8:11861 Change-Id: I114eb776c8228948ecca68d105224b121be8931b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960950Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#75149}
-
Dominik Inführ authored
This CL optimizes Heap::EnsureSweepingCompleted() by only ensure that sweeping is finished for that object's page only and not for the whole heap. For this purpose the page is removed from the sweeping_list_ and processed on the main thread. In case the object is in new space, this method will just use EnsureIterabilityCompleted() since the iterability task doesn't currently have any kind of synchronization. Also the new space will generally be much smaller. Bug: v8:11837 Change-Id: I7e878b5c84c223009fac0d58798197be5cd524e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2958488 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#75148}
-
Michael Lippautz authored
Before this CL the C strings were generated using new char[] and destroyed using delete. Fix this by avoiding a raw new[] call and directly using unique_ptr. Bug: chromium:1056170 Change-Id: I894171d58a3f7a765cdf86e07d3da2e9298a4a92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960275Reviewed-by:
-
Leszek Swirski authored
Add better support for lots of thin ticks by: * Removing stroke on ticks (so that the stroke isn't thicker than the tick itself) * Alternating colours of the ticks between light and dark (so that neighbouring ticks are still distinguishable) * Making selection drawing use isInputPending to allow faster looping over multiple ticks. Change-Id: Iaa13fe4820d3d3168e085dfc01d7581cbc1739f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959626 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: -
Santiago Aboy Solanes authored
In the same vein we did tagged stores, we can do tagged loads. As a drive-by, move GetTSANRelaxedStoreStub to CodeFactory. Bug: v8:7790, v8:11600 Change-Id: Ic1ef3245623756538eab64c3358047e3797195c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953162 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#75145}
-
Georg Neis authored
R=mvstanton@chromium.org Change-Id: Ia9b5b6e3b80334555faddd1fbc70995d414295a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960889Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75144}
-
Camillo Bruni authored
Bug: v8:11879 Change-Id: I3f2f65d38fc656155b27b8835516cbf2832bf269 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649032Reviewed-by:
-
Igor Sheludko authored
Bug: v8:11879, v8:11880 Change-Id: I6b37148ae2a971bda0cbb6636f64561ab0a02ba5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960215 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Liu Yu authored
Port 407317a2 Change-Id: I6d46b2c9b9bafb0287fa711822aac8ffdb30c7ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2962153 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b59724c..e6942ef Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/e5f25a3..6c29693 Rolling v8/third_party/aemu-linux-x64: KF0Sz0CG_sURJodN44_YMwy0VU9tagOFFB_3EDTux1kC..XSqCv80jM_M_v5sYf8LVksQaL1zsbc6Pp9y-6WBCkbsC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2f46970..e30a74f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ef579a1..3b56309 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I3b333c34f79e876889148c808c7e1aac3866cf11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2962152Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75140}
-
- 14 Jun, 2021 15 commits
-
-
Igor Sheludko authored
Bug: v8:11879 Change-Id: Ifb894d8beec6b54a9b7ff879dd4d6710306ba15b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960217 Commit-Queue: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a reland of 5d84b6cb. PS2 contains the fix for a copy&paste error in a preprocessor condition. Original change's description: > [no-wasm] Exclude trap-handler implementation > > The trap handler is only needed for WebAssembly, hence it can be > excluded in no-wasm builds (v8_enable_webassembly = false). > This makes it easier to port WebAssembly to platforms that do not need > to support WebAssembly. > > R=ahaas@chromium.org, jkummerow@chromium.org > CC=johnx@google.com > > Bug: v8:11877 > Change-Id: I25c34c2c4f1122227047e13add532ee2b9f73d2f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953285 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75101} Bug: v8:11877 Change-Id: I70dba5dc8762c65a9c751ff6619a3b0ebb542837 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960214Reviewed-by:
-
Igor Sheludko authored
This CL also removes code handler related logic from CodeFactory and removes unused CodeFactory::BinaryOperation(). Bug: v8:11879, v8:11880 Change-Id: I4ea3074b7143975bea3f9367bcab84cdfcd86827 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960948 Commit-Queue: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
Just as other skipped tests, this new test uses SAB to synchronize between Workers, thus timing (and hence amount of allocations) is nondeterministic. R=syg@chromium.org Bug: v8:11881 Change-Id: I9cd375a1f804aac4248a7c491e75a1c7c7919e82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959627Reviewed-by:
-
Thibaud Michaud authored
Relevant links: https://github.com/WebAssembly/exception-handling/issues/153 https://github.com/WebAssembly/exception-handling/pull/156 R=clemensb@chromium.org Bug: v8:8091 Change-Id: I0deeb9665c6648e643d0aa4f310b7676e1c2fa32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959624 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75135}
-
Milad Fa authored
Port 407317a2 Original Commit Message: - Convert Builtin to enum class - Change int-based builtin_index methods to use Builtin - Change Builtins::builtin to Builtins::code R=cbruni@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ic92eeea4a0d0aaf38d78a93bfbaac2bb10403dae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960908Reviewed-by:
-
Peter Kasting authored
TNode has a templated constructor from TNode<U>, but this doesn't take precedence over the auto-generated copy constructor, which results in a warning being fired. Fix by adding an explicit copy constructor that does what the templated constructor does, which in turn requires fixing some missing #includes that slipped by due to the lack of LazyTemplateChecks() in the autogenerated copy constructor. Bug: chromium:1213098 Change-Id: Iad40950261af8f88396be9227355e4e013837341 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953503Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#75133}
-
Clemens Backes authored
This reverts commit fd93f338. Reason for revert: Out of bounds errors in Unity benchmark (link is internal). Original change's description: > [wasm][liftoff] Cache the memory start register > > WebAssembly functions often have subsequent memory accesses, and each of > these memory accesses need the start address of the memory in a register. > With this CL the register with the memory start address is cached, so > only the first memory access has to load the memory start address into a > register, subsequent memory accesses can just reuse the register. > > In first measurements with the epic benchmark this reduces the size of > the generated Liftoff code by a bit more than 5%. > > R=clemensb@chromium.org > > Bug: v8:11862 > Change-Id: Ic33e7e3c00a4209570821269c728187affbeadcf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947403 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75113} Bug: v8:11862 Change-Id: I20c7e7d729cf9846499db90c02f8581d7f994ace No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960216 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75132}
-
Sathya Gunasekaran authored
Constructors define instance types for their instances while accessors define a range of permissable instance types for receiver checks.\ Bug: v8:11476 Change-Id: I48b5326ec0a4e847283c2fa5c8f1705302727453 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2821430Reviewed-by:
-
Camillo Bruni authored
improve logEntry hit testing performance fixing flame graph rendering adding some comments adding flamechart highlighting Bug: v8:10644, v8:11835 Change-Id: I2ab2f63b9e8339c6c25bb7023772fc97dfc56c2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959615 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Clemens Backes authored
Code protection scopes now work with shared code, hence the TODO can be removed. R=jkummerow@chromium.org Change-Id: I925732c653f652d4576f21e82c96c1477b11ec12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959612 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Clemens Backes authored
This configuration (PKU with fallback to mprotect) is already finched, and can hopefully be enabled by default soon. Hence stage it behind --future to get more test and fuzzer coverage. R=jkummerow@chromium.org CC=dlehmann@google.com Bug: v8:11714 Change-Id: I5c38c71582e79e3348e6296cbf175655d00a635c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959611Reviewed-by:
-
Camillo Bruni authored
- Convert Builtin to enum class - Change int-based builtin_index methods to use Builtin - Change Builtins::builtin to Builtins::code Change-Id: Id9e3bb83da97e8894ca7ca78e1e852da60675619 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2949104 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Now that try blocks don't need a catch handler, ensure that we still properly close the scope when we handle the "end" opcode. R=clemensb@chromium.org Change-Id: I012939d5b3ee9caee9275a2f0abd65e517593870 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959623Reviewed-by:
-
Leszek Swirski authored
Add a new LogEntry for sharedlib PCs Change-Id: I4f7fdca93a9905e41b73347df475dffcb84bcb89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959620 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
