- 16 Oct, 2017 27 commits
-
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Ife79f1d3c60f591c00bb1ecd340a9f1b31b02039 Reviewed-on: https://chromium-review.googlesource.com/720808Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#48598}
-
Michael Achenbach authored
NOTRY=true TBR=titzer@chromium.org Bug: chromium:775027 Change-Id: I0bd4a55e3530e1e2f26bbe416587f1421f6cdbae Reviewed-on: https://chromium-review.googlesource.com/721180Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48597}
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=marja@chromium.org Bug: v8:6837, v8:6921 Change-Id: I17cf5cbbac3d2992c3b3588cc66e8564982453b6 Reviewed-on: https://chromium-review.googlesource.com/681355Reviewed-by:Marja Hölttä <marja@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48596}
-
peterwmwong authored
- Extract core StringPrototypeRepeat code into a TFS builtin (StringRepeat) - Assumes arguments are a string and smi (no range checks) - Add StringPrototypePadStart and StringPrototypePadEnd TFJ builtins - Added StringPadAssembler to ensure common behavior - Removed functionality from string.js A quick benchmark shows significant performance gains for unoptimized code (2.1x to 2.46x) and optimized code (1.03x - 1.56x). https: //github.com/peterwmwong/v8-perf/blob/master/string-pad/README.md Bug: v8:5049 Change-Id: I6e4fe99fb62a3edb3d6906fd4f78b3576b5b0d13 Reviewed-on: https://chromium-review.googlesource.com/720067 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#48595}
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=yangguo@chromium.org Bug: v8:6837, v8:6921 Change-Id: I0c2deaea3f2ff5b5b25ba658470850534f1900ac Reviewed-on: https://chromium-review.googlesource.com/681435 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48594}
-
Junliang Yan authored
1. in AssembleMove and AssembleSwap, we need to distinguish Double and Float 2. in 32-bit mode, double needs to be counted as 2 slots in stack R=joransiu@ca.ibm.com, jbarboza@ca.ibm.com, michael_dawson@ca.ibm.com, mmallick@ca.ibm.com Bug: Change-Id: Iffe1844aa72e9d4c9492034c3df9a994e1304a27 Reviewed-on: https://chromium-review.googlesource.com/720676Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#48593}
-
Marja Hölttä authored
When skipping inner funcs is enabled, we also track variables for top level funcs. Thus, we also declared the function name for the function scope, even though it was the function scope for a function whose preparsing was aborted. This lead into declaring the function name twice. The fix is to declare the function name only in the success case. The code was "wrong" before too, but this was never a problem, since variable tracking and aborting preparsing were enabled for disjoint sets of functions (aborting preparsing only for top-level, and variable tracking for non-top-level). BUG=v8:5516,chromium:774475 Change-Id: Ie6c321cc834cd946e8843f73916fa7dd75e9cd09 Reviewed-on: https://chromium-review.googlesource.com/720920Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#48592}
-
Michael Achenbach authored
This reverts commit 56da97bb. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/15579 Original change's description: > [snapshot] Ship lazy TFJ builtins > > Design doc: goo.gl/dxkYDZ > > Bug: v8:6624 > Change-Id: I8813f79e415843ffe8d33a605a2662dbfc0c9764 > Reviewed-on: https://chromium-review.googlesource.com/674883 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Hablich <hablich@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48590} TBR=yangguo@chromium.org,hablich@chromium.org,jgruber@chromium.org Change-Id: I5513d2d20444a95937465ab86df295b031849f99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6624 Reviewed-on: https://chromium-review.googlesource.com/721079Reviewed-by:
-
Jakob Gruber authored
Design doc: goo.gl/dxkYDZ Bug: v8:6624 Change-Id: I8813f79e415843ffe8d33a605a2662dbfc0c9764 Reviewed-on: https://chromium-review.googlesource.com/674883Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#48590}
-
Ben L. Titzer authored
This is needed for proper deserialization of code and has the nice side effect of fixing the nasty race condition that led us to introducing a lock on the signature map. R=mtrofin@chromium.org CC=clemensh@chromium.org Bug: Change-Id: I6a018344ad8b58b088b20756d3b00ae08232bbb9 Reviewed-on: https://chromium-review.googlesource.com/718937 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48589}
-
Ivica Bogosavljevic authored
MachineOperatorBuilder was instantiated with default parameters and this caused unaligned memory access errors. Bug: Change-Id: Id95d074b2641ba4f002171b5c2990a520879f490 Reviewed-on: https://chromium-review.googlesource.com/720812Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Cr-Commit-Position: refs/heads/master@{#48588}
-
Leszek Swirski authored
Bug: v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I3294568a550b829b0ec90147a4cdaefe169bb7cb Reviewed-on: https://chromium-review.googlesource.com/718206Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This comment was left over in https://codereview.chromium.org/2601043002. R=machenbach@chromium.org NOTRY=true Bug: v8:6921 Change-Id: I5182fc624129948172ce436dc9b04c6fcd299d18 Reviewed-on: https://chromium-review.googlesource.com/720924Reviewed-by:
-
Clemens Hammacher authored
The readability/streams category is gone since https://codereview.chromium.org/777533005. R=machenbach@chromium.org Bug: v8:6921 Change-Id: If0e0f978275ad20278ccedcdd607c31ae30d3133 Reviewed-on: https://chromium-review.googlesource.com/720925Reviewed-by:
-
Ben L. Titzer authored
With the introduction of the WasmContext, compiled code is no longer specialized to the memory start and size (or recently, globals_start). This CL uses the same WasmContext between the interpreter and compiled code, removing the need for UpdateMemory() and cached instance info. R=clemensh@chromium.org Bug: Change-Id: I0bd52352c9b6f3029246e94e239dc29f635e7920 Reviewed-on: https://chromium-review.googlesource.com/712734 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48584}
-
Michael Achenbach authored
Also fix asan environment for testing on windows. TBR=sergiyb@chromium.org Bug: chromium:726584 Change-Id: Ic9e6afa714f4757ad1b0f2ebfa742e742e1c04b9 Reviewed-on: https://chromium-review.googlesource.com/720811 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Lippautz authored
With parallel marking enabled, both visitors have to be equal wrt. to actual visitation. The differences are captured by template parameters: - Retaining path tracing which we only do for full GCs. - Incremental marking of FixedArray. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_tsan_rel;master.tryserver.v8:v8_linux64_tsan_concurrent_marking_rel_ng;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: chromium:694255, chromium:750084 Change-Id: I177aeb0ee4f6a35e2f592ba257c9ddc14f88fd99 Reviewed-on: https://chromium-review.googlesource.com/704935 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48582}
-
Ben L. Titzer authored
This CL removes the code specialization for WASM functions that access globals. Previously, we were embedding the start address of the globals memory (globals_start) as a constant in the code, which required patching for every instance. We now put this base in to the WasmContext, which is available as a parameter to every WasmFunction. R=ahaas@chromium.org, CC=mtrofin@chromium.org Bug: Change-Id: I04bb739e898cc5a3b7dd081cc166483022d113fd Reviewed-on: https://chromium-review.googlesource.com/712595 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#48581}
-
Mike Stanton authored
They can be...eliminated. Bug: Change-Id: I234dddfb059fa15daf09c2095f1ea1813aa8428f Reviewed-on: https://chromium-review.googlesource.com/720802Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#48580}
-
Mike Stanton authored
In Array.prototype.map, we have to store the map result in an output array. If we know we are storing objects, or special objects like boolean, rather than a number, then we can reduce the amount of checks we have to do to transition the output array to the appropriate ElementsKind. Likewise, if we know we've got floating point values, we can specialize appropriately to a double array. Bug: v8:6896 Change-Id: I375daf604562b53638ea749945c1a4c907e33547 Reviewed-on: https://chromium-review.googlesource.com/711845 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Mathias Bynens authored
This patch introduces assertPromiseFulfills and assertPromiseFulfills as a replacement for assertPromiseResult because it’s more JavaScript-y. BUG=v8:6921 R=ahaas@chromium.org Also-By: ahaas@chromium.org Change-Id: I2f865dba3992ddf3b58987bf0b376d143edb5c31 Reviewed-on: https://chromium-review.googlesource.com/718746 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Michael Achenbach authored
ASAN compilation expects a blacklist file. NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:726584 Change-Id: I1755dc20d3e91f9b15f15e0d34886a4fb03d97c1 Reviewed-on: https://chromium-review.googlesource.com/720804Reviewed-by:
-
Michael Achenbach authored
Win asan needs separate "clang" config as clang is not the default on windows. TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:726584 Change-Id: Ic49eedf9a229eb3f81774c8d03c9d19ba1211c3d Reviewed-on: https://chromium-review.googlesource.com/720801Reviewed-by:
-
Michael Achenbach authored
V8 side for: https://chromium-review.googlesource.com/c/chromium/tools/build/+/720373 TBR=sergiyb@chromium.org NOTRY=true NOTREECHECKS=true Bug: chromium:726584 Change-Id: I240be307c1072a2fce354b4eda8a60e1c65b1607 Reviewed-on: https://chromium-review.googlesource.com/720796 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
When looking at /proc/self/maps, we need to take into account the offset in addition to the start and end addresses, otherwise --prof get's confused with binaries produced by lld. Change-Id: If6b484a8080a0393e91174c114dafe9a11964e8d Reviewed-on: https://chromium-review.googlesource.com/720371Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: v8:6918 Change-Id: I16d44acd8c5cf57d472e4e8ffebf08b3d316441c Reviewed-on: https://chromium-review.googlesource.com/720370Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fc1d428..0db5732 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I0fe5fdbdf90af216756c848c08d1b3b2b166c0f9 Reviewed-on: https://chromium-review.googlesource.com/720400Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#48572}
-
- 15 Oct, 2017 2 commits
-
-
Michael Achenbach authored
V8 side configs for: https://chromium-review.googlesource.com/c/chromium/tools/build/+/718938 NOTRY=true Bug: v8:6918 Change-Id: Ie375a65611c4426baafd352c0cca37d38d1a53b7 Reviewed-on: https://chromium-review.googlesource.com/718750 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#48571}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f630878..fc1d428 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/03a5bff..c0f385b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0235fed..d1283a8 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I8c2f52e0b625f79f22dee31a704edefee1676d75 Reviewed-on: https://chromium-review.googlesource.com/720398Reviewed-by:
-
- 14 Oct, 2017 5 commits
-
-
Georg Neis authored
R=gsathya@chromium.org Bug: Change-Id: I66bc6cffddea540e382b7f59f519a4d902a0c1b6 Reviewed-on: https://chromium-review.googlesource.com/712050Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#48569}
-
Sathya Gunasekaran authored
Bug: v8:6921 Change-Id: I0ce0a285181561f1940a0a1823134fbc87e698bc Reviewed-on: https://chromium-review.googlesource.com/720237 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 61292f0b. Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/18913 Original change's description: > [inspector] breakpoint after last break position should not jump to first line > > R=jgruber@chromium.org > > Bug: chromium:730177 > Change-Id: I0f3666a333604cb80bb51410c5edf2aceb0c6ef5 > Reviewed-on: https://chromium-review.googlesource.com/717717 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48556} TBR=kozyatinskiy@chromium.org,jgruber@chromium.org Change-Id: Ic4e961bf9c82e43281779c79e22660a55bfcb29d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:730177 Reviewed-on: https://chromium-review.googlesource.com/720376Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c6001bd..f630878 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/67c0157..03a5bff Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0c09c7a..0235fed TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I22871ddb4330486a03333983b9e832d071ed2720 Reviewed-on: https://chromium-review.googlesource.com/720278Reviewed-by:
-
Mike Stanton authored
We should explain why we default to StackFrame::OPTIMIZED rather than StackFrame::INTERPRETED when we don't have a great idea about what kind of frame we are looking at. Bug: Change-Id: I9d3cc84def6164ef79a4792822d52c11dfe8a448 Reviewed-on: https://chromium-review.googlesource.com/668450Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#48565}
-
- 13 Oct, 2017 6 commits
-
-
Adam Klein authored
Bug: v8:6092, v8:6921 Change-Id: I321ecc661832f2212d16260aa6b863cef56b7676 Reviewed-on: https://chromium-review.googlesource.com/719414Reviewed-by:
-
Eric Holk authored
Enabling trap handlers has been causing problems with sanitizers, stress bots, clusterfuzz, etc. Some of these fixes will require more in depth changes. In the meantime, this restores the original behavior so the bots can turn green again. This change reverts https://crrev.com/c/673548. Bug: v8:6924 Change-Id: I4277ae53bc98f9896b800d015fda2ce68ae9e6f5 Cq-Include-Trybots: master.tryserver.v8:v8_linux64_tsan_concurrent_marking_rel_ng Reviewed-on: https://chromium-review.googlesource.com/718480Reviewed-by:
-
Bill Budge authored
- Adds CodeGenerator::NeonInputOperand method for arm. - Specifies addressing mode when selecting Neon load/store. Bug: Change-Id: Iac0bb566c32882e6b9605d2978588af05493a5c7 Reviewed-on: https://chromium-review.googlesource.com/716714 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
-
Jakob Kummerow authored
As a simple and backmergeable fix for crbug.com/774459. Bug: chromium:774459 Tbr: bmeurer@chromium.org Change-Id: Ibe55ad13fe6be63a76dc3079a0288356ce35de9f Reviewed-on: https://chromium-review.googlesource.com/719461 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48561}
-
Adam Klein authored
Reuses the existing logic for BigInt.parseInt, adapted slightly to allow octal and binary radix prefixes (and to support parsing of a raw character buffer, rather than a v8::internal::String). Bug: v8:6791 Change-Id: I41904b2204721eac452e0765fa9ff0ab26ee343b Reviewed-on: https://chromium-review.googlesource.com/711334 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48560}
-
John Barboza authored
New OWNERS jbarboza and mmallick and remove bjaideep. Bug: Change-Id: I3d7b8d13cad441bd60b1d598e5553716799ef739 Reviewed-on: https://chromium-review.googlesource.com/714136Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
