- 14 Nov, 2017 17 commits
-
-
Andreas Haas authored
This CL implements the TaskRunners in the DefaultPlatform which has been added recently to the platform API. In addition I changed how task posting works on the DefaultPlatform. With this implementation the DefaultPlatform keeps one DefaultForegroundTaskRunner per isolate, plus one DefaultBackgroundTaskRunner. The DefaultPlatform owns these TaskRunners with a shared_ptr, which is also shared with any caller of GetForegroundTaskRunner or GetBackgroundTaskrunner. This CL moves the task management from the DefaultPlatform to the TaskRunners. The DefaultForegroundTaskRunner owns and manages the the task queue, the delayed task queue, and the idle task queue. The DefaultBackgroundTaskRunner owns the WorkerThread pool and the background task queue. In addition changed many Task* to std::unique_ptr<Task> to document task ownership. R=rmcilroy@chromium.org Change-Id: Ib9a01f1f45e5b48844a37d801f884210ec3f6c27 Reviewed-on: https://chromium-review.googlesource.com/753583 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49354}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I4fb315ddf9999a3e7e2306201e5ace69b4e0be4b Reviewed-on: https://chromium-review.googlesource.com/768713 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49353}
-
Toon Verwaest authored
[snapshot] Use ThinStrings instead of custom forwarding using the hashfield to deserialize internalized strings This is necessary to be able to store the string length next to the hash field in the same 64bit word on 64bit architectures. Otherwise the forwarding pointer will overwrite the length breaking heap guarantees. ThinStrings already just do the right thing, so just use that instead. Bug: v8:7065 Change-Id: I4922365e72421995cd11437cb91572ff56f8a9e8 Reviewed-on: https://chromium-review.googlesource.com/763231Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#49352}
-
Igor Sheludko authored
.. by using macros for defining field offsets. Bug: v8:5799 Change-Id: Id76e81bedb8f348b2efaa1d553bebac0ff90b474 Reviewed-on: https://chromium-review.googlesource.com/768382Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#49351}
-
Camillo Bruni authored
This partially retires --trace-parse and --trace-preparse which will be fully removed in a later CL. Drive-by-fix: make the Parser constructor arguments order more consistent. Bug: chromium:757467 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I80a688ce553adfa65ad346718604bd53a9e606a9 Reviewed-on: https://chromium-review.googlesource.com/744046 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#49350}
-
Andreas Haas authored
With this CL, {CreateDefaultPlatform} returns a unique_ptr to indicate that the caller owns the returned memory. We had several memory leaks where the memory of the DefaultPlatform did not get deallocated. In addition, the {TracingController} of the {DefaultPlatform} also gets received as a unique_ptr. Thereby we document that the {DefaultPlatform} takes ownership of the {TracingController}. Note that the memory of the {TracingController} was already owned by the {DefaultPlatform}, but it was not documented in the interface, and it was used incorrectly in tests. This CL fixes the asan issues in https://chromium-review.googlesource.com/c/v8/v8/+/753583 ([platform] Implement TaskRunners in the DefaultPlatform) R=rmcilroy@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0d1a6d3b22bb8289dc050b1977e4f58381cec675 Reviewed-on: https://chromium-review.googlesource.com/755033Reviewed-by:Adam Klein <adamk@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Camillo Bruni authored
This CL adds a very crude unittest to check that RuntimeCallStats work correctly with api callbacks present. This currently doesn't check that all parent timers (namely FunctionCallback) are handled properly. Drive-by-Fix: - Use Microseconds for all RCS timer tests - Add TestWithContext::SetGlobalProperty helper - Use explicit v8:: prefix in test-utils.{h,cc} Change-Id: I054e78abca0b87a3b9e07d3b06cccdad15403bae Reviewed-on: https://chromium-review.googlesource.com/766429 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49348}
-
Michael Stanton authored
This reverts commit f010b28f. Reason for revert: Introduces a clusterfuzz issue and CAnary crash Original change's description: > [TurboFan] Diagnostic code to track down bug in representation selection > > We need to characterize the types of dead (IrOpcode::kDead) nodes > introduced in compilation phases prior to representation selection. > Normally, a dead node isn't expected at the start of this phase. The > question is, which phase introduced the dead node and failed to > deal with it properly? > > Bug: chromium:780658 > Change-Id: Ief5b45480bb7d704a2d09dafd60b5d389e0fd42e > Reviewed-on: https://chromium-review.googlesource.com/765968 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49328} TBR=mvstanton@chromium.org,mstarzinger@chromium.org Change-Id: I5d628eb1de630ce4a353b6ef0f80fd74ad740f17 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:780658 Reviewed-on: https://chromium-review.googlesource.com/768747Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#49347}
-
peterwmwong authored
Bug: v8:7016 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I5a509fb91a337eec4a58ab4a13d7104e8ba3ff23 Reviewed-on: https://chromium-review.googlesource.com/760677 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Make sure we have at least two elements in the Map, otherwise we don't perform a proper dictionary lookup. Bug: chromium:781218 Change-Id: I471e3822b95c15e3a5b2ac54c8ad1f030bd54d40 Reviewed-on: https://chromium-review.googlesource.com/768708Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#49345}
-
Michael Achenbach authored
Temporary fix for isolate archiver behaving weirdly when the command is missing. NOTRY=true TBR=sergiyb@chromium.org Bug: v8:7012 Change-Id: I1ccee6be16605426e74b6c4a0379fa502106e5a9 Reviewed-on: https://chromium-review.googlesource.com/768727Reviewed-by:
-
peterwmwong authored
- Remove weak-collection.js - Adds TFJ builtins for WeakSet and WeakMap constructors - Unified helpers and constructor behavior into a BaseCollectionsAssembler - Fast paths for... - unmodified constructor function - argument is a fast JS array - entries are fast JS arrays, for Map/WeakMap - no arguments passed Quick benchmarks shows significant improvements (1.12x - 5.7x!) for ALL collection constructors (weak and non-weak): https://github.com/peterwmwong/v8-perf/blob/master/weakcollection-constructor/README.md More could be done for performance. Currently we always call out to JS to add entries, if we knew the prototype was unmodified, we could call the builtins directly. Bug: v8:5049, v8:6604 Change-Id: Id7912c1eed5bcf512df7fd6238f04166a8a5937e Reviewed-on: https://chromium-review.googlesource.com/760385Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Bug: v8:6791 Change-Id: I8519d0a9afdb457398ff428d0d3ec0734306052b Reviewed-on: https://chromium-review.googlesource.com/765947Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I41324b8bf1827c43a652fa5f6b83731eaa17776d Reviewed-on: https://chromium-review.googlesource.com/766887Reviewed-by:
-
Yang Guo authored
R=ulan@chromium.org This is in response to https: //github.com/nodejs/node/issues/16901 Change-Id: I78fd5ea5b1d5602c4e48b985189e1b4114ff6443 Reviewed-on: https://chromium-review.googlesource.com/758680Reviewed-by:
-
Mathias Bynens authored
The lookbehind tests weren’t being skipped in the “without lookbehind” case, resulting in a redundant test. Bug: v8:4545 Change-Id: Ia004508373ba6ec49fd9de690909467eb0a15361 Reviewed-on: https://chromium-review.googlesource.com/765468Reviewed-by:
-
v8-autoroll authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/aee17a9..755a485 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I501229bc239cb2f9a26996249daa998f6a0c1e32 Reviewed-on: https://chromium-review.googlesource.com/768447Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49338}
-
- 13 Nov, 2017 22 commits
-
-
Adam Klein authored
Since each Array literal containing a spread is individually queued for rewriting, there's no need for an AstVisitor here: a simple linear pass through the queue is sufficient. This patch deletes AstExpressionRewriter and all the machinery supporting it in the AST. This code was built with the idea of using it as a general expression rewriting mechanism in the parser, but those use cases never materialized, and Array spread remains the only thing that used this code. Bug: v8:6092 Change-Id: I754c4883099e840881b005f20216f86e57721d5a Reviewed-on: https://chromium-review.googlesource.com/765051Reviewed-by:
-
Michael Achenbach authored
This reverts commit 4091f2b3. Reason for revert: Flaky on the bots: https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/21321 https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/20879 https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/101 Original change's description: > Make intl/overrides/caching.js more 'robust' > > Bug: None > Test: intl/overrides/caching > Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng > Change-Id: Iffd0f58f76d6514924badca18a2112df572e53d2 > Reviewed-on: https://chromium-review.googlesource.com/757945 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Jungshik Shin <jshin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49334} TBR=adamk@chromium.org,jshin@chromium.org Change-Id: Id2fe00089c2bcbc8ecc7958fe13c8a80da733e60 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/766288Reviewed-by:
-
Adam Klein authored
Fix two more places where StringToBigInt differs from parseInt: - Binary and octal radix prefixes are supported - Trailing non-whitespace junk is not allowed This is done with a new Behavior enum in BigIntParseIntHelper, along with a couple of bool configuration flags in StringToIntHelper. Bug: v8:6791, v8:7038 Change-Id: Ib91bfc5ccb04ad0dd6c99bc81e19c1239264a469 Reviewed-on: https://chromium-review.googlesource.com/764595Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jungshik Shin authored
Bug: None Test: intl/overrides/caching Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Iffd0f58f76d6514924badca18a2112df572e53d2 Reviewed-on: https://chromium-review.googlesource.com/757945Reviewed-by:
-
Jungshik Shin authored
BUG=None TEST=test262/intl402/NumberFormat/* , intl/number-format/* Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I4fed7c749db1aee390675003d7dfdfea7bb94c7c Reviewed-on: https://chromium-review.googlesource.com/760042Reviewed-by:
-
Michal Majewski authored
Stress marking by starting it in random points between 0 and --stress_marking percent of the standard limit. Bug: v8:6972 Change-Id: I84572ba937f34cf4fd7b5eb2d532f48ff122a060 Reviewed-on: https://chromium-review.googlesource.com/763453 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Camillo Bruni authored
This CL fixes uses of HandleSlackTracking which previously would write fields twice. Additional checks ensure that only proper initial maps are used with slack tracking. Change-Id: Ifb03297635ed6b873eb8b27fec9794c9d36b71b6 Reviewed-on: https://chromium-review.googlesource.com/664810Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#49331}
-
Michael Starzinger authored
R=hpayer@chromium.org Change-Id: I748df06492b1712ff15cd56f6eeb159545986c93 Reviewed-on: https://chromium-review.googlesource.com/766431 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#49330}
-
Michael Achenbach authored
NOTRY=true TBR=majeski@google.com Bug: v8:7012 Change-Id: Iaac782596ab3fdb7338f04fe7b3af7474b36fa57 Reviewed-on: https://chromium-review.googlesource.com/766347Reviewed-by:
-
Mike Stanton authored
We need to characterize the types of dead (IrOpcode::kDead) nodes introduced in compilation phases prior to representation selection. Normally, a dead node isn't expected at the start of this phase. The question is, which phase introduced the dead node and failed to deal with it properly? Bug: chromium:780658 Change-Id: Ief5b45480bb7d704a2d09dafd60b5d389e0fd42e Reviewed-on: https://chromium-review.googlesource.com/765968Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#49328}
-
Michael Starzinger authored
This fixes a corner-case where resuming a suspended generator would not perform stack overflow checks and hence cause the stack to grow without bounds. R=neis@chromium.org BUG=chromium:781583 Change-Id: Ib04116e489ac6b962cb821263860497abb57bbae Reviewed-on: https://chromium-review.googlesource.com/765953Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Ib983e3dfa8fac25fd494fb24e245bfd0caadd7fd Reviewed-on: https://chromium-review.googlesource.com/766187Reviewed-by:
-
Camillo Bruni authored
- Update most callsites to use the new RunJS method - Update tests to use TestWithNativeContext if possible - Remove RunJS from test-helpers.cc - Remove TestWithRandomNumberGenerator from test-utils.h Change-Id: Ib2a6cc56334dc391ca6a2aeb7780fa324f44f109 Reviewed-on: https://chromium-review.googlesource.com/765373Reviewed-by:
-
Ulan Degenbaev authored
If there is a WeakMap in a retaining path of an object, then we have two choices: 1) use the WeakMap backing store as the retainer. 2) use the key in the WeakMap as the retainer. Both cases can be useful for debugging memory leaks. This patch adds a second parameter to %DebugTrackRetainingPath(). If this parameter is "track-ephemeral-path", then the retaining path printer will use the key in the WeakMap as a retainer. Otherwise, the WeakMap backing store will be reported as the retainer. Bug: v8:6987 Change-Id: I9feae25bc734c3abed501b9f901a36d2248a105c Reviewed-on: https://chromium-review.googlesource.com/753343 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49324}
-
Michael Lippautz authored
Bug: chromium:780749 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ifd7da70dd9adffe5de7f126539c4780799d55673 Reviewed-on: https://chromium-review.googlesource.com/763528Reviewed-by:
-
Michael Achenbach authored
NOTRY=true NOTREECHECKS=true TBR=sergiyb@chromium.org Bug: chromium:782226 Change-Id: I108616ea7c94040b29e5522fdd6bded420771414 Reviewed-on: https://chromium-review.googlesource.com/758266 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#49322}
-
Leszek Swirski authored
The consume code cache code path was only taken in the case where the isolate cache lookup failed, making the "hit isolate cache when consume code cache" histogram sample never work. Bug: chromium:769203 Change-Id: I15398f9ce4fc53602b323b8efb8ac9787440dd85 Reviewed-on: https://chromium-review.googlesource.com/765455Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#49321}
-
Daniel Clifford authored
Bug: chromium:783119 Change-Id: I617db4f6740fb2cfe036ccf162a12aa2bac28e86 Reviewed-on: https://chromium-review.googlesource.com/763460Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#49320}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Change-Id: I200c088d3cf1c3c1a16040b1395b534ccd9d9268 Reviewed-on: https://chromium-review.googlesource.com/765471Reviewed-by:
-
Camillo Bruni authored
The only empty PropertyArray is the empty_property_array object on the isolate. Allowing empty PropertyArrays causes the turbofan to ignore the existing hash when growing the backing store again. We currently only end up with the empty PropertyArray when following back transitions. Bug: chromium:781218, chromium:783713 Change-Id: If41dd09b965cdc8d957b9ca50ba3c8a7f4254769 Reviewed-on: https://chromium-review.googlesource.com/763230 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Bug: Change-Id: I1fbe94b3f874e24abc8ce2a6387ffe9d31dbb7b0 Reviewed-on: https://chromium-review.googlesource.com/765659 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Yuki Shiino authored
This patch adds a missing V8_EXPORT to Context::BackupIncumbentScope. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ic4146ee1dad2f84222671fc54b4a463282356417 Reviewed-on: https://chromium-review.googlesource.com/762834Reviewed-by:
-
- 11 Nov, 2017 1 commit
-
-
Jakob Gruber authored
Revert this and its follow-up as suspect for current canary OOM crasher. This reverts commit 4899bcb6. This reverts commit b73ee334. TBR=adamk@chromium.org,hpayer@chromium.org Bug: chromium:783708 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I4c00582e7ab2df22216ad6732e2843e9958db0c0 Reviewed-on: https://chromium-review.googlesource.com/765447Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49315}
-
