- 11 Sep, 2019 28 commits
-
-
Igor Sheludko authored
This is a first step towards removal of dynamic ParameterMode. Bug: v8:9708 Change-Id: I3502584264952dc12b44fd85b91274c9a0ddf31d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798622Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#63688}
-
Clemens Hammacher authored
Ensure that the jump tables do not take more than 50% of newly reserved code spaces. In particular, this ensures that the jump tables always fit in the newly reserved code space. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: I72cdbb7c7dc7916167594c0fc8e1ddb1511756ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782559 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63687}
-
Joshua Litt authored
Implements AsyncModules in SourceTextModule. However, there is no support in the parser or D8 for actually creating / resolving AsyncModules. Also adds a flag '--top-level-await,' but the only external facing change with the flag enabled is that Module::Evaluate returns a promise. Bug: v8:9344 Change-Id: Idc722efc1e2aa780d04bdb985bb7920ab969d34e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1728037Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#63686}
-
Dominik Inführ authored
SharedFunctionInfos that do not belong to a script were tracked in noscript_shared_function_infos. However this was only used in object-stats. Remove this since it was actually leaking memory in some use cases. Bug: v8:9674 Change-Id: I9482f7e5dedf975666a70684b3d2ea04c9a23518 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798423Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#63685}
-
Liviu Rau authored
Removed all references in .pyl files. Bug: v8:9694 Change-Id: Id6f1f6075b022836cda4f0b3d61eb0edbead17db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798422Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#63684}
-
Clemens Hammacher authored
This is a reland of d7d25d2a Original change's description: > [wasm] Patch jump tables in all code spaces > > If there are multiple code spaces, make sure to patch the jump tables > in all of them. > > R=mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: I2ec3d3de913b99623fd310004555337329588da0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1789289 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63651} Bug: v8:9477 Change-Id: I89c3d59d8366ac9479e58feea91dd40ee4e01f66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796065 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The jump table assembler is implemented on all architectures now, so remove the default code. It would be untested otherwise. R=mstarzinger@chromium.org Change-Id: I45e42fc04ebb3bb07d975648b1498e2ea4e757d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796328 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... to precisely express which guarantees does this operator provide. Drive-by-fix: use it for other tag-checking predicates in CSA. Bug: v8:9396 Change-Id: Ifee22922ac02ec8866038be1a97625a32638d521 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795504 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#63681}
-
Clemens Hammacher authored
This adds the --wasm-far-jump-table flag, which enables the extension of the far jump table with a slot for each wasm function. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: I61cb4592aa8ed75e2772371e9b7dbfdfe9bb0046 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792907 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This CL renames the runtime stub table to far jump table, and changes the implementation so it can later be patched concurrently. A follow-up CL will extend this table to also contain slots for wasm functions (if needed). R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: I20bf0a0bb66dc0333f794761c1506b27137b53e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1789159 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Georg Neis authored
Change-Id: Ie0bd818c629bed3011212fb7c8ab81202a462501 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798424Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#63678}
-
Joyee Cheung authored
This patch uses a bit in the Variable bit fields to distinguish static private names from instance private names, so that we can check the conflicts of private accessors that are complementary but with different staticness in the parser, and use this information later when generating code for checking static brands for private method access. Design doc: https://docs.google.com/document/d/1rgGRw5RdzaRrM-GrIMhsn-DLULtADV2dmIdh_iIZxlc/edit Bug: v8:8330 Change-Id: I8d70600e594e3d07f77ea519751b7ca2e0de87b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781010Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#63677}
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:8519 Change-Id: I3c63637fb9cb694e4d50be2fded1dcc02de7f2ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796559 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63676}
-
Joshua Litt authored
Also converts ACP from a Cell to a PropertyCell. Bug: v8:9463 Change-Id: I6cd26d4e4fd8869a17bf75f83cc177524f8082d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795742Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... to make it "smi-corrupting" decompression-friendly. Also add a cctest for the CSA implementation. Bug: v8:9706 Change-Id: I1f1b0aa1b40832a0c2ce81658da316b3e442189c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796802Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:6949, v8:9396 Change-Id: I19b865bea9ebe40f8f96cd220963cd3181412c82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792906 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#63673}
-
Michael Lippautz authored
Do not assume that the MaybeHandle that is returned when fetching for a property is valid and instead check for its contents. Treat an empty handle as not finding the right property. Bug: chromium:1002827 Change-Id: Iac158086ec5f66cd9602f4a73ae78de367dd3e77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796556 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds a test where we evaluate a variable that is context allocated (through the use of 'eval'), but not used by the closure. This did not work with the previous whitelist approach, but works now with the new blacklist approach (see https://crrev.com/c/1795354) Bug: v8:9482 Change-Id: I1e453dec0b624bf7e0312100e119d86c9c481ba9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796543 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63671}
-
Victor Gomes authored
From verwaest@ work on the Json's parser, we know that removing the allocation type argument when creating objects using the factory class increases performance. This will also allow us to optimise these functions in a latter CL. Change-Id: If78f62a63fe41453f4def8bea77b6eddc2ab7f36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792168Reviewed-by:
-
Santiago Aboy Solanes authored
functionality is: If rhs_is_smi is true, we are sure that rhs is a Smi. If rhs_is_smi is false, rhs might or not be a Smi. Therefore, rhs_known_smi fits better. Change-Id: Ie6dd0446ef85ba0730189e2012a21c24d1731b74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796551Reviewed-by:
-
Sigurd Schneider authored
Notry: true Notreechecks: true Change-Id: Ie15006dfd812a26486c7e2a5d09c713b92456ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796555 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:6949, v8:9396 Change-Id: If9fa66de4aecfe72c30ac81c563216fd5e057eb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792903 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL changes how variables are resolved during debug evaluate. We now re-parse the whole script when creating a ScopeIterator. This gives us accurate scope information for all parent scopes of the closure in which we stopped. Using this information, we build blacklists of stack-allocated variables. Each context on the chain in between the closure context up to the original native context is wrapped in a debug-evaluate context with such a blacklist attached. Variable lookup for debug-evalute contexts then works as follows: 1) Look up in the materialized stack variables (stayed the same). 2) Check the blacklist to find out whether to abort further lookup. 3) Look up in the original context. Steps 1-3 is repeated for each debug-evaluate context, since they mirror the original context chain. R=ulan@chromium.org, yangguo@chromium.org Change-Id: Ied8e5786772c70566da9627ee3b7eff066fba2b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795354Reviewed-by:
-
Mu Tao authored
Fix build errors introduced by commit af063685 and not fully fixed by commit db3cc4a2 Change-Id: Ifdc92f5d55061670127999058d374914985df762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795643Reviewed-by:
-
Mu Tao authored
Port ab0f9710 Original Commit Message: - Eliminates non-const reference parameters in test/cctest. Change-Id: I038314e0cc2b28e70e7ebcbd2d076ef62893285e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795646 Commit-Queue: Mu Tao <pamilty@gmail.com> Commit-Queue: Bill Budge <bbudge@chromium.org> Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#63664}
-
Michael Achenbach authored
Change-Id: I14103a02fa96f66f220559780e9d8ee116ff3e10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796548Reviewed-by:
-
Michael Achenbach authored
This reverts commit d72ae9ab. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Android%20Arm%20-%20builder/27990 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2d9fa32..0f7adef > > Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/74cfb57..cd73d21 > > Rolling v8/buildtools/linux64: git_revision:152c5144ceed9592c20f0c8fd55769646077569b..git_revision:ad9e442d92dcd9ee73a557428cfc336b55cbd533 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/884c81e..050abd8 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e5641be..d207f49 > > Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/3a45039..33a0d4f > > TBR=machenbach@chromium.org,tmrts@chromium.org > > Change-Id: I465ba35dd9e70e02c684687b656c34c5bd53ff23 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796705 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#63661} TBR=machenbach@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,tmrts@chromium.org Change-Id: I0ffabeb2df5a2949adf5ebb319bec20513a04c55 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796545Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2d9fa32..0f7adef Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/74cfb57..cd73d21 Rolling v8/buildtools/linux64: git_revision:152c5144ceed9592c20f0c8fd55769646077569b..git_revision:ad9e442d92dcd9ee73a557428cfc336b55cbd533 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/884c81e..050abd8 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e5641be..d207f49 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/3a45039..33a0d4f TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I465ba35dd9e70e02c684687b656c34c5bd53ff23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796705Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#63661}
-
- 10 Sep, 2019 12 commits
-
-
Frank Tang authored
Bug: chromium:997401 Change-Id: I7a78f4ad1fd05ab2bb2dbcd343060b2647aef4e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771954 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63660}
-
Michael Lippautz authored
Reuse the existing builtin and extension infrastructure to provide a garbage collection mechanism that allows for asynchronous execution. On --expose-gc, this changes the gc call to parse parameters the following: (1) Parse options when encountering an options object with known properties. (2) No parameters is parsed as {type: 'major', execution: 'sync'}. (3) Truthy parameter that is not setting options is parsed as {type: 'minor', execution: 'sync'}. (2) and (3) preserve backwards compatibility for existing callers as this may be used widely across various test and benchmarking infrastructures. Valid options: - type: 'major' or 'minor' for full GC and Scavenge, respectively. - execution: 'sync' or 'async' for synchronous and asynchronous execution respectively. Returns a Promise that resolves when GC is done when asynchronous execution is requested, and undefined otherwise. Note: This is implemented as builtin to avoid having any stack at all. This information is also passed to the embedder to allow skipping stack scanning. Change-Id: Ie5c9b6f0d55238abfeb9051ffa1837501d474934 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1793143 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: -
Santiago Aboy Solanes authored
Bug: v8:6949, v8:9396 Change-Id: I4c9382079190379661a26fbe6e1f4f6040a56d08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792902 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Gus Caplan authored
Bug: v8:9553 Change-Id: I376d4bd3d1554e1ed0bdeea79c47bd2a45e643d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795886 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#63657}
-
Z Nguyen-Huu authored
Bug: v8:8976 Change-Id: I281dc72dcdf03a1d05fdc632c9e9228d62bd85b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1783099 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Milad Farazmand authored
Port f72c844a Original Commit Message: Port f5ab7d38 Port 65f3861e Original Commit Message: In a new test suite: "wasm-api-tests", using a new binary "wasm_api_tests", powered by gtest/gmock (like unittests). Also fix a bunch of issues that these tests uncovered, mostly to ensure that the stack is walkable. R=miladfar@ca.ibm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Id52e771fee79210d6c295cecf56a322657cf2b8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795864 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#63655}
-
Clemens Hammacher authored
This reverts commit d7d25d2a. Reason for revert: crashes win32-debug: https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/21970 Original change's description: > [wasm] Patch jump tables in all code spaces > > If there are multiple code spaces, make sure to patch the jump tables > in all of them. > > R=mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: I2ec3d3de913b99623fd310004555337329588da0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1789289 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63651} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I4bdeb7394ebf002e3a84fececb0defba8bc9065d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9477 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796064Reviewed-by:
-
Igor Sheludko authored
This reverts commit 05d83a0e. Reason for revert: We passed the M78 branch point and should proceed testing the new elements kinds support. Original change's description: > Temporarily disable frozen/sealed elements kinds > > ... to prepare for merging this back to stable channel. > > Bug: chromium:992914 > Change-Id: Icbb257b5c02417d9222e60346575567360376264 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762021 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Auto-Submit: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63277} TBR=leszeks@chromium.org,ishell@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:992914, v8:996176 Change-Id: Iaa36c140c0c9c72ca0e58f5c3e7d4cad67027085 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795342Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#63653}
-
Leszek Swirski authored
Rather than duplicating code paths for in- and out-of-object stores, have one code path which checks whether it needs to load the property store (and change the storage location to the HeapNumber value for unboxed doubles). As a drive-by, change the representation dispatch into a switch, and inline the representation checks into that switch, to make explicit what checks for what and which paths transform the value. Also, TNodify some of the surrounding functions. Change-Id: Ia1bf698b4cec3ffce9aaa5732cda2e3be9efd8e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795345Reviewed-by:
-
Clemens Hammacher authored
If there are multiple code spaces, make sure to patch the jump tables in all of them. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: I2ec3d3de913b99623fd310004555337329588da0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1789289Reviewed-by:
-
Bill Budge authored
- Eliminates non-const reference parameters in src/objects. Bug: v8:9429 Change-Id: Ic39a59d54bda26c622db29f07143055c3cc6c7a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1794683Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=mslekova@chromium.org Change-Id: I3793426aaebd400ac93015b85ef11db5aecef52f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795357Reviewed-by:
-
