1. 08 May, 2019 1 commit
  2. 03 May, 2019 2 commits
  3. 06 Jun, 2018 1 commit
    • Andreas Haas's avatar
      [test] Make assertThrowsEquals use assertSame · 86a27207
      Andreas Haas authored
      The typical use of assertThrowsEquals is to check that a specific
      object is thrown. However, assertEquals only does a proper equality
      check for primitive types, not for complex types. Using assertSame
      does a reference equality check on objects, which is more what you
      would expect from assertThrowsEquals. For exception kind testing,
      assertThrowsEquals actually did not work correctly, assertThrows is
      better for that case.
      
      R=clemensh@chromium.org, mythria@chromium.org
      
      Change-Id: I24fb22e75fa33ebe90eb4bae40825119a054bba5
      Reviewed-on: https://chromium-review.googlesource.com/1087952Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53556}
      86a27207
  4. 30 Jun, 2017 1 commit
    • bmeurer's avatar
      [turbofan] Replace uninitialized JSConstruct nodes with SOFT deopt. · fd24deb0
      bmeurer authored
      Similar to JSCall, we can also replace uninitialized JSConstruct nodes
      with SOFT deopts to ensure that we don't generate unnecessary dead code.
      This for example shows up in the hot parts of the Node event emitter
      currently where the generic code for handling events with 4 or more
      parameters might not have been run, but we still generate most of the
      code because the new Array call in the beginning is not turned into
      a SOFT deopt immediately.
      
      Drive-by-fix: Also refactor the BytecodeGraphBuilder's handling of
      Construct bytecodes a bit to reduce the amount of code duplication.
      
      BUG=v8:4551, v8:5267
      R=jarin@chromium.org
      
      Review-Url: https://codereview.chromium.org/2958253002
      Cr-Commit-Position: refs/heads/master@{#46339}
      fd24deb0
  5. 23 Jun, 2017 1 commit
  6. 08 Jun, 2017 1 commit
  7. 06 Jun, 2017 1 commit