- 07 Oct, 2019 8 commits
-
-
Joey Gouly authored
Placing these tests in anonymous namespaces, is the suggested fix according to the GCC documentation. The GCC documentation states: "If a type A depends on a type B with no or internal linkage, defining it in multiple translation units would be an ODR violation because the meaning of B is different in each translation unit. If A only appears in a single translation unit, the best way to silence the warning is to give it internal linkage by putting it in an anonymous namespace as well." Change-Id: I69a1e9b5f1789e9a7a62c762cd499809a72e0ea5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1836255 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64128}
-
Clemens Backes authored
Because of a GCC bug we needed to use a functor instead of a constexpr function. Since we do not support gcc before version 5 any more, this can be cleaned up now. R=jkummerow@chromium.org Bug: v8:9396 Change-Id: I848c5a25e1d5fa44a1497b06826f9a59b93ed695 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835543Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64127}
-
Dominik Inführ authored
This CL removes the StoreBuffer and inserts slots into the RememberedSet directly from within the RecordWrite builtin. Only calls into C code when either the SlotSet-array or the bucket is not allocated. This avoids filling the store buffer up with duplicates or due to a write-heavy workload and then blocking the main thread on store buffer processing. The first CL (https://crrev.com/c/1815241) got reverted, because mksnapshot was using a different size for SlotSet than the final binary on ARM. This is fixed now, SlotSet has a standard layout. Bug: v8:9454 Change-Id: I881641f4ee08a8b42c36fdca8733138b908096bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1842452Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Dan Elphick authored
Fixes spurious DCHECK triggering due to bug introduced in https://chromium-review.googlesource.com/c/v8/v8/+/1836258. Bug: chromium:1011596 Change-Id: Ia3b1eb25d326e465b3239f191aad11d90a2e56a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844777Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64125}
-
Mathias Bynens authored
We've gathered sufficient data, so the use counter can now be removed again. The use counter was originally added here: - V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/1718145 - Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/1718367 The Chromium plumbing was removed here: https://chromium-review.googlesource.com/c/chromium/src/+/1839851 BUG=v8:9551 Change-Id: I829a0fe34d9ebade1403cb4d1c0b9c997f125074 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844774Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#64124}
-
Michael Achenbach authored
This adds a fake toolchain for pointer compression, used for correctness fuzzing. The toolchain enables us to have an extra build with inverse pointer-compression defaults side-by-side. The extra build is used similarly to existing x64/x86 comparisons, except that we now compare builds with different compile-time flags. Change-Id: I75491371262204b86eaa006ca8d04848f49121ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829275Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64123}
-
Michael Achenbach authored
The entries test262_variants and test262 are now equal after previous changes. This switches all to test262 to prepare removing the former. Bug: v8:9791 Change-Id: I677ea36798556e1aeed8bc11c3272804141e1eb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835539Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f60b4e5..359f95f TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I89fce2878ea8bfa1fa5803220bc9446e17767f55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844552Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64121}
-
- 06 Oct, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cf8d1d9..f60b4e5 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d696f20..c9256e1 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I8d3ee4364b25a6176865dd8a0d227465a9e6da17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1843093Reviewed-by:
-
- 05 Oct, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/90168ea..cf8d1d9 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8305659..ddbd321 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f3c5fef..d696f20 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ibfd3dc3fdeb38aec3ab5bdcad4d58163d2ad66c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1842077Reviewed-by:
-
- 04 Oct, 2019 20 commits
-
-
Ng Zhi An authored
Bug: v8:9728 Change-Id: Ie769ae0431b7924a4b8f8858681d57e92c00f4b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1808400Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#64118}
-
Ng Zhi An authored
We reuse PACKED_OP_LIST to generate *pd instructions. Introduce a new pd base method, similar to ps and vps. Bug: v8:9396 Change-Id: Id9d81c22c9110935484fd929ef7bf5cc20e9ae7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834767Reviewed-by:
-
Michael Lippautz authored
Change-Id: I0751c1761a2d07dd89d831ca6370ae01bc569b6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1841351 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... in order to improve performance of decompression code on C++ side (because computation of isolate root from isolate pointer becomes a trivial reinterpret cast) and measure the impact separately from other ptr-compr changes. Bug: v8:9353 Change-Id: I36906cef2968355411ee944d97625ecd2652646b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835550Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#64115}
-
Dominik Inführ authored
Now that sweeping uses its own RememberedSet, pre-freeing of empty buckets is not necessary anymore. Mutator inserts into a different remembered set, than the sweeper removes slots from. Bug: v8:9454 Change-Id: I65d046926aa82aeb9eca7694e6a7eff1331d7e01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835547 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 7177d87f Original Commit Message: Reorders the Smi check and the empty OptimizationMarker check as the latter implies the first and means there is now just a single comparison on the fast path. R=delphick@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I4129e8d710d25fb1df02742816ab3b56430a7523 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1841611Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64113}
-
Georg Neis authored
It was on JSGlobalProxyRef but in reality the property cells exist in the global object, not in the global proxy. Bug: v8:7790 Change-Id: Ia7bd5731c730db09602a1aec61b64b1355abf6a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1841352 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#64112}
-
Igor Sheludko authored
This is a reland of b271ea3c The failing arm64 disasm poison test was fixed. Original change's description: > [ptr-compr] Disable double fields unboxing > > Double field unboxing optimization is incompatible with pointer compression so > we land this CL before enabling pointer compression in order to separate memory > and performance regressions caused by disabled double field unboxing from > pointer compression change. > > Bug: v8:9799 > Change-Id: Ic8118356496a3f351344215b409f9722de6c9355 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835546 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64089} Tbr: verwaest@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_arm64_dbg Bug: v8:9799 Change-Id: Ib7c126d70859537c3d0bce54a49f23909c14a6ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1840411 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#64111}
-
Dan Elphick authored
Reorders the Smi check and the empty OptimizationMarker check as the latter implies the first and means there is now just a single comparison on the fast path. Bug: v8:9771 Change-Id: Ibba1f322944b17186842983e227684b301ed5f31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1833683 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#64110}
-
Mike Stanton authored
A slow dcheck can verify that hints are equal for the same SharedFunctionInfo+FeedbackVector combo. Bug: v8:7790 Change-Id: I43dcacf19c857770b609d13c310835a873c814fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835952 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#64109}
-
Georg Neis authored
Recursively serialize arguments to higher-order functions if appropriate. This should recover all or most of the Deltablue regression with --concurrent-inlining. It is also a prerequisite to allowing speculation in the call reducer for these situations. Bug: v8:7790, v8:9702 Change-Id: I1ac8ac8b8e4dc0f2e19c89aacfb45d18f2df190f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835541 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... as the smi-corrupting decompression seems to be stable enough. Bug: v8:9706 Change-Id: I404924ec4a12b37d8bc3e521c5563aa7e6357dc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835544Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:9799 Change-Id: I402133f6265f4a3129daef45615258d4a9b8f2f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1840154 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a reland of 35ca0abd. The last known issue is fixed in https://crrev.com/c/1832178. Original change's description: > [wasm] Ship far jump tables > > This flips the --wasm-far-jump-table flag. It will allow for more than > 128MB of code space per wasm module on arm64, and will increase the > limit on the number of modules per process on x64 (was ~1000 before, > because we reserved 1GB for the code space per module). > > R=mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: I870ec616f4812e38ef1e3fccf0629854a247bb4f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1815247 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Backes [né Hammacher] <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63967} Bug: v8:9477 Change-Id: I6d7de80e874e1d51512148fc3c1f45b0fc1474ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1840151Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64105}
-
Dan Elphick authored
This deletes unresolved VariableProxy objects created for labels in the preparser which prevents shadowed variables in enclosing scopes from being context-allocated. Previously this was only done in the full parser, which leads to bytecode mismatches with lazy source positions. Bug: chromium:1009728, v8:8510 Change-Id: If2d0c345346116a7f5aacbcd0cf3638e9f7e04cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1836258Reviewed-by:
-
Dominik Inführ authored
Do not store page_start_ in SlotSet anymore, when needed this address can be calculated cheaply and be passed in from the caller. Bug: v8:9454 Change-Id: I4cdb010e4126680d8df500e40ae3d0bc884cf501 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1838731Reviewed-by:
-
Dominik Inführ authored
Slots in the sweeping remembered set were not deleted when evacuation of an evacuation candidate fails. Also introduce DCHECKs for other usages of RemoveRange where deleting slots in the sweeping remembered set is not required. Bug: v8:9454 Change-Id: If809ea74e28817a9611104b1f2c6b34900e3432b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1838732Reviewed-by:
-
Jakob Gruber authored
The natives blob is deprecated and will be removed in the next release. Step 1 landed in https://crrev.com/c/1824944. Step 2 (this CL) is to mark API functions as V8_DEPRECATED. Step 3, in the next V8 release, is to remove these functions and all other natives support in V8. Bug: v8:7624 Change-Id: I177fa6197e06a3ca21787b4e2d74dd1689038b6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835536 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/12bec71..90168ea Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bb31bb3..8305659 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/336a2b1..f3c5fef Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/2ecd66c..93a34f0 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/22ecf17..6bc727d TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I078fc76450c99afc4f937a0be515bf686812a852 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1838813Reviewed-by:
-
Maya Lekova authored
This reverts commit f47706a7. Reason for revert: Breaks V8 Linux bot - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/34070 Original change's description: > [wasm] Add tests for SIMD JS-API errors > > Change-Id: I7fc2eb95f9a2d1ea45bc84543a05c84e32bb6d31 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1838924 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64098} TBR=gdeepti@chromium.org,ahaas@chromium.org,zhin@chromium.org Change-Id: I6640ba207e30200e6846a16cab0bd522cabf3108 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1839651Reviewed-by:
-
- 03 Oct, 2019 7 commits
-
-
Deepti Gandluri authored
Change-Id: I7fc2eb95f9a2d1ea45bc84543a05c84e32bb6d31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1838924Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#64098}
-
Milad Farazmand authored
Port 9dfe6359 Original Commit Message: Pushes the optimised code path to after the main interpreter path, so the straightline path is just normal interpretation. R=delphick@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ib275871fd8463bf6879ab1ab78e9b4146df98251 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1838611 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Bruce Dawson authored
merge_to_branch.py can fail partway through for many reasons (the EDITOR environment variable not being set being one) and on the next run this leads to an error saying: Exception: A merge is already in progress It is not obvious to those doing their first merge how to get past this. Searching the source code leads to the -f option but it should be possible to proceed without searching the source. This change adds "Use -f to continue" to the message. Change-Id: Ic9d8e404e044be3308e5ae3ef3a4430e4aa3ccc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1837028Reviewed-by:Yang Guo <yangguo@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#64096}
-
Sathya Gunasekaran authored
Change-Id: If5d92c95a043bb1711306820b61480d01da62b47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1836257Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#64095}
-
Pierre Langlois authored
When comparing with zero, we can generate a CBZ instruction instead of a CMP+B. If we teach TurboAssembler::JumpIfEqual() to do it then we can do it in code generated for binary switches. Change-Id: I39a045ed666fd6569bf9c9f6be28c4efbeeb01a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1836254Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:9552 Change-Id: If13a3ff1baa259cb0f51858c0d3c28bfef943499 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1822038 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5de2214..12bec71 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/16236fc..bb31bb3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5eac9d3..336a2b1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/925d2e5..22ecf17 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie28ab13a9238ca48e801c1df532110da52d3b9aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835747Reviewed-by:
-
- 02 Oct, 2019 3 commits
-
-
Irina Yatsenko authored
Change-Id: I63cf6cd9b22ea02846ec40eba214acb21304d418 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832637 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
-
Francis McCabe authored
This reverts commit b271ea3c. Reason for revert: breaks arm build: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/17575 Original change's description: > [ptr-compr] Disable double fields unboxing > > Double field unboxing optimization is incompatible with pointer compression so > we land this CL before enabling pointer compression in order to separate memory > and performance regressions caused by disabled double field unboxing from > pointer compression change. > > Bug: v8:9799 > Change-Id: Ic8118356496a3f351344215b409f9722de6c9355 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835546 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64089} TBR=ishell@chromium.org,verwaest@chromium.org Change-Id: Ief07d8d4b3c4a6f1439656f31b8d34ec99bf9747 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9799 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834769Reviewed-by:
Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#64090}
-
Igor Sheludko authored
Double field unboxing optimization is incompatible with pointer compression so we land this CL before enabling pointer compression in order to separate memory and performance regressions caused by disabled double field unboxing from pointer compression change. Bug: v8:9799 Change-Id: Ic8118356496a3f351344215b409f9722de6c9355 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835546 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
