- 06 Nov, 2018 31 commits
-
-
Sigurd Schneider authored
Change-Id: I1fe4454e3c0f2ec5cc044e36c311012d41e896a7 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1319768 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57287}
-
Sigurd Schneider authored
Change-Id: If8faa3c7c0324fc9d0a2704533278828c62d5b91 Notry: true Bug: v8:8128, v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1319765Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57286}
-
Sigurd Schneider authored
Bug: chromium:901798 Change-Id: I4b479d6431cc7cdfa53f9cdf6283d2ff86e32821 Reviewed-on: https://chromium-review.googlesource.com/c/1319760Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57285}
-
Clemens Hammacher authored
These tests are also used for streaming. This CL changes the test to actually output the exception that unexpectedly happened. R=ahaas@chromium.org Bug: v8:7921 Change-Id: Ia9c91a7d3d9452f9c0180329a5434f049b56c3c8 Reviewed-on: https://chromium-review.googlesource.com/c/1319755 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57284}
-
Clemens Hammacher authored
Any sane platform would process foreground tasks in a FIFO order. Hence our mock platform in the tests should do the same. R=ahaas@chromium.org Bug: v8:7921 Change-Id: Iafe1d9f2eb2a0c168f7e994f05b054756ef9e4af Reviewed-on: https://chromium-review.googlesource.com/c/1319754 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57283}
-
Michael Starzinger authored
R=herhut@chromium.org Change-Id: Iaac8c2e036a0343c4d4a5c50bc91fb3d35e5d760 Reviewed-on: https://chromium-review.googlesource.com/c/1319586Reviewed-by: Stephan Herhut <herhut@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57282}
-
Jakob Gruber authored
This condition is easy to miss at call sites and could create 'fast' arrays that are too large. Let's make this a runtime CHECK instead. Bug: chromium:901944 Change-Id: I8f8f161781414944b67099007a98f76972496ae2 Reviewed-on: https://chromium-review.googlesource.com/c/1319571Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57281}
-
Igor Sheludko authored
in TurboFan, CSA, Wasm and compiler tests. Tagged values decompression logic will depend on the machine type of the value being loaded so it must be correct. Bug: v8:7703 Change-Id: Ia9e7cc1e273e5a458d9de8aaa4adb0c970413b8b Reviewed-on: https://chromium-review.googlesource.com/c/1319573 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57280}
-
Jakob Gruber authored
The array length is modifiable by user code that is called as a side-effect during the sorting algorithm. We thus cannot base any guarantees on the current length, but must reference the initially-read array length instead. Note that even though the algorithm may read and write from beyond the current array length value, this adheres to the spec, which only requires accesses to be within the original array dimensions (i.e.: 0 <= i < original array length). Bug: chromium:901633 Change-Id: Id765e80d4231ff6f2a73e040ec94c2b07f8c5b0f Reviewed-on: https://chromium-review.googlesource.com/c/1317814 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#57279}
-
Michael Starzinger authored
R=herhut@chromium.org Change-Id: I7e81d233211ba29d9c48accda63a365e31f51617 Reviewed-on: https://chromium-review.googlesource.com/c/1319582Reviewed-by: Stephan Herhut <herhut@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57278}
-
Michael Starzinger authored
R=herhut@chromium.org Change-Id: Ic7fede18b89a14a8e0af255add5678a70b699475 Reviewed-on: https://chromium-review.googlesource.com/c/1319580Reviewed-by: Stephan Herhut <herhut@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57277}
-
Sigurd Schneider authored
Phi creation in the code assembler was dependent on the addresses of the CodeAssemblerVariable::Impl object. This caused non-determinism in mksnapshot which sometimes occurred on Windows. This CL adds IDs to CodeAssemblerVariable::Impl objects and ensures all iterations are done in ID order instead of object address order. Change-Id: I2b370dc5153202be864a5c13289e70f5ebd59e2e Bug: v8:8391 Reviewed-on: https://chromium-review.googlesource.com/c/1319749 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57276}
-
Dan Elphick authored
When deserializing the startup snapshot, call IterateStrongRoots with VISIT_FOR_SERIALIZATION rather than VISIT_ONLY_STRONG. To compensate, make the StartupDeserializer explicitly iterate over the partial snapshot cache. This makes the deserializer and serializer consistent in their use of the function and makes their differences explicit in the snapshot code itself. Bug: chromium:902230 Change-Id: I3a2ac858f4f6b3097b98a10ed2dd5ac5b9bf83e8 Reviewed-on: https://chromium-review.googlesource.com/c/1319585 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57275}
-
Sathya Gunasekaran authored
- Fix ParseBCP47 to return just the extension. The second argument to substr function is actually the length, not the end position of the substring :') - Remove extension keys that aren't part of the relevant extension keys - Use 'ca' as an relevant extension key for DateTimeFormat - Use the canonicalized locale tag after create the ICU locale is created, rather than the input locale tag. Bug: chromium:895942, v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I189709714d847e684b04409b734a60ff04ed7dd2 Reviewed-on: https://chromium-review.googlesource.com/c/1291076Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#57274}
-
Mike Stanton authored
Bug: v8:8418 Change-Id: I6d2efdf87bb4fc5454e5a4ee8e5a66463533615e Reviewed-on: https://chromium-review.googlesource.com/c/1317810 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57273}
-
Yang Guo authored
This is to ensure the snapshot is deterministic. Internal fields can contain: - reference to heap object - embedder-defined aligned pointer - a smi The latter two are not distinguishable by V8, so if the serializer callback returns non-zero value, we consider it to be an aligned pointer and clear it to ensure that the snapshot does not contain memory addresses that may not be deterministic. If the callback returns { nullptr, 0 } as result, we consider it to be a smi or some in-place data that we then serialize verbatim. R=jgruber@chromium.org Bug: chromium:870584 Change-Id: I3cf9abf135ffd28d8138fa32636b12596b076e13 Reviewed-on: https://chromium-review.googlesource.com/c/1304441 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57272}
-
Peter Marshall authored
Causing ASAN failures Bug: v8:5193 Change-Id: I7a899a6390bd1258a1afc8738e85f73239f44a59 Reviewed-on: https://chromium-review.googlesource.com/c/1319583Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57271}
-
Daniel Clifford authored
This is a reland of c88994f8 Turned out to not be the issue. Original change's description: > Fix Array.prototype.sort speed regression > > CanUseSameAccessor<ElementsAccessor: type> is array-sort.tq is super > performance-critical. Reverting the type-safe cleanup made in this > function while landing Array.prototype.slice. > > Bug=chromium:852764 > > Change-Id: I1252d2ff8e431581f916794807e59abb39248abb > Reviewed-on: https://chromium-review.googlesource.com/c/1317815 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Daniel Clifford <danno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57248} TBR=danno@chromium.org Change-Id: I627a131a8525ae4e131c6467561cab9832f3792f Reviewed-on: https://chromium-review.googlesource.com/c/1319581Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57270}
-
Georg Neis authored
Bug: chromium:901944 Change-Id: Iaf1dfaa5763162ae7952381fb8b64661d85ea1a8 Reviewed-on: https://chromium-review.googlesource.com/c/1317822Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57269}
-
Toon Verwaest authored
Change-Id: Iefea33f47ee4492c9c4d4e105e30f7e2d9128bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1319576Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57268}
-
Sigurd Schneider authored
Notry: true Change-Id: Iacc8aadc62956cf5fab13c60a9eaa52318519d62 Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1317813 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#57267}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: v8:8421 Change-Id: Ifbc7271da8a210b197b698f92aad925d3adf7244 Reviewed-on: https://chromium-review.googlesource.com/c/1319579 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57266}
-
Leszek Swirski authored
This reverts commit c88994f8. Reason for revert: Seems to break AccessibilitySelectionTest.List in webkit_unit_tests (https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Mac/15618) Original change's description: > Fix Array.prototype.sort speed regression > > CanUseSameAccessor<ElementsAccessor: type> is array-sort.tq is super > performance-critical. Reverting the type-safe cleanup made in this > function while landing Array.prototype.slice. > > Bug=chromium:852764 > > Change-Id: I1252d2ff8e431581f916794807e59abb39248abb > Reviewed-on: https://chromium-review.googlesource.com/c/1317815 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Daniel Clifford <danno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57248} TBR=danno@chromium.org,jgruber@chromium.org Change-Id: Ie447fd0382fee344326d928398595aa450ccdcca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1319577Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57265}
-
Toon Verwaest authored
This rethrows the underlying expression error if there is one. Bug: v8:8409 Change-Id: Icc8253e4006c554df9f6a6d850b087b03d88de2d Reviewed-on: https://chromium-review.googlesource.com/c/1319570Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57264}
-
Clemens Hammacher authored
Instead of passing and storing uint8_t* and size_t, we now more often store a Vector or OwnedVector, which encapsulates these two fields. This provides some more DCHECKs which happen automatically when getting a subvector into the buffer. Drive-by: More refactorings and removals of unneeded or rarely used helper methods. R=ahaas@chromium.org Bug: v8:8238 Change-Id: I1b24f90f1517fc50360854f46c2d001075544858 Reviewed-on: https://chromium-review.googlesource.com/c/1317817 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57263}
-
Igor Sheludko authored
In particular, output root name instead of root value when detecting accesses to roots table. For example: REX.W cmpq [r13+0x80] (root (0x391473a00569 <Map[16]>)),rbx REX.W movq rdi,[r13+0x18] (root (0x391473a007b9 <Map>)) REX.W movq rdi,[r13-0x20] (root (0x391473a005b9 <the_hole>)) turns into REX.W cmpq [r13+0x80] (root (heap_number_map)),rbx REX.W movq rdi,[r13+0x18] (root (fixed_array_map)) REX.W movq rdi,[r13-0x20] (root (the_hole_value)) Bug: v8:8238 Change-Id: I0f7bdcb7774a2fe450f930c1bc2f3ccd03064201 Reviewed-on: https://chromium-review.googlesource.com/c/1317823Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57262}
-
Joyee Cheung authored
Currently to obtain a v8::Array out of a C array or a std::vector, one needs to loop through the elements and call array->Set() multiple times, and these calls go into v8::Object::Set() which can be slow. This patch adds a new Array::New overload that converts a Local<Value>* with known size into a Local<Array>. Change-Id: I0a768f0e18eec51e78d58be455482ec6425ca188 Reviewed-on: https://chromium-review.googlesource.com/c/1317049Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#57261}
-
Michael Achenbach authored
TBR=sigurds@chromium.org NOTRY=true Bug: v8:7783 Change-Id: I17f1c17be365db7398e7e13dd62a6dd86a6cb008 Reviewed-on: https://chromium-review.googlesource.com/c/1319569 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57260}
-
tzik authored
Unlike other v8::Context getter on v8::Isolate, the v8::Context returned by GetEnteredOrMicrotaskContext may be non-NativeContext. However, Blink implicitly assumes all v8::Context is backed by NativeContexts. This CL updates GetEnteredOrMicrotaskContext() to check the resulting Context is NativeContext, and updates callers of EnterMicrotaskContext to use NativeContext. Change-Id: Ifae528f4ce8feb067f4ad1a43330dc55f4a8ed79 Reviewed-on: https://chromium-review.googlesource.com/c/1301653Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#57259}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b5b1fdc..47ccdba Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/03ce64d..9a5dbc6 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7e0b0c4..459aaba TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I24add833a4dee7301efa3f1ee2248351e3864074 Reviewed-on: https://chromium-review.googlesource.com/c/1319250Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57258}
-
Deepti Gandluri authored
This reverts commit de88bfb2. Reason for revert: Breaks msvc build https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/5765 Original change's description: > [wasm-simd] Implement remaining I8x16 SIMD ops on x64 > > - Implementation for I8x16 Shifts, and Mul > - Fix convert bug > - Enable all tests except for shuffle tests > > Change-Id: Id1a469d2883c30ea782c51d21dc462d211f94420 > Reviewed-on: https://chromium-review.googlesource.com/c/1318609 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57254} TBR=bbudge@chromium.org,gdeepti@chromium.org Change-Id: I09efd8002e27f457e89250336e6c3a12d8d9682c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1318097Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#57257}
-
- 05 Nov, 2018 9 commits
-
-
Adam Klein authored
This should allow for better parallelization when running these tests. Change-Id: Ib3cae7d6e8f0d2608470ca616eeac7eecae3b7ab Reviewed-on: https://chromium-review.googlesource.com/c/1318094Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57256}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cd2c8fe..b5b1fdc Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8c035b3..03ce64d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5df515eea0c133826fcc1a78fb2453a2a8043c98 Reviewed-on: https://chromium-review.googlesource.com/c/1318093 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57255}
-
Deepti Gandluri authored
- Implementation for I8x16 Shifts, and Mul - Fix convert bug - Enable all tests except for shuffle tests Change-Id: Id1a469d2883c30ea782c51d21dc462d211f94420 Reviewed-on: https://chromium-review.googlesource.com/c/1318609Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#57254}
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: chromium:899721 Change-Id: Ifdb4864e47a56cb0fe2565e44e79f3def496b138 Reviewed-on: https://chromium-review.googlesource.com/c/1317821 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#57253}
-
Jakob Kummerow authored
and split Smi out of objects.h into smi.h. Bug: v8:3770, v8:5402 Change-Id: I5ff7461495d29c785a76c79aca2616816a29ab1e Reviewed-on: https://chromium-review.googlesource.com/c/1313035Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57252}
-
Junliang Yan authored
Change-Id: I273764acb3881a5f682d3cc77e2c8f66bbb7b071 Reviewed-on: https://chromium-review.googlesource.com/c/1318091Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57251}
-
Frank Tang authored
This will give us some clusterfuzz coverage. Bug: v8:7871 Change-Id: I670572454e196b7617a446769216722302f697a9 Reviewed-on: https://chromium-review.googlesource.com/c/1306973Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57250}
-
Frank Tang authored
Bug: v8:7834 Change-Id: Ib53448757bbaf785ff39ba0da6f54c91e449035b Reviewed-on: https://chromium-review.googlesource.com/c/1314113Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57249}
-
Daniel Clifford authored
CanUseSameAccessor<ElementsAccessor: type> is array-sort.tq is super performance-critical. Reverting the type-safe cleanup made in this function while landing Array.prototype.slice. Bug=chromium:852764 Change-Id: I1252d2ff8e431581f916794807e59abb39248abb Reviewed-on: https://chromium-review.googlesource.com/c/1317815Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#57248}
-