- 20 Jul, 2016 3 commits
-
-
jgruber authored
Revert of Move Error methods to C++ (patchset #11 id:200001 of https://codereview.chromium.org/2142933003/ ) Reason for revert: Clusterfuzz failures: https://bugs.chromium.org/p/chromium/issues/detail?id=629749 Original issue's description: > Move Error methods to C++ > > This ports a large portion of Error methods to C++, > including the constructor, stack setter and getter, > and Error.prototype.toString. > > BUG= > > Committed: https://crrev.com/5742da056a290caa13a0b8717ddb1e43424e0d31 > Cr-Commit-Position: refs/heads/master@{#37870} TBR=yangguo@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2159223004 Cr-Commit-Position: refs/heads/master@{#37881}
-
zhengxing.li authored
port 9be015a2 (r37854) original commit message: Calling Runtime::kAbort through a builtin instead of the c-entry stub will allow to generate the call in a background thread, because a builtin provides its own handle, whereas a code stub does not. @v8-mips-ports: Could you take a special look at the padding that is done in MacroAssembler::Abort()? BUG= Review-Url: https://codereview.chromium.org/2166703002 Cr-Commit-Position: refs/heads/master@{#37880}
-
v8-autoroll authored
Rolling v8/build to 4b2ee7d1824cdc45d8e3d4076c05f9a8af10e4ac Rolling v8/tools/mb to 3f6bbf669fa2b89399cead251fe693ce71132779 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2166433004 Cr-Commit-Position: refs/heads/master@{#37879}
-
- 19 Jul, 2016 33 commits
-
-
neis authored
In parser.{cc,h}, replace CHECK_OK_CUSTOM by CHECK_OK_VOID, as that's all we need. Use this to convert all void* functions to void. R=adamk@chromium.org, nikolaos@chromium.org BUG= Review-Url: https://codereview.chromium.org/2165513004 Cr-Commit-Position: refs/heads/master@{#37878}
-
bjaideep authored
Port 9be015a2 Original commit message: Calling Runtime::kAbort through a builtin instead of the c-entry stub will allow to generate the call in a background thread, because a builtin provides its own handle, whereas a code stub does not. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2166553002 Cr-Commit-Position: refs/heads/master@{#37877}
-
peterssen authored
Add additional sanity checks for implicit parameters, mainly to prevent passing a wrong context, which can lead to obscure errors. This is a regression test after https://crrev.com/da4f2491501e54d436ed448c5e345480d1f5906b BUG=chromium:508898 Review-Url: https://codereview.chromium.org/2160563003 Cr-Commit-Position: refs/heads/master@{#37876}
-
cbruni authored
We are enabling this trial on canary to see if we can flush out some missing context restores. BUG= Review-Url: https://codereview.chromium.org/2164633002 Cr-Commit-Position: refs/heads/master@{#37875}
-
oth authored
Copies the behaviour of FullCode in attempting to get the state for ForInPrepare inline and falling back to the runtime if necessary. BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/2155153002 Cr-Commit-Position: refs/heads/master@{#37874}
-
klaasb authored
This adds an additional column with percentages to the output of bytecode_dispatch_report.py --top-dispatches-for-bytecode. The percentages always represent the relative number of dispatches to the target bytecode to all dispatches from the source bytecode. The additional flag --sort-sources-relative/-r allows sorting the "Top sources of dispatches to" the given bytecode by this column to more easily find bytecodes that significantly often dispatch to the target. BUG=v8:4899 LOG=N Review-Url: https://codereview.chromium.org/2159683003 Cr-Commit-Position: refs/heads/master@{#37873}
-
mythria authored
Revert of [Interpreter] Collect type feedback for 'new' in the bytecode handler (patchset #6 id:100001 of https://codereview.chromium.org/2153433002/ ) Reason for revert: This cl causes a large regression in octane (https://chromeperf.appspot.com/group_report?bug_id=629503). I have to investigate the reason before I can reland this. Original issue's description: > [Interpreter] Collect type feedback for 'new' in the bytecode handler > > Collect type feedback in the bytecode handler for 'new' bytecode. The > current implementation does not collect allocation site feedback. > > BUG=v8:4280, v8:4780 > LOG=N > > Committed: https://crrev.com/1eadc76419b323fb2e55ae9953142f801704aa59 > Cr-Commit-Position: refs/heads/master@{#37862} TBR=rmcilroy@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280, v8:4780 Review-Url: https://codereview.chromium.org/2165633003 Cr-Commit-Position: refs/heads/master@{#37872}
-
jyan authored
Should use the same Mask code as float32 to int32 R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2160573003 Cr-Commit-Position: refs/heads/master@{#37871}
-
jgruber authored
This ports a large portion of Error methods to C++, including the constructor, stack setter and getter, and Error.prototype.toString. BUG= Review-Url: https://codereview.chromium.org/2142933003 Cr-Commit-Position: refs/heads/master@{#37870}
-
bmeurer authored
Instead of wriring the elements kind transitions into the control flow early on, we do instead put this marker into the effect chain, so that the elements transitions are visible to the LoadElimination and can thus be optimized properly there. This CL itself doesn't add any of those optimizations, but just adds the foundations to make them possible later. R=jarin@chromium.org BUG=v8:4930,v8:5141 Review-Url: https://codereview.chromium.org/2164573003 Cr-Commit-Position: refs/heads/master@{#37869}
-
verwaest authored
Eagerly set arguments_, new_target_ and ths_function_ Scope, and unset if we don't need to allocate them. This probably slightly speeds up AllocateParameterLocals, but more importantly it removes ast_value_factory_ uses. If we get rid of ast_value_factory from Scope it's easier to lazily allocate it later from within a ScopeState object. BUG=v8:5209 Review-Url: https://codereview.chromium.org/2158333002 Cr-Commit-Position: refs/heads/master@{#37868}
-
jochen authored
BUG=chromium:618305 R=verwaest@chromium.org CC=dcheng@chromium.org,haraken@chromium.org Review-Url: https://codereview.chromium.org/2162443002 Cr-Commit-Position: refs/heads/master@{#37867}
-
oth authored
Original issue's description: > [interpeter] Move to table based peephole optimizer. > > Introduces a lookup table for peephole optimizations. > > Fixes some tests using BytecodePeepholeOptimizer::Write() that should > have been update to use BytecodePeepholeOptimizer::WriteJump(). > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/f4234422b93b21a286b0f31799009bcbe8b90b9e > Cr-Commit-Position: refs/heads/master@{#37819} BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/2164583002 Cr-Commit-Position: refs/heads/master@{#37866}
-
jochen authored
I plan to use this from ApiNatives, so move it to a common location. BUG= R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2161613002 Cr-Commit-Position: refs/heads/master@{#37865}
-
nikolaos authored
This patch restores the status of rewritable expressions, which were not considered valid variable references before CL 2126233002, regardless of the type of the wrapped expression. R=mstarzinger@chromium.org, verwaest@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2158853002 Cr-Commit-Position: refs/heads/master@{#37864}
-
marja authored
This reduces memory usage when parsing (because temp_zones are discarded every now and then) and work done by FuncNameInferrer. BUG= Review-Url: https://codereview.chromium.org/2156013002 Cr-Commit-Position: refs/heads/master@{#37863}
-
mythria authored
Collect type feedback in the bytecode handler for 'new' bytecode. The current implementation does not collect allocation site feedback. BUG=v8:4280, v8:4780 LOG=N Review-Url: https://codereview.chromium.org/2153433002 Cr-Commit-Position: refs/heads/master@{#37862}
-
marija.antic authored
Port 8e18a5f2 Failing on r6 due to wrong registers used in macro assembler. TEST=test-run-machops/RunInt32MulWithOverflowImm BUG= Review-Url: https://codereview.chromium.org/2165533002 Cr-Commit-Position: refs/heads/master@{#37861}
-
yangguo authored
TBR=mstarzinger@chromium.org BUG=v8:5207 Review-Url: https://codereview.chromium.org/2154393003 Cr-Commit-Position: refs/heads/master@{#37860}
-
bmeurer authored
R=jarin@chromium.org BUG=chromium:629435 Review-Url: https://codereview.chromium.org/2161013002 Cr-Commit-Position: refs/heads/master@{#37859}
-
verwaest authored
This will allow us to move more state from Scope into ScopeState and lazily allocate full Scopes only when needed. BUG=v8:5209 Review-Url: https://codereview.chromium.org/2160593002 Cr-Commit-Position: refs/heads/master@{#37858}
-
yangguo authored
R=mstarzinger@chromium.org BUG=v8:5207 Review-Url: https://codereview.chromium.org/2159113002 Cr-Commit-Position: refs/heads/master@{#37857}
-
sxa authored
Adds option to build a V8 library statically, but with the options on windows that allows it to be subsequently included in another DLL. On Windows this is required for it to correclty link against the correct C++ runtime. Require for our Node.js shared library build. Reference: https://github.com/nodejs/node/pull/7487 BUG= R=machenbach@chromium.org, michael_dawson@ca.ibm.com Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d Review-Url: https://codereview.chromium.org/2149963002 Cr-Original-Commit-Position: refs/heads/master@{#37814} Cr-Commit-Position: refs/heads/master@{#37856}
-
martyn.capewell authored
For 64-bit cmp, replace the if clause with InputOperand2_64(), and apply the same change to cmn. BUG= Review-Url: https://codereview.chromium.org/2160643002 Cr-Commit-Position: refs/heads/master@{#37855}
-
ahaas authored
Calling Runtime::kAbort through a builtin instead of the c-entry stub will allow to generate the call in a background thread, because a builtin provides its own handle, whereas a code stub does not. @v8-mips-ports: Could you take a special look at the padding that is done in MacroAssembler::Abort()? R=bmeurer@chromium.org, titzer@chromium.org, mstarzinger@chromium.org, v8-mips-ports@googlegroups.com, v8-arm-ports@googlegroups.com Review-Url: https://codereview.chromium.org/2156923002 Cr-Commit-Position: refs/heads/master@{#37854}
-
bmeurer authored
BUG=chromium:629062 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2155323003 Cr-Commit-Position: refs/heads/master@{#37853}
-
mstarzinger authored
This allows to pass deoptimization reasons to the profiler without the requirement of always providing a source position. The absence of deopt reasons is now communicated via a sentinel as the deopt id value. The deoptimization reasons recently added to TurboFan are now passed to the profiler. R=bmeurer@chromium.org TEST=cctest/test-cpu-profiler Review-Url: https://codereview.chromium.org/2159793002 Cr-Commit-Position: refs/heads/master@{#37852}
-
nikolaos authored
R=adamk@chromium.org, littledan@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2154253002 Cr-Commit-Position: refs/heads/master@{#37851}
-
bmeurer authored
We need to pay attention to potential side effects from parameter evaluation when inlining the fast case Array.prototype.shift. R=yangguo@chromium.org BUG=chromium:614644 Review-Url: https://codereview.chromium.org/2161943002 Cr-Commit-Position: refs/heads/master@{#37850}
-
bmeurer authored
Introduce a proper CodeStubAssembler::BranchIfToBooleanIsTrue helper method, that branches to if_true/if_false labels depending on whether the value that is passed would yield true or false when fed to ToBoolean. Use this helper to implement the bytecode handlers w/o having to materialize the temporary booleans and essentially branching twice. The CodeStubAssembler::BranchIfToBooleanIsTrue helper favors the most likely case of a Boolean constant now. Also migrate the ToBooleanStub to a ToBoolean TurboFan builtin, that also uses the helper method under the hood. Remove the now obsolete Oddball::to_boolean field. R=hpayer@chromium.org, rmcilroy@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2151163002 Cr-Commit-Position: refs/heads/master@{#37849}
-
marija.antic authored
Port of 26ecb4a1 TEST=mjsunit/es6/math-fround Review-Url: https://codereview.chromium.org/2156123002 Cr-Commit-Position: refs/heads/master@{#37848}
-
v8-autoroll authored
Rolling v8/base/trace_event/common to f8c51e1c3b08cd1c03986f098732b87ba98a3475 Rolling v8/build to 1303552bdbd1791ad26b62f7c7052cbbf0326574 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2161933002 Cr-Commit-Position: refs/heads/master@{#37847}
-
weiliang.lin authored
BUG= Review-Url: https://codereview.chromium.org/2158923002 Cr-Commit-Position: refs/heads/master@{#37846}
-
- 18 Jul, 2016 4 commits
-
-
ivica.bogosavljevic authored
In case of deoptimization after WordCompare test, the control flow is lost in the unoptimized version of the code because wrong register is used for comparision (a0 instead of v0) TEST=mjsunit/regress/regress-3717 BUG= Review-Url: https://codereview.chromium.org/2160533003 Cr-Commit-Position: refs/heads/master@{#37845}
-
thakis authored
Review-Url: https://codereview.chromium.org/2160633002 Cr-Commit-Position: refs/heads/master@{#37844}
-
jochen authored
I want to use those methods from ApiNatives so move them to a shared location. BUG= R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2156153002 Cr-Commit-Position: refs/heads/master@{#37843}
-
jochen authored
Original issue's description: > Don't compile functions in a context the caller doesn't have access to > > Instead just return undefined > > A side effect of this is that it's no longer possible to compile > functions in a detached context. > > BUG=chromium:541703 > R=verwaest@chromium.org,bmeurer@chromium.org BUG=chromium:541703 R=verwaest@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.chromium.org/2155503004 Cr-Commit-Position: refs/heads/master@{#37842}
-