- 06 Sep, 2018 15 commits
-
-
Michael Achenbach authored
NOTRY=true Bug: v8:7285,v8:8140 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9cb216de302bc787189f8f12f5b254909b0f5773 Reviewed-on: https://chromium-review.googlesource.com/1208496 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55682}
-
Michael Stanton authored
This reverts commit 34625fdb. Reason for revert: Test caused timeout, investigating. Original change's description: > [Builtins] Array.prototype.forEach perf regression on dictionaries. > > An unnecessary call to ToString() on the array index caused trips to > the runtime. The fix also includes performance micro-benchmarks so > we'll have a harder time regressing this case in future. > > Bug: v8:8112 > Change-Id: Iada5bd2e3c6d2246fb1225e7094f3d9c66ddafbd > Reviewed-on: https://chromium-review.googlesource.com/1206355 > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55653} TBR=mvstanton@chromium.org,tebbi@chromium.org Change-Id: I21de9b9b33edf03f2173f579c4ba0fc3dfd8ff88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8112 Reviewed-on: https://chromium-review.googlesource.com/1209288Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#55681}
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org,mvstanton@chromium.org Change-Id: I8e558509dc324aa5efe1ccb09cb9959eaabc5720 Reviewed-on: https://chromium-review.googlesource.com/1209303Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This adds the ability to add exception types to the export section of a module and reference them via the local exception index. Currently the export object then just contains the local index as a number, which is only temporary until we have proper export wrappers for exceptions. Also note that this tightens the restriction for the modules exception section to be located in between the import and the export section. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-export BUG=v8:8091 Change-Id: Ie26081c3f94e71cb576057db7e45ec5bd0e112f9 Reviewed-on: https://chromium-review.googlesource.com/1206873 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55679}
-
Simon Zünd authored
Some helpers in array.js are now dead code after the recent changes to array builtins (splice/unshift). R=jgruber@chromium.org Bug: v8:8015 Change-Id: I3e0c0280516b539533bcc3b21d84e448112e4ec7 Reviewed-on: https://chromium-review.googlesource.com/1208632Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#55678}
-
Daniel Bratell authored
In jumbo builds, many files are compiled in the same translation unit and share the same anonymous namespace. Now both gap_resolver.cc and register-allocator.cc defined kFloat32Bit (a mask representation of MachineRepresentation::kFloat32) which clashed if those files were compiled together. This patch inlines and removed one of the constants. Change-Id: Ic79e077e62ce9866b6201ec61a9df1e66d5e4a13 Reviewed-on: https://chromium-review.googlesource.com/1206572Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#55677}
-
Michael Achenbach authored
This optional trybot runs all tests not run by the CQ bot, but run by the CI release or debug bot. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:7285 Change-Id: Ifda294448ba92b8055a633ef1e26b4045a38f718 Reviewed-on: https://chromium-review.googlesource.com/1207852 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Yang Guo authored
We use signed comparison when we compare the difference between SP and stack limit to the size we are going to push, but need to use unsigned comparison when we compare SP and stack limit directly. R=mvstanton@chromium.org Bug: chromium:876210 Change-Id: I3ca5233677c42aebadb78920592a7c6d8e33a825 Reviewed-on: https://chromium-review.googlesource.com/1206870Reviewed-by:
-
Michael Achenbach authored
Bug: chromium:866862 Change-Id: Ib6c89d88344c2348de155fd54eafa03cf18ea88d Reviewed-on: https://chromium-review.googlesource.com/1206631Reviewed-by:
-
Yutaka Hirano authored
Currently, neither IsSharedCrossOrigin nor IsOpaque is set for an empty script. Hence an exception thrown from it (e.g., an exception thrown from native promise implementation) is treated as an error with blink::kNotSharableCrossOrigin. On the other hand, as the script is empty, there is no meaningful URL attached, which means the ExecutionContext's URL is used as the script's name in blink::SourceLocation::FromMessage. In other words, it works virtually as same as blink::kSharableCrossOrigin corresponding to ScriptOriginOptions with IsSharedCrossOrigin set and IsOpaque unset. With this CL, a ScriptOriginOptions with IsSharedCrossOrigin is set and IsOpaque is not set is attached to the empty script, as a preliminary step to deprecate kNotSharableCrossOrigin. Bug: chromium:875153,chromium:876248 Change-Id: I39279a43994337329b8bd9d28b6ca29f0ac30d9c Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1201689Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#55673}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4ca6fa3..ebaffbc Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/70783e3..bcc3e49 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f215ae6..0f5a0b4 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/e0c4613..0953bbd TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic41cdb4c6db298364c6adf399d49ddc8e0e8c787 Reviewed-on: https://chromium-review.googlesource.com/1208304Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55672}
-
Sathya Gunasekaran authored
Bug: v8:5751, chromium:881021 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I22514ceb5fb0953b728e67ba5266926e912ce9c1 Reviewed-on: https://chromium-review.googlesource.com/1208516Reviewed-by:
-
Simon Zünd authored
This CL implements a generic baseline version of Array.p.unshift in Torque, enabling us to remove the JS fall-back. The elements-accessor fast-path is still used, but the check whether to use it is also moved to Torque. Support for sparse JSArrays is removed. Drive-by change: Small refactoring in builtins-array that will get extended to other array builtins in a follow-up CL. R=cbruni@chromium.org, jgruber@chromium.org Bug: v8:7624 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7b23ce15e7b922eb333f61a408050dedec77c95a Reviewed-on: https://chromium-review.googlesource.com/1189902 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Yang Guo authored
This reverts commit f2c943fa. Reason for revert: Non-flaky failures here: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/20374 Original change's description: > [intl] Port collator#resolvedOptions to C++ > > Bug: v8:5751 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I236dd3a1b5390911a6c668201aec33e7db1cbd53 > Reviewed-on: https://chromium-review.googlesource.com/1208650 > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55668} TBR=yangguo@chromium.org,gsathya@chromium.org,usharma1998@gmail.com Change-Id: I018815ec7e3e692cc76a25590c2197a6cf37cc37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1208571Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55669}
-
Ujjwal Sharma authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I236dd3a1b5390911a6c668201aec33e7db1cbd53 Reviewed-on: https://chromium-review.googlesource.com/1208650 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55668}
-
- 05 Sep, 2018 25 commits
-
-
Sathya Gunasekaran authored
Bug: v8:7834 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie66f443b86d3cf7bd64cc338d84231045ca5e3c6 Reviewed-on: https://chromium-review.googlesource.com/1208517Reviewed-by:
-
Deepti Gandluri authored
BUG: v8:6532, chromium:874809 Change-Id: I55c00e8563741908cf0daf263152ce927ae18e7c Reviewed-on: https://chromium-review.googlesource.com/1205812 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55666}
-
Ujjwal Sharma authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7b126a318480c0d35d6440aa7aea109529ea8ee2 Reviewed-on: https://chromium-review.googlesource.com/1208651 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Previously in the JS implementation, this would throw (on property access) but this new behavior is more in line with how all the other intl objects work. Bug: v8:5751, chromium:880697 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I0bd073b2a0a6fc1eacd686083d8f1a72252cea53 Reviewed-on: https://chromium-review.googlesource.com/1207579 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Ujjwal Sharma authored
Bug: v8:5751 Change-Id: I978b5b1da41040132204b64dde3f44985b44255d Reviewed-on: https://chromium-review.googlesource.com/1208110 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Ujjwal Sharma authored
Change-Id: I4013a966c1f651f5e6cabfbc3f64a08eb01d0dad Bug: v8:5751 Reviewed-on: https://chromium-review.googlesource.com/1207670Reviewed-by:
-
Ujjwal Sharma authored
Rename all BreakIterator builtins from BreakIterator to V8BreakIterator. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I49437096e5a53d85f229421ddae8d61a7164d9a9 Reviewed-on: https://chromium-review.googlesource.com/1207410 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Junliang Yan authored
Use pc relative code on poisoning to allow relocation of bytecode handler. This is allow v8_enable_embedded_bytecode_handlers on ppc. Bug: v8:8068 Change-Id: I6e0a1e961e7e903f0935131cfc190c89c404cf67 Reviewed-on: https://chromium-review.googlesource.com/1205610 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Muntasir Mallick <mmallick@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55660}
-
Yannic Bonenberger authored
Change-Id: I2992b0db7f403f682032f9b427c1f8c5238cf61e Reviewed-on: https://chromium-review.googlesource.com/1205290Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55659}
-
Sathya Gunasekaran authored
Bug: v8:5367 Change-Id: I7c65840b62a461de87dc88f8dd2e31eba47e8adf Reviewed-on: https://chromium-review.googlesource.com/1205818Reviewed-by:
-
Benedikt Meurer authored
The Math.expm1() function can actually return -0, for example in the case that -0 is passed to it. Bug: chromium:880207 Change-Id: If3a7a3a1fb6a18075ba0d7816687dfd831ebe293 Reviewed-on: https://chromium-review.googlesource.com/1205072Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55657}
-
Michael Lippautz authored
Allow mocking the limits for ArrayBuffer allocation to simulate operating system OOM. Fixes: - Ensure OS limit > hard limit for external memory. This is necessary as any processing below the hard limit is opportunistic. E.g. a running sweeper may stall the current marking (GC) round. - Immediately process AB allocations when under memory pressure. Otherwise, the allocations may be stuck in a stalled task. Freeing them upon adding them to the collector still enables parallelism if possible. This reverts commit f3ad6cdb. Bug: chromium:845409 Change-Id: Ic3e458f2af231bae3d53afcfd6002a0347d3f12b Reviewed-on: https://chromium-review.googlesource.com/1206872 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I2e461f3f7b3abc666ed5dcc3294a14d27ef0fe60 Reviewed-on: https://chromium-review.googlesource.com/1194583Reviewed-by:
-
jgruber authored
This switches on a restricted register allocation for all CSA-generated builtins on ia32, which treats the kRootRegister (=ebx) as unallocatable. A few builtins are explicitly excluded. These still need to be fixed in follow-up CLs. But I'd like to bake this in now to ensure we don't add more code that cannot handle restricted allocation. All of this is still behind the (disabled-by-default on ia32) v8_embedded_builtins configuration. Bug: v8:6666 Change-Id: If5268aa00439406e1f4e0f7ee18496715a95fdd2 Reviewed-on: https://chromium-review.googlesource.com/1206874Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55654}
-
Mike Stanton authored
An unnecessary call to ToString() on the array index caused trips to the runtime. The fix also includes performance micro-benchmarks so we'll have a harder time regressing this case in future. Bug: v8:8112 Change-Id: Iada5bd2e3c6d2246fb1225e7094f3d9c66ddafbd Reviewed-on: https://chromium-review.googlesource.com/1206355 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55653}
-
jgruber authored
This mostly pushes code around (from the two specialized public ctors to the ConfigureFlags method), but does include one behavioral change in that all builtins/stubs/handlers now disables switch jump tables. Bug: v8:6666 Change-Id: I801d5bdc7a9c4bcc3bc5eb467a7c049404ffaff0 Reviewed-on: https://chromium-review.googlesource.com/1201785Reviewed-by:
Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This CL adds static assertions (in Liftoff) and DCHECKs (in wasm compiler) to validate that the size of loaded fields from the wasm instance object matches the expected size. This is to avoid future bugs where we change the size of integer fields and forget to update all code that uses these fields. R=titzer@chromium.org Bug: v8:8130, v8:6600 Change-Id: Ib7273800029135b851c0f0b1ca52886783b61fb0 Reviewed-on: https://chromium-review.googlesource.com/1203836 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55651}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: If4086054af6125c252acfbf32074e40ed98b8222 Reviewed-on: https://chromium-review.googlesource.com/1206356 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Bug: v8:7964 Change-Id: I540aa0f9b64969f70822f3956d5f9d0a0ea0fde2 Reviewed-on: https://chromium-review.googlesource.com/1206710Reviewed-by:
-
Camillo Bruni authored
The two bool parameters are used for DCHECks in most places. By introducing more specialized enumes kAccessorGetterProperty and kAccessorSetterProperty we can simplify the checks. Bug: v8:7926 Change-Id: I61023f2da0d96ca5a4fba65c6ead309567144786 Reviewed-on: https://chromium-review.googlesource.com/1202822 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55648}
-
Stephan Herhut authored
Change-Id: I34ad8910949e8eb265df53d66f79b315b4a990e6 Reviewed-on: https://chromium-review.googlesource.com/1206630Reviewed-by:
-
Clemens Hammacher authored
The main goal is to untangle Liftoff from the TF-based wasm compiler, but since the AccessBuilder does not simplify anything but rather adds complexity I also removed it from the wasm compiler. Instead, we now bottleneck all offset computations through the new ObjectAccess helper. R=titzer@chromium.org Bug: v8:6600 Change-Id: I362b7b889d68e89da8c30d3fad7b5bab07bee5c8 Reviewed-on: https://chromium-review.googlesource.com/1204090Reviewed-by:
-
Dan Elphick authored
Shrink embedded.cc by writing out octa words instead of bytes. This halves the size of the generated file from 28MB to 14MB in a debug build and reduces compile times for the file from ~2s to ~0.6s. Bug: v8:8129 Change-Id: I90893c7732d83f4eeedee964cd81958201e3b05c Reviewed-on: https://chromium-review.googlesource.com/1204111Reviewed-by:
-
Andreas Haas authored
V8 does not require the embedder to open a HandleScope before executing a v8::Task. However, d8 does open such a HandleScope. Because of that HandleScope we repeatedly found missing HandleScopes only in Chrome tests and not in d8 tests. The same is true for the context, which is not set when Chrome calls a v8::Task. With this CL we create a SealHandleScope around the execution of a v8::Task, and we set the context to nullptr, so that d8 matches Chrome better. Ideally d8 would not open a HandleScope in the first place, and would not set a context. Both make d8 behave different than Chrome and thereby may hide bugs from our testing infrastructure. However, the implementation of the InspectorClient requires them. I think the SealHandleScope and resetting the context is a good workaround at the moment. Yang, do you know if we can get rid of the context there in the long run? R=yangguo@chromium.org Change-Id: I8df0fabde7dfdcdc630d20af4c68f141ac3a454c Reviewed-on: https://chromium-review.googlesource.com/1177742Reviewed-by:
-
Michael Achenbach authored
Path names in import/export statements are relative to the file they are in. This fixes the logic and unblocks using the messages test suite on Android, which has cases importing files from mjsunit, which import more files from there. Bug: chromium:866862 Change-Id: I8d2ff645f69b67fbdaf4a622d06308e55298b0ce Reviewed-on: https://chromium-review.googlesource.com/1206570Reviewed-by:
-
