- 06 May, 2020 33 commits
-
-
Clemens Backes authored
This reverts commit 8c8e6b41. Reason for revert: Makes Mac64 debug quite flaky: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac64%20-%20debug/28766 Original change's description: > [offthread] Serialize new-space objects into old space > > If an object made it into serialization, it probably deserves to be in > old space when it is deserialized. This will also make off-thread > deserialization simpler, as there is no off-thread new space. > > Bug: chromium:1075999 > Change-Id: Icabf2f0ae0a3e0205a1094dd0ffe675e69bd1d8e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184291 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67606} TBR=ulan@chromium.org,jgruber@chromium.org,leszeks@chromium.org Change-Id: I0baca3c3b7985fcda6b9055f93111ec99c207d29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1075999 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183925Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67615}
-
Manos Koukoutos authored
Motivation: There were three versions of type decoding for wasm in the codebase. Not all of them decoded gc types with immediates (reference types) correctly. Changes: - Refactor the wasm binary decoder for unify type decoding. - Update BranchTypeImmediate and SelectTypeImmediate to handle reference types. Reference: https://github.com/WebAssembly/gc R=jkummerow@chromium.org Bug: v8:7748 Change-Id: I33b38c911d366570ca6ef2723ded5205698e1979 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179003 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67614}
-
Dan Elphick authored
This is a reland of afd9493a LSAN_IGNORE_OBJECTs for FreeListCategories are now removed. Original change's description: > [heap] Remove FreeList when sealing RO_SPACE > > This releases the FreeListCategories for each MemoryChunk when sealing > the ReadOnlySpace and deletes the FreeList. > > Additionally this also calls > ReleaseAllocatedMemoryNeededForWritableChunk for each MemoryChunk when > sealing when pointer compression is enabled even if no memory is to be > shared. > > Bug: v8:10454 > Change-Id: I45aec59f6d4fddedeb713e13095f58974cda279e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184292 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67598} Bug: v8:10454 Change-Id: I08fcd122437c65c01af526fa8316d5c9e3ebeb3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184297 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67613}
-
Igor Sheludko authored
Bug: v8:10484 Change-Id: I977c5974d33472f5af20d7646ad4cf2c58049632 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182452 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67612}
-
Jakob Gruber authored
These will be used by ic-collecting builtins called from both bytecode handlers and js-generic-lowering. For now only x64 is implemented. Bug: v8:8888 Change-Id: I12a21b40061b7cb6c9b3cbad6134e7457a6cfa44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184237 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#67611}
-
Nico Hartmann authored
When the input to a speculative BigInt operation was an undefined constant, no necessary type check was inserted by the RepresentationChanger. This CL fixes this. Bug: chromium:1077804 Change-Id: I3d4e15b1e018803d56e46c7b23b9d4b03832ba8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182455 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#67610}
-
Leszek Swirski authored
This patch unfies the finalization logic between the various unoptimized compilation paths in compiler.cc, taking the various post-processings and fixups needed for off-thread finalization and performing them in the same order for the other finalizations. It also unifies the general compilation path between streaming script compilation, main-thread script compilation, and main-thread lazy compilation, making the main-thread paths both use an iterative execution and finalization, and making all three use the same job helper methods and overall finalization helper. Bug: chromium:1011762 Change-Id: Ibe56f6d2f75a2deffbe9e0b600ded8a02293b722 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172790 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#67609}
-
Leszek Swirski authored
Move rewriting, scope analysis, and internalization, to be unconditional operations done after parsing rather than a separate compile phase. This removes some of the complexity about rememberering when to call Compiler::Analyze, and makes these paths a bit more uniform. Also, forbid allocating any more AST strings after AstValueFactory internalization, by nulling out the Zone. Add an InternalizePartial method which doesn't null out the zone for those cases where we do want to be able to allocate after internalizing (e.g. internalization before scope analysis). Change-Id: Id444246d8362a1d169baf664fc37657d9576fd96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182458Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#67608}
-
Clemens Backes authored
Interpreter entry compilation was removed in https://crrev.com/c/2172962. This CL removes the {WasmInterpreterEntryFrame} and the corresponding {WASM_INTERPRETER_ENTRY} code kind. Some follow-up cleanups are left as TODOs. R=jkummerow@chromium.org,bmeurer@chromium.org Bug: v8:10389 Change-Id: I1a43eba1ac1a751e05990c688088d99fc901231f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182456Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67607}
-
Leszek Swirski authored
If an object made it into serialization, it probably deserves to be in old space when it is deserialized. This will also make off-thread deserialization simpler, as there is no off-thread new space. Bug: chromium:1075999 Change-Id: Icabf2f0ae0a3e0205a1094dd0ffe675e69bd1d8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184291 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67606}
-
Clemens Backes authored
{base::Vector} comparison is easier to read (IMO), and more performant, since {memcmp} will be used internally instead of {strncmp}. R=ahaas@chromium.org Bug: v8:10155 Change-Id: If92361688a85e96aa661d3e05cc9966e5ea2d04a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2164796Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67605}
-
Jakob Gruber authored
Just alpha-sort the list. Tbr: ishell@chromium.org Bug: v8:8888 Change-Id: I8b31f4176d5ad623557a3c0d8ab3f6be80072566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184236Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67604}
-
Nico Hartmann authored
This reverts commit afd9493a. Reason for revert: Speculative revert due to https://ci.chromium.org/p/v8/builders/ci/V8%20Clusterfuzz%20Linux%20ASAN%20arm%20-%20debug%20builder/14978? Original change's description: > [heap] Remove FreeList when sealing RO_SPACE > > This releases the FreeListCategories for each MemoryChunk when sealing > the ReadOnlySpace and deletes the FreeList. > > Additionally this also calls > ReleaseAllocatedMemoryNeededForWritableChunk for each MemoryChunk when > sealing when pointer compression is enabled even if no memory is to be > shared. > > Bug: v8:10454 > Change-Id: I45aec59f6d4fddedeb713e13095f58974cda279e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184292 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67598} TBR=ulan@chromium.org,delphick@chromium.org Change-Id: I135c1ebc2340a75a30305b84625710ef14d9cdb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10454 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183921Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67603}
-
Leszek Swirski authored
Enable the use of Heap::AlignWithFiller off-thread by making the method static. Bug: chromium:1075999 Change-Id: I8071ae678f954dd4e960b2cd83f63dd22a948920 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184230Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#67602}
-
Nico Hartmann authored
Bug: v8:10391 Change-Id: Ic92cdaca38c2181427cc12ec5e572d5964afe704 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2152647Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#67601}
-
Leszek Swirski authored
Allow ReadOnlyRoots initialization from an OffThreadHeap, by creating a FromHeap getter on OffThreadIsolate analogous to the one on Isolate. Bug: chromium:1075999 Change-Id: Ie00e1547160e24d35bd7b0dd36d1b7eead87341e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184289Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#67600}
-
Leszek Swirski authored
Allow cleared references to be created with an OffThreadIsolate. This includes allowing isolate_root to be accessed from the OffThreadIsolate, for pointer decompression. Bug: chromium:1075999 Change-Id: I62e0fe2c1c6166a7b816593ae1ec5ddb1c25d861 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183911 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#67599}
-
Dan Elphick authored
This releases the FreeListCategories for each MemoryChunk when sealing the ReadOnlySpace and deletes the FreeList. Additionally this also calls ReleaseAllocatedMemoryNeededForWritableChunk for each MemoryChunk when sealing when pointer compression is enabled even if no memory is to be shared. Bug: v8:10454 Change-Id: I45aec59f6d4fddedeb713e13095f58974cda279e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184292Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#67598}
-
Clemens Backes authored
When updating the native module cache, the native module must have been created in the same engine before. Hence replace a conditional by a DCHECK, and add two more DCHECKs to ensure that all involved modules belong to the same engine. R=thibaudm@chromium.org Bug: v8:6847 Change-Id: Ieb66b6b0bda40cd3c4637d38918762bc01c3a2d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182640Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67597}
-
Jakob Gruber authored
Upon deserialization, serialized references to the global proxy are replaced by the actual global proxy object. We must do the same for the global proxy map. Drive-by: Updated other outdated test skips. Bug: v8:10504,v8:10416 Change-Id: Ib47ae2d08bbea2ca916f53152e9d4f75bb0a0e15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183913Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67596}
-
Ross McIlroy authored
Fully remove the successor blocks when effect-control-linearization reaches an unreachable node and is maintaining the schedule. Previously we just updated the current_block_'s successor and removed any unreachable predecessors from end, however if the current_block_ is not an original block in the schedule, but a new one added due to control flow from effect control linearization lowering, the removed successor blocks could still be re-connected to the end block when they were lowered. Instead, entirely remove these unreachable blocks from the predecessor / successor chains, and have the effect-control-linearizer avoid lowering these blocks entirely. BUG=chromium:1076569,v8:9684 Change-Id: I4b4216019d55aef5363d88255726b85df8e7ada5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179842Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#67595}
-
Leszek Swirski authored
The Isolate* parameter in the deserializer SanityCheck is unused, and is blocking the use of the deserializer off-thread. Bug: chromium:1075999 Change-Id: I0f2acae3c1aff62aafeb2680a2eecb44b1608803 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184290 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67594}
-
Tobias Tebbi authored
Change-Id: I4f610400eab6e24fb7eb06465ca9abc63d20fdb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182474Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67593}
-
Andreas Haas authored
This CL implements all variants of CompareExchange on arm. Implementing 64-bit CompareExchange on arm requires a lot of registers, with the additional constraint that the low-word register of new_value and result have to have an even register code, and that the corresponding high-word registers have a register code that is by one higher than the register code of the low-word register. This register allocation is achieved by assigning fixed registers to all values. R=clemensb@chromium.org, v8-arm-ports@googlegroups.com Bug: v8:10108 Change-Id: I2edfde15e80db0d45621a461793018d88e997431 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172791 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67592}
-
Tobias Tebbi authored
Bug: v8:10421, v8:7793 Change-Id: If11fc7666f04ed0914f5fdfcdaa87acb8655d956 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2169100 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#67591}
-
Marja Hölttä authored
There's no need for them to be in NativeContext. This CL moves the minimal subset of SFIs related to async functions and async generators. Bug: v8:10482 Change-Id: Ic90e342ae77b406c12dedf6b8f7e3fadb661b205 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179843 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67590}
-
Clemens Backes authored
So far we operated under the assumption that only a small number of modules is being created (and live) at a time, typically just one. Recently we saw webpages that create multiple modules at the same time. These counters should give us more insight into the typical number of modules in the wild. R=ecmziegler@chromium.org CC=jwd@chromium.org Bug: chromium:1076767 Change-Id: I81f657ee76ea155f0df2a5828e6b0f686a7ce7d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182376Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67589}
-
Zhao Jiazhong authored
Port c0eee179 https://crrev.com/c/2157648 Original Commit Message: ROL will be optional operator as arm, arm64 only have ROR. The reason for this CL is inefficient Wasm codegen for 64-bit left-rotation. Change-Id: I014575d300a97c6fb7dc54d89328fd997d314d92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182219Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#67588}
-
Jakob Gruber authored
These are currently expected to fail quite often since support is still incomplete. Let's add them to fyi bots for now and extend coverage later. Bug: v8:10416,chromium:1043058 Change-Id: I1fe60c85f3fcf1e7e2981c28908208b348150b7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181286 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#67587}
-
Clemens Backes authored
The number of worker threads in the default platform is currently capped at 8. At runtime, it's also capped by the number of actual cores available. Since d8 is often used for benchmarking (both internally and externally), this CL slightly increases the maximum to 16. At least wasm compilation is known to scale beyond 8 threads. If this increase does not cause any problems on bots, we might increase further in the future. R=mlippautz@chromium.org Change-Id: I04e138c51d7dc26c38b9384c8ea67a883c976050 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182454 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67586}
-
Jakob Gruber authored
The serializer currently cannot handle a heap state containing arbitrary compiled Code objects. As a quick fix for the --stress-snapshot d8 flag, we clear compiled data from the isolate prior to the serialize-deserialize-verify pass. With this change, mjsunit tests pass on x64. The %SerializeDeserializeNow() runtime function would require more work, since it is not possible to mutate the heap to this extent while still preserving a runnable host context and isolate. We will need another solution there. Drive-by: Skip the stress_snapshot variant except for the mjsunit suite. Tbr: machenbach@chromium.org Bug: v8:10493,v8:10416 Change-Id: Ie110da8b51613fcd69c7f391d3cf8589d6b04dd8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182429Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67585}
-
Jakob Gruber authored
The isolate snapshot must not contain context-dependent objects, thus root visitation must not reach context-dependent objects. This CL sanitizes the isolate around serialization by clearing & later restoring two lists: 1. feedback vectors for profiling tools, 2. detached contexts. Drive-by: Set an array buffer allocator for SerializeDeserializeAndVerify. Drive-by: Allow serialization of *another* native context when serializing a native context. Bug: v8:10416,v8:10493 Change-Id: I1c49bda364eccd6d44f9499a9926f4bcd31f665d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179008Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67584}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8aef078..3c7540e Rolling v8/third_party/aemu-linux-x64: i0Kh0s13OUsO28Cn7E_Vm5Rv0jN7IXSm_qrvu2cBDmMC..J3cO22hWB2vC_byojuODbkHgkNGvxvrCAEPaKGOx3GwC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/cd56abf..c5ffb21 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0f47d33..4de5413 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ibe41d58bb62a7c53bf223f40892dfedac1da38bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183356Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67583}
-
- 05 May, 2020 7 commits
-
-
Ng Zhi An authored
Bug: v8:10180 Change-Id: I8026a25d9b1a62a7c5d7b20b99f6474374333445 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2171551 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67582}
-
Anton Bikineev authored
This ports sweeper logic from Blink into a separate entity - Sweeper. Concurrent sweeping is in a followup. Bug: chromium:1056170 Change-Id: I41196225f0d882cb0ab5190d23e297ee2498df6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2167858 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67581}
-
Seth Brenith authored
Marja pointed out that the following code causes a Torque crash: Convert<Smi>(MessageTemplate::kFoo) This change is a small fix to not crash in that case. Bug: v8:7793, v8:10475 Change-Id: I7856366856a4cd7facdb19686a2d4c92b0d04516 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182175Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#67580}
-
Dan Elphick authored
Removes spurious self-include in src/heap/memory-chunk.h Bug: v8:10473 Change-Id: I0bdf3b6b62f3b3a241225a99d681ddc1f1bd6bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181329 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67579}
-
Ng Zhi An authored
It was assuming that the input is always a register, but it isn't. Bug: chromium:1078399 Change-Id: If14abb8ea34f9febfc04a67a8da260a7e66af7f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182176Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67578}
-
Deepti Gandluri authored
Revert "[compiler,api] Pass non-strings to the modifying callback when unconditional codegen is on." This reverts commit 0c9a0072. Reason for revert: Breaks tests on the blink bots, will block roll. https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux/4465 Original change's description: > [compiler,api] Pass non-strings to the modifying callback when unconditional codegen is on. > > In the current state, when unconditional compilation is on, strings are evaluated and other objects are passed through unchanged. After this, non-strings are passed to the modifying callback which could unwrap and eval them. eval(string) is not affected. > > If a non-modifying callback is set, it still takes the precedence, and the non-string object is returned as it would be currently (line 1933). > > Change-Id: I835b976b3420635baba245c08f8563a9e5b3b246 > Bug: chromium:1024786 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1917147 > Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67570} TBR=vogelheim@chromium.org,mvstanton@chromium.org,ssanfilippo@chromium.org,verwaest@chromium.org Change-Id: I75637347e92e805361f954be3515f84ca55d756b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1024786 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182178Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67577}
-
Georg Neis authored
Bug: chromium:1076708 Change-Id: I7f065791310606e11fe89936a36f0fe7cb0d38e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182639 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67576}
-