- 18 Jul, 2022 27 commits
-
-
ishell@chromium.org authored
... in order to avoid expensive computation of cage_base for Code objects and in order to avoid issues with wrong cage base values computed from Code objects in external code space. Drive-by: cage-bas'ify some accessors in JSFunction and Code. This is a step towards Code-less embedded builtins. Bug: v8:11880 Change-Id: I95dd8bcd4680e09c7463e1bc7d72dcbf9f2e5c1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769831Reviewed-by:
Patrick Thier <pthier@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#81788}
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: Ib8fadc272178fb0d49f7d5fab7d1953e2328a1ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3770107 Auto-Submit: Matthias Liedtke <mliedtke@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81787}
-
ishell@chromium.org authored
Bug: v8:11880 Change-Id: I07d5811132d2b1e3cb853f58972970c77fdae026 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769697 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Drive-by: Fix incorrect typing of Phi node in JSTypedLowering::ReduceJSHasInProtoypeChain Bug: v8:12619 Change-Id: Iac6e04e7de7596caa11d021f2cb0759b50aa9bc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3755113Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#81785}
-
Thibaud Michaud authored
Until crbug.com/1269989 is completely resolved. R=clemensb@chromium.org Bug: chromium:1269989 Change-Id: I35f6278425857d727ea99470d9531fd70a58a3c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769692 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81784}
-
ishell@chromium.org authored
... which might be undefined during initialization. Bug: v8:13054 Change-Id: Ia3a7a95ffb1133b5d3d299c36bfb3875bcee2dfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769830Reviewed-by:
-
Andreas Haas authored
This change already landed for x64, now come arm and ia32. The code already existed for arm64. The wasm instance got pushed three times in the lazy-compile builtin: 1) as part of the parameters; 2) as a parameter for the runtime function; 3) to load the jump table address after the runtime function; The third push can be avoided by loading the jump table address after all parameters get loaded from the stack again. R=clemensb@chromium.org Bug: v8:13049, v8:12926 Change-Id: Ifdbe943520c031ec5c480798694bcacc490a64bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764348Reviewed-by:
-
Clemens Backes authored
This is a reland of commit 8218c061. Compile errors on mac arm64 are fixed. Original change's description: > [wasm] Reset PKRU before spawning new threads > > We sometimes hit the DCHECK in the wasm code manager: > DCHECK_IMPLIES(writable, !MemoryProtectionKeyWritable()); > > This is because we spawn new threads while having a > {CodeSpaceWriteScope} open. In the case of PKU, this changes the PKRU > register to allow writes to the code space, and the value of that > register is inherited by any new thread. If this thread then tries to > switch to writable code spaces, it hits the DCHECK. It would hit a > similar DCHECK when trying to execute code. > > We fix this issue by temporarily resetting the PKRU register to > non-writable while we call the {NotifyConcurrencyIncrease} method. This > is not a very robust solution, as any new call that potentially happens > inside a {CodeSpaceWriteScope} needs to do the same, but refactoring the > code to avoid spawning new threads while being in writable state would > be a lot of work with other downsides. > > R=jkummerow@chromium.org > > Bug: v8:13075 > Change-Id: Ibc7270aa597902dc6d9649cb6bcdfce8b1a9bafc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3762579 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81729} Bug: v8:13075 Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_compile_rel Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_compile_dbg Change-Id: I2e634959c969fc022393ae51c391397c7195ee54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769829 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Leszek Swirski authored
We check page flags in the deferred write barrier, and bail out early if pointers to that page are not interesting. Make sure that the slot register saving happens after that early bailout, to avoid unbalanced push/pop. To avoid bugs like this in the future, add a stack size check as a prefix to every node's code gen. Bug: v8:7700 Change-Id: I54a00fcbc843d473a1ca1e6cf3d852a0c60621c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769695Reviewed-by:
Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#81780}
-
ishell@chromium.org authored
... in particular: * safepoint table accessors, * constant pool accessors, * handler table accessors. This is a step towards Code-less embedded builtins. Bug: v8:11880 Change-Id: I50c21000a821d0895295e4003ab321ddd8856546 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764349Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#81779}
-
Clemens Backes authored
The stack offsets of cache slots are always positive, but the compiler does not know that. The lack of this knowledge makes division by the system pointer size significantly more expensive. One solution would be to rewrite the division to be an actual right shift. Another solution is to teach the compiler that offsets are positive. This CL does the latter. This reduces the overall Liftoff compile time of the reproducer in the linked issue by nearly 25%. R=jkummerow@chromium.org, cbruni@chromium.org Bug: v8:13063 Change-Id: Ib55b35d407e9909c792ae095a6767aaa03faebdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3760453Reviewed-by:
-
Manos Koukoutos authored
Mostly test/cctest/. Bug: v8:13006 Change-Id: I8853d38feb79bed6234a4354ab25a13255a1871b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3755149 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
ishell@chromium.org authored
... for configurations with disabled pointer compression. Bug: v8:12797, v8:13059 Change-Id: I0547ded7934f1f28a4c2ca45738fefd7311576c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3763868 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#81776}
-
Manos Koukoutos authored
In {ControlPathState} with {kMultipleInstances}, a node should be able to be mapped to different states, but not twice to an identical state. Change-Id: Ida340a6f4f5e891f586d5a90e7ae818f24dfbe98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769693 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: -
Marja Hölttä authored
In this part: at Drive-by: test helper cleanup Bug: v8:11111 Change-Id: I760d0c4ee078c397c8a8365ec96101b488986d41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764344Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#81774}
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: Ie39a12097f287e0eaf7e3f6c0072dd4cd5a40457 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764347Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com> Reviewed-by:
-
Manos Koukoutos authored
Templetize ControlPathState on whether multiple states are allowed for the same node. Instantiate BranchElimination to allow a single state per node, and WasmGCOperatorReducer to allow multiple. This fixes a performance regression caused by crrev.com/c/3717994. Bug: chromium:1339826 Change-Id: Id52d643daad618f45c3d8509f2a661e177609a0c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3754941 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Samuel Groß authored
The sandbox crash filter must be installed after the sandbox has been initialized, which now happens during V8::Initialize. Bug: v8:10391 Change-Id: I0103e32f091843415aaff4ec1c9bd93603244144 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769689Reviewed-by:
-
Liviu Rau authored
- Removed duplication and unnecessary indirection from all suites testcfgs. - Introduced a more comprehensive context to cover both command context and other platform specific concerns. - Propagated above context to TestLoader to allow for test counting command execution on all platforms. - Wrapped original pool with another class to give it a new interface and allow injecting different implementations in the future. - Consolidated progress indicators under a single processor in the pipeline. - Consolidated result retention requirements calculation outside of pipeline chain. - Refactored LoaderProc and got it under tests. - Added some more tests for the standard runner. - Extracted BuildConfig class. Bug: v8:12785 Change-Id: I87be040e91f792a983662bb5a10d55b36a14ea7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3701595Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#81770}
-
Michael Lippautz authored
The configuration was only enabled behind `cppgc_enable_object_names = true` Bug: chromium:1321620 Change-Id: Id762a0603e6788ad218cc367b44c71a5c0f48e95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769827 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81769}
-
Alexander Schulze authored
Change-Id: Ia2cf7a509736ef6a9400b81a5726c717ac3c82b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3763869Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: v8:7700 Change-Id: I0fb6de81c924e8200bd0c3117e3bf08e0365d939 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764346 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#81767}
-
Michael Achenbach authored
Also sort the owners entries. No-Try: true Change-Id: Ie59dcd47bdf1e644cef9f1dc96201bdc1fcfdd38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769686Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/1531ee0..48c2d1c Expose google_benchmark.State for python bindings. (#1430) (Ross McIlroy) https://chromium.googlesource.com/external/github.com/google/benchmark/+/48c2d1c Suppress nvcc `offsetof` warning (#1429) (Cezary Skrzyński) https://chromium.googlesource.com/external/github.com/google/benchmark/+/4efcc47 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I758c48c4c5c061d980026f298531bb5d09e1f78d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3767890Reviewed-by:
-
Michael Achenbach authored
No-Try: true Bug: chromium:1292013 Change-Id: I5e30116230d88f2f38d20451735c5713691f2af2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3521791Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81764}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5c74423..679de1e R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I0e93dc6623c0bb15e9bb603bc8aae4e0362d6c44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3767889 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81763}
-
Hao Xu authored
Baseline compiler generates instructions for bytecode JumpLoop with the below layout: [OSR Check Armed] [OSR Handle Armed] [Jump Loop Header] This CL advances [Jump Loop Header] and the layout will be: [OSR Check Armed] [Jump Loop Header] [OSR Handle Armed] This can reduce the sizes of loops in baseline code. Change-Id: I0a3996fddffd33caaef965c05f5c2593ad8951bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3759947Reviewed-by:
-
- 17 Jul, 2022 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/84a5cd0..5c74423 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I0df2e2bc9e6b0480a63b52cfe0d5e933a06aaa70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3767886 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81761}
-
- 16 Jul, 2022 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/39eb47b..84a5cd0 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I5ecd049de24372eae11805995578512b22e5dba0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3766879 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81760}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8805677..1240e97 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/26bc518..8168f76 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I3f652ae4921ec21a276a82429dc231f2f1231b9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3766878 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81759}
-
- 15 Jul, 2022 10 commits
-
-
Michael Lippautz authored
- Avoid adding an Invalid type that can never be reached during traversal; - Expose class names as object names; Bug: chromium:1321620 Change-Id: Ie3d9f78d97703535ecf67d56235d564ab6a9a7e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3763866 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Milad Fa authored
This CL refactors simd load/store to accept a scratch register which will be used in macro-asm. LE enforced versions of them is also introduced. Change-Id: I97f4f4870d7889204b1d42cf50de85e234ecae36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3765514Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#81757}
-
Junliang Yan authored
Change-Id: I2fbeeb9e7c64fe6597069e5b23e57a0fef0063a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3765512Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#81756}
-
ishell@chromium.org authored
Previously these values weres stored only in the Code object associated with the embedded builtins. Bug: v8:11880 Change-Id: I8adf3f654c5c729a8cb58fc6941999b4c251896a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764442 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Currently the same reduction is used for both TypedArray's and DataView's byte{Length,Offset} accessors. But their behavior differ on detached buffers: TypedArray returns 0 while DataView throw. Do not do the optimization for DataViews if we can't depend on the detach protector. Bug: chromium:1344549 Change-Id: I38b533a62f756869380cb5c19fe254e03979e81a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3763785Reviewed-by: -
Jakob Kummerow authored
By about 10x-20x depending on platform and configuration. Shorter test strings make the set of all possible substrings considerably smaller. Fixed: v8:13074 Bug: v8:12868 Change-Id: I46ae94fbcba43080d06b1b825feae6b2acf819d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3763861Reviewed-by:
Andy Wingo <wingo@igalia.com> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81753}
-
Leszek Swirski authored
Move everything past the Smi check and "pointers-from-here" check in the write barrier into deferred code. This matches what TF does for kArchStoreWithWriteBarrier. Bug: v8:7700 Change-Id: I869e6d5c85c01a3e265abca6cfa6f86066c1ab96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764443Reviewed-by:
-
Leszek Swirski authored
For prototype loads from strings, we require an access check, since string maps are shared between native contexts. This makes our prototype constant load optimisation bail out to a generic load. We can, however skip this check given the knowledge that this is a prototype load from a primitive, and instead emit a string check. We can also be a slight bit more tolerant of multiple different string maps, same as TF. Bug: v8:7700 Change-Id: I4ad858cadea68246f903443d19fa6cdd65a14564 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3762576Reviewed-by:
-
Nikolaos Papaspyrou authored
This CL refactors the implementation of inner pointer resolution, based on the marking bitmap. MarkCompactCollector::FindBasePtrForMarking has most of its code that processes the marking bitmap moved to a utility function FindPreviousObjectForConservativeMarking, which iterates backwards to find the closest previous object on the page that has been marked. Bug: v8:12851 Change-Id: I980ac5712d8b1df792196d77edb9526ca2e13e2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3758227Reviewed-by:
-
Ben Noordhuis authored
Assembler::CheckBuffer() was defined inline in a header file but without inline linkage, causing an undefined symbol link error on arm64 macOS. Fixes: https://github.com/nodejs/node-v8/issues/233 Bug: v8:13055 Change-Id: Ifb638705e95de72b2e8d472e7092e88d77cf8ba8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749583 Auto-Submit: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by:
-
