Commits · 89d7bfda0d3d3ed48a174a2851cfe5da0b31f056 · Linshizhi / V8

03 Dec, 2015 3 commits

Reland of [debugger] do not restart frames that reference new.target for... · 15cb3fde

machenbach authored 9 years ago

Reland of [debugger] do not restart frames that reference new.target for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1493863004/ )

Reason for revert:
Didn't help...

Original issue's description:
> Revert of [debugger] do not restart frames that reference new.target for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1493363002/ )
>
> Reason for revert:
> [Sheriff] Speculative revert for https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3225
>
> Original issue's description:
> > [debugger] do not restart frames that reference new.target for liveedit.
> >
> > R=mstarzinger@chromium.org
> >
> > Committed: https://crrev.com/6fca870240bdbb07a365189b5eb0c98fa65b3682
> > Cr-Commit-Position: refs/heads/master@{#32572}
>
> TBR=mstarzinger@chromium.org,yangguo@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/1a61dab34b9849f3f70a42ce69317e22758c53a1
> Cr-Commit-Position: refs/heads/master@{#32582}

TBR=mstarzinger@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1492393003

Cr-Commit-Position: refs/heads/master@{#32587}

15cb3fde

Revert of [debugger] do not restart frames that reference new.target for... · 1a61dab3

machenbach authored 9 years ago

Revert of [debugger] do not restart frames that reference new.target for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1493363002/ )

Reason for revert:
[Sheriff] Speculative revert for https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3225

Original issue's description:
> [debugger] do not restart frames that reference new.target for liveedit.
>
> R=mstarzinger@chromium.org
>
> Committed: https://crrev.com/6fca870240bdbb07a365189b5eb0c98fa65b3682
> Cr-Commit-Position: refs/heads/master@{#32572}

TBR=mstarzinger@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1493863004

Cr-Commit-Position: refs/heads/master@{#32582}

1a61dab3

[debugger] do not restart frames that reference new.target for liveedit. · 6fca8702

yangguo authored 9 years ago

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/1493363002

Cr-Commit-Position: refs/heads/master@{#32572}

6fca8702

12 Aug, 2015 1 commit

Debugger: load debugger builtins as normal native JS. · 5df7d689

yangguo authored 9 years ago

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1282793002

Cr-Commit-Position: refs/heads/master@{#30136}

5df7d689

31 Jul, 2015 1 commit

Debugger: move implementation to a separate folder. · 1667c15e

yangguo authored 9 years ago

R=cbruni@chromium.org

Review URL: https://codereview.chromium.org/1265923002

Cr-Commit-Position: refs/heads/master@{#29951}

1667c15e

23 Jul, 2015 1 commit

Remove RestartFrame from live edit API · 84f8e1af

yurys authored 9 years ago

There is already non-throwing version FrameMirror.restart and RestartFrame in the livedit-debugger.js just adds a throwing wrapper around it.

Also NEEDS_STEP_IN_PROPERTY_NAME was removed, the client code can decide based on the stack_modified field if "step in" is required.

Chromium side was fixed in https://codereview.chromium.org/1249013002/

BUG=None
LOG=N

Review URL: https://codereview.chromium.org/1247363002

Cr-Commit-Position: refs/heads/master@{#29797}

84f8e1af

10 Dec, 2014 1 commit

Consistently use "use strict" where possible. · f65a023f

yangguo authored 10 years ago

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/789163002

Cr-Commit-Position: refs/heads/master@{#25748}

f65a023f

22 May, 2014 1 commit

Reland "Prevent liveedit on or under generators with open activations" · ab3afc57

yangguo@chromium.org authored 10 years ago

The change relative to the previous CL is a logic change in
DropActivationsInActiveThreadImpl.  The previous CL skipped the matcher
unless the frame was a JS frame; this was correct for
MultipleFunctionTarget but not for SingleFrameTarget.

I have not been able to reproduce the original failures on either
architecture (ia32 or x64; stack frame dropping is unsupported on other
architectures).

R=yangguo@chromium.org
LOG=N
TEST=mjsunit/harmony/generators-debug-liveedit.js
BUG=

Review URL: https://codereview.chromium.org/270283002

Patch from Andy Wingo <wingo@igalia.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21419 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ab3afc57

06 May, 2014 2 commits

Revert "Prevent liveedit on or under generators with open activations" · 5c9ad091

rossberg@chromium.org authored 10 years ago

Seems to crash some tests on buildbots.

TBR=ishell@chromium.org
CC=wingo@igalia.com,yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/273433002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21178 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5c9ad091

Prevent liveedit on or under generators with open activations · ab96529a

wingo@igalia.com authored 10 years ago

R=yangguo@chromium.org
LOG=N
TEST=mjsunit/harmony/generators-debug-liveedit.js
BUG=

Review URL: https://codereview.chromium.org/266983004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21174 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ab96529a

29 Apr, 2014 1 commit

Bulk update of Google copyright headers in source files. · d4b533d4

bmeurer@chromium.org authored 10 years ago

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/259183002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d4b533d4

17 Oct, 2013 1 commit

Cosmetic: Add macros for NaN, undefined and Infinity to native js code. · 8ef4b0ca

yangguo@chromium.org authored 11 years ago

Nobody should need to use $NaN, 0/0, 1/0 and void 0.

R=mvstanton@chromium.org
BUG=

Review URL: https://codereview.chromium.org/27491002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8ef4b0ca

20 Sep, 2013 1 commit

LiveEdit to mark more closure functions for re-instantiation when scope layout changes · f536eb16

prybin@chromium.org authored 11 years ago

BUG=v8:2872
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/23783007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f536eb16

03 Dec, 2012 1 commit

Issue 2429, core implementation and the protocol change · be4418ba

peter.rybin@gmail.com authored 12 years ago

Review URL: https://codereview.chromium.org/11421100

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

be4418ba

15 Jun, 2012 1 commit

Support 'restart call frame' debug command · bdfc48a3

peter.rybin@gmail.com authored 12 years ago

Review URL: https://chromiumcodereview.appspot.com/10544151

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11836 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bdfc48a3

25 Apr, 2012 1 commit

Add "step in recommended" to LiveEdit response object. · 53eb3b02

peter.rybin@gmail.com authored 12 years ago

Review URL: https://chromiumcodereview.appspot.com/10185006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11439 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

53eb3b02

16 Jan, 2012 1 commit

More spelling changes. · 70da367f

erik.corry@gmail.com authored 13 years ago

Review URL: http://codereview.chromium.org/9231009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10407 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

70da367f

28 Nov, 2011 1 commit

Clean up JavaScript files to better follow coding standard. · c7fccff9

lrn@chromium.org authored 13 years ago

Multiline conditionals must use braces.
Semicolons are not optional.

Review URL: http://codereview.chromium.org/8701006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10074 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c7fccff9

01 Jun, 2011 2 commits

Revert "Fix Issue 1320: LiveEdit: text differencer fails with out of memory on large files" · b4c15254

mikhail.naganov@gmail.com authored 13 years ago

Breaks compilation on Linux.

This reverts commit e72c5b1d69fb2cb2d5973f172666dd5d477e6f7e.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8154 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b4c15254

Fix Issue 1320: LiveEdit: text differencer fails with out of memory on large files · d7b7d7f8

peter.rybin@gmail.com authored 13 years ago

Review URL: http://codereview.chromium.org/7080029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8149 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d7b7d7f8

11 Jan, 2011 1 commit

Add fine-grained diff implementation to LiveEdit engine. · 7c468e53

peter.rybin@gmail.com authored 14 years ago

BUG=1013
TEST=

Review URL: http://codereview.chromium.org/6017008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6274 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7c468e53

24 Dec, 2010 1 commit

Fix variable conflict in nested for statement · fba2ef6c

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/5961011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6118 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fba2ef6c

07 Dec, 2010 3 commits

Update V8 to version 3.0 (re-land r5920). · 90b33703

kasperl@chromium.org authored 14 years ago

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5922 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

90b33703

Revert r5920. Will re-land shortly. · 51b494d0

kasperl@chromium.org authored 14 years ago

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5921 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

51b494d0

Update V8 to version 3.0. · e5860bd6

kasperl@chromium.org authored 14 years ago

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5920 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e5860bd6

15 Oct, 2010 1 commit

Remove trailing spaces from js files. · 01d7470b

ricow@chromium.org authored 14 years ago

This is a cosmetic change only.

Review URL: http://codereview.chromium.org/3797009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

01d7470b

12 Aug, 2010 1 commit

LiveEdit: reflect scope_info moving out of Code · f2270b2c

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/3131008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5255 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f2270b2c

02 Jul, 2010 1 commit

Describe LiveEdit changes and support preview mode · 6563b3a2

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/2883020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5015 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6563b3a2

28 Apr, 2010 2 commits

LiveEdit: clean JS sources a bit · 6f099e4c

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/1697016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4539 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6f099e4c

LiveEdit: breakpoints updates and fixes for related problems · 80453231

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/1800007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4533 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

80453231

21 Apr, 2010 1 commit

Support multi-chunk differences · af63e616

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/1672006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4467 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af63e616

19 Apr, 2010 1 commit

LiveEdit: calculate a real script difference · 8fdc7a5a

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/1652008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4441 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8fdc7a5a

14 Apr, 2010 2 commits

Format · 7721e484

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/1589036

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4420 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7721e484

Make a namespace for LiveEdit · 0e9149c5

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/1549041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4419 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0e9149c5

08 Apr, 2010 1 commit

LiveEdit: update breakpoint positions for non-changed functions · 4e6a738e

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/1090003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4359 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4e6a738e

06 Apr, 2010 1 commit

LiveEdit: implement frame dropping · be5bb26e

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/1118007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4351 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

be5bb26e

02 Apr, 2010 1 commit

Let LiveEdit accept a full new script source (rather than diff) · 560baa5e

peter.rybin@gmail.com authored 14 years ago

Review URL: http://codereview.chromium.org/1584008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4338 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

560baa5e

30 Mar, 2010 1 commit

Remove trailing regexp from .js files. · 1cf0439c

kmillikin@chromium.org authored 14 years ago

Removed trailing whitespace using regexp replace. No other changes.

Review URL: http://codereview.chromium.org/1559006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4314 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1cf0439c

23 Mar, 2010 1 commit

Merge the partial_snapshots branch back into bleeding_edge. For · 7d6a3b43

kasperl@chromium.org authored 15 years ago

now, the custom call generator stuff is disabled.
Review URL: http://codereview.chromium.org/1094014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4217 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7d6a3b43

15 Mar, 2010 1 commit

LiveEdit: patch positions in function · ad876956

peter.rybin@gmail.com authored 15 years ago

Review URL: http://codereview.chromium.org/914003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4139 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ad876956