- 17 Aug, 2020 11 commits
-
-
evih authored
Bug: v8:10701 Change-Id: Ic924352195076c9cdc6a2b5f20cd75a1dcc489df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2355950 Commit-Queue: Eva Herencsárová <evih@google.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69421}
-
Dominik Inführ authored
Allow AllocationObserver::Step to remove allocation observers as well. They could already add new observers (to start incremental marking), removing will be used when starting StressConcurrentAllocator from an allocation observer. Bug: v8:10315 Change-Id: I823ded2f9a408b3fa5269ee8416060d0cabb3162 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2357690Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#69420}
-
Thibaud Michaud authored
Temporarily disable multi-value until the launch is approved. R=ahaas@chromium.org Bug: chromium:1097717 Change-Id: Ifb2370d87ec5e531257852bc5fc5259386a022d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358675Reviewed-by:
-
Santiago Aboy Solanes authored
We can bypass the data() and do a direct access read. Bug: v8:7790 Change-Id: Id1d5b4ad9dcde1673fae07a076ad11322da4c724 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358730Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#69418}
-
Jakob Kummerow authored
This is a comment-only CL. Change-Id: I002b1765bfa839982ab11c22f744734fdd34d4ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352788Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69417}
-
Leszek Swirski authored
Change-Id: I86d8b2046a0809287be31172ec261e4679da66f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358731 Commit-Queue: Marja Hölttä <marja@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#69416}
-
Zeynep Cankara authored
This CL changes min/max of panel sizes for a better user experience. Additionally, removes the scroll bars while keeping the scroll functionality to alleviate the cluttered view. Bug: v8:10644 Change-Id: Ib95ed79dd58dbcd6b1932eb366f9d2177407c853 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2356346Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69415}
-
Santiago Aboy Solanes authored
object() is already a canonical persistent handle so we can use that. The necessary *Ref methods can be changed to bypass the data() and do the direct access into the bytecodes. Then, we can safely eliminate the bytecodes_ member. Bug: v8:7790 Change-Id: I84302e02bcb37ce1f4cd345b15ebadc0528a7028 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288865Reviewed-by:
-
Z Nguyen-Huu authored
This is a reland of 1b35c0fa Reason for revert: Seems to reliably break a numerics test: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/31516 It was really slow and timeout with debug build run this test mjsunit/math-exp-precision with --optimize-for-size because we resize cache in CSA. Default this to runtime would avoid the timeout. Also with --optimize-for-size, we don't have enough space to allocate full-size cache so avoid to resize cache in this case. In my local PC, time for this test decreases as follows. Before: 52s After: 3s Original change's description: > Improve NumberToString when cache miss and Smi > > Cache miss was handled in runtime before. This change add fast path for > Smi in this case. > > Perf show 30% improvement for the following example. > Before 67 ms > After 42 ms > > const start = new Date(); > const MAX = 1000000; > for (var i = 0; i < MAX; i++) { > i.toString(); > } > const end = new Date(); > console.log("Time :"+ (end-start)); > > Change-Id: I162e9c35f58551ca6a5a0efe79fb7c7b482a8594 > Bug: v8:10477 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332866 > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69362} Bug: v8:10477 Change-Id: I892a9007210032640d0bf22e61c8e7ad1a4377c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351398Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Georg Neis authored
We want to crash after printing :) Change-Id: Ia739b54655e9cbce56b4f774ef6af1a771db4c1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358674Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e7ee57c..939db33 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/93f80bc..361d367 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib0b75df46bca0c7fe2076c5180ffca097dfbbb79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2359268Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#69411}
-
- 16 Aug, 2020 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/055e1ba..e7ee57c Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/724075d..93f80bc TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I04b90882754a1fc75c224ae44706a3120a725e37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2359261Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c843282..055e1ba Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/69d9325..5abddab TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2e4b9ecb0b219910f4d5a9a9aaa3b95e56550699 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2359253Reviewed-by:
-
- 15 Aug, 2020 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7dff8d4..c843282 Rolling v8/third_party/aemu-linux-x64: NHKI_hy9EiYHTk25-SwU9lqq_Nmk1LQ748n-ZAtBu9YC..zCy9vIuheNK--OaT_8WBj3IbVxW_RuxRLMp8KWTLqzIC Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/5edcbfd..fc6c684 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c4d3ff4..69d9325 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0fa91d0..3bd3c99 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/8ce2286..6a38b0e Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/bb3f180..3c52ccd Rolling v8/third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/3f90fa0..61cfe2a Rolling v8/third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/8f45f5c..f2fb0f2 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6b794b9..724075d TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia6dc928e4d92d83fb7245bccad96d09312ea89c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358554Reviewed-by:
-
Frank Tang authored
Bug: v8:6891 Change-Id: I3552afff9cd6f065aba82eddcf3f4719ee1283e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2353414Reviewed-by:
-
- 14 Aug, 2020 14 commits
-
-
Shu-yu Guo authored
Bug: v8:10687, v8:9921 Change-Id: I7a81e9f9882c9a50d8ca70690e2ea409dc5c6c2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2357169Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#69406}
-
Bill Budge authored
This reverts commit 899cb348. Reason for revert: Added regression test fails on Arm Sim: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/11584 Original change's description: > [wasm][fuzzer] Fix exception detection > > Exceptions were detected by checking for a pending exception on the > isolate, but {CallWasmFunctionForTesting} was clearing any pending > exception before returning. > This CL fixes that by explicitly passing back a boolean which is set if > an exception occurred during execution. > > R=ahaas@chromium.org > > Bug: chromium:1115280 > Change-Id: Ife71ceef0751d18e0870335b9520c2bf77e351cc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352787 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69404} TBR=ahaas@chromium.org,clemensb@chromium.org Change-Id: I1d3c0e57df7ec25b09f2037c31c9b30eb0866548 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1115280 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2357189Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#69405}
-
Clemens Backes authored
Exceptions were detected by checking for a pending exception on the isolate, but {CallWasmFunctionForTesting} was clearing any pending exception before returning. This CL fixes that by explicitly passing back a boolean which is set if an exception occurred during execution. R=ahaas@chromium.org Bug: chromium:1115280 Change-Id: Ife71ceef0751d18e0870335b9520c2bf77e351cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352787Reviewed-by: -
Manos Koukoutos authored
Drive-by: Add flag implications for wasm experimental features: gc -> typed_funcref, typed_funcref -> reftypes. Bug: v8:9495 Change-Id: Ia6054886935d68e79b8f463289aa9e1e9d6484f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352777Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:9708, v8:6949 Change-Id: Iabe48b5c667f1073a0f521cb22627a22f2415199 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2353459 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#69402}
-
Santiago Aboy Solanes authored
Bug: v8:9708, v8:6949 Change-Id: I3d1bcf144c69a736b19b845d89e34af9bf15f5f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352786Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#69401}
-
Almothana Athamneh authored
Bug: chromium:1113183 Change-Id: I5f2b965f13db15b87d6b6194ccb64093a0b81fe8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2355947Reviewed-by:
Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#69400}
-
Zeynep Cankara authored
This CL fixes the chunk locations on timeline-tracks. The App updates the Ic panel upon receiving FocusEvent with an entry of ICLogEvent. Bug: v8:10644 Change-Id: I4d09851c154196cc6cb1544a275ed33c8ae8a8af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354814 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
-
Ulan Degenbaev authored
This is a reland of a7eff8cb Sheriffs: This CL effectively enables GC for inspector tests. It may uncover bugs in the existing inspector tests. If that happens please disable the failing test in test/inspector/inspector.status instead of reverting this CL. See https://crbug.com/v8/10748. Original change's description: > [inspector] Ensure progress of default task runners in inspector tests > > Bug: v8:10747, chromium:1098187 > Change-Id: I0215d2d85db4dd1d7fa376a0982cda5658f1683d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315982 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69387} Bug: v8:10747 Bug: chromium:1098187 Change-Id: Iab8f10b0535b0f35948fb507537f2bf65af5f33a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354815 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#69398}
-
Leszek Swirski authored
This patch introduces a new LocalIsolate and LocalFactory, which use LocalHeap and replace OffThreadIsolate and OffThreadFactory. This allows us to remove those classes, as well as the related OffThreadSpace, OffThreadLargeObjectSpace, OffThreadHeap, and OffThreadTransferHandle. OffThreadLogger becomes LocalLogger. LocalHeap behaves more like Heap than OffThreadHeap did, so this allows us to additionally remove the concept of "Finish" and "Publish" that the OffThreadIsolate had, and allows us to internalize strings directly with the newly-concurrent string table (where the implementation can now move to FactoryBase). This patch also removes the off-thread support from the deserializer entirely, as well as removing the LocalIsolateWrapper which allowed run-time distinction between Isolate and OffThreadIsolate. LocalHeap doesn't support the reservation model used by the deserializer, and we will likely move the deserializer to use LocalIsolate unconditionally once we figure out the details of how to do this. Bug: chromium:1011762 Change-Id: I1a1a0a72952b19a8a4c167c11a863c153a1252fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315990 Commit-Queue: Andreas Haas <ahaas@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#69397}
-
Santiago Aboy Solanes authored
Also TNodify it. Bug: v8:9708, v8:6949 Change-Id: I8f16c500875955cac97449a521772628b5b60b07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352785Reviewed-by:
-
Dominik Inführ authored
Run SimulateFullSpace in safepoint. Needed for FreeLinearAllocationArea which would race with concurrent allocation. Bug: v8:10315 Change-Id: If0c3c4e20edea1b05cc1a3e1a3e37fc29254a196 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354812Reviewed-by:
-
Dominik Inführ authored
Debugger uses DisableInlineAllocation, this races with concurrent allocation. Lock PagedSpace mutex for freeing the linear allocation area. Bug: v8:10315 Change-Id: If3b0c786943f99f7e9c7cefac9436e93b352e334 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354811Reviewed-by:
-
Marja Hölttä authored
Bug: v8:10239, chromium:1115354 Change-Id: Ifcb28b4f83e729107b6cbf090cd57be466495177 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351663Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
- 13 Aug, 2020 11 commits
-
-
Shu-yu Guo authored
This reached consensus in the March 2020 TC39. https://github.com/tc39/ecma262/pull/1908 This aligns JS with wasm, which allows atomics operations on non-shared linear memory. Bug: v8:10687, v8:9921 Change-Id: I7b60473b271cee6bccb342e97a4fd3781aedddb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330802 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
This fixes a case where we hit a DCHECK in Debug mode, or silently discarded bogus data in Release mode without rejecting the module. Fixed: chromium:1108815 Change-Id: I928ff244a54b016cd8470be1ec4b5faf2c7e3994 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349768 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69391}
-
Bill Budge authored
This reverts commit a7eff8cb. Reason for revert: adds tests which fail: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20concurrent%20marking/14266 Original change's description: > [inspector] Ensure progress of default task runners in inspector tests > > Bug: v8:10747, chromium:1098187 > Change-Id: I0215d2d85db4dd1d7fa376a0982cda5658f1683d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315982 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69387} TBR=ulan@chromium.org,petermarshall@chromium.org Change-Id: I2088dc8c13416c882212316c0b7137ea28beb563 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10747 Bug: chromium:1098187 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354421Reviewed-by:
-
Dominik Inführ authored
Bug: v8:10315 Change-Id: I70f62b5bc3856163aba2672149876b185fc20c00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2346277Reviewed-by:
-
Etienne Pierre-doray authored
Expose: - JobHandle::IsCompleted() - worker_count passed as argument to GetMaxConcurrency() - JobDelegate::GetTaskId With default implementation. Once gin implements it, it can be made pure virtual. Bug: chromium:1114823 Change-Id: I24ce60d1df6adff4061c050e5aa8bf8d7bb1cf5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352485 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Bug: v8:10747, chromium:1098187 Change-Id: I0215d2d85db4dd1d7fa376a0982cda5658f1683d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315982 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Change-Id: I7e7bc48b2e3aa00effec15ae5c8f99adde253fdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354389 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#69386}
-
Almothana Athamneh authored
Bug: chromium:1113183 Change-Id: Ie24412511c8eb29bdab14f0b4472c2741163e2fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352779 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Remove allocation_mutex_ and use the already existing space_mutex to protect the free list from concurrent allocation. Bug: v8:10315 Change-Id: I8d823bcb80dfa49c6431a6db875488bc8d6ee8b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352783Reviewed-by:
-
Dominik Inführ authored
Two tests already test concurrent allocation. Another one measures memory, so non-deterministic allocation would lead to higher memory usage than anticipated. Bug: v8:10315 Change-Id: If994233c87ea04076b850ffdf024f7783653e9db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352781Reviewed-by:
-
Zeynep Cankara authored
This CL establishes a naming consistency across the app by renaming classes. Class Name Changes: SelectEvent -> FocusEvent Entry -> IcLogEvent V8Map -> MapLogEvent Bug: v8:10644 Change-Id: Id075d9aa36ac6f03af0224feb0e38985b1445013 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349300 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
-
