- 17 Sep, 2018 40 commits
-
-
Junliang Yan authored
Port 6346cdb6 Original Commit Message: This adds support to TurboFan's representation selection for the Word64 representation, and makes use of that to handle indices for memory access and allocation instructions (i.e. LoadElement, StoreElement, Allocate, etc.). These instructions had previously used Word32 as representation for the indices / sizes, and then internally converted it to the correct representation (aka Word64 on 64-bit architectures) later on, but that was kind of brittle, and sometimes led to weird generated code. The change thus only adds support to convert integer values in the safe integer range from all kinds of representations to Word64 (on 64-bit architectures). We don't yet handle the opposite direction and none of the representation selection heuristics for the numeric operations were changed so far. This will be done in follow-up CLs. This CL itself is supposed to be neutral wrt. functionality, and only serves as a starting point, and a cleanup for the (weird) implicit Word64 index/size handling. R=bmeurer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ic7ea30639dea3c5f8a59e7100a15d5ed50073c20 Reviewed-on: https://chromium-review.googlesource.com/1228416Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55970}
-
Creddy authored
Temporarily disable one-shot optimization for debug-evaluate-no-side-effect-builtins-2 to fix the gc stress test. This issue will be fixed in the future CL (https://chromium-review.googlesource.com/c/v8/v8/+/1196725) that adds new bytecodes for loads and stores and one-shot optimizations will be enabled again. Change-Id: I6475557778da4553b5b6cbba1fda14c52d3dd91b Reviewed-on: https://chromium-review.googlesource.com/1228063Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Chandan Reddy <chandanreddy@google.com> Cr-Commit-Position: refs/heads/master@{#55969}
-
Benedikt Meurer authored
On Intel platforms, the kX64Cmp32 and kX64Test32 operations in TurboFan's backend automatically truncate their inputs to Word32 (aka they don't look at the upper bits), so the instruction selection can silently ignore TruncateInt64ToInt32 on the inputs. Bug: v8:8178 Change-Id: Ia50a38cac927e5b2155f092a8885da255a3dddca Reviewed-on: https://chromium-review.googlesource.com/1227935Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55968}
-
Alexei Filippov authored
Change-Id: I3d16a1e03a28a4ebd69b891cdb610e66230c9c3e Reviewed-on: https://chromium-review.googlesource.com/1227421Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#55967}
-
Alexei Filippov authored
Change-Id: Ib13782a8f5eea793b9a74d6f72c625a050069dc2 Reviewed-on: https://chromium-review.googlesource.com/1227681Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ibdb4b81e1ba764d73bac6592eeef5783097076fc Reviewed-on: https://chromium-review.googlesource.com/1225896Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55965}
-
Adam Klein authored
Instead include it in the files that need to use it. Change-Id: I2321f423ddcc1c0e779332c2e7d1a372bfb4ebbb Reviewed-on: https://chromium-review.googlesource.com/1227305Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#55964}
-
Clemens Hammacher authored
R=ahaas@chromium.org Bug: v8:8158 Change-Id: Ifb00cd7b106f1ac5614acfb5ff7c2e8c0a9b0170 Reviewed-on: https://chromium-review.googlesource.com/1228055Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55963}
-
Michael Starzinger authored
This avoids unnecessary stack-walks to determine the current context in WebAssembly runtime functions, in cases where the calling stub already determined the calling instance and can just set the context register itself before calling into the runtime. R=clemensh@chromium.org Change-Id: Iba02d479a7dad8907195bf94efb9d559be20a6d1 Reviewed-on: https://chromium-review.googlesource.com/1228035Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55962}
-
Clemens Hammacher authored
js-to-wasm wrappers check whether trap handlers are enabled process-wide, but are independent of their actual usage in the current instance. Thus remove this unneeded parameter. R=mstarzinger@chromium.org Bug: chromium:862123 Change-Id: I3793213864568b4e26eb3414239033491e4539f5 Reviewed-on: https://chromium-review.googlesource.com/1226974 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55961}
-
Ivica Bogosavljevic authored
Port 0c296cb2 Change-Id: Ic90f248e05a668cfda6f6a86772dcabbc5275ec0 Reviewed-on: https://chromium-review.googlesource.com/1228034Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#55960}
-
Michael Starzinger authored
This is a reland of a4105a43 Original change's description: > [wasm] Implement handling of exported/imported exceptions. > > This implements the proper semantics for matching exported/imported > exceptions by using the notion of an "exception tag" that is global to > the system. It can be used to match exceptions in one module against > exceptions declared and/or thrown in another module (or instance). > > R=clemensh@chromium.org > TEST=mjsunit/wasm/exceptions-shared > BUG=v8:8091 > > Change-Id: I37586d7be5d5e6169b3418dfbc415b26dd4750dd > Reviewed-on: https://chromium-review.googlesource.com/1226976 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55940} Bug: v8:8091 Change-Id: Ib85f099b26a8323a8a00299b5aaeb05aaff3c3c6 Reviewed-on: https://chromium-review.googlesource.com/1227975Reviewed-by:
-
Benedikt Meurer authored
Cleanup the JSArrayBuffer bit fields to use the proper object macros that are now otherwise used consistently across the code base. Also change TurboFan to consistently bailout when it sees an array buffer that was previously neutered, so that the generic path / builtins are again the chokepoints for the spec violations (the fact that we don't always raise exceptions when we see a neutered array buffer), except for the ArrayBufferView accessor inlining in the JSCallReducer, where we still turn the values into zero (because we don't have access to a CALL_IC speculation guard in the common case). This also removes the ArrayBufferWasNeutered simplified operator, and does regular LoadField + Number bitwise operations instead, which is good enough and allows us to get rid of a lot of unnecessary complexity. Bug: v8:4153, v8:7881, v8:8015, v8:8171, v8:8178 Change-Id: I4ce79ece762c632e6318f2ab7bcc6b2f82383947 Reviewed-on: https://chromium-review.googlesource.com/1226887Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55958}
-
Igor Sheludko authored
Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I2ce078b662e3dd93e0fac310b0d73c4cadbaccb3 Reviewed-on: https://chromium-review.googlesource.com/1226640 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I7d885f0e2ba3cdf97de190166dc4cdd24dc0c11e Reviewed-on: https://chromium-review.googlesource.com/1224091 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Clemens Hammacher authored
We still see occasions of "WebAssembly Instantiation: Out of memory: wasm memory", e.g. on the N5X arm64 bot. We already have a retry-loop around the {ReserveAddressSpace} call, so this error can only happen if {AllocatePages} fails. I cannot easily reproduce, so I will land this CL and hope that it fixes the flake. We might eventually replace all these gc-then-retry loops by a better mechanism which knows about process-wide allocations. Currently, {AllocatePages} is isolate-independent, and only calls {Platform::OnCriticalMemoryPressure}, but this call does nothing on the default platform. So trigger a GC on the current isolate instead. R=mlippautz@chromium.org Bug: chromium:883639, v8:7872, v8:8158 Change-Id: Ib4e4a4a5f6b598d5832c327b1fc83ccb3bada9bc Reviewed-on: https://chromium-review.googlesource.com/1226886Reviewed-by: -
Michael Starzinger authored
R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions BUG=v8:8091 Change-Id: I93227c29bb3591983f1901577afdf305637beb70 Reviewed-on: https://chromium-review.googlesource.com/1226803 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Only read-only pages don't have properly initialized reservation object. This is a reland of b0edf8e6 Bug: v8:8096 Change-Id: Ib2745d18e93788b92b0f9ffcaf996a1dad886b04 Reviewed-on: https://chromium-review.googlesource.com/1226875 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... in order to avoid page allocator filtering when notifying leak sanitizer. This is a reland of 0606bf91 Bug: v8:8015 Change-Id: I314eee7699ce2c8abeeafce4fcf185810ac252a9 Reviewed-on: https://chromium-review.googlesource.com/1226918 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Creddy authored
We do not have to collect feedback for function calls in one-shot code. This CL avoids allocating CallICslots for each function call by emitting CallNoFeedback bytecodes. We save one CallICSlot (two entries in feedback vector) per function call in One-shot. Bug: v8:8072 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic2580e5972acd5124c2e71d540985736ce797fe8 Reviewed-on: https://chromium-review.googlesource.com/1178051 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55951}
-
Benedikt Meurer authored
The computation to find the hash entry is already performed on Word64, and the actual value access later is also performed on Word64 indices, so there's no point to go to Word32 in between. Bug: v8:8015, v8:8178 Change-Id: I160e02166beceb79dcc8e69f9c365871a4c42606 Reviewed-on: https://chromium-review.googlesource.com/1226648Reviewed-by:
-
Michael Lippautz authored
Abort incremental marking pulls in the requirement to also be able to abort on the embedder side. In practice, aborting is never really needed and the GC should just finalize the existing collection and do an atomic followup if exact marking information is required. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic471332d01b0c4be26b71a06248af03255c61a9d Reviewed-on: https://chromium-review.googlesource.com/1225705Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55949}
-
Georg Neis authored
Also properly implement MapRef::GetInObjectPropertyOffset. Bug: v8:7790 Change-Id: I3e73247df67b7c40336b6c685b784dbf9e542340 Reviewed-on: https://chromium-review.googlesource.com/1226977 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#55948}
-
Clemens Hammacher authored
VirtualMemory objects can be moved since https://crrev.com/c/1213062, so there is no need any more to return them via pointer argument. This also makes the {AllocVirtualMemory} and {AlignedAllocVirtualMemory} functions superfluous. R=ishell@chromium.org, titzer@chromium.org Bug: v8:8015 Change-Id: Id72921e1c66a6c10be6647194603b8283e010e24 Reviewed-on: https://chromium-review.googlesource.com/1226972Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Marja Hölttä authored
It's the same as BytecodeArray::BodyDescriptor. BUG=v8:7308 Change-Id: I3821108cc6cc577261ce58cd034e21dfbe2c3c87 Reviewed-on: https://chromium-review.googlesource.com/1227126Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I993d04e6ca6b8986749bb3782113ef928952995b Reviewed-on: https://chromium-review.googlesource.com/1226975 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: If115a71b1c57eecdec7c57d3613a4f0bd90f2e66 Reviewed-on: https://chromium-review.googlesource.com/1226791Reviewed-by:
-
Benedikt Meurer authored
For NumberAdd/Subtract/Multiply we currently onlt consult the upper bound to decide whether to compute using Int32 or Float64 operations, whereas for NumberModulus, NumberEqual, etc. we do decide based on the feedback types, where the only significant difference is that we cannot promise Word32 truncations on the inputs. This change unifies the handling for NumberAdd/Subtract/Multiply as well, which triggers surprisingly often in our core benchmark suites.. Bug: v8:8015 Change-Id: If8ec1bc82d1e1b71285c829262a0d343a4eb2af7 Reviewed-on: https://chromium-review.googlesource.com/1226033 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit a4105a43. Reason for revert: GC stress failures (https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20GC%20Stress/3097) Original change's description: > [wasm] Implement handling of exported/imported exceptions. > > This implements the proper semantics for matching exported/imported > exceptions by using the notion of an "exception tag" that is global to > the system. It can be used to match exceptions in one module against > exceptions declared and/or thrown in another module (or instance). > > R=clemensh@chromium.org > TEST=mjsunit/wasm/exceptions-shared > BUG=v8:8091 > > Change-Id: I37586d7be5d5e6169b3418dfbc415b26dd4750dd > Reviewed-on: https://chromium-review.googlesource.com/1226976 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55940} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I5ef19ea3b67f470f2d7807810110d75415ba9ed6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8091 Reviewed-on: https://chromium-review.googlesource.com/1227933Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#55942}
-
Marja Hölttä authored
BodyDescriptorWeak is not needed for all classes. For the classes it's needed it's referred to explicitly (Foo::BodyDescriptorWeak::IterateBody()). BUG=v8:7308 Change-Id: If8591929cd588575e88f3d6f116ec2cac4941e8f Reviewed-on: https://chromium-review.googlesource.com/1226649Reviewed-by:
-
Michael Starzinger authored
This implements the proper semantics for matching exported/imported exceptions by using the notion of an "exception tag" that is global to the system. It can be used to match exceptions in one module against exceptions declared and/or thrown in another module (or instance). R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-shared BUG=v8:8091 Change-Id: I37586d7be5d5e6169b3418dfbc415b26dd4750dd Reviewed-on: https://chromium-review.googlesource.com/1226976 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Georg Neis authored
... as well as ScopeInfo::ContextLength. Bug: v8:7790 Change-Id: I3ca8b6f252d96b21d0990f8fc08e076eeeea4176 Reviewed-on: https://chromium-review.googlesource.com/1226973 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I5164899da0994a855182ed203572c5984ab87449 Reviewed-on: https://chromium-review.googlesource.com/1227070Reviewed-by:
-
Benedikt Meurer authored
This change introduces the necessary conversion operators to convert from Word64 to other representations (Tagged, Word32, Float64, etc.), and plugs in the Word64 representation for NumberAdd/NumberSubtract, such that TurboFan will go to Int64Add/Sub on 64-bit architectures when the inputs and the output of the operation is in safe integer range. This includes the necessary changes to the Deoptimizer to be able to rematerialize Int64 values as Smi/HeapNumber when going back to Ignition later. This change might affect performance, although measurements indicate that there should be no noticable performance impact. The goal is to have TurboFan support Word64 representation to a degree that changing the TypedArray length to an uint64_t (for 64-bit archs) becomes viable and doesn't have any negative performance implications. Independent of that we might get performance improvements in other areas such as for crypto code later. Bug: v8:4153, v8:7881, v8:8171, v8:8178 Design-Document: bit.ly/turbofan-word64 Change-Id: I29d56e2a31c1bae61d04a89d29ea73f21fd49c59 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel Reviewed-on: https://chromium-review.googlesource.com/1225709 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This adds another instance of the "if allocation fails, run GC then retry" pattern, this time for making the actual memory reservation for wasm memory. R=mlippautz@chromium.org Bug: chromium:883639, v8:7872, v8:8158 Change-Id: I40ed020ed2bbc253c4bbcbe51e3e9f5a0278d7a1 Reviewed-on: https://chromium-review.googlesource.com/1227117Reviewed-by:
-
Benedikt Meurer authored
While investigating crbug.com/878742 I found that somehow the MachineOperatorReducer lacks the ability to constant-fold comparisons of Float64 constants, which obviously leads to pretty weird code. Bug: v8:8015 Change-Id: I7e18ce10e9d5c87f131fb083ccd3e1e336189dae Reviewed-on: https://chromium-review.googlesource.com/1226132Reviewed-by:
-
Marja Hölttä authored
E.g., "ToWeakHeapObject" was misleading, since it didn't convert to a weak heap object, instead returned a weakly pointed heap object. Change the function names (in this case, to "GetHeapObjectIfWeak") to reflect this. Also make casts explicit, if a MaybeObject is an Object, we can call cast<Object>(). Previous version: https://chromium-review.googlesource.com/1219025 BUG=v8:7308 TBR=ishell@chromium.org, ulan@chromium.org, ahaas@chromium.org, yangguo@chromium.org, tebbi@chromium.org Change-Id: I503d4a2a3a68f85e9e02e1c2f9fc1c4187c8e9a1 Reviewed-on: https://chromium-review.googlesource.com/1226800Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
We can remove redundant NumberSilenceNaN operations if the input is known to be an OrderedNumber, which means that it's any number (incl. -0) but not NaN. This seems to specifically occur in applications that perform number crunching on arrays with integer values outside the Smi range, as these arrays will have double elements kind, but for most of the stores to these arrays TurboFan will be able to tell that it's not going to be a NaN. Bug: v8:8015 Change-Id: I451ac0bf0cec26be18b991f6c3756fb41f1fbd97 Reviewed-on: https://chromium-review.googlesource.com/1225897 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Michael Hablich authored
This reverts commit 1a225459. Reason for revert: Makes GC stress unhappy: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/18325 and blocks the roll Original change's description: > Implement ResolveLocale in C++. > > Bug: v8:8065, v8:5751 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Id9dc16455d63b7c436126c21758d64fae0ec8de9 > Reviewed-on: https://chromium-review.googlesource.com/1211402 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55925} TBR=bstell@chromium.org,gsathya@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8065, v8:5751 Change-Id: I4d71adb31ffd5ab0d2ae42c0255d0a05edbaad29 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1226646Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#55932}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ibc3dedb0bce78ddce4004ee386757ce504bb073a Reviewed-on: https://chromium-review.googlesource.com/1226792 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55931}
-
