- 17 Apr, 2017 4 commits
-
-
kozyatinskiy authored
Inspector doesn't use debugger context and this entering only slow down our async instrumentation. BUG=v8:6189 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2816373004 Cr-Commit-Position: refs/heads/master@{#44665}
-
gdeepti authored
- Add I16x8 Splat, ExtractLane, ReplaceLane, shift ops, Some BinOps and compare ops - Add pshufhw, pshuflw in the assembler, disassembler - Fix incorrect modrm for pextrw, this bug disregards the register allocated and always makes pextrw use rax. - Fix pextrw disasm to take the 0 - 7 bits of the immediate instead of 0 - 3. - Pextrw, pinsrw are in the assembler use 128 bit encodings, pextrw, pinsrw in the disassembler use legacy encodings, fix inconsistencies causing weird code gen when --print-code is used. Review-Url: https://codereview.chromium.org/2767983002 Cr-Commit-Position: refs/heads/master@{#44664}
-
bradnelson authored
BUG=None TEST=None R=mtrofin@chromium.org LOG=N Review-Url: https://codereview.chromium.org/2824793002 Cr-Commit-Position: refs/heads/master@{#44663}
-
gdeepti authored
R=bradnelson@chromium.org, mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2823953002 Cr-Commit-Position: refs/heads/master@{#44662}
-
- 16 Apr, 2017 1 commit
-
-
Michael Achenbach authored
NOTRY=true TBR=hablich@chromium.org Change-Id: I36418c2d0198c52a52ba3426a2792b2f52c29d67 Reviewed-on: https://chromium-review.googlesource.com/479411Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#44661}
-
- 15 Apr, 2017 1 commit
-
-
hablich authored
This reverts commit 8faf3d6f. Reason: blocks roll https://codereview.chromium.org/2820753003/ TBR=martyn.capewell@arm.com,jarin@chromium.org,bmeurer@chromium.org,machenbach@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2819093002 Cr-Commit-Position: refs/heads/master@{#44660}
-
- 14 Apr, 2017 3 commits
-
-
Adam Klein authored
Also simplify usage of Object.prototype methods in JS natives: now that they're added in bootstrapper, no need to import them. Change-Id: I0db53dd5acaed3aa0a5b46f730b31baa376e282d Reviewed-on: https://chromium-review.googlesource.com/478574 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#44659}
-
Adam Klein authored
Change-Id: I9973858f2596a9bc4d66afbb26612189fbded7f3 Reviewed-on: https://chromium-review.googlesource.com/478413Reviewed-by: Caitlin Potter <caitp@igalia.com> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#44658}
-
kozyatinskiy authored
- creating JSArray and further setter and getter calls are slower then on fixed array. BUG=v8:6189 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2813773002 Cr-Commit-Position: refs/heads/master@{#44657}
-
- 13 Apr, 2017 27 commits
-
-
Sathya Gunasekaran authored
If the current context is overwritten by doing Realm.navigate(0) we fail to delete the module embedder data from the correct current context, because we have an handle to the old context which was already cleaned up by calling DisposeRealm in RealmNavigate. This patch disallows navigation to the first realm. Bug: chromium:711165 Change-Id: I6b9d3187367dae9d1fe38c0efa361d461c94c917 Reviewed-on: https://chromium-review.googlesource.com/476970Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#44656}
-
bradnelson authored
Enabling on trunk after having landed change to add flag and disable for branch. BUG=None R=mtrofin@chromium.org,ahaas@chromium.org LOG=N Review-Url: https://codereview.chromium.org/2813213004 Cr-Commit-Position: refs/heads/master@{#44655}
-
machenbach authored
TBR=martyn.capewell@arm.com NOTRY=true Review-Url: https://codereview.chromium.org/2818563005 Cr-Commit-Position: refs/heads/master@{#44654}
-
bradnelson authored
Adding a flag to explicitly enable/disable async compile. Will cherrypick this to M59. Separately will land a change to re-enable this by default. BUG=v8:6264 R=mtrofin@chromium.org,ahaas@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2820553003 Cr-Commit-Position: refs/heads/master@{#44653}
-
martyn.capewell authored
This reverts commit cc047635. The CL was reverted due to a missing DEPS mirror. Original issue's description: > ARM64: Add NEON support > > Add assembler, disassembler and simulator support for NEON in the ARM64 backend. > > BUG= > > Review-Url: https://codereview.chromium.org/2622643005 > Cr-Commit-Position: refs/heads/master@{#44306} BUG= Review-Url: https://codereview.chromium.org/2812573003 Cr-Commit-Position: refs/heads/master@{#44652}
-
jkummerow authored
TBR=ishell@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2818773002 Cr-Commit-Position: refs/heads/master@{#44651}
-
jkummerow authored
Taking the slow runtime path for every non-internalized string key can be avoided by doing optimistic string table lookups: if there is a matching entry, use that; if there isn't, then no existing object has a property with that name. The hashing/internalizing logic is in C++ and called directly. Review-Url: https://codereview.chromium.org/2811333002 Cr-Commit-Position: refs/heads/master@{#44650}
-
Caitlin Potter authored
https://github.com/tc39/proposal-async-iteration/commit/e3246ad69cc6f83b34bdd3451c3c6abce37fd1f3 removed some redundancies in yield and yield*. In particular: - AsyncGeneratorRawYield becomes unnecessary, and is deleted in this CL - Parser::RewriteYieldStar() is updated to perform the IteratorValue() algorithm as appropriate BUG=v8:6187, v8:5855 R=rmcilroy@chromium.org, adamk@chromium.org, littledan@chromium.org, vogelheim@chromium.org Change-Id: I05e8429b9cbd4531c330ee53a05656b90162064c Reviewed-on: https://chromium-review.googlesource.com/471806Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#44649}
-
Michael Starzinger authored
R=tebbi@chromium.org Change-Id: I28cdf18616e16a681e2cab3f36263f3c09953b8b Reviewed-on: https://chromium-review.googlesource.com/476612 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#44648}
-
Leszek Swirski authored
Currently we count optimizations to decide to disable optimization, and count deopts to detect this decision and allow re-enabling optimizations after a while. However, throwing out TurboFan OSR code and GC optimized code evictions do not count as deopts, which means that the optimization count increases without increasing the deopt count. This increased optimization count disables further optimization -- which is bad, because these are not "true" deopts -- and can stop the optimization from being re-enabled, because the deopt count can't go high enough. Instead, we now only ever look at deopts to disable/re-enable optimization, and opt counts are only used for naming log files and in tests. Change-Id: I0c7d6be497545449a38cf952cd2f007ee51982ba Reviewed-on: https://chromium-review.googlesource.com/468811 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44647}
-
georgia.kouveli authored
This option doesn't work for ARM any more. BUG= Review-Url: https://codereview.chromium.org/2816703002 Cr-Commit-Position: refs/heads/master@{#44646}
-
bmeurer authored
If the new.target passed to the Array constructor cannot be a Proxy, then we know that the Array constructor cannot trigger any observable side-effects. R=jarin@chromium.org BUG=v8:6262 Review-Url: https://codereview.chromium.org/2821453002 Cr-Commit-Position: refs/heads/master@{#44645}
-
bmeurer authored
The JSArgumentsObject::length representation is initially Smi, so we can record that on the initial map and use it to optimize the accesses in TurboFan based on that. Similar for JSSloppyArgumentsObject::caller. BUG=v8:6262 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2810333004 Cr-Commit-Position: refs/heads/master@{#44644}
-
yangguo authored
R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2812603002 Cr-Commit-Position: refs/heads/master@{#44643}
-
Michael Hablich authored
TBR=machenbach@chromium.org,vogelheim@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2814993006 . Cr-Commit-Position: refs/heads/master@{#44642}
-
yangguo authored
This is requested for Node.js N-API. Tests to be added. Review-Url: https://codereview.chromium.org/2812613002 Cr-Commit-Position: refs/heads/master@{#44641}
-
jarin authored
Previously, we would only consider it if it pointed to a full-code JS function. Thus we could miss both optimized functions and bytecode handlers if they called frame-less code. Review-Url: https://codereview.chromium.org/2822433002 Cr-Commit-Position: refs/heads/master@{#44640}
-
Michael Starzinger authored
This fixes the validation of "|0" annotations of call sites that are used to indicate a "signed" return type of functions. We use lookahead during call validation and request deferred validation as part of the actual OR-expression. Special care has to be taken to get precedence levels of all involved operators right. R=clemensh@chromium.org TEST=mjsunit/asm/call-annotation BUG=v8:6183 Change-Id: If0586f669e7cee26a13425b0fd9f41098e852d68 Reviewed-on: https://chromium-review.googlesource.com/475871 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#44639}
-
jgruber authored
The condition only applies in unicode mode, where any lone surrogates are desugared into a character class (and will not be considered in this optimization). Non-unicode mode treats lone surrogates exactly like any other codepoint. BUG=chromium:711092 Review-Url: https://codereview.chromium.org/2808403006 Cr-Commit-Position: refs/heads/master@{#44638}
-
Franziska Hinkelmann authored
In eval scripts, the source code position can be 0 rather than greater than 0. Add regression test. Drive-by fix: unrelated typo. Bug: 707223 Change-Id: If52c0736daac3ad42ac6d324eb8ec5f1798f6f5a Reviewed-on: https://chromium-review.googlesource.com/476630Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#44637}
-
georgia.kouveli authored
This issue was fixed in VisitWord64And in 2f8ad11f. Port the fix to VisitWord32And. BUG= Review-Url: https://codereview.chromium.org/2815853002 Cr-Commit-Position: refs/heads/master@{#44636}
-
Michael Achenbach authored
Bug: chromium:710428,v8:6248 Change-Id: I70430d5a200199563bf5468a6cc80614307f63e6 Reviewed-on: https://chromium-review.googlesource.com/474847Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#44635}
-
bmeurer authored
When optimizing calls to get Object.prototype.__proto__ in JSCallReducer, we can also consume unreliable receiver map information, as long as the receiver maps are stable. In that case we also need to install proper stability dependencies. BUG=chromium:711195,v8:5267,v8:6241 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2816993002 Cr-Commit-Position: refs/heads/master@{#44634}
-
Clemens Hammacher authored
This CL implements the proposed change to show information about WebAssembly values and call frames via the inspector interface. Each interpreted WebAssembly frame will have two scopes: A global scope showing information about the memory (to be extended for globals), and a local scope showing information about parameters, local variables, and stack values. Names of local variables will be added later. R=ahaas@chromium.org, yangguo@chromium.org BUG=v8:6245,v8:5822 Change-Id: I0a35fddd0a353933c86adf62083233b08098a2c7 Reviewed-on: https://chromium-review.googlesource.com/474865 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#44633}
-
Michael Starzinger authored
This fixes the existing lowering of {JSGetSuperConstructor} nodes to unconditional throws. The above operator is marked as {kNoWrite} but runtime calls are not marked as such. Any deoptimizing operation after the throw would not be able to find a valid {Checkpoint}. We remove the lowering case in question. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-6248 BUG=v8:6248 Change-Id: I22c922947336254502f698b02f944cf35dd8688a Reviewed-on: https://chromium-review.googlesource.com/476570Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44632}
-
bmeurer authored
When the incoming value to ChangeFloat64ToTagged is in Smi range, we represent it as Smi instead of a HeapNumber. This addresses a range of problems where TurboFan unnecessarily deoptimizes because an operation learned Smi feedback in Ignition, but was then confronted with a tagged HeapNumber in TurboFan, just because the value was also represented as unboxed double somewhere in the meantime. BUG=v8:6256 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2815283002 Cr-Commit-Position: refs/heads/master@{#44631}
-
Sathya Gunasekaran authored
This patch delays the DisposeModuleEmbedderData call for the interative shell case until we exit the RunShell function. Bug: v8:5785 Change-Id: I01ff76000882cd1d6801fefc9ea3770c3f38c83b Reviewed-on: https://chromium-review.googlesource.com/476024 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#44630}
-
- 12 Apr, 2017 4 commits
-
-
Caitlin Potter authored
Adds some benchmarks copied from v8:4762. BUG=v8:4762, v8:5460 R=adamk@chromium.org Change-Id: I0b96080042781c2c46c0c8a3896a921bde97c1e5 Reviewed-on: https://chromium-review.googlesource.com/475934Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#44629}
-
jyan authored
R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2815903002 Cr-Commit-Position: refs/heads/master@{#44628}
-
jyan authored
Port a7c4e778 Original Commit Message: This change mirrors the semantics for derived class constructors. This change doesn't affect non class constructors. This change could potentially break web compat. More details: https://github.com/tc39/ecma262/pull/469 R=gsathya@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2815873003 Cr-Commit-Position: refs/heads/master@{#44627}
-
binji authored
It's required by the spec -- and observable -- that the index be validated before the conversion of the value(s) via ToInteger. The previous implementation also had an old test for validating the atomic index, which has now been switched to ToIndex. This also exposed an issue in the ia32 code generator: cmpxchg_b requires a byte register, but the ia32 instruction selector was ensuring that the new_value was a byte register, not the TempRegister. This change forces the temp register to use edx, which always can be used as a byte register (dl). This is the same behavior as currently used in UseByteRegister. BUG=v8:4614 R=jarin@chromium.org,jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2814753003 Cr-Commit-Position: refs/heads/master@{#44626}
-