- 26 Oct, 2017 25 commits
-
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: I2bf361cab6da5e57302fb83d384b5f7e8e847c9a Reviewed-on: https://chromium-review.googlesource.com/738145Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48972}
-
Michael Starzinger authored
This moves the initialization of the {Code::stub_key} field into the allocator for {Code} objects, essentially making the field in question immutable after allocation. R=verwaest@chromium.org BUG=v8:6792 Change-Id: I8ba2ffeea792d0d566995c08e3572ae63a7c1e94 Reviewed-on: https://chromium-review.googlesource.com/739141 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#48971}
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: I7a458991921b5241c11db8999be433f4b33ce639 Reviewed-on: https://chromium-review.googlesource.com/738144Reviewed-by:
-
Junliang Yan authored
Bug: Change-Id: I4ea086564ff4a7782c0c1bc232d9929fd73fd9f6 Reviewed-on: https://chromium-review.googlesource.com/738537Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#48969}
-
Michael Starzinger authored
R=ulan@chromium.org Change-Id: I141daeffde426a75293ffa0565c867d73a81cbfc Reviewed-on: https://chromium-review.googlesource.com/738776Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48968}
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: If91b709779912c37b88f3c57e46f7910b59cc240 Reviewed-on: https://chromium-review.googlesource.com/737870 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This move the {Code::next_code_link} into the data container, making it possible to mutate the field even when {Code} objects are protected. It also introduces a dedicated body descriptor for the container allowing for tagged fields to be part of the container. R=ulan@chromium.org BUG=v8:6792 Change-Id: I56a9d53e8bb35aeb0a7036e3abf3ebee1ba2928d Reviewed-on: https://chromium-review.googlesource.com/738184 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48966}
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: I1bb1e47ebf16e55e63ed4bbd9ce9eb0c01e8b754 Reviewed-on: https://chromium-review.googlesource.com/735440 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#48965}
-
Daniel Bevenius authored
This commit changes the pararmeter names in the comment for NewConsString which currently do not match the actual parameter names in the function definition or the declaration in code-stub-assembler.cc. Bug: Change-Id: I162a2027cc37512de8a09e520a1fb13c9445fa97 Reviewed-on: https://chromium-review.googlesource.com/657017Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#48964}
-
Peter Marshall authored
Bug: v8:6992 Change-Id: I7b440e5fba9d86cca5b96438a31023580ad7dba2 Reviewed-on: https://chromium-review.googlesource.com/738229 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Both the top_ pointer and the top_on_previous_step_ pointer can be one byte beyond the current page. Page::FromAddress call should take that into account. Bug: chromium:777177 Change-Id: I9cbb5bc6eab932afc6d0c915fd70a9a7b20ba62c Reviewed-on: https://chromium-review.googlesource.com/738204 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=leszeks@chromium.org Change-Id: I74ea24beb97976674891d869cbcad341c1eb4a05 Reviewed-on: https://chromium-review.googlesource.com/737996Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48961}
-
Michał Majewski authored
This reverts commit 5442e8b2. Reason for revert: https://crbug.com/v8/7006 Original change's description: > Reland "Reuse arch/mode discovery in deopt fuzzer" > > This is a reland of a24c7c9a > Original change's description: > > Reuse arch/mode discovery in deopt fuzzer > > > > Bug: v8:6917 > > Change-Id: I1b7169c8702c8649812b17579d38d64de676ed60 > > Reviewed-on: https://chromium-review.googlesource.com/723420 > > Commit-Queue: Michał Majewski <majeski@google.com> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48838} > > Bug: v8:6917 > Change-Id: I03b2c288257d44c2df9d0fa6cf4750d1c5719d59 > Reviewed-on: https://chromium-review.googlesource.com/735719 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48916} TBR=machenbach@chromium.org,majeski@google.com Change-Id: Ibbc16bb7115c8e8b93bd8f39065742d3c2d7739f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917, v8:7006 Reviewed-on: https://chromium-review.googlesource.com/737807 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48960}
-
Michał Majewski authored
This reverts commit 697b2c09. Reason for revert: <INSERT REASONING HERE> Original change's description: > Setting up the environment for testrunner refactored > > Bug: v8:6917 > Change-Id: Ibc3c738ef807d37d8b76f440d9765c4d0405c021 > Reviewed-on: https://chromium-review.googlesource.com/735421 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48923} TBR=machenbach@chromium.org,majeski@google.com Change-Id: Iafb29f1f13decc6e6ed00ed6e815008fcde1dc44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917 Reviewed-on: https://chromium-review.googlesource.com/737635Reviewed-by:
-
Georg Neis authored
R=jkummerow@chromium.org Bug: Change-Id: I2aaf7160f874985374b7b975912bf93261fdef4d Reviewed-on: https://chromium-review.googlesource.com/737831 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
jgruber authored
* Mark BytecodeOperands and Bytecodes AllStatic. * Add BytecodeOperands::kOperandScaleCount. * Add Bytecodes::ReusesExistingHandler in preparation for adding another callsite from deserialization. Bug: v8:6624 Change-Id: Ic8b5d444df5525ef6d14de6931b38afd926b251e Reviewed-on: https://chromium-review.googlesource.com/738092Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#48957}
-
Toon Verwaest authored
This attaches a constructor to the bound function map so we can identify the creation context using the map, it chooses the bound-function map from the same realm as the target's creation context (additionally to avoid memory leaks and unnecessary transitions), and finally drops the loop unwrapping bound functions in GetCreationContext. Bug: Change-Id: Icb6f4c29287f9cba69f11afbd070f52c0ad1aa16 Reviewed-on: https://chromium-review.googlesource.com/738097Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#48956}
-
Georg Neis authored
We can already construct wrapper objects using Object(). R=jkummerow@chromium.org Bug: v8:6791 Change-Id: Ic4079654ef1fcae2be4b588cb12c2645e199f4f7 Reviewed-on: https://chromium-review.googlesource.com/738089Reviewed-by:
-
Clemens Hammacher authored
The current implementation overapproximates the possible_nondeterminism_ bit by setting it whenever a NaN value is reinterpreted as integer, or stored to memory. This hides bugs in the interpreter that are handled as possible nondeterminism even though they are not. This CL fixes this by only setting the bit if a binary floating point operation is executed and one of the inputs is a NaN. R=ahaas@chromium.org Bug: v8:6954 Change-Id: Ib937ae7730dbb140c012d07fae23b40ae7ed3d6b Reviewed-on: https://chromium-review.googlesource.com/735599 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#48954}
-
Clemens Hammacher authored
The bug was recently introduced in https://crrev.com/c/730716. R=titzer@chromium.org Bug: v8:6954 Change-Id: I9b77baac9fafefaab163700432ddef6e9e686901 Reviewed-on: https://chromium-review.googlesource.com/735540Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48953}
-
Michael Starzinger authored
R=jarin@chromium.org BUG=v8:6792 Change-Id: I76e9acb96cd89d4de163e533a1007c91f6b9970f Reviewed-on: https://chromium-review.googlesource.com/738034Reviewed-by:
-
Clemens Hammacher authored
This way, we can also check the return code of d8. We currently have a bug (6981) which makes failing tests not being detected, even though the failure message is (sometimes) being printed. After this refactoring, we can write tests for our mjsunit test functions. R=machenbach@chromium.org Bug: v8:6981 Change-Id: I0aa0abcb0f9a4f622a1e1d1a4d826da1e6eb4f07 Reviewed-on: https://chromium-review.googlesource.com/737991Reviewed-by:
-
Michael Achenbach authored
The current_cpu value was erroneously removed from the build config json. In multi-arch builds, each toolchain subdirectory in the build-product output emits its own build-config json, where current_cpu determines the architecture type of the sub-build. Correctness-fuzzer runs could wrongly determined x86 sub-builds as x64. Bug: chromium:777285 Change-Id: I5104630cd8ebbd263d557fb29771a31a2a1d78c2 Reviewed-on: https://chromium-review.googlesource.com/737797Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48950}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2647b49..f034b7d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e2235db..5da4837 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/5e8001d..fe94e72 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I966cf7b3d44580ddeaa994050ba01cbb30676b6c Reviewed-on: https://chromium-review.googlesource.com/738556Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#48949}
-
Junliang Yan authored
R=joransiu@ca.ibm.com, jbarboza@ca.ibm.com Bug: Change-Id: I5d81c14c658af7e8fb5054e147aada9999fbde0c Reviewed-on: https://chromium-review.googlesource.com/737440Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#48948}
-
- 25 Oct, 2017 15 commits
-
-
Karl Schimpf authored
The motivation for this is that it greatly reduces the RelocInfo size. This also results in a small improvement in compile time. Note: This CL was based on https://codereview.chromium.org/2651833003, and basically reverts that CL (but handles code changes and some minor bugs in previous code). Bug: chromium:772780 Change-Id: I55dd48d3bddd4b3d1c8eec13791b3ee4c485c604 Reviewed-on: https://chromium-review.googlesource.com/730649Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Eric Holk <eholk@chromium.org> Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Cr-Commit-Position: refs/heads/master@{#48947}
-
Jakob Kummerow authored
Abstract equality comparison of a BigInt and a String converts the latter to BigInt. This conversion can fail; since we do not want to pass a context to the comparison function, we must signal such failure without throwing an exception. This CL uses the existing ShouldThrow enum to configure behavior of String-to-BigInt conversion, moving it out of Object into globals.h. Bug: v8:6791, v8:6979 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ibb98675079b8392cf03bbcbbbd5556108500a32d Reviewed-on: https://chromium-review.googlesource.com/734172 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Adam Klein authored
This flag has been on by default since Chrome 61. Bug: v8:5549 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I81c34d1d3a7dbd219acce2cdf0cf4917eb484002 Reviewed-on: https://chromium-review.googlesource.com/738312Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48945}
-
Jakob Kummerow authored
and use a newly-introduced "enum class Operation" in all other places that so far passed Token::Values around. Also delete some related dead code along the way. Bug: v8:6921 Change-Id: I062f396d304aa62298cfeff202e3132a4a5597c1 Reviewed-on: https://chromium-review.googlesource.com/736851 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48944}
-
Adam Klein authored
It's been on by default since Chrome 61. Bug: v8:4806 Change-Id: I748d9008d29997667458649d7bf4999e15ff8615 Reviewed-on: https://chromium-review.googlesource.com/737416 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:6791 Change-Id: I9c1ebddfab9f3d73642e61e43c3fbfd739efd56c Reviewed-on: https://chromium-review.googlesource.com/736722 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
This reverts commit 877de376. Reason for revert: Looks like this doesn't really move the needle (only w/ high iteration count). So let's not do the extra complexity unless there's a good reason to do so. Original change's description: > [turbofan] Introduce FindOrderedHashMapEntryForReceiverKey operator. > > This optimizes Map#get and Map#has for the case where the key is known > to be a JSReceiver. This generalizes the existing logic for the > FindOrderedHashMapEntryForSigned32Key operator to also deal with > receivers. This gives a nice 33% boost on the map-set-lookup-es6 test > of the six-speed benchmark suite. > > Drive-by-fix: Rename the FindOrderedHashMapEntryForInt32Key operator to > FindOrderedHashMapEntryForSigned32Key to match the naming of the types. > > R=jarin@chromium.org > > Bug: v8:5267, v8:7001 > Change-Id: Ifab8414f26adee7ec833d8cb94ae0ac49f2c3d35 > Reviewed-on: https://chromium-review.googlesource.com/738180 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48938} TBR=jarin@chromium.org,bmeurer@chromium.org Change-Id: Icaf9e22cb3412a97342c4e4cdc422d4aaa2d0ef9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5267, v8:7001 Reviewed-on: https://chromium-review.googlesource.com/738052Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48941}
-
Adam Klein authored
For the tagged case, we never use the Literal AST node, so don't bother creating them in the first place. Instead, store AstRawStrings directly, and only wrap with Literals when desugaring untagged templates into binary ops. This also makes the upcoming merge of Literal and AstValue simpler. Bug: v8:6984 Change-Id: I9f12710b05c6d63d7e91f2707cd08093f7ff3f11 Reviewed-on: https://chromium-review.googlesource.com/736151Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48940}
-
Clemens Hammacher authored
Since https://crrev.com/c/712734, this struct is not being used any more. R=titzer@chromium.org Change-Id: I5b7a73e99ef50fa4fd0f05f6e2b97fa54ea19f1d Reviewed-on: https://chromium-review.googlesource.com/738033Reviewed-by:
-
Benedikt Meurer authored
This optimizes Map#get and Map#has for the case where the key is known to be a JSReceiver. This generalizes the existing logic for the FindOrderedHashMapEntryForSigned32Key operator to also deal with receivers. This gives a nice 33% boost on the map-set-lookup-es6 test of the six-speed benchmark suite. Drive-by-fix: Rename the FindOrderedHashMapEntryForInt32Key operator to FindOrderedHashMapEntryForSigned32Key to match the naming of the types. R=jarin@chromium.org Bug: v8:5267, v8:7001 Change-Id: Ifab8414f26adee7ec833d8cb94ae0ac49f2c3d35 Reviewed-on: https://chromium-review.googlesource.com/738180Reviewed-by:
-
Andreas Haas authored
R=mstarzinger@chromium.org Change-Id: Ic36d33ff8d1edeefc745146ec1c1203e08181565 Reviewed-on: https://chromium-review.googlesource.com/737992Reviewed-by:
-
Andreas Haas authored
This reverts commit 361bb1a0. Reason for revert: See https://crbug.com/v8/6981 BUG=v8:6981 Original change's description: > [test] Refactor assertPromiseResult > > This patch introduces assertPromiseFulfills and assertPromiseFulfills as > a replacement for assertPromiseResult because it’s more JavaScript-y. > > BUG=v8:6921 > R=ahaas@chromium.org > > Also-By: ahaas@chromium.org > Change-Id: I2f865dba3992ddf3b58987bf0b376d143edb5c31 > Reviewed-on: https://chromium-review.googlesource.com/718746 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48578} Change-Id: Ie760d2422451f16acc616aae001fe9fd18bf5cd4 Reviewed-on: https://chromium-review.googlesource.com/738249Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#48936}
-
Anisha Rohra authored
Port 266e803e Original Commit Message: This CL adds a first implementation of Liftoff, the new wasm baseline compiler, for x64 and ia32. It currently supports the most important i32 instructions and control instructions. Whenever it encounters an instruction it does not support yet, it aborts. In a subsequent CL, Liftoff will be called from the WasmCompilationUnit, falling back to Turbofan compilation if the baseline compiler bails out. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, clemensh@chromium.org, titzer@chromium.org BUG= LOG=N Change-Id: I35ad2b0230c37f523e24aa90b637a67e5ce59083 Reviewed-on: https://chromium-review.googlesource.com/735784Reviewed-by:
-
Clemens Hammacher authored
The Float32(uint32_t) constructor should not be public, use Float32::FromBits explicitly if needed. R=ahaas@chromium.org Change-Id: I414e621deebde8cdb474f17e08fcc489dbc083cd Reviewed-on: https://chromium-review.googlesource.com/738173Reviewed-by:
-
Michael Starzinger authored
This makes sure flags on newly allocated {Code} objects are initialized from within the allocator itself instead of after the object has been created. It essentially makes these flags immutable. R=jarin@chromium.org BUG=v8:6792 Change-Id: I6bef183a25508faf1fec28d347956e766e65aecf Reviewed-on: https://chromium-review.googlesource.com/737633 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
