- 11 Oct, 2016 17 commits
-
-
verwaest authored
BUG=v8:5501 Review-Url: https://codereview.chromium.org/2406803003 Cr-Commit-Position: refs/heads/master@{#40160}
-
clemensh authored
This is needed for the asm.js -> WASM pipeline. A single exported function is exported as __single_function__, but we still want to see the correct function name on the stack, so the underlying wasm function has to carry the original name. R=ahaas@chromium.org, titzer@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2406133003 Cr-Commit-Position: refs/heads/master@{#40159}
-
mstarzinger authored
This enables preservation of bytecode by default. Thus far bytecode was cleared during tier-up by default and was only preserved in the staging configuration. R=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2384063010 Cr-Commit-Position: refs/heads/master@{#40158}
-
clemensh authored
I use it in a follow-up commit to delta-encode asm.js source positions. This commit also removes the redundant consume_bytes function. R=ahaas@chromium.org, titzer@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2406163002 Cr-Commit-Position: refs/heads/master@{#40157}
-
clemensh authored
Just a minor refactoring. We have the type for compiled modules, so use it where possible for better type safety. R=ahaas@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2405173002 Cr-Commit-Position: refs/heads/master@{#40156}
-
mlippautz authored
BUG=chromium:652721 R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2406913002 Cr-Commit-Position: refs/heads/master@{#40155}
-
epertoso authored
This makes the MachineGraphVerifier happy with the stub. R=jarin@chromium.org BUG= Review-Url: https://codereview.chromium.org/2394193002 Cr-Commit-Position: refs/heads/master@{#40154}
-
vogelheim authored
Using a global proxy (e.g. 'window.f', 'w.f' or 'this.f') is considerably slower than evaluating just 'f'. This CL aims to perform the necessary checks at compile time and inline the accesses. This is a follow-on CL to crrev.com/2369933005: - The initial upload is crrev.com/2369933005 + a rebase. - The remaining issues are the fixes requested by the reviewers on that CL. BUG=chromium:634276 Review-Url: https://codereview.chromium.org/2403003002 Cr-Commit-Position: refs/heads/master@{#40153}
-
jochen authored
R=verwaest@chromium.org BUG= Review-Url: https://codereview.chromium.org/2404913002 Cr-Commit-Position: refs/heads/master@{#40152}
-
machenbach authored
The test still runs into the 240s timeout on Nexus5 and Nexus7. NOTRY=true TBR=adamk, caitp Review-Url: https://codereview.chromium.org/2406173002 Cr-Commit-Position: refs/heads/master@{#40151}
-
jgruber authored
This test is timing out in gc-stress mode since RegExp.prototype.test was moved to C++. RE.proto.test will be improved shortly, and this test should be reenabled then. BUG=v8:5339 NOTRY=true Review-Url: https://codereview.chromium.org/2407133002 Cr-Commit-Position: refs/heads/master@{#40150}
-
yangguo authored
R=bmeurer@chromium.org BUG=v8:5049, v8:5086 Review-Url: https://codereview.chromium.org/2402363002 Cr-Commit-Position: refs/heads/master@{#40149}
-
v8-autoroll authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/b403fa6..98499f3 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/17093d4..83eadac Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapul/+log/c47d2e1..f1eba76 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2410723002 Cr-Commit-Position: refs/heads/master@{#40148}
-
zhengxing.li authored
port ec132e05 (r40086) original commit message: (GcStress failure was unrelated.) At one time, we hoped to generate the same code for different native contexts. But in truth, much performance comes from optimizing on the native context. Now we abandon this pathway. BUG= Review-Url: https://codereview.chromium.org/2404843002 Cr-Commit-Position: refs/heads/master@{#40147}
-
zhengxing.li authored
This CL set Floating-point precision in Math.Cos/Math.Sin in Crankshaft compiler to standard double precision which is expected by v8. BUG= Review-Url: https://codereview.chromium.org/2403803002 Cr-Commit-Position: refs/heads/master@{#40146}
-
adamk authored
Revert of [modules] Store Module metadata in per-Context EmbedderData (patchset #7 id:120001 of https://codereview.chromium.org/2393303002/ ) Reason for revert: Fails under LeakSanitizer on auto-roll fyi bot: https://build.chromium.org/p/client.v8.fyi/builders/Auto-roll%20-%20release%20process/builds/49447 Original issue's description: > [modules] Store Module metadata in per-Context EmbedderData > > Unifies the approaches used for storing the specifier -> module mapping > and the module -> directory mapping, using std::unordered_maps for both > and storing them per-Context. > > This requires adding a method to the v8::Module API to get a hash code > for a Module, but allows slimming down the API in return: gone are > SetEmbedderData/GetEmbedderData, along with the fourth argument > to ResolveModuleCallback. > > Besides a simpler API, this allows d8 to get closer to the HTML loader, > which requires each Realm to have a persistent module map (though this > capability is not yet exercised by any tests). > > BUG=v8:1569 > > Committed: https://crrev.com/9cf8fce74cf6e7afd6aea3f3545f6bb61572f277 > Cr-Commit-Position: refs/heads/master@{#40133} TBR=jochen@chromium.org,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1569 Review-Url: https://codereview.chromium.org/2406973003 Cr-Commit-Position: refs/heads/master@{#40145}
-
adamk authored
Revert of [d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData (patchset #2 id:20001 of https://codereview.chromium.org/2403303002/ ) Reason for revert: Still failing on auto-roll fyi bot Original issue's description: > [d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData > > BUG=v8:1569 > TBR=jochen@chromium.org > > Committed: https://crrev.com/cd6f1c98f989ef991da3ff465f183c1caa070918 > Cr-Commit-Position: refs/heads/master@{#40143} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1569 Review-Url: https://codereview.chromium.org/2403103004 Cr-Commit-Position: refs/heads/master@{#40144}
-
- 10 Oct, 2016 23 commits
-
-
adamk authored
BUG=v8:1569 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2403303002 Cr-Commit-Position: refs/heads/master@{#40143}
-
gsathya authored
The behavior was changed in https://codereview.chromium.org/2357423002 Review-Url: https://codereview.chromium.org/2403163002 Cr-Commit-Position: refs/heads/master@{#40142}
-
littledan authored
R=adamk BUG=v8:5337 Review-Url: https://codereview.chromium.org/2313873003 Cr-Commit-Position: refs/heads/master@{#40141}
-
adamk authored
These were used by the JS implementation, but are now dead code. R=caitp@igalia.com BUG=v8:5388 Review-Url: https://codereview.chromium.org/2410533002 Cr-Commit-Position: refs/heads/master@{#40140}
-
kozyatinskiy authored
* Inspector should depend on v8_libbase, v8 depedency is added in conditions section. * Inlined sources since they aren't used outside of this gyp file. BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2408833002 Cr-Commit-Position: refs/heads/master@{#40139}
-
heimbuef authored
BUG=v8:5409 Committed: https://crrev.com/a124feb0760896c8be61de08004a08c3bc9b4b3f Committed: https://crrev.com/fc840361e357a571c709e0239ae82cc089800b3f Review-Url: https://codereview.chromium.org/2348303002 Cr-Original-Original-Commit-Position: refs/heads/master@{#39633} Cr-Original-Commit-Position: refs/heads/master@{#40048} Cr-Commit-Position: refs/heads/master@{#40138}
-
heimbuef authored
BUG=v8:5409 Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e Committed: https://crrev.com/316669f62ea3834395bf4caab7bc3d7c32f6bbc6 Review-Url: https://codereview.chromium.org/2335343007 Cr-Original-Original-Commit-Position: refs/heads/master@{#39631} Cr-Original-Commit-Position: refs/heads/master@{#40044} Cr-Commit-Position: refs/heads/master@{#40137}
-
bradnelson authored
BUG=v8:5053 TEST=None R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2395333003 Cr-Commit-Position: refs/heads/master@{#40136}
-
titzer authored
R=bradnelson@chromium.org,aseemgarg@chromium.org BUG= Review-Url: https://codereview.chromium.org/2408823002 Cr-Commit-Position: refs/heads/master@{#40135}
-
neis authored
- Make testcfg.py ignore files ending in "_FIXTURE.js", which are not supposed to be tested standalone but only as imports to other modules. - Refine test262.status to match where we are with the modules implementation. BUG=v8:1569 R=adamk@chromium.org Review-Url: https://codereview.chromium.org/2400713004 Cr-Commit-Position: refs/heads/master@{#40134}
-
adamk authored
Unifies the approaches used for storing the specifier -> module mapping and the module -> directory mapping, using std::unordered_maps for both and storing them per-Context. This requires adding a method to the v8::Module API to get a hash code for a Module, but allows slimming down the API in return: gone are SetEmbedderData/GetEmbedderData, along with the fourth argument to ResolveModuleCallback. Besides a simpler API, this allows d8 to get closer to the HTML loader, which requires each Realm to have a persistent module map (though this capability is not yet exercised by any tests). BUG=v8:1569 Review-Url: https://codereview.chromium.org/2393303002 Cr-Commit-Position: refs/heads/master@{#40133}
-
mlippautz authored
R=ulan@chromium.org BUG= Review-Url: https://codereview.chromium.org/2409553003 Cr-Commit-Position: refs/heads/master@{#40132}
-
adamk authored
StringFromCodePointOperator needed to derive from Operator1<UnicodeEncoding> rather than plain old Operator. This was thankfully caught by the CFI build. R=bmeurer@chromium.org, caitp@chromium.org BUG=v8:5498 Review-Url: https://codereview.chromium.org/2398403003 Cr-Commit-Position: refs/heads/master@{#40131}
-
gsathya authored
Review-Url: https://codereview.chromium.org/2397373004 Cr-Commit-Position: refs/heads/master@{#40130}
-
neis authored
Extend a test of namespace imports such that it accesses the object inside a with statement (inside a sloppy function). Drive-by-fix: remove duplicate initialization of embedder data (probably due to bad merge). R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2405603003 Cr-Commit-Position: refs/heads/master@{#40129}
-
mythria authored
Revert of [Interpreter] Collect feedback about Oddballs in Subtract Stub. (patchset #2 id:20001 of https://codereview.chromium.org/2406843002/ ) Reason for revert: breaks win32-debug bot. Original issue's description: > [Interpreter] Collect feedback about Oddballs in Subtract Stub. > > BUG=v8:4280, v8:5400 > LOG=N > > Committed: https://crrev.com/d5d283b27d406486e2f8d7b44c6d2b3db4f98458 > Cr-Commit-Position: refs/heads/master@{#40124} TBR=leszeks@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280, v8:5400 Review-Url: https://codereview.chromium.org/2407923002 Cr-Commit-Position: refs/heads/master@{#40128}
-
petermarshall authored
Also add a test for when the first argument is null or undefined, as there are no tests that cover this currently. BUG=v8:5364 Review-Url: https://codereview.chromium.org/2399423003 Cr-Commit-Position: refs/heads/master@{#40127}
-
mtrofin authored
The spurious failures were caused by the compiled module template and its corresponding owning object getting out of sync due to memory allocations (which may trigger GC) between the points each were fetched. Specifically, the {original} was first obtained; then a GC may happen when cloning the {code_table}. At this point, the {original}'s owner may have been collected, getting us down the path of not cloning. When time comes to patch up globals, we incorrectly try to patch them assuming the global start is at 0 (nullptr), which in fact it isn't. This change roots early, in a GC-free area, both objects. Additionally, it avoids publishing to the instances chain the new instance until the very end. This way: - the objects used to create the new instance offer a consistent view - the instances chain does not see the object we try to form. If something fails, we can safely retry. - since the owner is rooted, the state of the front of the instances chain stays unchanged - with the same compiled module we started from. So the early belief that we needed to clone is not invalidated by any interspersed GC. This situation suffers from a sub-optimality discussed in the design document, in that, in a memory constrained system, the following snippet may surprisingly fail: var m = new WebAssembly.Module(...); var i1 = new WebAssembly.Instance(m); i1 = null; var i2 = new WebAssembly.Instance(m); //may fail. This will be addressed subsequently. BUG=v8:5451 Review-Url: https://codereview.chromium.org/2395063002 Cr-Commit-Position: refs/heads/master@{#40126}
-
titzer authored
R=rossberg@chromium.org BUG=chromium:575167 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_msan_rel Committed: https://crrev.com/640ae3f9d20dcae915dbfa978bf48944cd4d0dc3 Review-Url: https://codereview.chromium.org/2403823002 Cr-Original-Commit-Position: refs/heads/master@{#40121} Cr-Commit-Position: refs/heads/master@{#40125}
-
mythria authored
BUG=v8:4280, v8:5400 LOG=N Review-Url: https://codereview.chromium.org/2406843002 Cr-Commit-Position: refs/heads/master@{#40124}
-
machenbach authored
Revert of [wasm] Base address for data segments can also be the value of a global variable. (patchset #1 id:1 of https://codereview.chromium.org/2403823002/ ) Reason for revert: msan not happy: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/11332 Original issue's description: > [wasm] Base address for data segments can also be the value of a global variable. > > R=rossberg@chromium.org > BUG=chromium:575167 > > Committed: https://crrev.com/640ae3f9d20dcae915dbfa978bf48944cd4d0dc3 > Cr-Commit-Position: refs/heads/master@{#40121} TBR=rossberg@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2402373002 Cr-Commit-Position: refs/heads/master@{#40123}
-
jgruber authored
This CL ports RegExp.prototype.test, RegExp.prototype.match and RegExp.prototype.search to C++. Performance regressions are expected but should be improved in an upcoming CL. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2394713003 Cr-Commit-Position: refs/heads/master@{#40122}
-
titzer authored
R=rossberg@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403823002 Cr-Commit-Position: refs/heads/master@{#40121}
-