- 06 Jun, 2022 2 commits
-
-
Liu Yu authored
Port commit a52b44f0 Bug: v8:12908 Change-Id: Ifcafab2f29d416f39fa48082e86c3c3b72508bad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3690453 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu Yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#80952}
-
Lu Yahan authored
Port commit a52b44f0 Original Commit Message: Prototype the instruction on the interpreter, and Arm64. Details of instruction lowerings on all relevant architectures can be found at: https://github.com/WebAssembly/relaxed-simd/issues/52 Change-Id: Ie0415f5c6a543517aa488a36ea5e575c6612ec0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687424 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80951}
-
- 05 Jun, 2022 1 commit
-
-
Anton Bikineev authored
The CL splits the Oilpan giga-cage in two 2GB reservations: one for normal pages and the other for large ones. The split enables fast page-header lookup (assuming most objects reside on normal pages), which is needed for: 1) the young generation project, where the remembered set will move to pages; 2) the shared-cage project, to find HeapBase* from page-headers. Bug: v8:12231, chromium:1029379 Change-Id: I4ae9e8a75a307ed0dff9a2ec4f1247b80e17ebd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688519 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#80950}
-
- 04 Jun, 2022 1 commit
-
-
Igor Sheludko authored
Bug: v8:11111 Change-Id: I52caef43e7f2b3921ef34eeb50e41f1dedf90e32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3689570 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80949}
-
- 03 Jun, 2022 22 commits
-
-
Igor Sheludko authored
... when allocating Code objects from background thread. Bug: chromium:1329012, chromium:1330887 Change-Id: Ia2731ba463381c826d14591f4ba3b3fe15d15a0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688517 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80948}
-
Clemens Backes authored
Using the constexpr {value()} accessor instead of the non-constexpr implicit conversion operator makes GCC recognize the method as inlinable again. Before, we got (shortened): heap/heap-allocator-inl.h:167:18: error: inlining failed in call to always_inline ‘HeapAllocator::AllocateRaw’: function not inlinable The issue was introduced by https://crrev.com/c/3683321. R=mlippautz@chromium.org Bug: v8:12887 Change-Id: I5879dc0afb23d1d5bb782bf9444703e9cba148f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688515Reviewed-by:Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80947}
-
Andrey Kosyakov authored
This was originally part of https://crrev.com/c/v8/v8/+/3662540, but got accidentally lost during revert and re-roll. Change-Id: I38097884e50f086e2a71319cf820c628ba736a8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687417 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#80946}
-
Jakob Kummerow authored
Calling memset directly is faster than std::fill for multi-byte element types. Change-Id: I83b997740146688f87b86901825e31d6644bc25b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687700 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80945}
-
Milad Fa authored
Port a52b44f0 Original Commit Message: Prototype the instruction on the interpreter, and Arm64. Details of instruction lowerings on all relevant architectures can be found at: https://github.com/WebAssembly/relaxed-simd/issues/52 R=irezvov@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ia42e3f7fcb77d5515ee20bb428902cc3ff033f69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688290 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80944}
-
Clemens Backes authored
The {AddOutOfLineTrap} method shows up with several percent of runtime in performance profiles. The majority of that was spent copying entries when growing the underlying vector. Pre-reserving space in that vector removes most of that overhead. R=thibaudm@chromium.org Change-Id: I1befb75b070d4f803770c2afcc5c82ffb9bfb522 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688511Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80943}
-
Milad Fa authored
Applying the set of unittest changes from https://crrev.com/c/3678208 to BE. Change-Id: I02d0f2f388720e3acc35660042d5c2c76fa589e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687474Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80942}
-
Jakob Kummerow authored
Fixed: v8:12935 Change-Id: Ib4dfdc276e6a9f465666b068bdbe31776429f359 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687699 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Clemens Backes authored
As the {CompilationTimeCallback} does not react to {kFinishedCompilationChunk}, it does not need to stay alive after a "final" compilation event. Drive-by: Make the enum a boolean enum. R=jkummerow@chromium.org Bug: v8:12899 Change-Id: Iffacd6e3d9a0f2474a51f07cf01419b2badf98c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667083 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80940}
-
Clemens Backes authored
There are two flag updates from the Wasm C-API. Both are unnecessary: FLAG_expose_gc is not needed because we call the internal API for garbage collection; this is always allowed. FLAG_experimental_wasm_eh is enabled by default, so does not need to be set to true in that test. R=jkummerow@chromium.org Bug: v8:12887 Change-Id: If56506228cd89d5452e71376e4c2f6a4ec636979 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687690Reviewed-by:
-
Clemens Backes authored
Extend the effect of --freeze-flags-after-init to also protect updates of individual flags instead of only the API. For this, we wrap each flag in a {FlagValue} class which implicitly converts to the value of the flag. Some cases still require the explicit {value()} accessor though. That accessor is {constexpr}, in contrast to the implicit conversion, because otherwise clang emits a lot of warnings about dead code within "if (FLAG...)" scopes. R=cbruni@chromium.org Bug: v8:12887 Change-Id: I87d3457e49ceb317d34d6a21cf09c520d4171eb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683321Reviewed-by:Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#80938}
-
Igor Sheludko authored
... as a pair of Code and CodeDataContainer. In order to stop creating and using trampoline Code objects for builtins we need a different way to represent an "embedded builtin" code lookup result of builtin trampoline Code objects. We can't switch to CodeT for this purpose because GC still needs to be able to locate not yet evacuated Code objects in order to update old code pointers on the stack once Code objects are moved. Bug: v8:11880 Change-Id: I296636a6728a11c8e3220b3fee43fd12ff633c1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3684813Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80937}
-
Nico Hartmann authored
Bug: v8:12783 Change-Id: Icf9e5b29863a1d4bfc8924ea34476d2a9998c391 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683322 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80936}
-
Marja Hölttä authored
It mostly worked out of the box. Only the dictionary mode prototype chain walk code paths had to be updated. Bug: v8:11111 Change-Id: Ia8336964d29304916a34e305f32bb33bb06e211a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683340 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Clemens Backes authored
This makes some checks a bit stricter to avoid accepting illegal relaxed SIMD opcodes. 1) The default case in the Liftoff compiler should be UNREACHABLE, such that the switch case is required to cover all defined opcodes. 2) The {WasmOpcodes::IsRelaxedSimdOpcode} wrongly also returned {true} for opcodes like 0xfd300. We should really check nibbles 3-5 for the exact value 0xfd1. 3) {WasmOpcodes::Signature} was returning a non-null signatures for illegal opcodes like 0xfd200, because {IsRelaxedSimdOpcode} returned false, and then we would just use the lower bytes for the lookup in the SIMD signature table. R=thibaudm@chromium.org CC=gdeepti@chromium.org Bug: chromium:1324081 Change-Id: Idbfde570ccd782e59b47b96e7ca8cc28fa7fae98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687309 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Marja Hölttä authored
Reason: https://bugs.chromium.org/p/chromium/issues/detail?id=1331309 Reverted commits: "[compiler] Remove the optimized OSR code if deoptimizing at inside of loop" https://chromium-review.googlesource.com/c/v8/v8/+/3648219 "[compiler] Add condition use_ic to the removing the optimized OSR code logic" https://chromium-review.googlesource.com/c/v8/v8/+/3679846 "[compiler] Add out of bytecode array to break condition of removing OSR" https://chromium-review.googlesource.com/c/v8/v8/+/3686589 Bug: v8:12927, chromium:1330405, chromium:1330452, chromium:1330454, chromium:1330486, chromium:1330545 Change-Id: Idc335e1f6d236a7398b14b64c87da234106bee69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687695Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80933}
-
Leszek Swirski authored
We need to make sure that a fallthrough merge state immediately after an unconditional deopt is also marked dead. This means rotating the loop so that we do a first MergeDeadIntoFrameState pass on the current bytecode, before advancing. Bug: v8:7700 Change-Id: Ib00294a8ab7645427f1c120d4938b38719391586 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672414 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Clemens Backes authored
The value of the counter is never used, so remove it. This not only cleans up code, but also makes triggering tier-up a little bit faster because we do not need to take a mutex any more. R=ahaas@chromium.org Bug: v8:12899 Change-Id: I09f7df4d49b0d94567cd84ccb2aaa6fd86b96c37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667645Reviewed-by:
-
Clemens Backes authored
This fully removes the kFinishedTopTierCompilation event, and any handling of it. In a dynamic tiering world, that event has no meaning any more. R=ahaas@chromium.org Bug: v8:12899 Change-Id: I36484e36f7c36f2ac4fcb111e67a14509c2eefef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667081 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
We introduce a Turbofan pass which optimizes wasm-gc nodes based on the types of their inputs. Bug: v8:7748 Change-Id: I281eb0785e9e4201ef925ec201d76dc3d274ad05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679198Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/234a35b..a568526 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/5e737be..86ab9dd Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1cac3de..3a2e446 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f3d894f..13c50b4 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/393c871..4e79fda R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I65224d5895760ea6db806a71a3bff944f673ac26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688471 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80928}
-
jameslahm authored
This CL adds the serialization and deserialization for properties in class. TODO: we could use serialized start_position and length in function to add ClassPositions property to class. Bug: v8:11525 Change-Id: I065039932b3c10c6b757b331aba0ced36eba84e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3682878Reviewed-by:
-
- 02 Jun, 2022 14 commits
-
-
Milad Fa authored
This test requires shared cage implemented. More details under https://crrev.com/c/3673354 . Change-Id: Ib1d39dcc2fd6c8abb4f79bf6b845132c34d2ec8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687475Reviewed-by:
-
Igor Sheludko authored
Drive-by: don't record builtins into wasm generated code sizes. Bug: v8:11880 Change-Id: I02085c36e1831b26d7537c16be047345a0d4bca3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3684410 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Ilya Rezvov authored
Prototype the instruction on the interpreter, and Arm64. Details of instruction lowerings on all relevant architectures can be found at: https://github.com/WebAssembly/relaxed-simd/issues/52 Bug: v8:12908 Change-Id: If8ffb82c38042191c67c9b5c23a231877d4f2159 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679848Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Ilya Rezvov <irezvov@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80924}
-
Toon Verwaest authored
Smis are represented in feedback by the heap number map. Turns out the megamorphic load IC always just missed instead of using the map. Fixing this improves a microbenchmark by ~6x. Change-Id: I4c6d0ec1abb88ae34b212cfc69cc6b020060753b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683318Reviewed-by:
-
Deepti Gandluri authored
This reverts commit c443858f. Reason for revert: Several UBSan failures: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/21547/overview Original change's description: > Allow lookup of matching scripts in Isolate compilation cache > > Currently, if the same script text is compiled multiple times with > differing details (such as name, line number, or host-defined options), > then multiple copies of that script are added to the Isolate's > compilation cache. However, any attempt to look up those scripts can > find only the first instance. This change makes the script compilation > cache behave more consistently by checking the details while searching > the hash table for a match, rather than after a potential match has been > found. > > Bug: v8:12808 > Change-Id: Ic9da0bf74f359d4f1c88af89d585404f173056ee > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3671615 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#80919} Bug: v8:12808 Change-Id: I6d007374fb607a2670ca260c6bd0d6774d7f51d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687311 Auto-Submit: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80922}
-
Liviu Rau authored
- moved test data closer to tests - removed the coverage related code - refactored to remove boilerplate from test code Bug: v8:12785 Change-Id: I1013d29d8ff2c3ecb786c294ae3b3ab6decdca20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683610 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#80921}
-
Toon Verwaest authored
Code ageing too early can have a bad impact on performance. Let's evaluate keeping code alive a little longer. Later we can look at more elaborate heuristics. Change-Id: Ib220c4dcd24165d6b6e5020cb1829c669ed3e736 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3686416 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/main@{#80920}
-
Seth Brenith authored
Currently, if the same script text is compiled multiple times with differing details (such as name, line number, or host-defined options), then multiple copies of that script are added to the Isolate's compilation cache. However, any attempt to look up those scripts can find only the first instance. This change makes the script compilation cache behave more consistently by checking the details while searching the hash table for a match, rather than after a potential match has been found. Bug: v8:12808 Change-Id: Ic9da0bf74f359d4f1c88af89d585404f173056ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3671615Reviewed-by:
-
Junliang Yan authored
Change-Id: I65bf086579c51e7c73c25317952aa53919b07fa9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687471 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80918}
-
Leszek Swirski authored
This reverts commit c7aef552. Reason for revert: Merged the wrong CL for the fix. Original change's description: > [maglev] Fix dead fallthrough merging > > Add a method which optionally merges dead fallthrough paths, in case the > iteration in EmitUnconditionalDeopt reaches a merge point that is live > from another jump but dead on the fallthrough. > > Bug: v8:7700 > Change-Id: Ie505cd5356fcf70208f2f6d3e52b805956485f74 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663086 > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80878} Bug: v8:7700 Change-Id: I75a21777aecfa08138fcc25a882ae109f3409159 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687649 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80917}
-
Liu Yu authored
commit ce9d6d49 Bug: v8:12781 Change-Id: I2010281c04a26cd93fefabae98cf9a6585210013 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687069 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Clemens Backes authored
Use the existing {base::Optional} instead of the extra {MaybeBoolFlag} struct. This makes writing to a maybe-flag simpler because you just write a boolean value and that automatically initializes the optional. R=cbruni@chromium.org Bug: v8:12887 Change-Id: I940d20286d65ba4355dc04b4b6068a306706f295 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3686412Reviewed-by: -
Clemens Backes authored
This adds a new flag to freeze all flag values after initializing V8. For now, the only effect is that future calls to {SetFlagsFromString}, {SetFlagsFromCommandLine} or {EnforceFlagImplications} will fail. In the future (once tests and embedders are fixed to not change flags after initialization) we plan to actually protect flag values via memory protection. R=cbruni@chromium.org Bug: v8:12887 Change-Id: I7974bb9b86715694122f788e08952f7dcc3acdbd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679099 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
We should not use kSimd, which has already shipped. Instead, use a new kRelaxedSimd bailout reason. R=thibaudm@chromium.org Bug: chromium:1324081 Change-Id: I394e288014245ed9ae69e20f811f8cf7555e6149 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3686413Reviewed-by:
-
