- 18 Jul, 2016 21 commits
-
-
jarin authored
This makes sure that we preserve call's tailness even if we have introduced a loop exit between the call and the return. BUG=chromium:628773 Review-Url: https://codereview.chromium.org/2155123002 Cr-Commit-Position: refs/heads/master@{#37832}
-
mvstanton authored
In int32 multiplication, if we have a positive integer as input, then we know we can't produce a -0 answer. The same is true if truncation is applied (x * y | 0). Without this information, we have to rather annoyingly check if the result of multiplication is 0, then OR the inputs to check for negativity, and possibly return -0. In TurboFan, we'll deopt in this case. BUG= Review-Url: https://codereview.chromium.org/2154073002 Cr-Commit-Position: refs/heads/master@{#37831}
-
yangguo authored
R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2152923003 Cr-Commit-Position: refs/heads/master@{#37830}
-
bbudge authored
LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2157873002 Cr-Commit-Position: refs/heads/master@{#37829}
-
georgia.kouveli authored
Based on 317dc057. BUG= Review-Url: https://codereview.chromium.org/2152253002 Cr-Commit-Position: refs/heads/master@{#37828}
-
franzih authored
For angular.js on Speedometer, this results in 8.96% speed up, i.e., the tests take on average 762ms with this patch, 837ms without. BUG= v8:5175 Review-Url: https://codereview.chromium.org/2134803002 Cr-Commit-Position: refs/heads/master@{#37827}
-
ahaas authored
These tests seem to pass just fine. R=titzer@chromium.org BUG=v8:4795 Review-Url: https://codereview.chromium.org/2162433002 Cr-Commit-Position: refs/heads/master@{#37826}
-
bangfu.tao authored
BUG= A bug in android-run.py, which caused the android_arm.release.check throws error: data/local/tmp/v8/test/mjsunit/wasm/function-prototype.js:7: Error loading file load("test/mjsunit/wasm/wasm-constants.js"); Review-Url: https://codereview.chromium.org/2070323002 Cr-Commit-Position: refs/heads/master@{#37825}
-
jochen authored
BUG= R=ulan@chromium.org,verwaest@chromium.org Review-Url: https://codereview.chromium.org/2153423002 Cr-Commit-Position: refs/heads/master@{#37824}
-
bmeurer authored
So far TurboFan wasn't adding the deoptimization reasons for eager/soft deoptimization exits that can be used by either the DevTools profiler or the --trace-deopt flag. This adds basic support for deopt reasons on Deoptimize, DeoptimizeIf and DeoptimizeUnless nodes and threads through the reasons to the code generation. Also moves the DeoptReason to it's own file (to resolve include cycles) and drops unused reasons. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2161543002 Cr-Commit-Position: refs/heads/master@{#37823}
-
machenbach authored
Revert of Add force_dynamic_crt to build as static library but with /MD on windows (patchset #3 id:40001 of https://codereview.chromium.org/2149963002/ ) Reason for revert: Fails gyp build with chromium: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/37051 Blocks roll: https://codereview.chromium.org/2157903002/ Please add the trybot ios-simulator on reland. Original issue's description: > [build] Add force_dynamic_crt option to build a static library with /MD on windows > > Adds option to build a V8 library statically, but with the options on > windows that allows it to be subsequently included in another DLL. On > Windows this is required for it to correclty link against the correct > C++ runtime. Require for our Node.js shared library build. > > Reference: https://github.com/nodejs/node/pull/7487 > > BUG= > R=machenbach@chromium.org, michael_dawson@ca.ibm.com > > Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d > Cr-Commit-Position: refs/heads/master@{#37814} TBR=michael_dawson@ca.ibm.com,franzih@chromium.org,sxa@uk.ibm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2155073002 Cr-Commit-Position: refs/heads/master@{#37822}
-
oth authored
Revert of [interpeter] Move to table based peephole optimizer. (patchset #38 id:730001 of https://codereview.chromium.org/2118183002/ ) Reason for revert: Break MIPS port. Original issue's description: > [interpeter] Move to table based peephole optimizer. > > Introduces a lookup table for peephole optimizations. > > Fixes some tests using BytecodePeepholeOptimizer::Write() that should > have been update to use BytecodePeepholeOptimizer::WriteJump(). > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/f4234422b93b21a286b0f31799009bcbe8b90b9e > Cr-Commit-Position: refs/heads/master@{#37819} TBR=rmcilroy@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Review-Url: https://codereview.chromium.org/2161563002 Cr-Commit-Position: refs/heads/master@{#37821}
-
yangguo authored
R=bmeurer@chromium.org BUG=v8:5197 Review-Url: https://codereview.chromium.org/2155633002 Cr-Commit-Position: refs/heads/master@{#37820}
-
oth authored
Introduces a lookup table for peephole optimizations. Fixes some tests using BytecodePeepholeOptimizer::Write() that should have been update to use BytecodePeepholeOptimizer::WriteJump(). BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/2118183002 Cr-Commit-Position: refs/heads/master@{#37819}
-
mstarzinger authored
This fixes the deoptimization information for the lazy bailout point after a [[ToObject]] operation inserted for with statements. The result value was pushed on the operand stack but erroneously ignored and left on the operand stack by the FullCodeGenerator. R=jarin@chromium.org TEST=mjsunit/regress/regress-5205 BUG=v8:5205 Review-Url: https://codereview.chromium.org/2158443002 Cr-Commit-Position: refs/heads/master@{#37818}
-
marja authored
crbug.com/518788 looks like AstValueFactory::strings_ would contain nullptrs which shouldn't be possible. This CL makes us crash earlier before putting nullptrs into it. It's paranoid, since Zone should already crash before returning nullptr. BUG=518788 LOG=n R=adamk@chromium.org Review-Url: https://codereview.chromium.org/2156513002 Cr-Commit-Position: refs/heads/master@{#37817}
-
marja authored
BUG= Review-Url: https://codereview.chromium.org/2145753006 Cr-Commit-Position: refs/heads/master@{#37816}
-
neis authored
Highlights: - Record all imports and exports in the ModuleDescriptor. - Remove ImportDeclaration; instead, introduce a new variable kind for imports. - Set name on default exported anonymous functions. Still to do: declaration of namespace imports. BUG=v8:1569 Review-Url: https://codereview.chromium.org/2108193003 Cr-Commit-Position: refs/heads/master@{#37815}
-
sxa authored
Adds option to build a V8 library statically, but with the options on windows that allows it to be subsequently included in another DLL. On Windows this is required for it to correclty link against the correct C++ runtime. Require for our Node.js shared library build. Reference: https://github.com/nodejs/node/pull/7487 BUG= R=machenbach@chromium.org, michael_dawson@ca.ibm.com Review-Url: https://codereview.chromium.org/2149963002 Cr-Commit-Position: refs/heads/master@{#37814}
-
weiliang.lin authored
Review-Url: https://codereview.chromium.org/2161503002 Cr-Commit-Position: refs/heads/master@{#37813}
-
bjaideep authored
Port 8e18a5f2 R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Review-Url: https://codereview.chromium.org/2152363002 Cr-Commit-Position: refs/heads/master@{#37812}
-
- 17 Jul, 2016 2 commits
-
-
jarin authored
We will try to loop inner-most loops if they have <1000 nodes (randomly chosen value). This is an experimental CL to see the performance impact of peeling, both on compile time and on the generated code. Review-Url: https://codereview.chromium.org/2156573002 Cr-Commit-Position: refs/heads/master@{#37811}
-
v8-autoroll authored
Rolling v8/build to e609d4bcabeef6b140c6326caea53c5b6dbec72a TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2155043002 Cr-Commit-Position: refs/heads/master@{#37810}
-
- 16 Jul, 2016 4 commits
-
-
joransiu authored
The GetStackPointer() routine in test-platform uses an inline assembly code to store the current stack pointer value into a static variable sp_addr. The existing asm code for S390 uses an ST/STG instruction, with the memory operand associated with the general ('=g') constraint to sp_addr. On GCC 4.8.5, the GCC compiler got confused and treated sp_addr as an integer operand instead of memory operand, resulting in a store being emitted that writes to an invalid meory location. Given the specific store instructions being inlined here, we should restict the sp_addr operand to explicitly be a memory operand using '=m' instead of '=g'. R=bmeurer@chromium.org,jkummerow@chormium.org,rmcilroy@chromium.org,yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2158523002 Cr-Commit-Position: refs/heads/master@{#37809}
-
jarin authored
Delaying for merges caused branch cloning using dummy effect phi inputs, potentially splitting the effect chain at start. We still have to delay the creation for loops because we need to break cycles. BUG=chromium:628403 Review-Url: https://codereview.chromium.org/2159603002 Cr-Commit-Position: refs/heads/master@{#37808}
-
gdeepti authored
- Add Simd128 type to Wasm AST types - Decode SIMD prefix, wasm opcodes correctly - Add a pass that converts SIMD machine ops to runtime calls - Sample opcodes Int32x4Splat, Int32x4ExtractLane and test LOG=N BUG=v8:4124 R=bradnelson@chromium.org, bbudge@chromium.org, titzer@chromium.org Committed: https://crrev.com/73df92fc2fdbbfadc17e8ab4e58ec56ae2b3d91a Review-Url: https://codereview.chromium.org/1991143002 Cr-Original-Commit-Position: refs/heads/master@{#37789} Cr-Commit-Position: refs/heads/master@{#37807}
-
v8-autoroll authored
Rolling v8/build to c409cdb27d5dfcfd5d08f22b18af9010ae50b6a8 Rolling v8/third_party/android_tools to 20a4bd598cf3ba8434311156ce94c110a0024fe7 Rolling v8/tools/mb to 6aa2ae44b604e6feec721bec77208210142dd4f5 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2154983002 Cr-Commit-Position: refs/heads/master@{#37806}
-
- 15 Jul, 2016 13 commits
-
-
dpranke authored
This change makes the architecture that we target generated v8 code for a property of the current toolchain, rather than a global setting that applies to every toolchain. This will allow us to properly build two snapshots for two different architectures in a single build, which is needed for android webview/monochrome builds. R=brettw@chromium.org, jochen@chromium.org, michaelbai@chromium.org BUG=625383 Review-Url: https://codereview.chromium.org/2116913002 Cr-Commit-Position: refs/heads/master@{#37805}
-
jyan authored
port 8e18a5f2 R=bjaideep@ca.ibm.com, mvstanton@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Review-Url: https://codereview.chromium.org/2153913002 Cr-Commit-Position: refs/heads/master@{#37804}
-
jkummerow authored
No compiled handlers required! Instead, the type feedback vector contains a Smi encoding the field index. Review-Url: https://codereview.chromium.org/2133233002 Cr-Commit-Position: refs/heads/master@{#37803}
-
alph authored
When it is in executing JS state there should be a JS stack. Having no stack means something is wrong with frame pointer, so just skip the bogus sample. Review-Url: https://codereview.chromium.org/2151103002 Cr-Commit-Position: refs/heads/master@{#37802}
-
ishell authored
Revert of [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations. (patchset #2 id:20001 of https://codereview.chromium.org/2147433002/ ) Reason for revert: Unfortunately, the performance issues are still there on Android. Original issue's description: > [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations. > > This should avoid weird performance issues when changing layout of Code::flags field. > > BUG=chromium:618701 > > Committed: https://crrev.com/aa4140b1ccc114b82700471513c715f68b7c5dac > Cr-Commit-Position: refs/heads/master@{#37755} TBR=jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:618701 Review-Url: https://codereview.chromium.org/2147213004 Cr-Commit-Position: refs/heads/master@{#37801}
-
jpp authored
The issue was caused by a mishandling of "special" identifiers, i.e., the module's name, and the module's parameter. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=628446 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST= cctest/asmjs/test-asm-typer.cc TEST= cctest/wasm/* LOG=N Review-Url: https://codereview.chromium.org/2147403002 Cr-Commit-Position: refs/heads/master@{#37800}
-
ssanfilippo authored
This commit introduces support for writing unwinding tables in the .eh_frame format, to be inserted in the jitdump read by Linux perf and emitted with FLAG_perf_prof and FLAG_perf_prof_unwinding_info enabled. x64 is fully implemented and tested, arm and arm64 are untested and the unwinding information needs to be expanded, but the mechanism is ready. BUG=v8:4899 LOG=N Review-Url: https://codereview.chromium.org/2026313002 Cr-Commit-Position: refs/heads/master@{#37799}
-
machenbach authored
This uses the same compiler flag as the chrome executable does for better performance comparison. BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2152853004 Cr-Commit-Position: refs/heads/master@{#37798}
-
machenbach authored
This sets default values for v8_enable_gdbjit and v8_imminent_deprecation_warnings, while allowing to override them as gn args. Without this patch the project-specific overrides have no effect. BUG=chromium:474921, chromium:626064 Review-Url: https://codereview.chromium.org/2153753002 Cr-Commit-Position: refs/heads/master@{#37797}
-
ishell authored
BUG=chromium:628573 Review-Url: https://codereview.chromium.org/2153783002 Cr-Commit-Position: refs/heads/master@{#37796}
-
bgeron authored
With this patch, every node in turbo-*.json has an opcode, a title, and a label. The label field is new; the opcode and title were already there. The title is for the mouseover text. The label is what will be displayed in the graph view, unless it's too long, in which case only the opcode will be displayed. (This is similar to the preexisting behaviour of putting titles in labels, except that the titles were rarely short enough to fit in a label.) With this patch, the labels generated are in practice the same as the titles we had before, except for LoadField and StoreField, which will be rendered as LoadField[[+432]] and StoreField[[+432]] (if 432 was the offset). This diff adds an overloadable method virtual void Operator1<T>::PrintParameter(ostream&, PrintVerbosity) for each type T to Operator1. Its default implementation just uses operator<<(ostream&, T const&) and adds square brackets around it, but it is overridden for FieldAccess to print "[+432]" in the example case. BUG= R=jarin,danno Review-Url: https://codereview.chromium.org/2093013002 Cr-Commit-Position: refs/heads/master@{#37795}
-
oth authored
> Original issue's description: > [interpreter] Reduce dependencies in bytecodes.{h,cc} > > This CL reduces the number of dependencies bytecodes.{h,cc} to facilitate > generating the bytecode peephole optimizer table during build. Specifically, > it avoids depending on v8_base. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/4edebb1cd870ae6c1359ad54f83e618e185883b1 > Cr-Commit-Position: refs/heads/master@{#37715} BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/2149093002 Cr-Commit-Position: refs/heads/master@{#37794}
-
neis authored
This reverts commit 457c0257 because it caused a regression in SunSpider/string-fasta and possibly AreWeFastYet/Life. Need to implement this in a smarter way. TBR=littledan@chromium.org BUG=chromium:627729,v8:5113 Review-Url: https://codereview.chromium.org/2149303003 Cr-Commit-Position: refs/heads/master@{#37793}
-