1. 04 Mar, 2019 1 commit
  2. 30 Oct, 2018 1 commit
    • Hai Dang's avatar
      Fix typing of binary operators on BigInt. · c5c6b8bc
      Hai Dang authored
      BinaryNumberOpTyper was not monotonic: if one input changes
      from Number to Numeric, while the other input stays BigInt,
      the result would change from Number to BigInt.
      
      We have some fuzzing tests for monotonicity but unfortunately
      they never generated the inputs required for triggering this bug.
      We'll look into improving our tests.
      
      Bug: v8:8380
      Change-Id: I7320d9ae4b89ad8798bf9e97cc272edba2162a77
      Reviewed-on: https://chromium-review.googlesource.com/c/1307418
      Commit-Queue: Hai Dang <dhai@google.com>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57125}
      c5c6b8bc