- 03 Aug, 2016 13 commits
-
-
jgruber authored
The func_index parameter passed to GetWasmFunctionNameFromTable can be user-controlled through the CallSite constructor. Catch out-of-bounds reads and return null as the function name in such cases. This applies to the 5.3 branch and will be reverted on TOT in a bit. BUG=632965 Review-Url: https://codereview.chromium.org/2199333002 Cr-Commit-Position: refs/heads/master@{#38276}
-
yangguo authored
Revert of [Tracing] Embed V8 runtime call stats into tracing. (patchset #6 id:100001 of https://codereview.chromium.org/2187693002/ ) Reason for revert: Sanitizer failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10989/ https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/7786/ Original issue's description: > [Tracing] Embed V8 runtime call stats into tracing. > > Currently we have V8 RuntimeCallStats that is independently from tracing when > running d8 with flag --runtime_call_stats. This patch embeds V8 runtime call > stats into tracing, by having a global table of runtime call counters each > isolate, resetting the table each time we enter a top level trace event, and > dumping the table for each top level trace event. This will make trace file more > compat, as well as enable runtime call stats in tracing system. > > This patch adds ~5% overhead to V8 when the category is enabled, we measure the > overhead by running a script when category is enabled. > > BUG=v8:5089 > > Committed: https://crrev.com/d014866173eaa2b548c566217b2c94b1d49385fa > Cr-Commit-Position: refs/heads/master@{#38270} TBR=cbruni@chromium.org,fmeawad@chromium.org,machenbach@chromium.org,bmeurer@chromium.org,adamk@chromium.org,rmcilroy@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5089 Review-Url: https://codereview.chromium.org/2203913004 Cr-Commit-Position: refs/heads/master@{#38275}
-
zhengxing.li authored
port a7581443 (r38231) original commit message: When we narrow a signed32 comparison to uint8 or uint16 representation, we also need to change the condition to unsigned comparisons otherwise the comparison will be done on int16/int8 which interprets the narrowed bits wrong. BUG= Review-Url: https://codereview.chromium.org/2206913002 Cr-Commit-Position: refs/heads/master@{#38274}
-
yangguo authored
The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 Review-Url: https://codereview.chromium.org/2199253002 Cr-Original-Commit-Position: refs/heads/master@{#38268} Cr-Commit-Position: refs/heads/master@{#38273}
-
yangguo authored
Revert of [inspector] include additional outputs from protocol handler generator. (patchset #2 id:20001 of https://codereview.chromium.org/2199253002/ ) Reason for revert: Compile warnings: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds/1901/steps/compile/logs/stdio Original issue's description: > [inspector] include additional outputs from protocol handler generator. > > The protocol handler generator generates these files into a default location if > not specified by flag as output. We should account for these files and > explicitly set its output location. > > R=machenbach@chromium.org > > Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 > Cr-Commit-Position: refs/heads/master@{#38268} TBR=machenbach@chromium.org,faith4roy16@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2206573004 Cr-Commit-Position: refs/heads/master@{#38272}
-
zhengxing.li authored
port 5bc24397 (r38219) original commit message: This will enable the interpreter to add a bytecode and use the stub. BUG= Review-Url: https://codereview.chromium.org/2205813002 Cr-Commit-Position: refs/heads/master@{#38271}
-
lpy authored
Currently we have V8 RuntimeCallStats that is independently from tracing when running d8 with flag --runtime_call_stats. This patch embeds V8 runtime call stats into tracing, by having a global table of runtime call counters each isolate, resetting the table each time we enter a top level trace event, and dumping the table for each top level trace event. This will make trace file more compat, as well as enable runtime call stats in tracing system. This patch adds ~5% overhead to V8 when the category is enabled, we measure the overhead by running a script when category is enabled. BUG=5089 Review-Url: https://codereview.chromium.org/2187693002 Cr-Commit-Position: refs/heads/master@{#38270}
-
zhengxing.li authored
port 205457b1 (r38195) original commit message: BUG= Review-Url: https://codereview.chromium.org/2206543002 Cr-Commit-Position: refs/heads/master@{#38269}
-
yangguo authored
The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2199253002 Cr-Commit-Position: refs/heads/master@{#38268}
-
bmeurer authored
Infer a more precise type even in case where NaN and/or -0 is a possible outcome of the operation, and use this more precise type to improve code generation for the modulus itself by trying harder to stick to Word32 operations instead of going to Float64, and also optimize the pattern where we compare the output of x % y to some non-zero integer constant K, in which case we can truncate the output of x % y to Word32 if the type of x % y is Signed32/Unsigned32 \/ NaN \/ MinusZero, as NaN and MinusZero will both be truncated to zero, which cannot match the non zero constant K. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2202413002 Cr-Commit-Position: refs/heads/master@{#38267}
-
caitp authored
BUG=v8:5162 R=bmeurer@chromium.org, cbruni@chromium.org Review-Url: https://codereview.chromium.org/2205883003 Cr-Commit-Position: refs/heads/master@{#38266}
-
v8-autoroll authored
Rolling v8/build to 957253ade4c8b5125afa41102ca41a0b19985e4e Rolling v8/buildtools to c3a780dcb63ff053439315f761190ffab0480ad4 Rolling v8/third_party/WebKit/Source/platform/inspector_protocol to 7d2a29d289d54b8ff9c330efc5145158f1191af2 Rolling v8/tools/mb to e100ad0410f9de1e859a143fe20a9b58f8f8d420 Rolling v8/tools/swarming_client to e4288c3040a32f2e7ad92f957668f2ee3d36e5a6 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2201303002 Cr-Commit-Position: refs/heads/master@{#38265}
-
bjaideep authored
Port 5bc24397 Original commit message: This will enable the interpreter to add a bytecode and use the stub. R=klaasb@google.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/2200263003 Cr-Commit-Position: refs/heads/master@{#38264}
-
- 02 Aug, 2016 27 commits
-
-
mtrofin authored
A fix would be to walk the reloc info and RecordWriteIntoCode. Doing so, however, upsets a scavenger DCHECK. We stumbled upon this issue because we were placing wasm objects (fixed arrays) in NEW_SPACE, rather than OLD_SPACE. These fixed arrays were subsequently referenced from Code objects, which were then cloned. The current CL ensures wasm constructs are allocated in OLD_SPACE, by pre-tenuring them (consistent with other wasm allocations). In addition, it adds a DCHECK for CopyCode clarifying its lack of support for references to NEW_SPACE. We can investigate in a subsequent CL making CopyCode more robust, pending understanding of the Scavenger's assumptions. BUG= Review-Url: https://codereview.chromium.org/2201663003 Cr-Commit-Position: refs/heads/master@{#38263}
-
titzer authored
R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review-Url: https://codereview.chromium.org/2209433002 Cr-Commit-Position: refs/heads/master@{#38262}
-
adamk authored
They may have once been different, but they're now redundant with each other. This simplifies both Context::Lookup and its callers. Review-Url: https://codereview.chromium.org/2200303002 Cr-Commit-Position: refs/heads/master@{#38261}
-
adamk authored
This was being allowed due to the use of BindingFlags instead of VariableMode to determine whether a looked-up binding was lexical. Because function declarations are hoisted, they never need hole checks, and so were being miscategorized as non-lexical. This patch augments Context::Lookup with a VariableMode out param, which allows this check to determine precisely whether the binding is lexical. BUG=v8:4454, v8:5256 Review-Url: https://codereview.chromium.org/2206483004 Cr-Commit-Position: refs/heads/master@{#38260}
-
jpp authored
BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 Review-Url: https://codereview.chromium.org/2200213002 Cr-Commit-Position: refs/heads/master@{#38259}
-
marja authored
Revert of Put Scopes into temporary Zone (patchset #12 id:220001 of https://codereview.chromium.org/2193793002/ ) Reason for revert: Broke Node.js tests (test-require-dot etc.) Original issue's description: > Put Scopes into temporary Zone > > When parsing a eagerly-parsed-but-lazily-compiled function, we > used to put some of its AST nodes into a discardable Zone. This > CL puts the function Scope, its inner Scopes and the related AST > nodes (Declarations, VariableProxys) into the temporary Zone > too. This reduces peak memory usage and enables future work to > keep the temporary Zone around for later compilation. > > BUG= > > Committed: https://crrev.com/eaebdd858b466057ccc39894a172c9b66868e8f7 > Cr-Commit-Position: refs/heads/master@{#38232} TBR=adamk@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2205013002 Cr-Commit-Position: refs/heads/master@{#38258}
-
machenbach authored
This prepares for adding the ignition_staging variant to the default variant set. BUG=v8:5238 Review-Url: https://codereview.chromium.org/2205883002 Cr-Commit-Position: refs/heads/master@{#38257}
-
adamk authored
It's shipped in M52. R=caitp@igalia.com, littledan@chromium.org Review-Url: https://codereview.chromium.org/2203843002 Cr-Commit-Position: refs/heads/master@{#38256}
-
rskang authored
BUG=v8:4561 Review-Url: https://codereview.chromium.org/2190973003 Cr-Commit-Position: refs/heads/master@{#38255}
-
machenbach authored
This is not referenced anymore by the infrastructure after: https://codereview.chromium.org/2202113003/ BUG=v8:5238 Review-Url: https://codereview.chromium.org/2203023003 Cr-Commit-Position: refs/heads/master@{#38254}
-
machenbach authored
This adds a gyp/gn variable to control printing to stdout on Android. This is false by default and true for all v8 stand-alone android bots. BUG=chromium:629806 Review-Url: https://codereview.chromium.org/2183063002 Cr-Commit-Position: refs/heads/master@{#38253}
-
alph authored
Review-Url: https://codereview.chromium.org/2203573004 Cr-Commit-Position: refs/heads/master@{#38252}
-
alph authored
Review-Url: https://codereview.chromium.org/2197393003 Cr-Commit-Position: refs/heads/master@{#38251}
-
mstarzinger authored
This completely removes translation of exception handler predictions from the graph IR. We now rely on the runtime using deoptimization infomation via {FrameSummary} for predictions in optimized code. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2207533002 Cr-Commit-Position: refs/heads/master@{#38250}
-
cbruni authored
We no longer need NeanderObject, the only user left was the message listener machanism which could be replace by direct uses of FixedArrays. BUG=chromium:630217 Review-Url: https://codereview.chromium.org/2195243003 Cr-Commit-Position: refs/heads/master@{#38249}
-
machenbach authored
It should be enough to specify --variants=... with the desired set of variants. The stress/nostress shortcuts might get confusing soon, as we intend to move the stress option out of the developer default set. BUG=v8:5238 Review-Url: https://codereview.chromium.org/2195373002 Cr-Commit-Position: refs/heads/master@{#38248}
-
yangguo authored
R=mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2197183002 Cr-Commit-Position: refs/heads/master@{#38247}
-
epertoso authored
BUG= Review-Url: https://codereview.chromium.org/2201073002 Cr-Commit-Position: refs/heads/master@{#38246}
-
alph authored
Review-Url: https://codereview.chromium.org/2204873003 Cr-Commit-Position: refs/heads/master@{#38245}
-
alph authored
Review-Url: https://codereview.chromium.org/2204893002 Cr-Commit-Position: refs/heads/master@{#38244}
-
hpayer authored
Revert of [heap] Re-enable black allocation when finalizing marking. (patchset #1 id:1 of https://codereview.chromium.org/2202993002/ ) Reason for revert: Crashes on tree. Original issue's description: > [heap] Re-enable black allocation when finalizing marking. > > BUG=chromium:630386 > LOG=n > > Committed: https://crrev.com/2c75cfd731e11daa649faf2e91cbb84767b11f8e > Cr-Commit-Position: refs/heads/master@{#38240} TBR=ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:630386 Review-Url: https://codereview.chromium.org/2204593005 Cr-Commit-Position: refs/heads/master@{#38243}
-
bmeurer authored
This is a simple cleanup to use the recently added CheckMaps operator instead of the hand-crafted map check sequence. R=epertoso@chromium.org Review-Url: https://codereview.chromium.org/2199263002 Cr-Commit-Position: refs/heads/master@{#38242}
-
bmeurer authored
We cannot just blindly make a representation selection for Phi or Select based on the truncations, but we also need to consider the type of the inputs (or actually of the Phi/Select node itself). We can only use Word32 representation based on Word32 truncation if the inputs are Number or Oddball, same for Float64. R=epertoso@chromium.org BUG=v8:5255 Review-Url: https://codereview.chromium.org/2206553002 Cr-Commit-Position: refs/heads/master@{#38241}
-
hpayer authored
BUG=chromium:630386 LOG=n Review-Url: https://codereview.chromium.org/2202993002 Cr-Commit-Position: refs/heads/master@{#38240}
-
hpayer authored
BUG= Review-Url: https://codereview.chromium.org/2205853002 Cr-Commit-Position: refs/heads/master@{#38239}
-
machenbach authored
Without this fix, two rules [PASS, MODIFIER] and [FAIL] would be joined as [PASS, MODIFIER, FAIL], undermining the intention of the second rule to mark a test as failing. BUG=v8:4680,v8:4900 Review-Url: https://codereview.chromium.org/2201033002 Cr-Commit-Position: refs/heads/master@{#38238}
-
mstarzinger authored
R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2207503002 Cr-Commit-Position: refs/heads/master@{#38237}
-